Re: [Bug-wget] How to switch off the status bar?

2015-03-08 Thread Noël Köthe
Hello,

Am Samstag, den 07.03.2015, 09:58 + schrieb Thomas Sefzick:
> When calling wget via the 'catch' command from inside a (Tcl-)script the
> script detects an error.
> This started with wget version 1.16.2 and seems to be caused by the status
> bar which is always(?) activated.
> 'wget -q' is not quiet anymore.
> 
> Which option should I use to get the old behaviour of '-q'?

This is a bug in version 1.16.2:

https://savannah.gnu.org/bugs/index.php?44403

(includes the link to the patch which is already commited to git)

Regards

Noël



signature.asc
Description: This is a digitally signed message part


Re: [Bug-wget] [Bug-Wget] Add some documentation

2015-03-08 Thread Darshit Shah
Something like this?


On Sun, Mar 8, 2015 at 7:11 PM, Ander Juaristi  wrote:
>
> On 03/06/2015 05:35 PM, Darshit Shah wrote:
>>
>> Can someone please take a look at the language and see if it is clear
>> enough?
>>
>
> I would add an extra line emphasizing the fact that the post data is always
> sent as-is.
> Editing your patch inline:
>
> +When sending a POST request using the @samp{--post-file} option, Wget
> treats
> +the file as a binary file and will send every character in the POST request
> without making modifications.
> +This includes any control characters such as a newline or formfeed
> character.
> +
>
> When writing documentation, repeating important aspects is usually a Good
> Thing.
>
> --
> Regards,
> - AJ
>
>
>



-- 
Thanking You,
Darshit Shah
From aaedc68bcff5a9311ed806d972ce88a1d2c12a96 Mon Sep 17 00:00:00 2001
From: Darshit Shah 
Date: Fri, 6 Mar 2015 22:00:24 +0530
Subject: [PATCH] Docs: --post-file is binary data

Wget considers the file mentioned in the --post-file argument as a
binary file and does not strip any control characters. The lack of this
information in the documentation can cause a lot of headaches debugging
for a simple issue
---
 doc/wget.texi | 5 +
 1 file changed, 5 insertions(+)

diff --git a/doc/wget.texi b/doc/wget.texi
index dafd7bb..b1faf8c 100644
--- a/doc/wget.texi
+++ b/doc/wget.texi
@@ -1521,6 +1521,11 @@ Please note that wget does not require the content to be of the form
 simply transmit whatever data is provided to it. Most servers however expect
 the POST data to be in the above format when processing HTML Forms.
 
+When sending a POST request using the @samp{--post-file} option, Wget treats
+the file as a binary file and will send every character in the POST request
+without stripping trailing newline or formfeed characters. Any other control
+characters in the text will also be sent as-is in the POST request.
+
 Please be aware that Wget needs to know the size of the POST data in
 advance.  Therefore the argument to @code{--post-file} must be a regular
 file; specifying a FIFO or something like @file{/dev/stdin} won't work.
-- 
2.3.1



Re: [Bug-wget] Issue with --content-on-error and --convert-links

2015-03-08 Thread Yousong Zhou
Hi,

On 31 January 2015 at 10:13, Yousong Zhou  wrote:
 Ah sorry, my fault / misunderstanding.
 Since the patch changes Wget behaviour I would apply it after the next 
 bugfix
 release.
 A test case would be perfect. Please consider creating a python test case 
 (see
 directory testenv). We will move all test cases from perl to python by the
 time.

>>>
>>> Well, there they are, with a few fixes for other issues I encountered
>>> when preparing for this.
>>
>> patches look fine to me, could you please ensure to write the commit
>> message using the ChangeLog format?
>>
>> When it is just one line log, you can just use the format:
>>
>> * blah/file (function): Describe what changed.
>>
>> Otherwise use the format:
>>
>> one short line to describe the change
>>
>> * blah/file1 (foo): Describe what changed here.
>> * blah/file2 (bar): And here.
>>
>> More about the ChangeLog style here:
>>
>> https://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html#Style-of-Change-Logs
>>
>
> Changes are made to
>
>  - Follow GNU Changelog style commit message.
>  - Update the 2nd patch so that no color codes will be printed when
> the stdout is not a tty-like device.
>

I noticed that wget v1.16.2 has been released.  Is it okay that this
series can be reviewed again and applied?  FYI, attachments can be
found at link [1]

 [1] Re: [Bug-wget] Issue with --content-on-error and --convert-links,
https://lists.gnu.org/archive/html/bug-wget/2015-01/msg00073.html

Regards.

   yousong



Re: [Bug-wget] [Bug-Wget] Add some documentation

2015-03-08 Thread Ander Juaristi


On 03/06/2015 05:35 PM, Darshit Shah wrote:

Can someone please take a look at the language and see if it is clear enough?



I would add an extra line emphasizing the fact that the post data is always 
sent as-is.
Editing your patch inline:

+When sending a POST request using the @samp{--post-file} option, Wget treats
+the file as a binary file and will send every character in the POST request 
without making modifications.
+This includes any control characters such as a newline or formfeed character.
+

When writing documentation, repeating important aspects is usually a Good Thing.

--
Regards,
- AJ