Re: [Bug-wget] [GSoC Update] Week 1
Maybe I missed something, but why should the MHD dependency become _mandatory_? Why not conditionally-compile and run the tests only if MHD is present? MHD does the same for libcurl. Making the dependency optional also avoids the obvious possibility of circular dependencies if we ever were to add libwget2-based tests to MHD :-). On 06/05/2017 06:46 PM, Didik Setiawan wrote: > * With Libmicrohttpd becomes mandatory package to install before building > Wget2 >binary, there must be proper warning about this requirement, otherwise the >building process will fail. I have add oneliner information into README.md. >Please notice me if there are some other places where I can add warning > like >this. signature.asc Description: OpenPGP digital signature
Re: [Bug-wget] [GSoC Update] Week 2
On 06/13/2017 05:42 AM, Didik Setiawan wrote: >- Last check failed when the test try to resolve URL with question mark. > E.g: "/subdir1/subpage1.html?query¶m", when I debug, it return just > "/subdir1/subpage1.html" so the result is 404 not found. I also check > using > logging example source code provided in Libmicrohttpd tutorial [4]. When > I > access using http client such as Wget2 and Firefox, the result is still > the > same. The URL result omit the query part. Need to confirm to > Libmicrohttpd > side about this, whether it is intended behaviour or not. Yes, that's intended, for URL parameters/arguments you need to use MHD_get_connection_values() with kind=MHD_GET_ARGUMENT_KIND to inspect them. Happy hacking! Christian signature.asc Description: OpenPGP digital signature
