Re: [Bug-wget] fix: wget hangs with -r and -O - (bug #40426)
"daniele.cal...@tin.it" writes:
> * configure.ac: added a summary of build options
> diff --git a/src/main.c b/src/main.c
> index 19d7253..d051f7c 100644
> --- a/src/main.c
> +++ b/src/main.c
> @@ -1549,9 +1549,9 @@ for details.\n\n"));
>if (fstat (fileno (output_stream), &st) == 0 && S_ISREG
> (st.st_mode))
> output_stream_regular = true;
> }
> - if (!output_stream_regular && opt.convert_links)
> + if (!output_stream_regular && (opt.convert_links || opt.recursive))
> {
> - fprintf (stderr, _("-k can be used together with -O only if \
> + fprintf (stderr, _("-k or -r can be used together with -O only if \
> outputting to a regular file.\n"));
>print_usage (1);
>exit(1);
>
we are approaching a release and I would like we don't break existing
translations. Would you mind duplicating this block and repeating the
error message, so to not break the translations for the "-k" version:
1) "-k can be used together with -O only if"
2) "-r can be used together with -O only if"
we can merge these back after the release, when we will have time to fix
translations again. Sorry for the additional step.
Giuseppe
Re: [Bug-wget] fix: wget hangs with -r and -O - (bug #40426)
Am Donnerstag, 14. November 2013, 21:00:13 schrieb Tim Rühsen: > Am Montag, 11. November 2013, 18:06:53 schrieb daniele.cal...@tin.it: > > Hello, > > > > In attachment a fix of the bug #40426 > > Hi Daniele, > > thanks for your contribution. > > But it would be nice to have -O and -r working together. > > Did you try to find out why Wget blocks ? You are right in fixing it the quick way. Since Wget's designers decided to first save to disk and then load again the same file, -O - and -r won't work together. Wget is hanging because it reads from STDIN and waits for data. To fix it, the downloaded file should stay in memory to be parsed OR be saved twice when -O - comes together with -r ... Tim signature.asc Description: This is a digitally signed message part.
Re: [Bug-wget] fix: wget hangs with -r and -O - (bug #40426)
Am Montag, 11. November 2013, 18:06:53 schrieb daniele.cal...@tin.it: > Hello, > > In attachment a fix of the bug #40426 Hi Daniele, thanks for your contribution. But it would be nice to have -O and -r working together. Did you try to find out why Wget blocks ? Regards, Tim signature.asc Description: This is a digitally signed message part.
[Bug-wget] fix: wget hangs with -r and -O - (bug #40426)
Hello, In attachment a fix of the bug #40426 Bye Daniele Calore -- wget-bug-40426-fix.diff Description: Binary data
