[Bug-XBoard] [bug #34990] Use of Mono mode once permanently swictces to bitmap pieces
Update of bug #34990 (project xboard): Status:None = Wont Fix Open/Closed:Open = Closed ___ Follow-up Comment #2: The mono-mode bitmaps, instated by defining a -bitmapDirectory, can be reset using the View-Board menu, so no need to edit the config file by hand. ___ Reply to this item at: http://savannah.gnu.org/bugs/?34990 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Bug-XBoard mailing list Bug-XBoard@gnu.org https://lists.gnu.org/mailman/listinfo/bug-xboard
Re: [Bug-XBoard] [bug #34990] Use of Mono mode once permanently swictces to bitmap pieces
You are right about that. However when I tried I got a segfault! Oh yes, now I remember that occurred to me too. The patch that fixed the animation masks on swithing back to color mode fixes that too. A string constant (DEF_BITMAP_DIR) is assigned to appData.bitmapDirectory when you change to monoMode if it was NULL. So when I try to change bitmap directory later DEF_BITMAP_DIR is attempted free()'ed, and xboard crashes. Add a strdup() at xboard.c:1946. ___ Bug-XBoard mailing list Bug-XBoard@gnu.org https://lists.gnu.org/mailman/listinfo/bug-xboard
Re: [Bug-XBoard] [bug #34990] Use of Mono mode once permanently swictces to bitmap pieces
Den 22-12-2011 10:41, h.g. muller skrev: You are right about that. However when I tried I got a segfault! Oh yes, now I remember that occurred to me too. The patch that fixed the animation masks on swithing back to color mode fixes that too. Fine, but where is the patch? ___ Bug-XBoard mailing list Bug-XBoard@gnu.org https://lists.gnu.org/mailman/listinfo/bug-xboard
Re: [Bug-XBoard] [bug #34990] Use of Mono mode once permanently swictces to bitmap pieces
At 20:23 22-12-2011 +0100, Byrial Jensen wrote: Den 22-12-2011 10:41, h.g. muller skrev: You are right about that. However when I tried I got a segfault! Oh yes, now I remember that occurred to me too. The patch that fixed the animation masks on swithing back to color mode fixes that too. Fine, but where is the patch? In hgm.nubati.net (hgmaster branch) ___ Bug-XBoard mailing list Bug-XBoard@gnu.org https://lists.gnu.org/mailman/listinfo/bug-xboard ___ Bug-XBoard mailing list Bug-XBoard@gnu.org https://lists.gnu.org/mailman/listinfo/bug-xboard
Re: [Bug-XBoard] [bug #34990] Use of Mono mode once permanently swictces to bitmap pieces
Den 21-12-2011 22:33, h.g. muller skrev: The only way to revert this is to quit xboard and manually edit .xboardrc to remove the automatically inserted -bitmapDirectory option. This is not true: the bitmapDirectory can be specified from the View-Board menu dialog as well. You are right about that. However when I tried I got a segfault! A string constant (DEF_BITMAP_DIR) is assigned to appData.bitmapDirectory when you change to monoMode if it was NULL. So when I try to change bitmap directory later DEF_BITMAP_DIR is attempted free()'ed, and xboard crashes. Add a strdup() at xboard.c:1946. Switching to modo-mode does force it to a default value when it was not yet set, because you mut ue bitmap pieces in mono-mode, and they are not built in. But it is not forbidden to use bitmap pieces in color mode, so there is no reason to force the bitmapDirectory to empty when switching off mono-mode. The user will have to indicate explicitly he wants that, by clearing the bitmapDirectory field in the dialog together with unticking mono-mode. You could argue that a value is forced in, should be automatically removed again when it is no more needed. ___ Bug-XBoard mailing list Bug-XBoard@gnu.org https://lists.gnu.org/mailman/listinfo/bug-xboard
[Bug-XBoard] [bug #34990] Use of Mono mode once permanently swictces to bitmap pieces
Follow-up Comment #1, bug #34990 (project xboard): Please read bitmap where I wrote bitmark. It was a typo. ___ Reply to this item at: http://savannah.gnu.org/bugs/?34990 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Bug-XBoard mailing list Bug-XBoard@gnu.org https://lists.gnu.org/mailman/listinfo/bug-xboard
