[Bug 63300] mod_status lists BusyWorkers IdleWorkers keys twice
https://bz.apache.org/bugzilla/show_bug.cgi?id=63300 Christophe JAILLET changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org For additional commands, e-mail: bugs-h...@httpd.apache.org
[Bug 63300] mod_status lists BusyWorkers IdleWorkers keys twice
https://bz.apache.org/bugzilla/show_bug.cgi?id=63300 --- Comment #12 from Rainer Jung --- Committed to 2.4.x in r1911892. Will be part of 2.4.58. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org For additional commands, e-mail: bugs-h...@httpd.apache.org
[Bug 63300] mod_status lists BusyWorkers IdleWorkers keys twice
https://bz.apache.org/bugzilla/show_bug.cgi?id=63300 --- Comment #11 from Rainer Jung --- Proposed for backport to 2.4.x. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org For additional commands, e-mail: bugs-h...@httpd.apache.org
[Bug 63300] mod_status lists BusyWorkers IdleWorkers keys twice
https://bz.apache.org/bugzilla/show_bug.cgi?id=63300 --- Comment #10 from Yann Ylavic --- The typo was fixed in r1909606 already, thanks for reviewing/noticing! -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org For additional commands, e-mail: bugs-h...@httpd.apache.org
[Bug 63300] mod_status lists BusyWorkers IdleWorkers keys twice
https://bz.apache.org/bugzilla/show_bug.cgi?id=63300
--- Comment #9 from Tomas Korbar ---
Hi Rainer,
I think there is a typo.
+if (res == SERVER_GRACEFUL)
+graceful++;
+if (is_async) {
+thread_graceful_buffer[i]++;
+} else {
+busy++;
+if (is_async)
thread_busy_buffer[i]++;
You indented the first "if (is_async)" as if it was guarded by the "if (res ==
SERVER_GRACEFUL)" condition but it is not.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org
For additional commands, e-mail: bugs-h...@httpd.apache.org
[Bug 63300] mod_status lists BusyWorkers IdleWorkers keys twice
https://bz.apache.org/bugzilla/show_bug.cgi?id=63300 --- Comment #8 from Rainer Jung --- See also: https://svn.apache.org/viewvc?view=revision=r1909429 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org For additional commands, e-mail: bugs-h...@httpd.apache.org
[Bug 63300] mod_status lists BusyWorkers IdleWorkers keys twice
https://bz.apache.org/bugzilla/show_bug.cgi?id=63300 --- Comment #7 from Rainer Jung --- I just added a fix for trunk in 1909429 and plan to suggest it for backport. The changelog item would be: mod_status: Remove duplicate keys "BusyWorkers" and "IdleWorkers". Resolve inconsistency between the previous two occurrences by counting workers in state SERVER_GRACEFUL no longer as busy, but instead in a new counter "GracefulWorkers" (or on HTML view as "workers gracefully restarting"). Also add the graceful counter as a new column to the existing HTML per process table for async MPMs. That should explain, how I resolved it. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org For additional commands, e-mail: bugs-h...@httpd.apache.org
[Bug 63300] mod_status lists BusyWorkers IdleWorkers keys twice
https://bz.apache.org/bugzilla/show_bug.cgi?id=63300 --- Comment #6 from Tomas Korbar --- Hi guys, Any plan to fix this? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org For additional commands, e-mail: bugs-h...@httpd.apache.org
[Bug 63300] mod_status lists BusyWorkers IdleWorkers keys twice
https://bz.apache.org/bugzilla/show_bug.cgi?id=63300 Tomas Korbar changed: What|Removed |Added CC||tkor...@redhat.com --- Comment #5 from Tomas Korbar --- Created attachment 38466 --> https://bz.apache.org/bugzilla/attachment.cgi?id=38466=edit mod_status.patch Hi, i would also like this to be resolved. I Reproduced this issue on Fedora-Rawhide. My proposal is to remove the first set of BusyWorkers IdleWorkers when ?auto query is supplied and let only the second set be printed out with correct values which count with gracefully finishing threads but renaming is also ok. Thanks for any help. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org For additional commands, e-mail: bugs-h...@httpd.apache.org
[Bug 63300] mod_status lists BusyWorkers IdleWorkers keys twice
https://bz.apache.org/bugzilla/show_bug.cgi?id=63300 --- Comment #4 from Stefan Neufeind --- Either way. But having a solution would be great. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org For additional commands, e-mail: bugs-h...@httpd.apache.org
[Bug 63300] mod_status lists BusyWorkers IdleWorkers keys twice
https://bz.apache.org/bugzilla/show_bug.cgi?id=63300 --- Comment #3 from Rainer Jung --- I would prefer to rename to fields for the async values, because they are calculated in an independent way. Deltas may point to problems. For instance: BusyWorkers => BusyAsyncWorkers IdleWorkers => IdleAsyncWorkers Although of course in the async case there are only async workers, no others. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org For additional commands, e-mail: bugs-h...@httpd.apache.org
[Bug 63300] mod_status lists BusyWorkers IdleWorkers keys twice
https://bz.apache.org/bugzilla/show_bug.cgi?id=63300 --- Comment #2 from Stefan Neufeind --- Would be great to avoid duplicate values here. In the meantime others like collectd have implemented workarounds. But imho duplicate values should be prevented at the source. https://github.com/collectd/collectd/pull/3131 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org For additional commands, e-mail: bugs-h...@httpd.apache.org
[Bug 63300] mod_status lists BusyWorkers IdleWorkers keys twice
https://bz.apache.org/bugzilla/show_bug.cgi?id=63300 --- Comment #1 from Christian Zuckschwerdt --- Suggested fix would be to make https://github.com/apache/httpd/blob/2.4.39/modules/generators/mod_status.c#L554 ap_rprintf(r, "BusyWorkers: %d\nIdleWorkers: %d\n", busy, ready); conditional on is_async. Not sure though if both outputs could report different values? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org For additional commands, e-mail: bugs-h...@httpd.apache.org
