Re: bgpd "network (inet|inet6) rtlabel" does not mimic functionality of "network (inet|inet6) static"

2018-09-29 Thread Sebastian Benoit
Sebastian Benoit(be...@openbsd.org) on 2018.09.26 21:18:32 +0200:
> Claudio Jeker(clau...@openbsd.org) on 2018.09.26 20:34:04 +0200:
> > On Wed, Sep 26, 2018 at 08:14:09PM +0200, Sebastian Benoit wrote:
> > > Jon Williams(j...@jonwillia.ms) on 2018.09.25 16:51:25 -0400:
> > > > >Synopsis: Newly connected rtlabel networks are not advertised by bgpd
> > > > >Category:  system
> > > > >Environment:
> > > >   System  : OpenBSD 6.3
> > > >   Details : OpenBSD 6.3 (GENERIC.MP) #107: Sat Mar 24 14:21:59 MDT 
> > > > 2018
> > > >
> > > > dera...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP
> > > > 
> > > >   Architecture: OpenBSD.amd64
> > > >   Machine : amd64
> > > > >Description:
> > > >   "network (inet|inet6) rtlabel" should pick up new routes with the 
> > > > label.
> > > > >How-To-Repeat:
> > > >   1) Run bgpd with a configuration containing:
> > > > 
> > > >   network inet rtlabel export
> > > > 
> > > >   Add a route with this label and start bgpd.
> > > > 
> > > >   `bgpctl show network` will contain this route
> > > > 
> > > >   Delete the route and recreate it. `bgpctl show network` will *not* 
> > > > contain this route.
> > > > 
> > > >   2) Run bgpd with a configuration containing:
> > > > 
> > > >   network inet static
> > > > 
> > > >   Add a static route and start bgpd.
> > > > 
> > > >   `bgpctl show network` will contain this route
> > > > 
> > > >   Delete the route and recreate it. `bgpctl show network` will contain 
> > > > this route.
> > > 
> > > 
> > > Here is a possible fix for your problem, please test.
> > > 
> > > Diff is against -current.
> > > 
> 
> updated diff:

Hi,

i commited that diff to -current.

We will finish release 6.4 soon, so i would appreciate if you can test this.

If you dont want to compile it yourself, tomorrows snapshot should contain
the fix.

Thanks,
Benno



Re: Easily reproducible kernel panic on reboot with 2018-09-14 snapshot (amd64)

2018-09-29 Thread Bob Beck
Please give me some details of your setup to reproduce this. (since I
don't use "resflash")


On Sat, Sep 15, 2018 at 12:35 PM Jarkko Oranen  wrote:
>
> As the summary says, this is rather easy to reproduce.
>
> I use resflash to build myself router images based on OpenBSD. Today I
> built an image from 6.4 snapshot sets, and there's a panic, apparently
> when unmounting the mfs filesystems resflash uses.
>
> I booted up the image on a fresh QEMU VM with virt-manager defaults (1
> vCPU, 1024GB of RAM, IDE disk). at the end is the entirety of the
> serial console output from boot to crash.
>
> The panic also occurs on my APU2.
>
> I can also make available the full resflash image if needed (it
> contains no significant customization besides resflash, just miniupnpd
> and flashrom installed with pkg_add). It's about 200MB when compressed
>
> rebooting...
> >> OpenBSD/amd64 BOOT 3.41
> boot>
> booting hd0d:/bsd: 10487559+2536464+266272+0+671744
> [697576+119+850536+593286]=0xf5e110
> entry point at 0x1000158
> [ using 2142480 bytes of bsd ELF symbol table ]
> Copyright (c) 1982, 1986, 1989, 1991, 1993
> The Regents of the University of California.  All rights
> reserved.
> Copyright (c) 1995-2018 OpenBSD. All rights reserved.
> https://www.OpenBSD.org
>
> OpenBSD 6.4-beta (GENERIC.MP) #296: Fri Sep 14 22:53:46 MDT 2018
> dera...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.M
> P
> real mem = 1056833536 (1007MB)
> avail mem = 1015603200 (968MB)
> mpath0 at root
> scsibus0 at mpath0: 256 targets
> mainbus0 at root
> bios0 at mainbus0: SMBIOS rev. 2.8 @ 0xf5b30 (9 entries)
> bios0: vendor SeaBIOS version "?-20180531_142017-buildhw-
> 08.phx2.fedoraproject.org-1.fc28" date 04/01/2014
> bios0: QEMU Standard PC (i440FX + PIIX, 1996)
> acpi0 at bios0: rev 0
> acpi0: sleep states S5
> acpi0: tables DSDT FACP APIC
> acpi0: wakeup devices
> acpitimer0 at acpi0: 3579545 Hz, 24 bits
> acpimadt0 at acpi0 addr 0xfee0: PC-AT compat
> cpu0 at mainbus0: apid 0 (boot processor)
> cpu0: Intel Core Processor (Haswell, no TSX, IBRS), 3392.57 MHz, 06-3c-
> 01
> cpu0:
> FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36
> ,CFLUSH,MMX,FXSR,SSE,SSE2,SSE3,PCLMUL,SSSE3,FMA3,CX16,PCID,SSE4.1,SSE4.
> 2,x2APIC,MOVBE,POPCNT,DEADLINE,AES,XSAVE,AVX,F16C,RDRAND,HV,NXE,RDTSCP,
> LONG,LAHF,ABM,FSGSBASE,BMI1,AVX2,SMEP,BMI2,ERMS,INVPCID,IBRS,IBPB,ARAT,
> XSAVEOPT,MELTDOWN
> cpu0: 64KB 64b/line 2-way I-cache, 64KB 64b/line 2-way D-cache, 512KB
> 64b/line 16-way L2 cache
> cpu0: ITLB 255 4KB entries direct-mapped, 255 4MB entries direct-mapped
> cpu0: DTLB 255 4KB entries direct-mapped, 255 4MB entries direct-mapped
> cpu0: smt 0, core 0, package 0
> mtrr: Pentium Pro MTRR support, 8 var ranges, 88 fixed ranges
> cpu0: apic clock running at 1000MHz
> ioapic0 at mainbus0: apid 0 pa 0xfec0, version 11, 24 pins
> acpiprt0 at acpi0: bus 0 (PCI0)
> acpicpu0 at acpi0: C1(@1 halt!)
> "ACPI0006" at acpi0 not configured
> acpicmos0 at acpi0
> "PNP0A06" at acpi0 not configured
> "PNP0A06" at acpi0 not configured
> "PNP0A06" at acpi0 not configured
> "QEMU0002" at acpi0 not configured
> "ACPI0010" at acpi0 not configured
> pvbus0 at mainbus0: KVM
> pci0 at mainbus0 bus 0
> pchb0 at pci0 dev 0 function 0 "Intel 82441FX" rev 0x02
> pcib0 at pci0 dev 1 function 0 "Intel 82371SB ISA" rev 0x00
> pciide0 at pci0 dev 1 function 1 "Intel 82371SB IDE" rev 0x00: DMA,
> channel 0 wired to compatibility, channel 1 wired to compatibility
> wd0 at pciide0 channel 0 drive 0: 
> wd0: 16-sector PIO, LBA48, 1906MB, 3903488 sectors
> wd0(pciide0:0:0): using PIO mode 4, DMA mode 2
> pciide0: channel 1 disabled (no drives)
> piixpm0 at pci0 dev 1 function 3 "Intel 82371AB Power" rev 0x03: apic 0
> int 9
> iic0 at piixpm0
> vga1 at pci0 dev 2 function 0 "Red Hat QXL Video" rev 0x04
> wsdisplay0 at vga1 mux 1: console (80x25, vt100 emulation)
> wsdisplay0: screen 1-5 added (80x25, vt100 emulation)
> em0 at pci0 dev 3 function 0 "Intel 82540EM" rev 0x03: apic 0 int 11,
> address 52:54:00:fc:51:31
> uhci0 at pci0 dev 4 function 0 "Intel 82801I USB" rev 0x03: apic 0 int
> 11
> uhci1 at pci0 dev 4 function 1 "Intel 82801I USB" rev 0x03: apic 0 int
> 10
> uhci2 at pci0 dev 4 function 2 "Intel 82801I USB" rev 0x03: apic 0 int
> 10
> ehci0 at pci0 dev 4 function 7 "Intel 82801I USB" rev 0x03: apic 0 int
> 11
> usb0 at ehci0: USB revision 2.0
> uhub0 at usb0 configuration 1 interface 0 "Intel EHCI root hub" rev
> 2.00/1.00 addr 1
> virtio0 at pci0 dev 5 function 0 "Qumranet Virtio Console" rev 0x00
> virtio0: no matching child driver; not configured
> virtio1 at pci0 dev 6 function 0 "Qumranet Virtio Memory" rev 0x00
> viomb0 at virtio1
> virtio1: apic 0 int 10
> isa0 at pcib0
> isadma0 at isa0
> fdc0 at isa0 port 0x3f0/6 irq 6 drq 2
> com0 at isa0 port 0x3f8/8 irq 4: ns16550a, 16 byte fifo
> com0: console
> pckbc0 at isa0 port 0x60/5 irq 1 irq 12
> pckbd0 at pckbc0 (kbd slot)
> wskbd0 at pckbd0: console keyboard, using wsdisplay0
> 

Re: Bug in OpenBSD 6.3 /usr/bin/wc

2018-09-29 Thread Scott Cheloha
On Thu, Sep 27, 2018 at 05:09:22PM -0500, Scott Cheloha wrote:
> > On Sep 27, 2018, at 10:26, Todd C. Miller  wrote:
> > 
> >> On Thu, 27 Sep 2018 16:19:46 +0100, Dave Hines wrote:
> >> 
> >> Oops - my patch contained a bug (though it worked on my machine).
> >> Here is a corrected patch for /usr/src/usr.bin/wc/wc.c
> > 
> > That fix looks correct to me.
> 
> Ditto, works here. I will commit tonight if someone else doesn't
> chime in.
> 
> (ok cheloha@ if someone else commits first)

Committed, thanks!