Re: terminal is cleared when logging as root

2023-10-24 Thread Daniel Jakots
On Tue, 24 Oct 2023 13:48:31 -0600, Todd C. Miller
 wrote:

> Index: etc/root/dot.profile
> ===
> RCS file: /cvs/src/etc/root/dot.profile,v
> retrieving revision 1.9
> diff -u -p -u -r1.9 dot.profile
> --- etc/root/dot.profile  13 Dec 2010 12:54:31 -  1.9
> +++ etc/root/dot.profile  24 Oct 2023 19:44:21 -
> @@ -11,11 +11,7 @@ umask 022
>  case "$-" in
>  *i*)# interactive shell
>   if [ -x /usr/bin/tset ]; then
> - if [ X"$XTERM_VERSION" = X"" ]; then
> - eval `/usr/bin/tset -sQ '-munknown:?vt220'
> $TERM`
> - else
> - eval `/usr/bin/tset -IsQ '-munknown:?vt220'
> $TERM`
> - fi
> + eval `/usr/bin/tset -IsQ '-munknown:?vt220' $TERM`
>   fi
>   ;;
>  esac

Applying this to my /root/.profile fixes the issue, thanks!



Re: terminal is cleared when logging as root

2023-10-24 Thread Todd C . Miller
On Tue, 24 Oct 2023 10:12:12 +0100, Stuart Henderson wrote:

> On 2023/10/24 08:21, Nicholas Marriott wrote:
> > I can't see what is different in tset, both old and new should just
> > send is2 and that hasn't changed as far as I can tell.
> > 
> > Can someone show me the output of this from before the ncurses update
> > (maybe 7.4-release):
> > 
> > /usr/bin/tset -sQ '-munknown:?vt220' vt220 2>&1|cat -v
>
> With older curses, this calls ioctl TIOCGETA on stderr and fails.
>
> 81046 tset CALL  ioctl(2,TIOCGETA,0x798691d3a00)  81046 tset 
> RET   ioctl -1 errno 25 Inappropriate ioctl for device

Perhaps we should just use the -I flag in the startup files for all
terminals.  I don't know that terminal initialization is useful for
anything other than real (not emulated) terminals.  If someone wants
to hook up a real vt100 they can remove the -I flag.

 - todd

Index: etc/skel/dot.login
===
RCS file: /cvs/src/etc/skel/dot.login,v
retrieving revision 1.6
diff -u -p -u -r1.6 dot.login
--- etc/skel/dot.login  15 Dec 2015 16:37:58 -  1.6
+++ etc/skel/dot.login  24 Oct 2023 19:43:51 -
@@ -3,11 +3,7 @@
 # csh login file
 
 if ( ! $?TERMCAP ) then
-   if ( $?XTERM_VERSION ) then
-   tset -IQ '-munknown:?vt220' $TERM
-   else
-   tset -Q '-munknown:?vt220' $TERM
-   endif
+   tset -IQ '-munknown:?vt220' $TERM
 endif
 
 stty   newcrt crterase
Index: etc/root/dot.login
===
RCS file: /cvs/src/etc/root/dot.login,v
retrieving revision 1.14
diff -u -p -u -r1.14 dot.login
--- etc/root/dot.login  20 Dec 2009 15:35:35 -  1.14
+++ etc/root/dot.login  24 Oct 2023 19:42:22 -
@@ -5,11 +5,7 @@
 if ( -x /usr/bin/tset ) then
set noglob histchars=""
onintr finish
-   if ( $?XTERM_VERSION ) then
-   eval `tset -IsQ '-munknown:?vt220' $TERM`
-   else
-   eval `tset -sQ '-munknown:?vt220' $TERM`
-   endif
+   eval `tset -IsQ '-munknown:?vt220' $TERM`
finish:
unset noglob histchars
onintr
Index: etc/root/dot.profile
===
RCS file: /cvs/src/etc/root/dot.profile,v
retrieving revision 1.9
diff -u -p -u -r1.9 dot.profile
--- etc/root/dot.profile13 Dec 2010 12:54:31 -  1.9
+++ etc/root/dot.profile24 Oct 2023 19:44:21 -
@@ -11,11 +11,7 @@ umask 022
 case "$-" in
 *i*)# interactive shell
if [ -x /usr/bin/tset ]; then
-   if [ X"$XTERM_VERSION" = X"" ]; then
-   eval `/usr/bin/tset -sQ '-munknown:?vt220' $TERM`
-   else
-   eval `/usr/bin/tset -IsQ '-munknown:?vt220' $TERM`
-   fi
+   eval `/usr/bin/tset -IsQ '-munknown:?vt220' $TERM`
fi
;;
 esac



Re: terminal is cleared when logging as root

2023-10-24 Thread Stuart Henderson
On 2023/10/24 08:21, Nicholas Marriott wrote:
> I can't see what is different in tset, both old and new should just
> send is2 and that hasn't changed as far as I can tell.
> 
> Can someone show me the output of this from before the ncurses update
> (maybe 7.4-release):
> 
> /usr/bin/tset -sQ '-munknown:?vt220' vt220 2>&1|cat -v

With older curses, this calls ioctl TIOCGETA on stderr and fails.

81046 tset CALL  ioctl(2,TIOCGETA,0x798691d3a00)  81046 tset
 RET   ioctl -1 errno 25 Inappropriate ioctl for device

It will run under script instead though:

$ /usr/bin/tset -sQ '-munknown:?vt220' vt220^M^M
^M^[[3g^[H^[H^[H^[H^[H^[H   
 ^[H^[H^M^MTERM=vt220;^M



Re: terminal is cleared when logging as root

2023-10-24 Thread Nicholas Marriott
I can't see what is different in tset, both old and new should just
send is2 and that hasn't changed as far as I can tell.

Can someone show me the output of this from before the ncurses update
(maybe 7.4-release):

/usr/bin/tset -sQ '-munknown:?vt220' vt220 2>&1|cat -v



On Mon, Oct 23, 2023 at 03:14:46PM -0600, Todd C. Miller wrote:
> On Mon, 23 Oct 2023 13:16:36 -0400, Daniel Jakots wrote:
> 
> > I installed a new machine on Saturday (with -current) and I noticed
> > that when I logged in as root the terminal get cleared but not cleanly.
> > I upgraded a existing machine to a newer snapshot and then the problem
> > appeared as well.
> >
> > This happens when using `doas su -`, `ssh root@` and I think I had it on
> > console as well.
> > For some reason, it doesn't happen with my regular user.
> >
> > Previous snapshot was from 2023-10-13. I guess it's since the
> > libcurses update on the 17th?
> 
> This is probably caused by the tset(1) update.
> 
>  - todd
> 



Re: terminal is cleared when logging as root

2023-10-23 Thread Todd C . Miller
On Mon, 23 Oct 2023 13:16:36 -0400, Daniel Jakots wrote:

> I installed a new machine on Saturday (with -current) and I noticed
> that when I logged in as root the terminal get cleared but not cleanly.
> I upgraded a existing machine to a newer snapshot and then the problem
> appeared as well.
>
> This happens when using `doas su -`, `ssh root@` and I think I had it on
> console as well.
> For some reason, it doesn't happen with my regular user.
>
> Previous snapshot was from 2023-10-13. I guess it's since the
> libcurses update on the 17th?

This is probably caused by the tset(1) update.

 - todd



Re: terminal is cleared when logging as root

2023-10-23 Thread Hrvoje Popovski
On 23.10.2023. 19:16, Daniel Jakots wrote:
> Hi, I installed a new machine on Saturday (with -current) and I noticed
> that when I logged in as root the terminal get cleared but not cleanly.
> I upgraded a existing machine to a newer snapshot and then the problem
> appeared as well. This happens when using `doas su -`, `ssh root@` and I
> think I had it on console as well. For some reason, it doesn't happen
> with my regular user. Previous snapshot was from 2023-10-13. I guess
> it's since the libcurses update on the 17th? Cheers, Daniel

Hi,

I confirm what Daniel said over ssh and over console I'm getting this


OpenBSD/amd64 (r620-1.srce.hr) (tty01)

login: root
Password:
Last login: Mon Oct 23 10:18:24 on tty01
OpenBSD 7.4-current (GENERIC.MP) #1419: Mon Oct 23 10:14:12 MDT 2023

Welcome to OpenBSD: The proactively secure Unix-like operating system.

Please use the sendbug(1) utility to report bugs in the system.
Before reporting a bug, please try to reproduce it with the latest
version of the code.  With bug reports, please try to ensure that
enough information to reproduce the problem is enclosed, and if a
known fix for it exists, include that as well.

You have mail.
F



r620-1#



when I login as user over console

OpenBSD/amd64 (r620-2.srce.hr) (tty01)

login: hrvoje
Password:
Last login: Mon Oct 23 19:55:11 on ttyp2 from 161.53.255.123
OpenBSD 7.4-current (GENERIC.MP) #1419: Mon Oct 23 10:14:12 MDT 2023

Welcome to OpenBSD: The proactively secure Unix-like operating system.

Please use the sendbug(1) utility to report bugs in the system.
Before reporting a bug, please try to reproduce it with the latest
version of the code.  With bug reports, please try to ensure that
enough information to reproduce the problem is enclosed, and if a
known fix for it exists, include that as well.

You have new mail.
r620-2$ su -
Password:
F



r620-2#



terminal is cleared when logging as root

2023-10-23 Thread Daniel Jakots
Hi,

I installed a new machine on Saturday (with -current) and I noticed
that when I logged in as root the terminal get cleared but not cleanly.
I upgraded a existing machine to a newer snapshot and then the problem
appeared as well.

This happens when using `doas su -`, `ssh root@` and I think I had it on
console as well.
For some reason, it doesn't happen with my regular user.

Previous snapshot was from 2023-10-13. I guess it's since the
libcurses update on the 17th?

Cheers,
Daniel

dmesg:
OpenBSD 7.4-current (GENERIC.MP) #1415: Fri Oct 20 10:00:26 MDT 2023
dera...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP
real mem = 4278042624 (4079MB)
avail mem = 4128636928 (3937MB)
random: good seed from bootblocks
mpath0 at root
scsibus0 at mpath0: 256 targets
mainbus0 at root
bios0 at mainbus0: SMBIOS rev. 2.8 @ 0xf59a0 (11 entries)
bios0: vendor SeaBIOS version "1.15.0-1" date 04/01/2014
bios0: QEMU Standard PC (Q35 + ICH9, 2009)
acpi0 at bios0: ACPI 3.0
acpi0: sleep states S5
acpi0: tables DSDT FACP APIC MCFG WAET
acpi0: wakeup devices
acpitimer0 at acpi0: 3579545 Hz, 24 bits
acpimadt0 at acpi0 addr 0xfee0: PC-AT compat
cpu0 at mainbus0: apid 0 (boot processor)
cpu0: Intel(R) Core(TM) i7-9700T CPU @ 2.00GHz, 312.77 MHz, 06-9e-0d
cpu0:
FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,MMX,FXSR,SSE,SSE2,SS,SSE3,PCLMUL,VMX,SSSE3,FMA3,CX16,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,MOVBE,POPCNT,DEADLINE,AES,XSAVE,AVX,F16C,RDRAND,HV,NXE,PAGE1GB,RDTSCP,LONG,LAHF,ABM,3DNOWP,PERF,FSGSBASE,TSC_ADJUST,BMI1,AVX2,SMEP,BMI2,ERMS,INVPCID,MPX,RDSEED,ADX,SMAP,CLFLUSHOPT,UMIP,MD_CLEAR,IBRS,IBPB,STIBP,SSBD,ARAT,IBRS_ALL,SKIP_L1DFL,MDS_NO,IF_PSCHANGE,TSX_CTRL,XSAVEOPT,XSAVEC,XGETBV1,XSAVES
cpu0: 32KB 64b/line 8-way D-cache, 32KB 64b/line 8-way I-cache, 4MB
64b/line 16-way L2 cache, 16MB 64b/line 16-way L3 cache cpu0: smt 0,
core 0, package 0 mtrr: Pentium Pro MTRR support, 8 var ranges, 88
fixed ranges cpu0: apic clock running at 1000MHz cpu1 at mainbus0: apid
1 (application processor) cpu1: Intel(R) Core(TM) i7-9700T CPU @
2.00GHz, 270.19 MHz, 06-9e-0d cpu1:
FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,MMX,FXSR,SSE,SSE2,SS,SSE3,PCLMUL,VMX,SSSE3,FMA3,CX16,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,MOVBE,POPCNT,DEADLINE,AES,XSAVE,AVX,F16C,RDRAND,HV,NXE,PAGE1GB,RDTSCP,LONG,LAHF,ABM,3DNOWP,PERF,FSGSBASE,TSC_ADJUST,BMI1,AVX2,SMEP,BMI2,ERMS,INVPCID,MPX,RDSEED,ADX,SMAP,CLFLUSHOPT,UMIP,MD_CLEAR,IBRS,IBPB,STIBP,SSBD,ARAT,IBRS_ALL,SKIP_L1DFL,MDS_NO,IF_PSCHANGE,TSX_CTRL,XSAVEOPT,XSAVEC,XGETBV1,XSAVES
cpu1: 32KB 64b/line 8-way D-cache, 32KB 64b/line 8-way I-cache, 4MB
64b/line 16-way L2 cache, 16MB 64b/line 16-way L3 cache cpu1: smt 0,
core 0, package 1 ioapic0 at mainbus0: apid 0 pa 0xfec0, version
11, 24 pins acpimcfg0 at acpi0 acpimcfg0: addr 0xb000, bus 0-255
acpiprt0 at acpi0: bus 0 (PCI0)
"ACPI0006" at acpi0 not configured
acpipci0 at acpi0 PCI0: 0x0010 0x0011 0x
com0 at acpi0 COM1 addr 0x3f8/0x8 irq 4: ns16550a, 16 byte fifo
acpicmos0 at acpi0
"PNP0A06" at acpi0 not configured
"PNP0A06" at acpi0 not configured
"PNP0A06" at acpi0 not configured
"QEMU0002" at acpi0 not configured
"ACPI0010" at acpi0 not configured
acpicpu0 at acpi0: C1(@1 halt!)
acpicpu1 at acpi0: C1(@1 halt!)
pvbus0 at mainbus0: KVM
pvclock0 at pvbus0
pci0 at mainbus0 bus 0
pchb0 at pci0 dev 0 function 0 "Intel 82G33 Host" rev 0x00
vga1 at pci0 dev 1 function 0 "Qumranet Virtio 1.x GPU" rev 0x01
wsdisplay0 at vga1 mux 1: console (80x25, vt100 emulation)
wsdisplay0: screen 1-5 added (80x25, vt100 emulation)
ppb0 at pci0 dev 2 function 0 vendor "Red Hat", unknown product 0x000c
rev 0x00: apic 0 int 22 pci1 at ppb0 bus 1
virtio0 at pci1 dev 0 function 0 "Qumranet Virtio 1.x Network" rev 0x01
vio0 at virtio0: address 52:54:00:06:db:03
virtio0: msix per-VQ
ppb1 at pci0 dev 2 function 1 vendor "Red Hat", unknown product 0x000c
rev 0x00: apic 0 int 22 pci2 at ppb1 bus 2
xhci0 at pci2 dev 0 function 0 vendor "Red Hat", unknown product 0x000d
rev 0x01: msix, xHCI 0.0 usb0 at xhci0: USB revision 3.0
uhub0 at usb0 configuration 1 interface 0 "Red Hat xHCI root hub" rev
3.00/1.00 addr 1 ppb2 at pci0 dev 2 function 2 vendor "Red Hat",
unknown product 0x000c rev 0x00: apic 0 int 22 pci3 at ppb2 bus 3
virtio1 at pci3 dev 0 function 0 "Qumranet Virtio 1.x Console" rev 0x01
virtio1: no matching child driver; not configured
ppb3 at pci0 dev 2 function 3 vendor "Red Hat", unknown product 0x000c
rev 0x00: apic 0 int 22 pci4 at ppb3 bus 4
virtio2 at pci4 dev 0 function 0 "Qumranet Virtio 1.x Storage" rev 0x01
vioblk0 at virtio2
scsibus1 at vioblk0: 1 targets
sd0 at scsibus1 targ 0 lun 0: 
sd0: 92160MB, 512 bytes/sector, 188743680 sectors
virtio2: msix per-VQ
ppb4 at pci0 dev 2 function 4 vendor "Red Hat", unknown product 0x000c
rev 0x00: apic 0 int 22 pci5 at ppb4 bus 5
virtio3 at pci5 dev 0 function 0 vendor "Qumranet", unknown product
0x1045 rev 0x01 viomb0 at virtio3
virtio3: apic 0 int 22
ppb5 at