Re: [RTEMS Project] #2331: c/src/lib/libbsp/sparc/shared/1553/gr1553b.c: 2 * memory leak ?

[RTEMS trac]

#2331: c/src/lib/libbsp/sparc/shared/1553/gr1553b.c: 2 * memory leak ?
-+---
 Reporter:  David Binderman  |   Owner:  Daniel Hellstrom
 Type:  defect   |  Status:  closed
 Priority:  normal   |   Milestone:  4.11.4
Component:  arch/sparc   | Version:  4.11
 Severity:  normal   |  Resolution:  fixed
 Keywords:   |  Blocked By:
 Blocking:   |
-+---
Changes (by Daniel Hellstrom ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"a100457c7d59fa2111429efc6b7b1b70f9f6984f/rtems"
 a100457/rtems]:
 {{{
 #!CommitTicketReference repository="rtems"
 revision="a100457c7d59fa2111429efc6b7b1b70f9f6984f"
 leon,gr1553b: improve init check

 Check in init3 not needed since same data is already checked in init2
 stage. Adds an extra check that the APB register space is available before
 accessing it.

 Closes #2331
 }}}

--
Ticket URL: 
RTEMS Project 
RTEMS Project
___
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs

Re: [RTEMS Project] #2331: c/src/lib/libbsp/sparc/shared/1553/gr1553b.c: 2 * memory leak ?

[RTEMS trac]

#2331: c/src/lib/libbsp/sparc/shared/1553/gr1553b.c: 2 * memory leak ?
-+---
 Reporter:  David Binderman  |   Owner:  Daniel Hellstrom
 Type:  defect   |  Status:  assigned
 Priority:  normal   |   Milestone:  4.11.4
Component:  arch/sparc   | Version:  4.11
 Severity:  normal   |  Resolution:
 Keywords:   |  Blocked By:
 Blocking:   |
-+---

Comment (by Chris Johns):

 Can the fix in `master` be applied to the `4.11` branch?

--
Ticket URL: 
RTEMS Project 
RTEMS Project
___
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs

Re: [RTEMS Project] #2331: c/src/lib/libbsp/sparc/shared/1553/gr1553b.c: 2 * memory leak ?

[RTEMS trac]

#2331: c/src/lib/libbsp/sparc/shared/1553/gr1553b.c: 2 * memory leak ?
-+---
 Reporter:  David Binderman  |   Owner:  Daniel Hellstrom
 Type:  defect   |  Status:  assigned
 Priority:  normal   |   Milestone:  4.11.3
Component:  arch/sparc   | Version:  4.11
 Severity:  normal   |  Resolution:
 Keywords:   |  Blocked By:
 Blocking:   |
-+---
Changes (by Chris Johns):

 * component:  unspecified => arch/sparc


--
Ticket URL: 
RTEMS Project 
RTEMS Project
___
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs

Re: [RTEMS Project] #2331: c/src/lib/libbsp/sparc/shared/1553/gr1553b.c: 2 * memory leak ?

[RTEMS trac]

#2331: c/src/lib/libbsp/sparc/shared/1553/gr1553b.c: 2 * memory leak ?
-+---
 Reporter:  David Binderman  |   Owner:  Daniel Hellstrom
 Type:  defect   |  Status:  assigned
 Priority:  normal   |   Milestone:  4.11.3
Component:  unspecified  | Version:  4.11
 Severity:  normal   |  Resolution:
 Keywords:   |  Blocked By:
 Blocking:   |
-+---

Comment (by Chris Johns):

 Should this change also be fixed on the 4.11 branch?

--
Ticket URL: 
RTEMS Project 
RTEMS Project
___
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs

Re: [RTEMS Project] #2331: c/src/lib/libbsp/sparc/shared/1553/gr1553b.c: 2 * memory leak ?

[RTEMS trac]

#2331: c/src/lib/libbsp/sparc/shared/1553/gr1553b.c: 2 * memory leak ?
-+---
 Reporter:  David Binderman  |   Owner:  Daniel Hellstrom
 Type:  defect   |  Status:  assigned
 Priority:  normal   |   Milestone:  4.11.3
Component:  General  | Version:  4.11
 Severity:  normal   |  Resolution:
 Keywords:   |
-+---

Comment (by Daniel Hellstrom):

 Fixed in master by 360fb2fe75c88a5cc6ebff08f37fe60936352f62.

--
Ticket URL: 
RTEMS Project 
RTEMS Project
___
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs

Re: [RTEMS Project] #2331: c/src/lib/libbsp/sparc/shared/1553/gr1553b.c: 2 * memory leak ?

[RTEMS trac]

#2331: c/src/lib/libbsp/sparc/shared/1553/gr1553b.c: 2 * memory leak ?
-+---
 Reporter:  dcb  |   Owner:  daniel
 Type:  defect   |  Status:  assigned
 Priority:  normal   |   Milestone:  4.11.1
Component:  General  | Version:  4.10
 Severity:  normal   |  Resolution:
 Keywords:   |
-+---

Comment (by daniel):

 case 1 is a memory leak. It should be safe for the driver to assume that
 dev-businfo always is initialized, setting it to NULL makes no sense when
 a device have been created. Rather it should check if the APB registers
 are present.

 case 2. is ok as Joel points out.

 The driver does not implement the drvmgr device remove() function, so the
 memory is never freed.

 I will suggest a pacth.

--
Ticket URL: http://devel.rtems.org/ticket/2331#comment:3
RTEMS Project http://www.rtems.org/
RTEMS Project
___
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs

Re: [RTEMS Project] #2331: c/src/lib/libbsp/sparc/shared/1553/gr1553b.c: 2 * memory leak ?

[RTEMS trac]

#2331: c/src/lib/libbsp/sparc/shared/1553/gr1553b.c: 2 * memory leak ?
-+---
 Reporter:  dcb  |   Owner:  daniel
 Type:  defect   |  Status:  assigned
 Priority:  normal   |   Milestone:  4.11.1
Component:  General  | Version:  4.10
 Severity:  normal   |  Resolution:
 Keywords:   |
-+---

Comment (by joel.sherrill):

 I believe case 1 is a leak on the error case.

 Case 2 looks OK. The two malloc'ed chunks of memory have been placed on a
 list for future use.

 Are two free's called on the close path?

--
Ticket URL: http://devel.rtems.org/ticket/2331#comment:2
RTEMS Project http://www.rtems.org/
RTEMS Project
___
bugs mailing list
bugs@rtems.org
http://lists.rtems.org/mailman/listinfo/bugs