Re: Need reviewer: OpenJDK7 binary plug logic removal

2010-12-23 Thread Andrew Haley

On 12/23/2010 05:32 AM, David Holmes wrote:

Kelly O'Hair said the following on 12/23/10 11:51:

Need reviewer: OpenJDK7 binary plug logic removal

7008723: Remove binary plugs creation and use from openjdk
http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-plug-removal/webrev/


Looks nicely eradicated to me. Surprised how far it's tentacles spread ...


Indeed.  This patch surely is worthy of a little celebration.
Begone, binary plugs, never again to darken our doors...

Andrew.


Re: Need reviewer: OpenJDK7 binary plug logic removal

2010-12-23 Thread Dr Andrew John Hughes
On 09:56 Thu 23 Dec , Andrew Haley wrote:
 On 12/23/2010 05:32 AM, David Holmes wrote:
  Kelly O'Hair said the following on 12/23/10 11:51:
  Need reviewer: OpenJDK7 binary plug logic removal
 
  7008723: Remove binary plugs creation and use from openjdk
  http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-plug-removal/webrev/
 
  Looks nicely eradicated to me. Surprised how far it's tentacles spread ...
 
 Indeed.  This patch surely is worthy of a little celebration.
 Begone, binary plugs, never again to darken our doors...
 
 Andrew.

Looks good to me too.  Good to see the jdk7 README finally being updated :-)
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8