date:20130118

Here is a new webrev with my sorts incorporated. This has been baking 
for quite a while in build-infra now and seems to be working.


http://cr.openjdk.java.net/~erikj/8004151/webrev.jdk.04/

/Erik

On 2012-12-07 11:05, Erik Joelsson wrote:

(resending to full recepients list)

I just hit another issue. I tried using a jdk8 boot-jdk and the order 
of the output was different in the generated sizes file compared to 
the one in the repo. Sorting both resulted in a clean diff.


/Erik

On 2012-12-05 14:20, Fredrik Öhrström wrote:

2012-11-29 15:54, Fredrik Öhrström skrev:

2012-11-29 15:36, Erik Joelsson skrev:
I just submitted a patch to build-infra for the dual generation on 
all platforms since it breaks comparisons between old and new 
build. In general, we can't change behavior in new build without 
also changing the old before the old is removed.


Removing sizes.64-solaris-i386 breaks the old build on solaris-x86, 
so I have readded it to build-infra.


Thanks Erik! The new and updated webrev is here:

http://cr.openjdk.java.net/~ohrstrom/webrev-8004151-gensrcX11wrapper-v2/ 
http://cr.openjdk.java.net/%7Eohrstrom/webrev-8004151-gensrcX11wrapper-v2/ 



Ok, new webrev incorporating a few more Erik changes. Any comments 
from the AWT experts?

http://cr.openjdk.java.net/~ohrstrom/webrev-8004151-gensrcX11wrapper-v3/

//Fredrik

jdk8 - no docs directory

Hi, I built jdk8 last night and left NO_DOCS=true off but I have no docs
directory.  What do I need to do?  Here are the highlights of what  did:
- install the import bundle from
http://jre.us.oracle.com/java/re/jdk/8.0/promoted/latest/bundles/windows-i586/jdk-8-ea-windows-i586.tar.gz
- set ALT_JDK_IMPORT_PATH pointing to it
- clone top level: hg clone http://hg.openjdk.java.net/jdk8/awt
- clone jdk8: hg clone http://hg.openjdk.java.net/jdk8/awt/jdk
- cd ...\jdk\make
- make ARCH_DATA_MODEL=32 ALLOW_DOWNLOADS=true fastdebug_build

The build ran  a long time and appears to have finished normally.

Pete

Review Request: 8006567: jre/lib/applet missing from Mac JDK installation

When copying the j2*-image dirs to j2*-bundle, empty directories weren't 
included. This caused jre/lib/applet to be missing. This patch makes 
sure empty directories are also copied over.


http://cr.openjdk.java.net/~erikj/8006567/webrev.jdk.01/

/Erik

Re: Review Request: 8003693: build-infra: bridgeBuild should allow for partial build (no hotspot)


Erik:

Making it possible to use --with-import-hotspot through bridgeBuild 
and jprt. Also converted check for open only to use same wildcard 
construction as the new HOTSPOT_AVAILABLE to avoid unneeded shell 
expressions.


http://cr.openjdk.java.net/~erikj/8003693/webrev.root.01/


Looks good-

Tim

Review Request: 8006579: build-infra: In jvm.cfg, alias -server to -client when no server jvm is built.

Small patch to fix a minor difference between new and old build. In 
jvm.cfg, alias -server to -client when no server jvm is built.


http://cr.openjdk.java.net/~erikj/8006579/webrev.jdk.01/

/Erik

Review Request: 8006583: build-infra: Remove /javax/swing/SwingBeanInfoBase.java from src.zip

Cleanup after JDK-8005096, which accidentally added 
/javax/swing/SwingBeanInfoBase.java to src.zip for build-infra but not 
for old build.


http://cr.openjdk.java.net/~erikj/8006583/webrev.jdk.01/

/Erik

Re: Review Request: 8006579: build-infra: In jvm.cfg, alias -server to -client when no server jvm is built.


Erik:

Small patch to fix a minor difference between new and old build. In 
jvm.cfg, alias -server to -client when no server jvm is built.


http://cr.openjdk.java.net/~erikj/8006579/webrev.jdk.01/


Looks good.

Tim

unexpected hg status report

I just ran hg status on a newly cloned jdk8 jdk directory and everything
is listed as modified.  I don't know if I did something wrong or
something else is broken.  Here's what I did:

- install the import bundle from
http://jre.us.oracle.com/java/re/jdk/8.0/promoted/latest/bundles/windows-i586/jdk-8-ea-windows-i586.tar.gz
- set ALT_JDK_IMPORT_PATH pointing to it
- clone top level: hg clone http://hg.openjdk.java.net/jdk8/awt
- clone jdk8: hg clone http://hg.openjdk.java.net/jdk8/awt/jdk
- cd ...\jdk\make
- make ARCH_DATA_MODEL=32 ALLOW_DOWNLOADS=true fastdebug_build
- make ARCH_DATA_MODEL=32 ALLOW_DOWNLOADS=true docs // found out
fastdebug doesn't build docs
- cd ..
- hg import --no-commit ...\jdk.patch (patches for 3 files) // it
failed, due to uncommitted changes
- hg status // all files in jdk tree listed as modified

Do I have to start over?

Pete

Re: unexpected hg status report

I diffed one of the files:
old mode 100644
new mode 100755

While I've occasionally run into mode differences before on files I've
changed I haven't seen this problem on every file.  I'm running cygwig
on Win 7.

Pete

On 1/18/13 11:23 AM, Pete Brunet wrote:
 I just ran hg status on a newly cloned jdk8 jdk directory and everything
 is listed as modified.  I don't know if I did something wrong or
 something else is broken.  Here's what I did:

 - install the import bundle from
 http://jre.us.oracle.com/java/re/jdk/8.0/promoted/latest/bundles/windows-i586/jdk-8-ea-windows-i586.tar.gz
 - set ALT_JDK_IMPORT_PATH pointing to it
 - clone top level: hg clone http://hg.openjdk.java.net/jdk8/awt
 - clone jdk8: hg clone http://hg.openjdk.java.net/jdk8/awt/jdk
 - cd ...\jdk\make
 - make ARCH_DATA_MODEL=32 ALLOW_DOWNLOADS=true fastdebug_build
 - make ARCH_DATA_MODEL=32 ALLOW_DOWNLOADS=true docs // found out
 fastdebug doesn't build docs
 - cd ..
 - hg import --no-commit ...\jdk.patch (patches for 3 files) // it
 failed, due to uncommitted changes
 - hg status // all files in jdk tree listed as modified

 Do I have to start over?

 Pete

Re: Review Request: 8006583: build-infra: Remove /javax/swing/SwingBeanInfoBase.java from src.zip


Hi Erik-

Cleanup after JDK-8005096, which accidentally added 
/javax/swing/SwingBeanInfoBase.java to src.zip for build-infra but not 
for old build.


http://cr.openjdk.java.net/~erikj/8006583/webrev.jdk.01/


Looks good.

Tim

Re: unexpected hg status report

This is probably not the right workaround but it worked for me:
cd ... // one level above awt
chmod -R 644 awt
cd .../jdk
hg status // two files found, an exe and a bat
chmod 755 src/share/sample/scripting/scriptpad/src/scripts/memory.bat
chmod 755 test/sun/management/windows/revokeall.exe

Now hg status runs clean. 

cding to directories fails and would require more 755s on dirs you want
to cd too but Win Explorer doesn't complain.

Pete

On 1/18/13 11:34 AM, Pete Brunet wrote:
 I diffed one of the files:
 old mode 100644
 new mode 100755

 While I've occasionally run into mode differences before on files I've
 changed I haven't seen this problem on every file.  I'm running cygwig
 on Win 7.

 Pete

 On 1/18/13 11:23 AM, Pete Brunet wrote:
 I just ran hg status on a newly cloned jdk8 jdk directory and everything
 is listed as modified.  I don't know if I did something wrong or
 something else is broken.  Here's what I did:

 - install the import bundle from
 http://jre.us.oracle.com/java/re/jdk/8.0/promoted/latest/bundles/windows-i586/jdk-8-ea-windows-i586.tar.gz
 - set ALT_JDK_IMPORT_PATH pointing to it
 - clone top level: hg clone http://hg.openjdk.java.net/jdk8/awt
 - clone jdk8: hg clone http://hg.openjdk.java.net/jdk8/awt/jdk
 - cd ...\jdk\make
 - make ARCH_DATA_MODEL=32 ALLOW_DOWNLOADS=true fastdebug_build
 - make ARCH_DATA_MODEL=32 ALLOW_DOWNLOADS=true docs // found out
 fastdebug doesn't build docs
 - cd ..
 - hg import --no-commit ...\jdk.patch (patches for 3 files) // it
 failed, due to uncommitted changes
 - hg status // all files in jdk tree listed as modified

 Do I have to start over?

 Pete

Re: unexpected hg status report

There have been other reports of similar file permission problems when 
command line access via Cygwin is mixed with creating directories or 
doing other operations via the Windows GUI (explorer?).


I don't have a reference handy, but some searching should be able to 
uncover the email threads in archives of build-dev or 
build-infra-...@openjdk.java.net


My solution is to eschew the Windows GUI and use the command line, just 
as you would on any other server.


Tim

On 01/18/13 10:39, Pete Brunet wrote:

This is probably not the right workaround but it worked for me:
cd ... // one level above awt
chmod -R 644 awt
cd .../jdk
hg status // two files found, an exe and a bat
chmod 755 src/share/sample/scripting/scriptpad/src/scripts/memory.bat
chmod 755 test/sun/management/windows/revokeall.exe

Now hg status runs clean.

cding to directories fails and would require more 755s on dirs you want
to cd too but Win Explorer doesn't complain.

Pete

On 1/18/13 11:34 AM, Pete Brunet wrote:

I diffed one of the files:
old mode 100644
new mode 100755

While I've occasionally run into mode differences before on files I've
changed I haven't seen this problem on every file.  I'm running cygwig
on Win 7.

Pete

On 1/18/13 11:23 AM, Pete Brunet wrote:

I just ran hg status on a newly cloned jdk8 jdk directory and everything
is listed as modified.  I don't know if I did something wrong or
something else is broken.  Here's what I did:

- install the import bundle from
http://jre.us.oracle.com/java/re/jdk/8.0/promoted/latest/bundles/windows-i586/jdk-8-ea-windows-i586.tar.gz
- set ALT_JDK_IMPORT_PATH pointing to it
- clone top level: hg clone http://hg.openjdk.java.net/jdk8/awt
- clone jdk8: hg clone http://hg.openjdk.java.net/jdk8/awt/jdk
- cd ...\jdk\make
- make ARCH_DATA_MODEL=32 ALLOW_DOWNLOADS=true fastdebug_build
- make ARCH_DATA_MODEL=32 ALLOW_DOWNLOADS=true docs // found out
fastdebug doesn't build docs
- cd ..
- hg import --no-commit ...\jdk.patch (patches for 3 files) // it
failed, due to uncommitted changes
- hg status // all files in jdk tree listed as modified

Do I have to start over?

Pete

Re: unexpected hg status report

Hi Tim, I did the whole process from the cygwin command line, as I
normally do. I just mentioned Explorer as a way to look through
directories since I 644'd everything as a workaround and so was getting
access denied messages when cding to 644'd directories. This issue of
hg status reporting that everything has been modified after a clone is
new. hg diff indicates that the repo thinks all my files should be 644
but the clone process apparently made them all 755. At least that's
what I think is going on. I don't know if the permissions are wrong in
the cloned repo (.hg directory) or the cloned files in the workspace.

Pete

On 1/18/13 12:55 PM, Tim Bell wrote:
There have been other reports of similar file permission problems when
command line access via Cygwin is mixed with creating directories or
doing other operations via the Windows GUI (explorer?).

I don't have a reference handy, but some searching should be able to
uncover the email threads in archives of build-dev or
build-infra-...@openjdk.java.net

My solution is to eschew the Windows GUI and use the command line,
just as you would on any other server.

Tim

On 01/18/13 10:39, Pete Brunet wrote:
This is probably not the right workaround but it worked for me:
cd ... // one level above awt
chmod -R 644 awt
cd .../jdk
hg status // two files found, an exe and a bat
chmod 755 src/share/sample/scripting/scriptpad/src/scripts/memory.bat
chmod 755 test/sun/management/windows/revokeall.exe

Now hg status runs clean.

cding to directories fails and would require more 755s on dirs you want
to cd too but Win Explorer doesn't complain.

Pete

On 1/18/13 11:34 AM, Pete Brunet wrote:
I diffed one of the files:
old mode 100644
new mode 100755

While I've occasionally run into mode differences before on files I've
changed I haven't seen this problem on every file. I'm running cygwig
on Win 7.

Pete

On 1/18/13 11:23 AM, Pete Brunet wrote:
I just ran hg status on a newly cloned jdk8 jdk directory and
everything
is listed as modified. I don't know if I did something wrong or
something else is broken. Here's what I did:

- install the import bundle from
http://jre.us.oracle.com/java/re/jdk/8.0/promoted/latest/bundles/windows-i586/jdk-8-ea-windows-i586.tar.gz

- set ALT_JDK_IMPORT_PATH pointing to it
- clone top level: hg clone http://hg.openjdk.java.net/jdk8/awt
- clone jdk8: hg clone http://hg.openjdk.java.net/jdk8/awt/jdk
- cd ...\jdk\make
- make ARCH_DATA_MODEL=32 ALLOW_DOWNLOADS=true fastdebug_build
- make ARCH_DATA_MODEL=32 ALLOW_DOWNLOADS=true docs // found out
fastdebug doesn't build docs
- cd ..
- hg import --no-commit ...\jdk.patch (patches for 3 files) // it
failed, due to uncommitted changes
- hg status // all files in jdk tree listed as modified

Do I have to start over?

Pete

Re: unexpected hg status report