Re: RFR 8010280: jvm.cfg needs updating for non-server builds

[Mandy Chung]

On 4/16/2013 7:34 PM, David Holmes wrote:


A "simple" sanity test? ;-) This would involve finding all the 
libjvm's in a JRE and extracting their names, then finding and reading 
the jvm.cfg file in the JRE, then invoking the VM with all the 
possible entries in jvm.cfg and using the version string to try and 
see if the right VM was selected (or the right error produced). That 
sounds like a pretty horrible test to write. :(  I think noreg-hard is 
best for this one. :)


What I was thinking is a simple one to make sure that the jvm of the 
KNOWN entry does exist (that at least validates one part of the jvm.cfg 
:)  In any case, your change is good to push.


Mandy

Re: RFR 8010280: jvm.cfg needs updating for non-server builds

[David Holmes]

On 17/04/2013 3:51 AM, Mandy Chung wrote:


On 4/15/2013 3:42 PM, David Holmes wrote:

FYI updated webrev at same location, removing the dead code Erik spotted.

http://cr.openjdk.java.net/~dholmes/8010280/webrev/



Looks good to me.  Nit: CopyFiles.gmk line 340 - you may want to remove
the extra space to align with the next line.


Thanks Mandy.


I've attached all the generated versions below.


Thanks for the generated files that are helpful for the review. Have you
considered adding a simple sanity test, if not present, to validate
jvm.cfg matches with the vm binaries bundled in JAVA_HOME? Just a
thought and maybe you can file a RFE to add such a test later if you
think it's a good idea.


A "simple" sanity test? ;-) This would involve finding all the libjvm's 
in a JRE and extracting their names, then finding and reading the 
jvm.cfg file in the JRE, then invoking the VM with all the possible 
entries in jvm.cfg and using the version string to try and see if the 
right VM was selected (or the right error produced). That sounds like a 
pretty horrible test to write. :(  I think noreg-hard is best for this 
one. :)


Thanks,
David


Mandy

How to deal with a missing VM? (was Re: RFR 8010280: jvm.cfg needs updating for non-server builds)

[David Holmes]

This change to the jvm.cfg file needs to be put through our internal CCC 
process for approval. Given that, and that this is mostly about policy 
(not mechanism) and there is no absolute right answer just a 
not-unreasonable default, I thought I would solicit opinions on this.


what should be the behaviour if you ask for a VM that could be, but 
isn't present? Options:


a) Missing from jvm.cfg so VM error:

Unrecognized option: -client
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

b) ERROR in jvm.cfg

Error: client VM not supported

c) WARN in jvm.cfg

Warning: client VM not supported;  VM will be used

d) ALIAS to default (which is in effect a silent warning but with 
control over which VM to use)


e) IGNORE (which seems to be a degenerate case of ALIAS as it just uses 
the default)


Note that this has no affect on the Oracle JDK (SE or Embedded) as the 
committed jvm.cfg (possibly with '-minimal KNOWN' added) will be used. 
This is primarily about developer builds.


Thanks,
David


On 16/04/2013 8:42 AM, David Holmes wrote:

FYI updated webrev at same location, removing the dead code Erik spotted.

http://cr.openjdk.java.net/~dholmes/8010280/webrev/

On 16/04/2013 2:25 AM, Mike Duigou wrote:

Hi David;

I remember reviewing the jvm.cfg config patch for JDK 7. I had hoped
to see the "classic" and "green" flags go away and some of the other
legacy flags like "-hotspot" reduced to WARN. What's the difference
between removing an entry completely and retaining it with "ERROR"?


Just the nature of the error message:

 > java -green
Error: green VM not supported
 > java -blue
Unrecognized option: -blue
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

I wasn't touching any of the legacy stuff - though if this needs to go
to CCC I would suggest removing all the legacy entries.


Additionally I don't like that aliases have differing definitions and
some confusing ones like "-server ALIASED_TO -client". Is this
necessary or just historically convenient?


I don't like aliases period! Historically (and this is very recent
history) it was necessary to deal with the test suites being applied to
a JDK with, eg, only client VM. Every test that specified -server would
fail if the alias didn't exist (and as I stated we're moving away from
that ie the tests don't set -client or -server but the complete test
suite run does, and it knows what VM is under test.

Personally I'd probably choose WARN for any VM not present.

The problem is that the "right" thing depends on who is building what,
and how they plan to use it. All I can do is define a not-unreasonable
default policy. I also have a time constraint as I need to get this in
before the 23rd to meet an internal deadline.

I've attached all the generated versions below.

Thanks,
David

::
linux-i586-client/jdk/lib/i386/jvm.cfg
::
-client KNOWN
-server ALIASED_TO -client
-hotspot ALIASED_TO -client
-classic WARN
-native ERROR
-green ERROR
::
linux-i586-client-server/jdk/lib/i386/jvm.cfg
::
# Copyright (c) 2001, 2013, Oracle and/or its affiliates. All rights
reserved.
# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
#
# This code is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License version 2 only, as
# published by the Free Software Foundation.  Oracle designates this
# particular file as subject to the "Classpath" exception as provided
# by Oracle in the LICENSE file that accompanied this code.
#
# This code is distributed in the hope that it will be useful, but WITHOUT
# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
# FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
# version 2 for more details (a copy is included in the LICENSE file that
# accompanied this code).
#
# You should have received a copy of the GNU General Public License version
# 2 along with this work; if not, write to the Free Software Foundation,
# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
#
# Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
# or visit www.oracle.com if you need additional information or have any
# questions.
#
# List of JVMs that can be used as an option to java, javac, etc.
# Order is important -- first in this list is the default JVM.
# NOTE that this both this file and its format are UNSUPPORTED and
# WILL GO AWAY in a future release.
#
# You may also select a JVM in an arbitrary location with the
# "-XXaltjvm=" option, but that too is unsupported
# and may not be available in a future release.
#
-client IF_SERVER_CLASS -server
-server KNOWN
-hotspot ALIASED_TO -client
-classic WARN
-native ERROR
-green ERROR
::
linux-i586-client-server-minimal1/jdk/lib/i386/jvm.cfg
::
# Copyright (c) 2001, 2013, Oracle and/or its affiliates. All 

Fix zero build on arm

[Omair Majid]

Hi,

The following webrev makes zero build succesfully on arm:
http://cr.openjdk.java.net/~omajid/webrevs/zero-on-arm/00/

The only problem I ran into while trying to build zero on armv7l is that
the gcc there does not like -m32. The changes make the build system
check whether the compiler supports the -m32/-m64 flag before using it.

Any thoughts or comments?

Thanks,
Omair

-- 
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681

hg: jdk8/build/langtools: 19 new changesets

[david . katleman]

Changeset: 330b35b27e68
Author:darcy
Date:  2013-03-26 17:17 -0700
URL:   http://hg.openjdk.java.net/jdk8/build/langtools/rev/330b35b27e68

7041251: Use j.u.Objects utility methods in langtools
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/util/Pair.java
! src/share/classes/javax/annotation/processing/AbstractProcessor.java

Changeset: 33b6a52f0037
Author:darcy
Date:  2013-03-26 18:15 -0700
URL:   http://hg.openjdk.java.net/jdk8/build/langtools/rev/33b6a52f0037

7059170: Assume availablility of URLClassLoader.close
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/util/BaseFileManager.java
- src/share/classes/com/sun/tools/javac/util/CloseableURLClassLoader.java

Changeset: 7bebe17ff323
Author:mcimadamore
Date:  2013-03-28 11:38 +
URL:   http://hg.openjdk.java.net/jdk8/build/langtools/rev/7bebe17ff323

8010469: Bad assertion in LambdaToMethod
Summary: Add assertion in LambdaToMethod.serializedLambdaName
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java

Changeset: a200d8ccfe47
Author:mcimadamore
Date:  2013-03-28 11:39 +
URL:   http://hg.openjdk.java.net/jdk8/build/langtools/rev/a200d8ccfe47

8010490: FindBugs: double assignments in LambdaToMethod.visitIdent
Summary: Remove dead code from LambdaToMethod
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java

Changeset: 991f11e13598
Author:jjg
Date:  2013-03-28 10:49 -0700
URL:   http://hg.openjdk.java.net/jdk8/build/langtools/rev/991f11e13598

8006346: doclint should make allowance for headers generated by standard doclet
Reviewed-by: mcimadamore

! src/share/classes/com/sun/tools/doclint/Checker.java
! src/share/classes/com/sun/tools/doclint/DocLint.java
! src/share/classes/com/sun/tools/doclint/Env.java
! src/share/classes/com/sun/tools/javac/main/Main.java
! src/share/classes/com/sun/tools/javadoc/DocEnv.java
+ test/tools/javac/doclint/ImplicitHeadersTest.java
+ test/tools/javadoc/doclint/ImplicitHeadersTest.java

Changeset: d3648557391b
Author:jjg
Date:  2013-03-28 10:58 -0700
URL:   http://hg.openjdk.java.net/jdk8/build/langtools/rev/d3648557391b

8010511: Tests are creating files in /tmp
Reviewed-by: darcy

! test/tools/javac/T6558476.java
! test/tools/javac/T6900149.java
! test/tools/javac/diags/CheckExamples.java
! test/tools/javac/diags/RunExamples.java

Changeset: 29c6984a1673
Author:vromero
Date:  2013-04-02 10:51 +0100
URL:   http://hg.openjdk.java.net/jdk8/build/langtools/rev/29c6984a1673

4965689: class literal code wastes a byte
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/jvm/Code.java
! src/share/classes/com/sun/tools/javac/jvm/Gen.java
! src/share/classes/com/sun/tools/javac/jvm/Items.java
+ test/tools/javac/T4965689/ClassLiteralWastesByteTest.java

Changeset: 46d2f144ebbd
Author:lana
Date:  2013-04-02 12:00 -0700
URL:   http://hg.openjdk.java.net/jdk8/build/langtools/rev/46d2f144ebbd

Merge


Changeset: 0d47e6131490
Author:darcy
Date:  2013-04-03 12:27 -0700
URL:   http://hg.openjdk.java.net/jdk8/build/langtools/rev/0d47e6131490

8011052: Add DEFAULT to javax.lang.model.Modifier
Reviewed-by: abuckley, jjg

! src/share/classes/com/sun/tools/javac/code/Flags.java
! src/share/classes/javax/lang/model/element/Modifier.java
! test/tools/javac/processing/model/element/TestExecutableElement.java

Changeset: e06dc8345d9c
Author:lana
Date:  2013-04-05 14:51 -0700
URL:   http://hg.openjdk.java.net/jdk8/build/langtools/rev/e06dc8345d9c

Merge


Changeset: b71a61d39cf7
Author:mcimadamore
Date:  2013-04-08 15:51 +0100
URL:   http://hg.openjdk.java.net/jdk8/build/langtools/rev/b71a61d39cf7

8010922: Cleanup: add support for ad-hoc method check logic
Summary: Support pluggable method checkers
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/Attr.java
! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java
! src/share/classes/com/sun/tools/javac/comp/Infer.java
! src/share/classes/com/sun/tools/javac/comp/Resolve.java

Changeset: b54122b9372d
Author:mcimadamore
Date:  2013-04-08 15:52 +0100
URL:   http://hg.openjdk.java.net/jdk8/build/langtools/rev/b54122b9372d

8010823: DefaultMethodTest.testReflectCall fails with new lambda VM
Summary: Fix lambda test
Reviewed-by: jjg

! test/tools/javac/lambdaShapes/org/openjdk/tests/vm/DefaultMethodsTest.java

Changeset: e9d986381414
Author:mcimadamore
Date:  2013-04-08 15:53 +0100
URL:   http://hg.openjdk.java.net/jdk8/build/langtools/rev/e9d986381414

8010404: Lambda debugging: redundant LineNumberTable entry for lambda capture
Summary: Ignore indy entries in LineNumberTable
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/jvm/Code.java
! src/share/classes/com/sun/tools/javac/jvm/Gen.java
! test/tools/javac/lambda/TestInvokeDynamic.java

Changeset: 94a202228ec2
Author:mcimadamore
Date:  2013-04-08 15:57 +0100
URL:   htt

hg: jdk8/build/nashorn: 30 new changesets

[david . katleman]

Changeset: 41a212ea8c0c
Author:sundar
Date:  2013-03-28 20:48 +0530
URL:   http://hg.openjdk.java.net/jdk8/build/nashorn/rev/41a212ea8c0c

8010924: Dealing with undefined property gets you a fatal stack
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/internal/runtime/resources/mozilla_compat.js
+ test/script/basic/JDK-8010924.js

Changeset: e2ea7a29b9c1
Author:lagergren
Date:  2013-03-29 08:55 +0100
URL:   http://hg.openjdk.java.net/jdk8/build/nashorn/rev/e2ea7a29b9c1

8010995: The bug ID 8010710 accidentally got two digits transposed in the 
checkin and unit test name
Reviewed-by: hannesw, sundar

+ test/script/basic/JDK-8010710.js
+ test/script/basic/JDK-8010710.js.EXPECTED
- test/script/basic/JDK-8017010.js
- test/script/basic/JDK-8017010.js.EXPECTED

Changeset: 704f3083af8a
Author:sundar
Date:  2013-03-29 18:38 +0530
URL:   http://hg.openjdk.java.net/jdk8/build/nashorn/rev/704f3083af8a

8011063: With older ant, we get the error "The  type doesn't support 
nested text data ("${run.te...jvmargs}")."
Reviewed-by: hannesw, ksrini

! make/build.xml

Changeset: a094fc010120
Author:jlaskey
Date:  2013-03-31 08:19 -0300
URL:   http://hg.openjdk.java.net/jdk8/build/nashorn/rev/a094fc010120

8011095: PropertyHashMap.rehash() does not grow enough
Reviewed-by: hannesw, lagergren
Contributed-by: james.las...@oracle.com

! src/jdk/nashorn/internal/runtime/PropertyHashMap.java
! src/jdk/nashorn/internal/runtime/PropertyMap.java

Changeset: 3e4369fb810b
Author:hannesw
Date:  2013-04-02 13:55 +0200
URL:   http://hg.openjdk.java.net/jdk8/build/nashorn/rev/3e4369fb810b

8011219: Regression with recent PropertyMap history changes
Reviewed-by: jlaskey, lagergren

! src/jdk/nashorn/internal/runtime/PropertyMap.java

Changeset: 5362d96d5915
Author:sundar
Date:  2013-04-02 17:40 +0530
URL:   http://hg.openjdk.java.net/jdk8/build/nashorn/rev/5362d96d5915

8011209: Object.getOwnPropertyDescriptor(function(){"use 
strict"},"caller").get.length is not 0
Reviewed-by: lagergren, hannesw, jlaskey

! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java
+ test/script/basic/JDK-8011209.js

Changeset: 9b845033c888
Author:lana
Date:  2013-04-02 12:01 -0700
URL:   http://hg.openjdk.java.net/jdk8/build/nashorn/rev/9b845033c888

Merge


Changeset: d82bc6ba3981
Author:lana
Date:  2013-04-05 14:52 -0700
URL:   http://hg.openjdk.java.net/jdk8/build/nashorn/rev/d82bc6ba3981

Merge


Changeset: af6fc67aa73d
Author:jlaskey
Date:  2013-04-02 11:37 -0300
URL:   http://hg.openjdk.java.net/jdk8/build/nashorn/rev/af6fc67aa73d

8011233: Create a Nashorn shell for JavaFX
Reviewed-by: lagergren, sundar
Contributed-by: james.las...@oracle.com

! make/build.xml
! make/project.properties
+ tools/fxshell/jdk/nashorn/tools/FXShell.java

Changeset: be5d2e472e22
Author:jlaskey
Date:  2013-04-02 11:38 -0300
URL:   http://hg.openjdk.java.net/jdk8/build/nashorn/rev/be5d2e472e22

Merge


Changeset: 159dbe2e02eb
Author:sundar
Date:  2013-04-02 20:42 +0530
URL:   http://hg.openjdk.java.net/jdk8/build/nashorn/rev/159dbe2e02eb

8011237: Object.isExtensible(Object.getOwnPropertyDescriptor(function(){"use 
strict"},"caller").get) should be false
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java
+ test/script/basic/JDK-8011237.js

Changeset: e9af5451d2d1
Author:sundar
Date:  2013-04-02 23:01 +0530
URL:   http://hg.openjdk.java.net/jdk8/build/nashorn/rev/e9af5451d2d1

8011274: Object.getOwnPropertyDescriptor(function(){"use 
strict"},"caller").get.hasOwnProperty("prototype") should be false
Reviewed-by: lagergren, jlaskey

! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java
+ test/script/basic/JDK-8011274.js

Changeset: e63b20d4f08a
Author:sundar
Date:  2013-04-03 11:41 +0530
URL:   http://hg.openjdk.java.net/jdk8/build/nashorn/rev/e63b20d4f08a

8011357: Array.prototype.slice and Array.prototype.splice should not call user 
defined valueOf of start, end arguments more than once
Reviewed-by: lagergren, hannesw

! src/jdk/nashorn/internal/objects/NativeArray.java
+ test/script/basic/JDK-8011357.js

Changeset: 51da1afbab26
Author:attila
Date:  2013-04-03 11:13 +0200
URL:   http://hg.openjdk.java.net/jdk8/build/nashorn/rev/51da1afbab26

8011362: Overloaded method resolution foiled by nulls
Reviewed-by: hannesw, sundar

! src/jdk/internal/dynalink/beans/ClassString.java
! src/jdk/internal/dynalink/beans/OverloadedMethod.java
+ test/script/basic/JDK-8011362.js
+ test/script/basic/JDK-8011362.js.EXPECTED
+ test/src/jdk/nashorn/test/models/Jdk8011362TestSubject.java

Changeset: b4191da366be
Author:sundar
Date:  2013-04-03 15:27 +0530
URL:   http://hg.openjdk.java.net/jdk8/build/nashorn/rev/b4191da366be

8011365: Array.prototype.join and Array.prototype.toString do not throw 
TypeError on null, undefined
Reviewed-by: attila, hannesw, lagergren

! src

hg: jdk8/build/jdk: 47 new changesets

[david . katleman]

Changeset: 87c62f03bc07
Author:jgodinez
Date:  2013-03-27 12:42 -0700
URL:   http://hg.openjdk.java.net/jdk8/build/jdk/rev/87c62f03bc07

8010005: [parfait] Memory leak in jdk/src/macosx/native/sun/awt/CTextPipe.m
Reviewed-by: bae, prr
Contributed-by: jia-hong.c...@oracle.com

! src/macosx/native/sun/awt/CTextPipe.m

Changeset: 9d4f539e36b6
Author:lana
Date:  2013-04-02 17:03 -0700
URL:   http://hg.openjdk.java.net/jdk8/build/jdk/rev/9d4f539e36b6

Merge

- make/com/sun/servicetag/Makefile
- src/share/classes/com/sun/servicetag/BrowserSupport.java
- src/share/classes/com/sun/servicetag/Installer.java
- src/share/classes/com/sun/servicetag/LinuxSystemEnvironment.java
- src/share/classes/com/sun/servicetag/RegistrationData.java
- src/share/classes/com/sun/servicetag/RegistrationDocument.java
- src/share/classes/com/sun/servicetag/Registry.java
- src/share/classes/com/sun/servicetag/ServiceTag.java
- src/share/classes/com/sun/servicetag/SolarisServiceTag.java
- src/share/classes/com/sun/servicetag/SolarisSystemEnvironment.java
- src/share/classes/com/sun/servicetag/SunConnection.java
- src/share/classes/com/sun/servicetag/SystemEnvironment.java
- src/share/classes/com/sun/servicetag/UnauthorizedAccessException.java
- src/share/classes/com/sun/servicetag/Util.java
- src/share/classes/com/sun/servicetag/WindowsSystemEnvironment.java
- src/share/classes/com/sun/servicetag/package.html
- src/share/classes/com/sun/servicetag/resources/Putback-Notes.txt
- src/share/classes/com/sun/servicetag/resources/javase_5_swordfish.properties
- src/share/classes/com/sun/servicetag/resources/javase_6_swordfish.properties
- src/share/classes/com/sun/servicetag/resources/javase_7_swordfish.properties
- src/share/classes/com/sun/servicetag/resources/javase_servicetag.properties
- src/share/classes/com/sun/servicetag/resources/jdk_header.png
- src/share/classes/com/sun/servicetag/resources/product_registration.xsd
- src/share/classes/com/sun/servicetag/resources/register.html
- src/share/classes/com/sun/servicetag/resources/register_ja.html
- src/share/classes/com/sun/servicetag/resources/register_zh_CN.html
- test/com/sun/servicetag/DeleteServiceTag.java
- test/com/sun/servicetag/DuplicateNotFound.java
- test/com/sun/servicetag/FindServiceTags.java
- test/com/sun/servicetag/InstanceUrnCheck.java
- test/com/sun/servicetag/InvalidRegistrationData.java
- test/com/sun/servicetag/InvalidServiceTag.java
- test/com/sun/servicetag/JavaServiceTagTest.java
- test/com/sun/servicetag/JavaServiceTagTest1.java
- test/com/sun/servicetag/NewRegistrationData.java
- test/com/sun/servicetag/SvcTagClient.java
- test/com/sun/servicetag/SystemRegistryTest.java
- test/com/sun/servicetag/TestLoadFromXML.java
- test/com/sun/servicetag/UpdateServiceTagTest.java
- test/com/sun/servicetag/Util.java
- test/com/sun/servicetag/ValidRegistrationData.java
- test/com/sun/servicetag/environ.properties
- test/com/sun/servicetag/missing-environ-field.xml
- test/com/sun/servicetag/newer-registry-version.xml
- test/com/sun/servicetag/registration.xml
- test/com/sun/servicetag/servicetag1.properties
- test/com/sun/servicetag/servicetag2.properties
- test/com/sun/servicetag/servicetag3.properties
- test/com/sun/servicetag/servicetag4.properties
- test/com/sun/servicetag/servicetag5.properties
- test/sun/tools/jstat/gcPermCapacityOutput1.awk
- test/sun/tools/jstat/jstatGcPermCapacityOutput1.sh

Changeset: 2904672aed21
Author:lana
Date:  2013-04-09 14:59 -0700
URL:   http://hg.openjdk.java.net/jdk8/build/jdk/rev/2904672aed21

Merge


Changeset: 96750ebc769b
Author:denis
Date:  2013-03-27 16:19 +0400
URL:   http://hg.openjdk.java.net/jdk8/build/jdk/rev/96750ebc769b

7075105: WIN: Provide a way to format HTML on drop
Reviewed-by: uta, serb

! src/macosx/classes/sun/lwawt/macosx/CDataTransferer.java
! src/share/classes/java/awt/datatransfer/DataFlavor.java
! src/share/classes/java/awt/datatransfer/SystemFlavorMap.java
! src/share/classes/sun/awt/datatransfer/DataTransferer.java
! src/share/classes/sun/awt/dnd/SunDropTargetContextPeer.java
! src/solaris/classes/sun/awt/X11/XDataTransferer.java
! src/windows/classes/sun/awt/windows/WDataTransferer.java
+ test/java/awt/datatransfer/HTMLDataFlavors/HTMLDataFlavorTest.java
+ test/java/awt/datatransfer/HTMLDataFlavors/HtmlTransferable.java
+ test/java/awt/datatransfer/HTMLDataFlavors/ManualHTMLDataFlavorTest.html
+ test/java/awt/datatransfer/HTMLDataFlavors/ManualHTMLDataFlavorTest.java
+ test/java/awt/datatransfer/HTMLDataFlavors/PutAllHtmlFlavorsOnClipboard.java
+ 
test/java/awt/datatransfer/HTMLDataFlavors/PutOnlyAllHtmlFlavorOnClipboard.java
+ 
test/java/awt/datatransfer/HTMLDataFlavors/PutSelectionAndFragmentHtmlFlavorsOnClipboard.java

Changeset: 29570523b6cb
Author:ant
Date:  2013-03-29 16:12 +0400
URL:   http://hg.openjdk.java.net/jdk8/build/jdk/rev/29570523b6cb

8010375: sun.swing.JLightweightFrame should be implemented for XToolkit
Reviewed-by: anthony

! src/share

hg: jdk8/build: 9 new changesets

[david . katleman]

Changeset: fc1e08c2bb27
Author:mduigou
Date:  2013-04-01 11:48 -0700
URL:   http://hg.openjdk.java.net/jdk8/build/rev/fc1e08c2bb27

8010267: Add test-clean for cleaning of testoutput directory from output 
directory. Add depedency on test-clean to clean
Reviewed-by: mchung, tbell

! common/makefiles/Main.gmk

Changeset: 26a4456cb19e
Author:jgish
Date:  2013-03-26 13:41 -0400
URL:   http://hg.openjdk.java.net/jdk8/build/rev/26a4456cb19e

8009824: webrev.ksh generated jdk.patch files do not handle renames, copies, 
and shouldn't be applied
Summary: use hg export --git to produce proper patch file
Reviewed-by: mduigou

! make/scripts/webrev.ksh

Changeset: 760074bec012
Author:mduigou
Date:  2013-04-01 21:11 -0700
URL:   http://hg.openjdk.java.net/jdk8/build/rev/760074bec012

8011178: improve common/bin/hgforest.sh python detection (MacOS)
Reviewed-by: ohair

! common/bin/hgforest.sh

Changeset: bcbdbcfe7ed8
Author:lana
Date:  2013-04-02 11:55 -0700
URL:   http://hg.openjdk.java.net/jdk8/build/rev/bcbdbcfe7ed8

Merge


Changeset: 7320922b694e
Author:mduigou
Date:  2013-04-02 14:56 -0700
URL:   http://hg.openjdk.java.net/jdk8/build/rev/7320922b694e

8011342: hgforest.sh : 'python --version' not supported on older python
Reviewed-by: wetmore

! common/bin/hgforest.sh

Changeset: 575f2ca947ab
Author:mduigou
Date:  2013-04-03 16:26 -0700
URL:   http://hg.openjdk.java.net/jdk8/build/rev/575f2ca947ab

8011350: hgforest.sh uses non-POSIX sh features that may fail with some shells
Reviewed-by: tbell, katleman, dholmes

! common/bin/hgforest.sh

Changeset: 11c057460b91
Author:lana
Date:  2013-04-05 14:49 -0700
URL:   http://hg.openjdk.java.net/jdk8/build/rev/11c057460b91

Merge


Changeset: 4c13b7994f38
Author:lana
Date:  2013-04-16 08:10 -0700
URL:   http://hg.openjdk.java.net/jdk8/build/rev/4c13b7994f38

Merge

! common/makefiles/Main.gmk

Changeset: df9b5240f0a7
Author:katleman
Date:  2013-04-16 14:57 -0700
URL:   http://hg.openjdk.java.net/jdk8/build/rev/df9b5240f0a7

Merge

Re: RFR 8010280: jvm.cfg needs updating for non-server builds

[Mandy Chung]

On 4/15/2013 3:42 PM, David Holmes wrote:

FYI updated webrev at same location, removing the dead code Erik spotted.

http://cr.openjdk.java.net/~dholmes/8010280/webrev/



Looks good to me.  Nit: CopyFiles.gmk line 340 - you may want to remove 
the extra space to align with the next line.



I've attached all the generated versions below.


Thanks for the generated files that are helpful for the review. Have you 
considered adding a simple sanity test, if not present, to validate 
jvm.cfg matches with the vm binaries bundled in JAVA_HOME? Just a 
thought and maybe you can file a RFE to add such a test later if you 
think it's a good idea.


Mandy

Re: RFR 8010280: jvm.cfg needs updating for non-server builds

[Mike Duigou]

On Apr 15 2013, at 15:42 , David Holmes wrote:

> On 16/04/2013 2:25 AM, Mike Duigou wrote:
>> What's the difference between removing an entry completely and retaining it 
>> with "ERROR"?
> 
> Just the nature of the error message:
> 
> > java -green
> Error: green VM not supported
> > java -blue
> Unrecognized option: -blue
> Error: Could not create the Java Virtual Machine.
> Error: A fatal exception has occurred. Program will exit.
> 
> I wasn't touching any of the legacy stuff - though if this needs to go to CCC 
> I would suggest removing all the legacy entries.

OK.

> 
>> Additionally I don't like that aliases have differing definitions and some 
>> confusing ones like "-server ALIASED_TO -client". Is this necessary or just 
>> historically convenient?
> 
> I don't like aliases period! Historically (and this is very recent history) 
> it was necessary to deal with the test suites being applied to a JDK with, 
> eg, only client VM. Every test that specified -server would fail if the alias 
> didn't exist (and as I stated we're moving away from that ie the tests don't 
> set -client or -server but the complete test suite run does, and it knows 
> what VM is under test.
> 
> Personally I'd probably choose WARN for any VM not present.
> 
> The problem is that the "right" thing depends on who is building what, and 
> how they plan to use it. All I can do is define a not-unreasonable default 
> policy. I also have a time constraint as I need to get this in before the 
> 23rd to meet an internal deadline.

Understood.

Mike

Re: RFR: 8011347: JDK-8009824 has broken webrev with some ksh versions

[Daniel Fuchs]

On 4/16/13 5:02 PM, Jim Gish wrote:

I've updated the version to 24.0 and add Mike as a reviewer.  Could
someone please push this for me?


Hi Jim,

I think you will need to update the bug id in your comment:

http://cr.openjdk.java.net/~jgish/Bug8011347-webrev/tl.changeset

8009824: JDK-8009824 has broken webrev with some ksh versions
^^^

shouldn't that be 8011347 ?

-- daniel




Thanks,
 Jim

On 04/15/2013 06:34 PM, Mike Duigou wrote:

I think the version number needs to be changed. My vote is to bump it
to 24.0

Mike

On Apr 12 2013, at 11:08 , Jim Gish wrote:


Please review http://cr.openjdk.java.net/~jgish/Bug8011347-webrev/
, which fixes
the current webrev issues on solaris and mac.

Thanks,
   Jim

--
Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
Oracle Java Platform Group | Core Libraries Team
35 Network Drive
Burlington, MA 01803
jim.g...@oracle.com

Re: RFR: 8011347: JDK-8009824 has broken webrev with some ksh versions

[Jim Gish]

I've updated the version to 24.0 and add Mike as a reviewer.  Could 
someone please push this for me?


Thanks,
Jim

On 04/15/2013 06:34 PM, Mike Duigou wrote:

I think the version number needs to be changed. My vote is to bump it to 24.0

Mike

On Apr 12 2013, at 11:08 , Jim Gish wrote:


Please review http://cr.openjdk.java.net/~jgish/Bug8011347-webrev/ 
, which fixes the 
current webrev issues on solaris and mac.

Thanks,
   Jim

--
Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
Oracle Java Platform Group | Core Libraries Team
35 Network Drive
Burlington, MA 01803
jim.g...@oracle.com



--
Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
Oracle Java Platform Group | Core Libraries Team
35 Network Drive
Burlington, MA 01803
jim.g...@oracle.com