Re: Fix the version of required jdk

[Volker Simonis]

Hi Yuji,

your fix looks reasonable. But as the name implies,
'generated-configure.sh' is a generated file. A complete patch should
change the source files (in this case common/autoconf/help.m4) and
recreate 'generated-configure.sh' by calling
common/autoconf/autogen.sh (you should use autoconf 2.69).

You also need as sponsor from within Oracle because only they can
check in changes to 'generated-configure.sh' (because it also touches
the closed sources).

Regards,
Volker


On Fri, Mar 11, 2016 at 7:48 AM, KUBOTA Yuji  wrote:
> Hi everyone.
>
> configure of jdk9 (and build-infra/jdk9) requires boot jdk version is 8 or 9.
> But help message requires jdk7. Especially, yum_help requires JRE.
> So I create a small patch to fix, please someone review it?
>
> I do not have an account of openjdk, so I want a sponsor.
>
> diff --git a/common/autoconf/generated-configure.sh
> b/common/autoconf/generated-configure.sh
> --- a/common/autoconf/generated-configure.sh
> +++ b/common/autoconf/generated-configure.sh
> @@ -4053,7 +4053,7 @@
>  devkit)
>PKGHANDLER_COMMAND="sudo apt-get install build-essential" ;;
>  openjdk)
> -  PKGHANDLER_COMMAND="sudo apt-get install openjdk-7-jdk" ;;
> +  PKGHANDLER_COMMAND="sudo apt-get install openjdk-8-jdk" ;;
>  alsa)
>PKGHANDLER_COMMAND="sudo apt-get install libasound2-dev" ;;
>  cups)
> @@ -4076,7 +4076,7 @@
>  devkit)
>PKGHANDLER_COMMAND="sudo yum groupinstall \"Development Tools\"" ;;
>  openjdk)
> -  PKGHANDLER_COMMAND="sudo yum install java-1.7.0-openjdk" ;;
> +  PKGHANDLER_COMMAND="sudo yum install java-1.8.0-openjdk-devel" ;;
>  alsa)
>PKGHANDLER_COMMAND="sudo yum install alsa-lib-devel" ;;
>  cups)
>
> Thanks,
> Yuji

Re: RFR: 8151630 and 8151631 ios build failures after b106 merge

[Gary Adams]

A minor problem arises when we eliminate the last cmd from the ios build.
When making images the support/modules_cmds-stripped is passed to the
jimage tool, but the directory is not created if no cmds were processed.

This will be a moot issue once the jigsaw integration is complete. In 
the interim,

here is a workaround I'd like to add that gets past the problem.

diff --git a/make/Images.gmk b/make/Images.gmk
--- a/make/Images.gmk
+++ b/make/Images.gmk
@@ -121,6 +121,7 @@
 $(call DependOnVariable, JDK_MODULES_LIST)
 $(ECHO) Creating jdk jimage
 $(RM) -r $(JDK_IMAGE_DIR) $(JDK_SORTED_MODULES)
+$(call MakeDir, $(MODULES_CMDS))
 $(JIMAGE_TOOL) --mods $(JDK_MODULES_LIST) --output $(JDK_IMAGE_DIR) \
 $(MODULES_XML) > $(JDK_SORTED_MODULES)
 $(TOUCH) $@
@@ -129,6 +130,7 @@
 $(call DependOnVariable, JRE_MODULES_LIST)
 $(ECHO) Creating jre jimage
 $(RM) -r $(JRE_IMAGE_DIR) $(JRE_SORTED_MODULES)
+$(call MakeDir, $(MODULES_CMDS))
 $(JIMAGE_TOOL) --mods $(JRE_MODULES_LIST) --output $(JRE_IMAGE_DIR) \
 $(MODULES_XML) > $(JRE_SORTED_MODULES)
 $(TOUCH) $@

On 03/10/16 12:12, Erik Joelsson wrote:

Looks ok for now.

/Erik

On 2016-03-10 17:43, Gary Adams wrote:

Here are two quick fixes for ios build issues after the b106 merge

A quick workaround for the ios build issue with upack executable is 
to noop
the launcher makefile, similar to what has been done for other 
launcher makefiles.
A longer term solution will be added later with a proper configure 
flag to disable

building command line launchers.

The ios-arm64 (aka aarch64 zero vm) needs template files for 
UnixConstants
and SocketOptionRegistry. It was using the ios-arm templates. Rather 
than

complicate the makefiles the ios-arm files have been cloned.

  Webrev: http://cr.openjdk.java.net/~gadams/8151631/webrev.00/
   JIRA:
https://bugs.openjdk.java.net/browse/JDK-8151630?filter=-1
https://bugs.openjdk.java.net/browse/JDK-8151631?filter=-1

Re: RFR: 8151630 and 8151631 ios build failures after b106 merge

[Erik Joelsson]

Looks ok for now.

/Erik

On 2016-03-10 17:43, Gary Adams wrote:

Here are two quick fixes for ios build issues after the b106 merge

A quick workaround for the ios build issue with upack executable is to 
noop
the launcher makefile, similar to what has been done for other 
launcher makefiles.
A longer term solution will be added later with a proper configure 
flag to disable

building command line launchers.

The ios-arm64 (aka aarch64 zero vm) needs template files for 
UnixConstants

and SocketOptionRegistry. It was using the ios-arm templates. Rather than
complicate the makefiles the ios-arm files have been cloned.

  Webrev: http://cr.openjdk.java.net/~gadams/8151631/webrev.00/
   JIRA:
   https://bugs.openjdk.java.net/browse/JDK-8151630?filter=-1
   https://bugs.openjdk.java.net/browse/JDK-8151631?filter=-1

RFR: 8151630 and 8151631 ios build failures after b106 merge

[Gary Adams]

Here are two quick fixes for ios build issues after the b106 merge

A quick workaround for the ios build issue with upack executable is to noop
the launcher makefile, similar to what has been done for other launcher 
makefiles.
A longer term solution will be added later with a proper configure flag 
to disable

building command line launchers.

The ios-arm64 (aka aarch64 zero vm) needs template files for UnixConstants
and SocketOptionRegistry. It was using the ios-arm templates. Rather than
complicate the makefiles the ios-arm files have been cloned.

  Webrev: http://cr.openjdk.java.net/~gadams/8151631/webrev.00/
   JIRA:
   https://bugs.openjdk.java.net/browse/JDK-8151630?filter=-1
   https://bugs.openjdk.java.net/browse/JDK-8151631?filter=-1