Re: bash configure fails on missing javah

2018-01-02 Thread Martin Buchholz
I agree configure should not fail if javah is not found.  A high quality
configure test would first check if javac -h works, then fall back to javah
if that works, regardless of the boot jdk's version.

On Tue, Jan 2, 2018 at 6:33 AM, Nir Lisker  wrote:

> I'm trying to build OpenJDK 11 as instructed here:
> http://hg.openjdk.java.net/jdk/jdk/raw-file/tip/doc/building.html.
>
> When executing `bash configure
> --with-import-modules=jfx_path\rt\build\modular-sdk`
> (I've build JavaFX) the build fails:
>
> checking for java in Boot JDK... ok
> checking for javac in Boot JDK... ok
> checking for javah in Boot JDK... not found
> configure: Your Boot JDK seems broken. This might be fixed by explicitly
> setting --with-boot-jdk
> configure: error: Could not find javah in the Boot JDK
> configure exiting with result code 1
>
> The boot JDK is 10, which does not have javah anymore, so it is no
> surprise. I could point boot JDK to a previous version, but I don't think I
> should need to. What I should do?
>
> Nir
>


Re: bash configure fails on missing javah

2018-01-02 Thread David Holmes

On 3/01/2018 12:33 AM, Nir Lisker wrote:

I'm trying to build OpenJDK 11 as instructed here:
http://hg.openjdk.java.net/jdk/jdk/raw-file/tip/doc/building.html.

When executing `bash configure
--with-import-modules=jfx_path\rt\build\modular-sdk`
(I've build JavaFX) the build fails:

checking for java in Boot JDK... ok
checking for javac in Boot JDK... ok
checking for javah in Boot JDK... not found
configure: Your Boot JDK seems broken. This might be fixed by explicitly
setting --with-boot-jdk
configure: error: Could not find javah in the Boot JDK
configure exiting with result code 1

The boot JDK is 10, which does not have javah anymore, so it is no
surprise. I could point boot JDK to a previous version, but I don't think I
should need to. What I should do?


We haven't bumped the version to 11 yet so you should still be building 
"10" with a boot JDK of 9.


David


Nir



[10] Review Request: 8193673 Regression manual Test javax/swing/JFileChooser/6515169/bug6515169.java fails

2018-01-02 Thread Sergey Bylokhov

Hello.
Please review the fix for jdk10. The fix will be pushed to:
http://hg.openjdk.java.net/jdk/jdk10

Bug: https://bugs.openjdk.java.net/browse/JDK-8193673
Webrev can be found at: http://cr.openjdk.java.net/~serb/8193673/webrev.00

The fix for JDK-8189656[1] missed an update of Gensrc-java.desktop.gmk 
which compiles the property files for windows L


[1] https://bugs.openjdk.java.net/browse/JDK-8189656

--
Best regards, Sergey.


bash configure fails on missing javah

2018-01-02 Thread Nir Lisker
I'm trying to build OpenJDK 11 as instructed here:
http://hg.openjdk.java.net/jdk/jdk/raw-file/tip/doc/building.html.

When executing `bash configure
--with-import-modules=jfx_path\rt\build\modular-sdk`
(I've build JavaFX) the build fails:

checking for java in Boot JDK... ok
checking for javac in Boot JDK... ok
checking for javah in Boot JDK... not found
configure: Your Boot JDK seems broken. This might be fixed by explicitly
setting --with-boot-jdk
configure: error: Could not find javah in the Boot JDK
configure exiting with result code 1

The boot JDK is 10, which does not have javah anymore, so it is no
surprise. I could point boot JDK to a previous version, but I don't think I
should need to. What I should do?

Nir