Re: RFR(xxs): 8202822: Add .git to .hgignore
Thanks Erik! I'll push this now under the trivial rule. Thanks, Thomas On Wed, May 9, 2018 at 5:52 PM, Erik Joelssonwrote: > Looks good to me. > > /Erik > > > > On 2018-05-08 21:59, Thomas Stüfe wrote: >> >> Hi all, >> >> could we add .git to .hgignore? >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8202822 >> >> Diff: >> >> --- a/.hgignore Wed May 09 06:51:41 2018 +0200 >> +++ b/.hgignore Wed May 09 06:55:10 2018 +0200 >> @@ -13,3 +13,4 @@ >> NashornProfile.txt >> .*/JTreport/.* >> .*/JTwork/.* >> +.*/.git/.* >> >> Thanks! >> >> Thomas > >
Re: RFR: 8201274: Launch Single-File Source-Code Programs
On 5/4/18 2:59 PM, Jonathan Gibbons wrote: Here's an update to the previously proposed patch for JEP 330: Launch Single-File Source-Code Programs. It includes all review feedback so far. The changes are mostly minor, but with the addition of more test cases. The webrev includes a delta-webrev for those that just want to see what has changed since last time. Full webrev: http://cr.openjdk.java.net/~jjg/8201274/webrev.mq/index.html Original webrev: http://cr.openjdk.java.net/~jjg/8201274/webrev.mq/webrev.v1/index.html Delta webrev: http://cr.openjdk.java.net/~jjg/8201274/webrev.mq/webrev.v2/index.html I looked through the change and it looks fine to me. Mandy
Re: RFR(L) : 8199384 : [TESTBUG] Open source VM testbase MLVM tests
Build changes look good. /Erik On 2018-05-09 14:09, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8199384/webrev.00/index.html 61414 lines changed: 61414 ins; 0 del; 0 mod; Hi all, could you please review this patch which open sources MLVM tests from VM testbase? these tests were developed in early days of JSR292 to test different aspects of MethodHandles and invokedynamic. As usually w/ VM testbase code, these tests are old, they have been run in hotspot testing for a long period of time. Originally, these tests were run by a test harness different from jtreg and had different build and execution schemes, some parts couldn't be easily translated to jtreg, so tests might have actions or pieces of code which look weird. In a long term, we are planning to rework them. JBS: https://bugs.openjdk.java.net/browse/JDK-8199384 webrev: http://cr.openjdk.java.net/~iignatyev//8199384/webrev.00/index.html testing: :vmTestbase_vm_mlvm test group Thanks, -- Igor
RFR(L) : 8199384 : [TESTBUG] Open source VM testbase MLVM tests
http://cr.openjdk.java.net/~iignatyev//8199384/webrev.00/index.html > 61414 lines changed: 61414 ins; 0 del; 0 mod; Hi all, could you please review this patch which open sources MLVM tests from VM testbase? these tests were developed in early days of JSR292 to test different aspects of MethodHandles and invokedynamic. As usually w/ VM testbase code, these tests are old, they have been run in hotspot testing for a long period of time. Originally, these tests were run by a test harness different from jtreg and had different build and execution schemes, some parts couldn't be easily translated to jtreg, so tests might have actions or pieces of code which look weird. In a long term, we are planning to rework them. JBS: https://bugs.openjdk.java.net/browse/JDK-8199384 webrev: http://cr.openjdk.java.net/~iignatyev//8199384/webrev.00/index.html testing: :vmTestbase_vm_mlvm test group Thanks, -- Igor
Re: RFR(xxs): 8202822: Add .git to .hgignore
Feel free :) On Wed, May 9, 2018 at 5:56 PM, John Paul Adrian Glaubitzwrote: > Shouldn't we also add .hg to .gitignore? :-) > > > On 05/09/2018 05:52 PM, Erik Joelsson wrote: >> >> Looks good to me. >> >> /Erik >> >> >> On 2018-05-08 21:59, Thomas Stüfe wrote: >>> >>> Hi all, >>> >>> could we add .git to .hgignore? >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8202822 >>> >>> Diff: >>> >>> --- a/.hgignore Wed May 09 06:51:41 2018 +0200 >>> +++ b/.hgignore Wed May 09 06:55:10 2018 +0200 >>> @@ -13,3 +13,4 @@ >>> NashornProfile.txt >>> .*/JTreport/.* >>> .*/JTwork/.* >>> +.*/.git/.* >>> >>> Thanks! >>> >>> Thomas > > > -- > .''`. John Paul Adrian Glaubitz > : :' : Debian Developer - glaub...@debian.org > `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de > `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Re: RFR(xxs): 8202822: Add .git to .hgignore
Thanks! On Wed, May 9, 2018 at 5:52 PM, Erik Joelssonwrote: > Looks good to me. > > /Erik > > > > On 2018-05-08 21:59, Thomas Stüfe wrote: >> >> Hi all, >> >> could we add .git to .hgignore? >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8202822 >> >> Diff: >> >> --- a/.hgignore Wed May 09 06:51:41 2018 +0200 >> +++ b/.hgignore Wed May 09 06:55:10 2018 +0200 >> @@ -13,3 +13,4 @@ >> NashornProfile.txt >> .*/JTreport/.* >> .*/JTwork/.* >> +.*/.git/.* >> >> Thanks! >> >> Thomas > >
Re: RFR(xxs): 8202822: Add .git to .hgignore
Shouldn't we also add .hg to .gitignore? :-) On 05/09/2018 05:52 PM, Erik Joelsson wrote: Looks good to me. /Erik On 2018-05-08 21:59, Thomas Stüfe wrote: Hi all, could we add .git to .hgignore? Bug: https://bugs.openjdk.java.net/browse/JDK-8202822 Diff: --- a/.hgignore Wed May 09 06:51:41 2018 +0200 +++ b/.hgignore Wed May 09 06:55:10 2018 +0200 @@ -13,3 +13,4 @@ NashornProfile.txt .*/JTreport/.* .*/JTwork/.* +.*/.git/.* Thanks! Thomas -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Re: RFR(xxs): 8202822: Add .git to .hgignore
Looks good to me. /Erik On 2018-05-08 21:59, Thomas Stüfe wrote: Hi all, could we add .git to .hgignore? Bug: https://bugs.openjdk.java.net/browse/JDK-8202822 Diff: --- a/.hgignore Wed May 09 06:51:41 2018 +0200 +++ b/.hgignore Wed May 09 06:55:10 2018 +0200 @@ -13,3 +13,4 @@ NashornProfile.txt .*/JTreport/.* .*/JTwork/.* +.*/.git/.* Thanks! Thomas
Re: [11] RFR for JDK-8202544: Hide unused exports in libzip
Any volunteers from core-libs and/or hotspot? Thank you, Alexey On 02/05/2018 13:02, Magnus Ihse Bursie wrote: Looks good to me, FWIW. /Magnus 2 maj 2018 kl. 13:52 skrev Alexey Ivanov: Hi, Could you please review the following fix for jdk11? bug: https://bugs.openjdk.java.net/browse/JDK-8202544 webrev: http://cr.openjdk.java.net/~aivanov/8202544/jdk11/webrev.0/ The following exported functions in libzip are not used: ZIP_GetEntry, ZIP_FreeEntry, ZIP_Lock, ZIP_Unlock, ZIP_Read I removed JNIEXPORT modifiers from these functions. With the fix, they're not exported on Windows; on Linux they're listed as Local rather than Global. I ran tests, no failures. Thank you in advance. Regards, Alexey
Re: Build failure on Fedora 28
Hi, Note that slowdebug builds work: $ ./build/linux-x86_64-normal-server-slowdebug/images/jdk/bin/java -version openjdk version "11-internal" 2018-09-25 OpenJDK Runtime Environment (slowdebug build 11-internal+0-adhoc.sgehwolf.openjdk-hs) OpenJDK 64-Bit Server VM (slowdebug build 11-internal+0-adhoc.sgehwolf.openjdk-hs, mixed mode) In summary we have: * Build fails with fastdebug/release debug config (-O3) * Build succeeds with slowdebug (-O0) * F28 has GCC 8 * Older GCC-based builds continue to work for fastdebug/release config * JDK 10.0.1 builds fine with GCC 8. So far showing all symptoms of either a GCC bug or some UB in recent OpenJDK code which breaks with new optimizations done in GCC 8. I'll continue to investigate what it is... Cheers, Severin On Wed, 2018-05-09 at 17:03 +0900, Yasumasa Suenaga wrote: > Hi Thomas, > > Build was succeeded with --with-build-jdk= > configure > option, but JDK image does not work as below: > > ``` > [ysuenaga@f4i jdk]$ > ./build/linux-x86_64-normal-server-fastdebug/images/jdk/bin/java > --version > Error occurred during initialization of VM > java/lang/NoClassDefFoundError: java/lang/Object > ``` > > > Thanks, > > Yasumasa > > > 2018-05-09 14:36 GMT+09:00 Thomas Stüfe: > > Hi, > > > > sorry for quick dropping in. Just wanted to remark that it may be > > useful to run with --with-build-jdk= with being a good > > working > > jdk you trust. It must be close to the source you build - I usually > > use a clean current release build. > > > > This excludes build errors which may be caused by the JDK you are > > building being faulty (the build uses itself in places). > > > > ..Thomas > > > > On Wed, May 9, 2018 at 5:46 AM, Yasumasa Suenaga > m> wrote: > > > Hi David, > > > > > > I uploaded build.log: > > > http://cr.openjdk.java.net/~ysuenaga/openjdk-fc28/build.log > > > > > > Is it enough? > > > > > > > > > Thanks, > > > > > > Yasumasa > > > > > > > > > > > > 2018-05-09 11:17 GMT+09:00 David Holmes > > > : > > > > On 9/05/2018 12:09 PM, Yasumasa Suenaga wrote: > > > > > > > > > > Hi David, > > > > > > > > > > 2018-05-09 10:48 GMT+09:00 David Holmes > > > > com>: > > > > > > > > > > > > Can you build with LOG=trace to try and see the actual > > > > > > command that is > > > > > > failing? > > > > > > > > > > > > > > > I tried it and got following logs. They look good to me. > > > > > > > > > > > > Not enough there for me to comment :) > > > > > > > > > > > > > > > * Creating interim-image > > > > > > > > > > + > > > > > /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server- > > > > > fastdebug/jdk/bin/jlink > > > > > -J-XX:+UseSerialGC -J-Xms32M -J-Xmx512M -J- > > > > > XX:TieredStopAtLevel=1 > > > > > -J-Djlin > > > > > k.debug=true --module-path > > > > > > > > > > /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server- > > > > > fastdebug/support/interim-jmods > > > > > --endian little --output > > > > > > > > > > /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server- > > > > > fastdebug/support/interim-image > > > > > --disable-plugin generate-jli-classes --add-modules > > > > > java.base,java.logging > > > > > > > > > > > > So this seems to produce an interim image that won't run - > > > > correct? I'd be > > > > scouring the log in the lead up to this to see if anything > > > > seems to be > > > > unusual. Can you upload the log to cr.openjdk.java.net? Or > > > > email me > > > > directly? > > > > > > > > Thanks, > > > > David > > > > > > > > > > > > > > > > > > * Command on error: > > > > > > > > > > + > > > > > /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server- > > > > > fastdebug/support/interim-image/bin/java > > > > > > > > > > -XX:DumpLoadedClassList=/home/ysuenaga/OpenJDK/jdk/build/linu > > > > > x-x86_64-normal-server- > > > > > fastdebug/support/link_opt/classlist.raw > > > > > -Djava.lang.invoke.MethodHandle.TRACE_RESOLVE=true -cp > > > > > > > > > > /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server- > > > > > fastdebug/support/classlist.jar > > > > > build.tools.classlist.HelloClasslist > > > > > > > > > > Thanks, > > > > > > > > > > Yasumasa > > > > > > > > > > > > > > > > David > > > > > > > > > > > > > > > > > > On 9/05/2018 11:39 AM, Yasumasa Suenaga wrote: > > > > > > > > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > 2018-05-09 0:27 GMT+09:00 Erik Joelsson > > > > > > acle.com>: > > > > > > > > > > > > > > > > > > > > > > > > Hello, > > > > > > > > > > > > > > > > Your assessment is looks correct so far. At this point, > > > > > > > > one would have > > > > > > > > to > > > > > > > > start debugging the image to figure out what's wrong > > > > > > > > with it. Are you > > > > > > > > able > > > > > > > > to run the exploded image in > > > > > > > > ./build/linux-x86_64-normal-server- > > > > > > > >
Re: Build failure on Fedora 28
Hi Yasumasa, On Wed, May 9, 2018 at 10:03 AM, Yasumasa Suenagawrote: > Hi Thomas, > > Build was succeeded with --with-build-jdk= configure > option, but JDK image does not work as below: > > ``` > [ysuenaga@f4i jdk]$ > ./build/linux-x86_64-normal-server-fastdebug/images/jdk/bin/java > --version > Error occurred during initialization of VM > java/lang/NoClassDefFoundError: java/lang/Object > ``` > Yes, I expected that. The intent was only to make it easier to analyze the crash. I usually prefer that to analyzing build logs to find the crashing vm call. Maybe it is just a matter of preference. I know some people actually prefer the crashes during the build since they consider the build to be a good first-line stress test. Thanks, Thomas > > Thanks, > > Yasumasa > > > 2018-05-09 14:36 GMT+09:00 Thomas Stüfe : >> Hi, >> >> sorry for quick dropping in. Just wanted to remark that it may be >> useful to run with --with-build-jdk= with being a good working >> jdk you trust. It must be close to the source you build - I usually >> use a clean current release build. >> >> This excludes build errors which may be caused by the JDK you are >> building being faulty (the build uses itself in places). >> >> ..Thomas >> >> On Wed, May 9, 2018 at 5:46 AM, Yasumasa Suenaga wrote: >>> Hi David, >>> >>> I uploaded build.log: >>> http://cr.openjdk.java.net/~ysuenaga/openjdk-fc28/build.log >>> >>> Is it enough? >>> >>> >>> Thanks, >>> >>> Yasumasa >>> >>> >>> >>> 2018-05-09 11:17 GMT+09:00 David Holmes : On 9/05/2018 12:09 PM, Yasumasa Suenaga wrote: > > Hi David, > > 2018-05-09 10:48 GMT+09:00 David Holmes : >> >> Can you build with LOG=trace to try and see the actual command that is >> failing? > > > I tried it and got following logs. They look good to me. Not enough there for me to comment :) > > > * Creating interim-image > > + > /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/jdk/bin/jlink > -J-XX:+UseSerialGC -J-Xms32M -J-Xmx512M -J-XX:TieredStopAtLevel=1 > -J-Djlin > k.debug=true --module-path > > /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/interim-jmods > --endian little --output > > /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/interim-image > --disable-plugin generate-jli-classes --add-modules > java.base,java.logging So this seems to produce an interim image that won't run - correct? I'd be scouring the log in the lead up to this to see if anything seems to be unusual. Can you upload the log to cr.openjdk.java.net? Or email me directly? Thanks, David > > * Command on error: > > + > /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/interim-image/bin/java > > -XX:DumpLoadedClassList=/home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/link_opt/classlist.raw > -Djava.lang.invoke.MethodHandle.TRACE_RESOLVE=true -cp > > /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/classlist.jar > build.tools.classlist.HelloClasslist > > Thanks, > > Yasumasa > > >> David >> >> >> On 9/05/2018 11:39 AM, Yasumasa Suenaga wrote: >>> >>> >>> Hi, >>> >>> 2018-05-09 0:27 GMT+09:00 Erik Joelsson : Hello, Your assessment is looks correct so far. At this point, one would have to start debugging the image to figure out what's wrong with it. Are you able to run the exploded image in ./build/linux-x86_64-normal-server-fastdebug/jdk/bin/java? >>> >>> >>> >>> It works. So I wonder why invalid image was built. >>> >>> ``` >>> $ ./build/linux-x86_64-normal-server-fastdebug/jdk/bin/java --version >>> openjdk 11-internal 2018-09-25 >>> OpenJDK Runtime Environment (fastdebug build >>> 11-internal+0-adhoc.ysuenaga.jdk) >>> OpenJDK 64-Bit Server VM (fastdebug build >>> 11-internal+0-adhoc.ysuenaga.jdk, mixed mode) >>> ``` >>> >>> I'm waiting for Severin's evaluation :-) >>> >>> >>> Thanks, >>> >>> Yasumasa >>> >>> Has anyone at Redhat built successfully on Fedora 28 yet? /Erik On 2018-05-08 06:42, Yasumasa Suenaga wrote: > > > > Hi all, > > I tried to build OpenJDK (jdk/jdk) on Fedora 28 x64, but it failed as > following: > > ``` > [ysuenaga@fc28 jdk]$ make images > Building target 'images' in configuration >
Re: Build failure on Fedora 28
Hi Thomas, Build was succeeded with --with-build-jdk= configure option, but JDK image does not work as below: ``` [ysuenaga@f4i jdk]$ ./build/linux-x86_64-normal-server-fastdebug/images/jdk/bin/java --version Error occurred during initialization of VM java/lang/NoClassDefFoundError: java/lang/Object ``` Thanks, Yasumasa 2018-05-09 14:36 GMT+09:00 Thomas Stüfe: > Hi, > > sorry for quick dropping in. Just wanted to remark that it may be > useful to run with --with-build-jdk= with being a good working > jdk you trust. It must be close to the source you build - I usually > use a clean current release build. > > This excludes build errors which may be caused by the JDK you are > building being faulty (the build uses itself in places). > > ..Thomas > > On Wed, May 9, 2018 at 5:46 AM, Yasumasa Suenaga wrote: >> Hi David, >> >> I uploaded build.log: >> http://cr.openjdk.java.net/~ysuenaga/openjdk-fc28/build.log >> >> Is it enough? >> >> >> Thanks, >> >> Yasumasa >> >> >> >> 2018-05-09 11:17 GMT+09:00 David Holmes : >>> On 9/05/2018 12:09 PM, Yasumasa Suenaga wrote: Hi David, 2018-05-09 10:48 GMT+09:00 David Holmes : > > Can you build with LOG=trace to try and see the actual command that is > failing? I tried it and got following logs. They look good to me. >>> >>> >>> Not enough there for me to comment :) * Creating interim-image + /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/jdk/bin/jlink -J-XX:+UseSerialGC -J-Xms32M -J-Xmx512M -J-XX:TieredStopAtLevel=1 -J-Djlin k.debug=true --module-path /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/interim-jmods --endian little --output /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/interim-image --disable-plugin generate-jli-classes --add-modules java.base,java.logging >>> >>> >>> So this seems to produce an interim image that won't run - correct? I'd be >>> scouring the log in the lead up to this to see if anything seems to be >>> unusual. Can you upload the log to cr.openjdk.java.net? Or email me >>> directly? >>> >>> Thanks, >>> David >>> >>> * Command on error: + /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/interim-image/bin/java -XX:DumpLoadedClassList=/home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/link_opt/classlist.raw -Djava.lang.invoke.MethodHandle.TRACE_RESOLVE=true -cp /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/classlist.jar build.tools.classlist.HelloClasslist Thanks, Yasumasa > David > > > On 9/05/2018 11:39 AM, Yasumasa Suenaga wrote: >> >> >> Hi, >> >> 2018-05-09 0:27 GMT+09:00 Erik Joelsson : >>> >>> >>> Hello, >>> >>> Your assessment is looks correct so far. At this point, one would have >>> to >>> start debugging the image to figure out what's wrong with it. Are you >>> able >>> to run the exploded image in >>> ./build/linux-x86_64-normal-server-fastdebug/jdk/bin/java? >> >> >> >> It works. So I wonder why invalid image was built. >> >> ``` >> $ ./build/linux-x86_64-normal-server-fastdebug/jdk/bin/java --version >> openjdk 11-internal 2018-09-25 >> OpenJDK Runtime Environment (fastdebug build >> 11-internal+0-adhoc.ysuenaga.jdk) >> OpenJDK 64-Bit Server VM (fastdebug build >> 11-internal+0-adhoc.ysuenaga.jdk, mixed mode) >> ``` >> >> I'm waiting for Severin's evaluation :-) >> >> >> Thanks, >> >> Yasumasa >> >> >>> Has anyone at Redhat built successfully on Fedora 28 yet? >>> >>> /Erik >>> >>> >>> >>> On 2018-05-08 06:42, Yasumasa Suenaga wrote: Hi all, I tried to build OpenJDK (jdk/jdk) on Fedora 28 x64, but it failed as following: ``` [ysuenaga@fc28 jdk]$ make images Building target 'images' in configuration 'linux-x86_64-normal-server-fastdebug' gmake[3]: *** [GenerateLinkOptData.gmk:64: /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/link_opt/classlist] Error 1 gmake[2]: *** [make/Main.gmk:448: generate-link-opt-data] Error 2 ERROR: Build failed for target 'images' in configuration 'linux-x86_64-normal-server-fastdebug' (exit code 2) No indication of failed target found. Hint: Try searching the build log for '] Error'. Hint: See doc/building.html#troubleshooting for assistance.
Re: Build failure on Fedora 28
On 9/05/2018 5:40 PM, Yasumasa Suenaga wrote: Hi David, 2018-05-09 16:26 GMT+09:00 David Holmes: On 9/05/2018 5:19 PM, Yasumasa Suenaga wrote: Hi David, I uploaded trace log: http://cr.openjdk.java.net/~ysuenaga/openjdk-fc28/trace-all.log It seems to open module file, but any class is not loaded from there. The last line I see is: [0.266s][trace][gc,tlab ] TLAB: fill thread: 0x7fd7c801f800 [id: 17487] desired_size: 491KB slow allocs: 0 refill waste: 7864B alloc: 0.9 2048KB refills: 1 waste 0.0% gc: 0B slow: 0B fast: 0B is that right? Seems we just have a silent abort during VM initialization. This seems quite bizarre. Yes, I guess VM was aborted because it could not load java/lang/Object. http://mail.openjdk.java.net/pipermail/build-dev/2018-May/021999.html Ah so you still see: Error occurred during initialization of VM java/lang/NoClassDefFoundError: java/lang/Object I'm surprised there isn't more in the log prior to reaching that point. David - Can you run it in the debugger? No, I ran `./java -Xlog:all=trace:/home/ysuenaga/trace-all.log --version` Thanks, Yasumasa Thanks, David Thanks, Yasumasa 2018-05-09 15:31 GMT+09:00 David Holmes : On 9/05/2018 1:46 PM, Yasumasa Suenaga wrote: Hi David, I uploaded build.log: http://cr.openjdk.java.net/~ysuenaga/openjdk-fc28/build.log Is it enough? It's all there is. :) But no errors. It all is fine right up to the part that it isn't. Can you run: /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/interim-image/bin/java with full logging enabled - -Xlog:all=trace (I think that's the right syntax). It may show how far the VM gets before something goes wrong. Thanks, David Thanks, Yasumasa 2018-05-09 11:17 GMT+09:00 David Holmes : On 9/05/2018 12:09 PM, Yasumasa Suenaga wrote: Hi David, 2018-05-09 10:48 GMT+09:00 David Holmes : Can you build with LOG=trace to try and see the actual command that is failing? I tried it and got following logs. They look good to me. Not enough there for me to comment :) * Creating interim-image + /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/jdk/bin/jlink -J-XX:+UseSerialGC -J-Xms32M -J-Xmx512M -J-XX:TieredStopAtLevel=1 -J-Djlin k.debug=true --module-path /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/interim-jmods --endian little --output /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/interim-image --disable-plugin generate-jli-classes --add-modules java.base,java.logging So this seems to produce an interim image that won't run - correct? I'd be scouring the log in the lead up to this to see if anything seems to be unusual. Can you upload the log to cr.openjdk.java.net? Or email me directly? Thanks, David * Command on error: + /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/interim-image/bin/java -XX:DumpLoadedClassList=/home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/link_opt/classlist.raw -Djava.lang.invoke.MethodHandle.TRACE_RESOLVE=true -cp /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/classlist.jar build.tools.classlist.HelloClasslist Thanks, Yasumasa David On 9/05/2018 11:39 AM, Yasumasa Suenaga wrote: Hi, 2018-05-09 0:27 GMT+09:00 Erik Joelsson : Hello, Your assessment is looks correct so far. At this point, one would have to start debugging the image to figure out what's wrong with it. Are you able to run the exploded image in ./build/linux-x86_64-normal-server-fastdebug/jdk/bin/java? It works. So I wonder why invalid image was built. ``` $ ./build/linux-x86_64-normal-server-fastdebug/jdk/bin/java --version openjdk 11-internal 2018-09-25 OpenJDK Runtime Environment (fastdebug build 11-internal+0-adhoc.ysuenaga.jdk) OpenJDK 64-Bit Server VM (fastdebug build 11-internal+0-adhoc.ysuenaga.jdk, mixed mode) ``` I'm waiting for Severin's evaluation :-) Thanks, Yasumasa Has anyone at Redhat built successfully on Fedora 28 yet? /Erik On 2018-05-08 06:42, Yasumasa Suenaga wrote: Hi all, I tried to build OpenJDK (jdk/jdk) on Fedora 28 x64, but it failed as following: ``` [ysuenaga@fc28 jdk]$ make images Building target 'images' in configuration 'linux-x86_64-normal-server-fastdebug' gmake[3]: *** [GenerateLinkOptData.gmk:64: /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/link_opt/classlist] Error 1 gmake[2]: *** [make/Main.gmk:448: generate-link-opt-data] Error 2 ERROR: Build failed for target 'images' in configuration 'linux-x86_64-normal-server-fastdebug' (exit code 2) No indication of failed target found. Hint: Try searching the build log for '] Error'. Hint: See
Re: Build failure on Fedora 28
Hi David, 2018-05-09 16:26 GMT+09:00 David Holmes: > On 9/05/2018 5:19 PM, Yasumasa Suenaga wrote: >> >> Hi David, >> >> I uploaded trace log: >>http://cr.openjdk.java.net/~ysuenaga/openjdk-fc28/trace-all.log >> >> It seems to open module file, but any class is not loaded from there. > > > The last line I see is: > > [0.266s][trace][gc,tlab ] TLAB: fill thread: 0x7fd7c801f800 > [id: 17487] desired_size: 491KB slow allocs: 0 refill waste: 7864B alloc: > 0.9 2048KB refills: 1 waste 0.0% gc: 0B slow: 0B fast: 0B > > is that right? Seems we just have a silent abort during VM initialization. > This seems quite bizarre. Yes, I guess VM was aborted because it could not load java/lang/Object. http://mail.openjdk.java.net/pipermail/build-dev/2018-May/021999.html > Can you run it in the debugger? No, I ran `./java -Xlog:all=trace:/home/ysuenaga/trace-all.log --version` Thanks, Yasumasa > Thanks, > David > >> >> Thanks, >> >> Yasumasa >> >> >> >> 2018-05-09 15:31 GMT+09:00 David Holmes : >>> >>> On 9/05/2018 1:46 PM, Yasumasa Suenaga wrote: Hi David, I uploaded build.log: http://cr.openjdk.java.net/~ysuenaga/openjdk-fc28/build.log Is it enough? >>> >>> >>> >>> It's all there is. :) But no errors. It all is fine right up to the part >>> that it isn't. >>> >>> Can you run: >>> >>> >>> /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/interim-image/bin/java >>> >>> with full logging enabled - -Xlog:all=trace (I think that's the right >>> syntax). It may show how far the VM gets before something goes wrong. >>> >>> Thanks, >>> David >>> >>> Thanks, Yasumasa 2018-05-09 11:17 GMT+09:00 David Holmes : > > > On 9/05/2018 12:09 PM, Yasumasa Suenaga wrote: >> >> >> >> Hi David, >> >> 2018-05-09 10:48 GMT+09:00 David Holmes : >>> >>> >>> >>> Can you build with LOG=trace to try and see the actual command that >>> is >>> failing? >> >> >> >> >> I tried it and got following logs. They look good to me. > > > > > Not enough there for me to comment :) >> >> >> >> >> * Creating interim-image >> >> + >> >> >> /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/jdk/bin/jlink >> -J-XX:+UseSerialGC -J-Xms32M -J-Xmx512M -J-XX:TieredStopAtLevel=1 >> -J-Djlin >> k.debug=true --module-path >> >> >> >> /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/interim-jmods >> --endian little --output >> >> >> >> /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/interim-image >> --disable-plugin generate-jli-classes --add-modules >> java.base,java.logging > > > > > So this seems to produce an interim image that won't run - correct? I'd > be > scouring the log in the lead up to this to see if anything seems to be > unusual. Can you upload the log to cr.openjdk.java.net? Or email me > directly? > > Thanks, > David > > >> >> * Command on error: >> >> + >> >> >> /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/interim-image/bin/java >> >> >> >> -XX:DumpLoadedClassList=/home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/link_opt/classlist.raw >> -Djava.lang.invoke.MethodHandle.TRACE_RESOLVE=true -cp >> >> >> >> /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/classlist.jar >> build.tools.classlist.HelloClasslist >> >> Thanks, >> >> Yasumasa >> >> >>> David >>> >>> >>> On 9/05/2018 11:39 AM, Yasumasa Suenaga wrote: Hi, 2018-05-09 0:27 GMT+09:00 Erik Joelsson : > > > > > Hello, > > Your assessment is looks correct so far. At this point, one would > have > to > start debugging the image to figure out what's wrong with it. Are > you > able > to run the exploded image in > ./build/linux-x86_64-normal-server-fastdebug/jdk/bin/java? It works. So I wonder why invalid image was built. ``` $ ./build/linux-x86_64-normal-server-fastdebug/jdk/bin/java --version openjdk 11-internal 2018-09-25 OpenJDK Runtime Environment (fastdebug build 11-internal+0-adhoc.ysuenaga.jdk) OpenJDK 64-Bit Server VM (fastdebug build 11-internal+0-adhoc.ysuenaga.jdk, mixed mode) ```
Re: Build failure on Fedora 28
On 9/05/2018 5:19 PM, Yasumasa Suenaga wrote: Hi David, I uploaded trace log: http://cr.openjdk.java.net/~ysuenaga/openjdk-fc28/trace-all.log It seems to open module file, but any class is not loaded from there. The last line I see is: [0.266s][trace][gc,tlab ] TLAB: fill thread: 0x7fd7c801f800 [id: 17487] desired_size: 491KB slow allocs: 0 refill waste: 7864B alloc: 0.9 2048KB refills: 1 waste 0.0% gc: 0B slow: 0B fast: 0B is that right? Seems we just have a silent abort during VM initialization. This seems quite bizarre. Can you run it in the debugger? Thanks, David Thanks, Yasumasa 2018-05-09 15:31 GMT+09:00 David Holmes: On 9/05/2018 1:46 PM, Yasumasa Suenaga wrote: Hi David, I uploaded build.log: http://cr.openjdk.java.net/~ysuenaga/openjdk-fc28/build.log Is it enough? It's all there is. :) But no errors. It all is fine right up to the part that it isn't. Can you run: /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/interim-image/bin/java with full logging enabled - -Xlog:all=trace (I think that's the right syntax). It may show how far the VM gets before something goes wrong. Thanks, David Thanks, Yasumasa 2018-05-09 11:17 GMT+09:00 David Holmes : On 9/05/2018 12:09 PM, Yasumasa Suenaga wrote: Hi David, 2018-05-09 10:48 GMT+09:00 David Holmes : Can you build with LOG=trace to try and see the actual command that is failing? I tried it and got following logs. They look good to me. Not enough there for me to comment :) * Creating interim-image + /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/jdk/bin/jlink -J-XX:+UseSerialGC -J-Xms32M -J-Xmx512M -J-XX:TieredStopAtLevel=1 -J-Djlin k.debug=true --module-path /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/interim-jmods --endian little --output /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/interim-image --disable-plugin generate-jli-classes --add-modules java.base,java.logging So this seems to produce an interim image that won't run - correct? I'd be scouring the log in the lead up to this to see if anything seems to be unusual. Can you upload the log to cr.openjdk.java.net? Or email me directly? Thanks, David * Command on error: + /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/interim-image/bin/java -XX:DumpLoadedClassList=/home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/link_opt/classlist.raw -Djava.lang.invoke.MethodHandle.TRACE_RESOLVE=true -cp /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/classlist.jar build.tools.classlist.HelloClasslist Thanks, Yasumasa David On 9/05/2018 11:39 AM, Yasumasa Suenaga wrote: Hi, 2018-05-09 0:27 GMT+09:00 Erik Joelsson : Hello, Your assessment is looks correct so far. At this point, one would have to start debugging the image to figure out what's wrong with it. Are you able to run the exploded image in ./build/linux-x86_64-normal-server-fastdebug/jdk/bin/java? It works. So I wonder why invalid image was built. ``` $ ./build/linux-x86_64-normal-server-fastdebug/jdk/bin/java --version openjdk 11-internal 2018-09-25 OpenJDK Runtime Environment (fastdebug build 11-internal+0-adhoc.ysuenaga.jdk) OpenJDK 64-Bit Server VM (fastdebug build 11-internal+0-adhoc.ysuenaga.jdk, mixed mode) ``` I'm waiting for Severin's evaluation :-) Thanks, Yasumasa Has anyone at Redhat built successfully on Fedora 28 yet? /Erik On 2018-05-08 06:42, Yasumasa Suenaga wrote: Hi all, I tried to build OpenJDK (jdk/jdk) on Fedora 28 x64, but it failed as following: ``` [ysuenaga@fc28 jdk]$ make images Building target 'images' in configuration 'linux-x86_64-normal-server-fastdebug' gmake[3]: *** [GenerateLinkOptData.gmk:64: /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/link_opt/classlist] Error 1 gmake[2]: *** [make/Main.gmk:448: generate-link-opt-data] Error 2 ERROR: Build failed for target 'images' in configuration 'linux-x86_64-normal-server-fastdebug' (exit code 2) No indication of failed target found. Hint: Try searching the build log for '] Error'. Hint: See doc/building.html#troubleshooting for assistance. make[1]: *** [/home/ysuenaga/OpenJDK/jdk/make/Init.gmk:305: main] Error 2 make: *** [/home/ysuenaga/OpenJDK/jdk/make/Init.gmk:186: images] Error 2 ``` It seems "interim-image" is not valid: ``` [ysuenaga@fc28 jdk]$ ./build/linux-x86_64-normal-server-fastdebug/support/interim-image/bin/java --version Error occurred during initialization of VM java/lang/NoClassDefFoundError: java/lang/Object ``` It can succeed on Fedora 27. So I think it causes by OS. I've disabled SELinux, and warnings / errors are nothing in `journalctl -a`. Do you have any
Re: Build failure on Fedora 28
Hi David, I uploaded trace log: http://cr.openjdk.java.net/~ysuenaga/openjdk-fc28/trace-all.log It seems to open module file, but any class is not loaded from there. Thanks, Yasumasa 2018-05-09 15:31 GMT+09:00 David Holmes: > On 9/05/2018 1:46 PM, Yasumasa Suenaga wrote: >> >> Hi David, >> >> I uploaded build.log: >>http://cr.openjdk.java.net/~ysuenaga/openjdk-fc28/build.log >> >> Is it enough? > > > It's all there is. :) But no errors. It all is fine right up to the part > that it isn't. > > Can you run: > > /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/interim-image/bin/java > > with full logging enabled - -Xlog:all=trace (I think that's the right > syntax). It may show how far the VM gets before something goes wrong. > > Thanks, > David > > >> >> Thanks, >> >> Yasumasa >> >> >> >> 2018-05-09 11:17 GMT+09:00 David Holmes : >>> >>> On 9/05/2018 12:09 PM, Yasumasa Suenaga wrote: Hi David, 2018-05-09 10:48 GMT+09:00 David Holmes : > > > Can you build with LOG=trace to try and see the actual command that is > failing? I tried it and got following logs. They look good to me. >>> >>> >>> >>> Not enough there for me to comment :) * Creating interim-image + /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/jdk/bin/jlink -J-XX:+UseSerialGC -J-Xms32M -J-Xmx512M -J-XX:TieredStopAtLevel=1 -J-Djlin k.debug=true --module-path /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/interim-jmods --endian little --output /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/interim-image --disable-plugin generate-jli-classes --add-modules java.base,java.logging >>> >>> >>> >>> So this seems to produce an interim image that won't run - correct? I'd >>> be >>> scouring the log in the lead up to this to see if anything seems to be >>> unusual. Can you upload the log to cr.openjdk.java.net? Or email me >>> directly? >>> >>> Thanks, >>> David >>> >>> * Command on error: + /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/interim-image/bin/java -XX:DumpLoadedClassList=/home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/link_opt/classlist.raw -Djava.lang.invoke.MethodHandle.TRACE_RESOLVE=true -cp /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/classlist.jar build.tools.classlist.HelloClasslist Thanks, Yasumasa > David > > > On 9/05/2018 11:39 AM, Yasumasa Suenaga wrote: >> >> >> >> Hi, >> >> 2018-05-09 0:27 GMT+09:00 Erik Joelsson : >>> >>> >>> >>> Hello, >>> >>> Your assessment is looks correct so far. At this point, one would >>> have >>> to >>> start debugging the image to figure out what's wrong with it. Are you >>> able >>> to run the exploded image in >>> ./build/linux-x86_64-normal-server-fastdebug/jdk/bin/java? >> >> >> >> >> It works. So I wonder why invalid image was built. >> >> ``` >> $ ./build/linux-x86_64-normal-server-fastdebug/jdk/bin/java --version >> openjdk 11-internal 2018-09-25 >> OpenJDK Runtime Environment (fastdebug build >> 11-internal+0-adhoc.ysuenaga.jdk) >> OpenJDK 64-Bit Server VM (fastdebug build >> 11-internal+0-adhoc.ysuenaga.jdk, mixed mode) >> ``` >> >> I'm waiting for Severin's evaluation :-) >> >> >> Thanks, >> >> Yasumasa >> >> >>> Has anyone at Redhat built successfully on Fedora 28 yet? >>> >>> /Erik >>> >>> >>> >>> On 2018-05-08 06:42, Yasumasa Suenaga wrote: Hi all, I tried to build OpenJDK (jdk/jdk) on Fedora 28 x64, but it failed as following: ``` [ysuenaga@fc28 jdk]$ make images Building target 'images' in configuration 'linux-x86_64-normal-server-fastdebug' gmake[3]: *** [GenerateLinkOptData.gmk:64: /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/link_opt/classlist] Error 1 gmake[2]: *** [make/Main.gmk:448: generate-link-opt-data] Error 2 ERROR: Build failed for target 'images' in configuration 'linux-x86_64-normal-server-fastdebug' (exit code 2) No indication of failed target found. Hint: Try searching the build log for '] Error'. Hint: See doc/building.html#troubleshooting for assistance. make[1]: ***
Re: Build failure on Fedora 28
On 9/05/2018 1:46 PM, Yasumasa Suenaga wrote: Hi David, I uploaded build.log: http://cr.openjdk.java.net/~ysuenaga/openjdk-fc28/build.log Is it enough? It's all there is. :) But no errors. It all is fine right up to the part that it isn't. Can you run: /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/interim-image/bin/java with full logging enabled - -Xlog:all=trace (I think that's the right syntax). It may show how far the VM gets before something goes wrong. Thanks, David Thanks, Yasumasa 2018-05-09 11:17 GMT+09:00 David Holmes: On 9/05/2018 12:09 PM, Yasumasa Suenaga wrote: Hi David, 2018-05-09 10:48 GMT+09:00 David Holmes : Can you build with LOG=trace to try and see the actual command that is failing? I tried it and got following logs. They look good to me. Not enough there for me to comment :) * Creating interim-image + /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/jdk/bin/jlink -J-XX:+UseSerialGC -J-Xms32M -J-Xmx512M -J-XX:TieredStopAtLevel=1 -J-Djlin k.debug=true --module-path /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/interim-jmods --endian little --output /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/interim-image --disable-plugin generate-jli-classes --add-modules java.base,java.logging So this seems to produce an interim image that won't run - correct? I'd be scouring the log in the lead up to this to see if anything seems to be unusual. Can you upload the log to cr.openjdk.java.net? Or email me directly? Thanks, David * Command on error: + /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/interim-image/bin/java -XX:DumpLoadedClassList=/home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/link_opt/classlist.raw -Djava.lang.invoke.MethodHandle.TRACE_RESOLVE=true -cp /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/classlist.jar build.tools.classlist.HelloClasslist Thanks, Yasumasa David On 9/05/2018 11:39 AM, Yasumasa Suenaga wrote: Hi, 2018-05-09 0:27 GMT+09:00 Erik Joelsson : Hello, Your assessment is looks correct so far. At this point, one would have to start debugging the image to figure out what's wrong with it. Are you able to run the exploded image in ./build/linux-x86_64-normal-server-fastdebug/jdk/bin/java? It works. So I wonder why invalid image was built. ``` $ ./build/linux-x86_64-normal-server-fastdebug/jdk/bin/java --version openjdk 11-internal 2018-09-25 OpenJDK Runtime Environment (fastdebug build 11-internal+0-adhoc.ysuenaga.jdk) OpenJDK 64-Bit Server VM (fastdebug build 11-internal+0-adhoc.ysuenaga.jdk, mixed mode) ``` I'm waiting for Severin's evaluation :-) Thanks, Yasumasa Has anyone at Redhat built successfully on Fedora 28 yet? /Erik On 2018-05-08 06:42, Yasumasa Suenaga wrote: Hi all, I tried to build OpenJDK (jdk/jdk) on Fedora 28 x64, but it failed as following: ``` [ysuenaga@fc28 jdk]$ make images Building target 'images' in configuration 'linux-x86_64-normal-server-fastdebug' gmake[3]: *** [GenerateLinkOptData.gmk:64: /home/ysuenaga/OpenJDK/jdk/build/linux-x86_64-normal-server-fastdebug/support/link_opt/classlist] Error 1 gmake[2]: *** [make/Main.gmk:448: generate-link-opt-data] Error 2 ERROR: Build failed for target 'images' in configuration 'linux-x86_64-normal-server-fastdebug' (exit code 2) No indication of failed target found. Hint: Try searching the build log for '] Error'. Hint: See doc/building.html#troubleshooting for assistance. make[1]: *** [/home/ysuenaga/OpenJDK/jdk/make/Init.gmk:305: main] Error 2 make: *** [/home/ysuenaga/OpenJDK/jdk/make/Init.gmk:186: images] Error 2 ``` It seems "interim-image" is not valid: ``` [ysuenaga@fc28 jdk]$ ./build/linux-x86_64-normal-server-fastdebug/support/interim-image/bin/java --version Error occurred during initialization of VM java/lang/NoClassDefFoundError: java/lang/Object ``` It can succeed on Fedora 27. So I think it causes by OS. I've disabled SELinux, and warnings / errors are nothing in `journalctl -a`. Do you have any idea to resolve this issue? Thanks, Yasumasa