Re: RFR: JDK-8204973: Add build support for filtering translations
Hi Erik, The modifications to the logging test look good to me. Caveat: I don't speak chinese nor japanese ;-) cheers, -- daniel On 13/06/18 20:47, Erik Joelsson wrote: Hello, Oracle will reduce the number of languages that it maintains translations of JDK resources for. The current translations will remain in the source for now, but we need a way to filter out a set of translations at build time so that we only include the ones we support. This patch adds such a configuration option. It also changes how Oracle builds by using the option to exclude all translations except English, Japanese, Simplified Chinese and Traditional Chinese. Anyone else building OpenJDK will by default include all translations present in the source, just as before. I added a test that verifies this for builds with the "IMPLEMENTOR" field in the release file set to "Oracle Corporation". The test will not be run for other OpenJDK builds. I had to modify an existing test for java.logging which used various translations to verify localized log messages to only use translations that Oracle chooses to include. Since this is the second test that specifically verifies build behavior, I moved the previous such test together with this new test into a common top level test directory "build", under the jdk test root. I put these tests in the jdk tier3 test group. I have run all tier1, 2 and 3 tests in Mach 5 as well as specifically looked for tests that use the java.util.Locale class and ran them locally. Webrev: http://cr.openjdk.java.net/~erikj/8204973/webrev.01/index.html Bug: https://bugs.openjdk.java.net/browse/JDK-8204973 /Erik
RFR: JDK-8204973: Add build support for filtering translations
Hello, Oracle will reduce the number of languages that it maintains translations of JDK resources for. The current translations will remain in the source for now, but we need a way to filter out a set of translations at build time so that we only include the ones we support. This patch adds such a configuration option. It also changes how Oracle builds by using the option to exclude all translations except English, Japanese, Simplified Chinese and Traditional Chinese. Anyone else building OpenJDK will by default include all translations present in the source, just as before. I added a test that verifies this for builds with the "IMPLEMENTOR" field in the release file set to "Oracle Corporation". The test will not be run for other OpenJDK builds. I had to modify an existing test for java.logging which used various translations to verify localized log messages to only use translations that Oracle chooses to include. Since this is the second test that specifically verifies build behavior, I moved the previous such test together with this new test into a common top level test directory "build", under the jdk test root. I put these tests in the jdk tier3 test group. I have run all tier1, 2 and 3 tests in Mach 5 as well as specifically looked for tests that use the java.util.Locale class and ran them locally. Webrev: http://cr.openjdk.java.net/~erikj/8204973/webrev.01/index.html Bug: https://bugs.openjdk.java.net/browse/JDK-8204973 /Erik
Re: RFR(xs): 8204935: [aix] TOC overflow in libjvm.so (release build)
Thank you Magnus. On Wed, Jun 13, 2018 at 3:40 PM, Magnus Ihse Bursie wrote: > Looks good to me. > > /Magnus > >> 13 juni 2018 kl. 10:28 skrev Thomas Stüfe : >> >> Thank you Matthias! >> >> I'll wait for someone from the Oracle Build Group to have a say. >> >> ..Thomas >> >> On Wed, Jun 13, 2018 at 9:43 AM, Baesken, Matthias >> wrote: >>> Hi Thomas , thanks for fixing it, looks good ( not a Reviewer however) . >>> >>> Best regards, Matthias >>> >>> >>> -Original Message- From: ppc-aix-port-dev [mailto:ppc-aix-port-dev- boun...@openjdk.java.net] On Behalf Of Thomas Stüfe Sent: Mittwoch, 13. Juni 2018 08:14 To: build-dev ; ppc-aix-port- d...@openjdk.java.net Subject: RFR(xs): 8204935: [aix] TOC overflow in libjvm.so (release build) Hi all, may I have reviews for this small build fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8204935 webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8204935-aix-toc- overflow/webrev.00/webrev/ We finally have reached the point where even the standard (not gtest) release build libjvm.so got too large and blew its TOC. Hurray for templates. On the bright side, no need to keep different flags for different libjvm variants anymore. Kudos to whoever added auto-automake to the build, that makes these kind of changes really easier :) Thank you, Best Regards, Thomas >
Re: RFR(xs): 8204935: [aix] TOC overflow in libjvm.so (release build)
Looks good to me. /Magnus > 13 juni 2018 kl. 10:28 skrev Thomas Stüfe : > > Thank you Matthias! > > I'll wait for someone from the Oracle Build Group to have a say. > > ..Thomas > > On Wed, Jun 13, 2018 at 9:43 AM, Baesken, Matthias > wrote: >> Hi Thomas , thanks for fixing it, looks good ( not a Reviewer however) . >> >> Best regards, Matthias >> >> >> >>> -Original Message- >>> From: ppc-aix-port-dev [mailto:ppc-aix-port-dev- >>> boun...@openjdk.java.net] On Behalf Of Thomas Stüfe >>> Sent: Mittwoch, 13. Juni 2018 08:14 >>> To: build-dev ; ppc-aix-port- >>> d...@openjdk.java.net >>> Subject: RFR(xs): 8204935: [aix] TOC overflow in libjvm.so (release build) >>> >>> Hi all, >>> >>> may I have reviews for this small build fix: >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8204935 >>> webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8204935-aix-toc- >>> overflow/webrev.00/webrev/ >>> >>> We finally have reached the point where even the standard (not gtest) >>> release build libjvm.so got too large and blew its TOC. Hurray for >>> templates. On the bright side, no need to keep different flags for >>> different libjvm variants anymore. >>> >>> Kudos to whoever added auto-automake to the build, that makes these >>> kind of changes really easier :) >>> >>> Thank you, >>> >>> Best Regards, Thomas
Re: RFR(xs): 8204935: [aix] TOC overflow in libjvm.so (release build)
Thank you Matthias! I'll wait for someone from the Oracle Build Group to have a say. ..Thomas On Wed, Jun 13, 2018 at 9:43 AM, Baesken, Matthias wrote: > Hi Thomas , thanks for fixing it, looks good ( not a Reviewer however) . > > Best regards, Matthias > > > >> -Original Message- >> From: ppc-aix-port-dev [mailto:ppc-aix-port-dev- >> boun...@openjdk.java.net] On Behalf Of Thomas Stüfe >> Sent: Mittwoch, 13. Juni 2018 08:14 >> To: build-dev ; ppc-aix-port- >> d...@openjdk.java.net >> Subject: RFR(xs): 8204935: [aix] TOC overflow in libjvm.so (release build) >> >> Hi all, >> >> may I have reviews for this small build fix: >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8204935 >> webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8204935-aix-toc- >> overflow/webrev.00/webrev/ >> >> We finally have reached the point where even the standard (not gtest) >> release build libjvm.so got too large and blew its TOC. Hurray for >> templates. On the bright side, no need to keep different flags for >> different libjvm variants anymore. >> >> Kudos to whoever added auto-automake to the build, that makes these >> kind of changes really easier :) >> >> Thank you, >> >> Best Regards, Thomas
Re: RFR(xs): 8204935: [aix] TOC overflow in libjvm.so (release build)
Thank you Goetz! On Wed, Jun 13, 2018 at 8:54 AM, Lindenmaier, Goetz wrote: > Hi Thomas, > > thanks for fixing and doing the cleanup right away. > Looks good. > > Best regards, > Goetz. > >> -Original Message- >> From: ppc-aix-port-dev [mailto:ppc-aix-port-dev- >> boun...@openjdk.java.net] On Behalf Of Thomas Stüfe >> Sent: Mittwoch, 13. Juni 2018 08:14 >> To: build-dev ; ppc-aix-port- >> d...@openjdk.java.net >> Subject: RFR(xs): 8204935: [aix] TOC overflow in libjvm.so (release build) >> >> Hi all, >> >> may I have reviews for this small build fix: >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8204935 >> webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8204935-aix-toc- >> overflow/webrev.00/webrev/ >> >> We finally have reached the point where even the standard (not gtest) >> release build libjvm.so got too large and blew its TOC. Hurray for >> templates. On the bright side, no need to keep different flags for >> different libjvm variants anymore. >> >> Kudos to whoever added auto-automake to the build, that makes these >> kind of changes really easier :) >> >> Thank you, >> >> Best Regards, Thomas
RE: RFR(xs): 8204935: [aix] TOC overflow in libjvm.so (release build)
Hi Thomas , thanks for fixing it, looks good ( not a Reviewer however) . Best regards, Matthias > -Original Message- > From: ppc-aix-port-dev [mailto:ppc-aix-port-dev- > boun...@openjdk.java.net] On Behalf Of Thomas Stüfe > Sent: Mittwoch, 13. Juni 2018 08:14 > To: build-dev ; ppc-aix-port- > d...@openjdk.java.net > Subject: RFR(xs): 8204935: [aix] TOC overflow in libjvm.so (release build) > > Hi all, > > may I have reviews for this small build fix: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8204935 > webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8204935-aix-toc- > overflow/webrev.00/webrev/ > > We finally have reached the point where even the standard (not gtest) > release build libjvm.so got too large and blew its TOC. Hurray for > templates. On the bright side, no need to keep different flags for > different libjvm variants anymore. > > Kudos to whoever added auto-automake to the build, that makes these > kind of changes really easier :) > > Thank you, > > Best Regards, Thomas
