Re: compiling openJdk 11 on windows 7 32bits fail

2019-02-10 Thread David Holmes

On 8/02/2019 5:07 am, Franco Gastón Pellegrini wrote:

I tried compiling JDK 12 for 32 bits, and I get similar errors:

=== Output from failing command(s) repeated here ===
* For target hotspot_variant-client_libjvm_objs_classFileParser.obj:
classFileParser.cpp
c:/cygwin64/home/franc/java/jdk12/src/hotspot/share/classfile/classFileParser.cpp(312): 
error C2220: warning treated as error - no 'object' file generated
c:/cygwin64/home/franc/java/jdk12/src/hotspot/share/classfile/classFileParser.cpp(312): 
warning C4267: '=': conversion from 'size_t' to 'u2', possible loss of data

    ... (rest of output omitted)


This is an issue we ran into compiling 8u with VS2017:

https://bugs.openjdk.java.net/browse/JDK-8205677

We probably never noticed in JDK 12 because we don't do 32-bits builds 
with VS2017.


David
-

* All command lines available in 
/cygdrive/c/cygwin64/home/franc/java/jdk12/build/windows-x86-client-fastdebug/make-support/failure-logs.

=== End of repeated output ===

No indication of failed target found.
Hint: Try searching the build log for '] Error'.
Hint: See doc/building.html#troubleshooting for assistance.

make[1]: *** [/home/franc/java/jdk12/make/Init.gmk:310: main] Error 2
make: *** [/home/franc/java/jdk12/make/Init.gmk:186: default] Error 2


El mié., 6 de feb. de 2019 a la(s) 19:23, Franco Gastón Pellegrini 
(francogpellegr...@gmail.com ) escribió:


I just tried --disable-warnings-as-errors, and JDK 11 64bits as a
bootjdk, but I get a lots of errors, and it refuse to build, like this:


c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/classfile/classFileParser.cpp(310):
warning C4267: '=': conversion from 'size_t' to 'u2', possible loss
of data
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(229):
error C2956: sized deallocation function 'operator delete(void*,
size_t)' would be chosen as placement deallocation function.
predefined C++ types (compiler internal)(44): note: see declaration
of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(250):
error C2956: sized deallocation function 'operator delete(void*,
size_t)' would be chosen as placement deallocation function.
predefined C++ types (compiler internal)(44): note: see declaration
of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(289):
error C2956: sized deallocation function 'operator delete(void*,
size_t)' would be chosen as placement deallocation function.
predefined C++ types (compiler internal)(44): note: see declaration
of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(312):
error C2956: sized deallocation function 'operator delete(void*,
size_t)' would be chosen as placement deallocation function.
predefined C++ types (compiler internal)(44): note: see declaration
of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(333):
error C2956: sized deallocation function 'operator delete(void*,
size_t)' would be chosen as placement deallocation function.
predefined C++ types (compiler internal)(44): note: see declaration
of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(372):
error C2956: sized deallocation function 'operator delete(void*,
size_t)' would be chosen as placement deallocation function.
predefined C++ types (compiler internal)(44): note: see declaration
of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(437):
error C2956: sized deallocation function 'operator delete(void*,
size_t)' would be chosen as placement deallocation function.
predefined C++ types (compiler internal)(44): note: see declaration
of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(541):
error C2956: sized deallocation function 'operator delete(void*,
size_t)' would be chosen as placement deallocation function.
predefined C++ types (compiler internal)(44): note: see declaration
of 'operator delete'



El mié., 6 de feb. de 2019 a la(s) 16:15, Erik Joelsson
(erik.joels...@oracle.com ) escribió:

If you are running into warnings treated as errors, please try
configuring with --disable-warnings-as-errors. That is often
needed on
less tested platforms.

Note that as long as you run the build on a 64 bit system, you
can use a
64 bit bootjdk to build a 32 bit JDK.

/Erik

On 2019-02-06 11:07, Franco Gastón Pellegrini wrote:
 > Can this be fixed before JDK 12? I will not able to compile
java 12 32bits
 > because I will not have java 11 32bits as a boot-jdk.
 >
 > El sáb., 24 de nov. de 2018 a 

Re: RFR: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-02-10 Thread Alan Bateman

On 08/02/2019 18:53, Mandy Chung wrote:


Renaming it to make it clear is good.  How about:

--strip-debug-attribute
--strip-native-debug-symbols

--strip-debug will invoke both --strip-debug-attribute and
--strip-native-debug-symbols, if supported.

Typically we want to strip both.  If only stripping debug attribute,
then it can use --strip-debug-attribute.

What do you think?
This make sense and I'm just wondering if we need to extend this to 
debug symbols that are in external files. This suggests exploring 
whether it should imply --exclude-files too.




:

Hmm... I thought it allows optional arguments. LegalNoticeFilePlugin
accepts an optional argument.
I don't think --dedup-legal-notices works without an option. It would be 
generally useful to allow optional values.


-Alan