Re: compiling openJdk 11 on windows 7 32bits fail

[David Holmes]

On 12/02/2019 1:45 pm, Franco Gastón Pellegrini wrote:
I just downloaded again (to be sure about my errors) JDK 12 and use this 
command:
bash ./configure --enable-debug --disable-warnings-as-errors 
--with-target-bits=32 --with-toolchain-version=2017 
--with-jvm-variants=client --with-boot-jdk="/cygdrive/c/Program 
Files/Java/jdk-11.0.2/";


and I get:

ERROR: Build failed for target 'default (exploded-image)' in 
configuration 'windows-x86-client-fastdebug' (exit code 2)

Stopping sjavac server

=== Output from failing command(s) repeated here ===
* For target support_native_java.desktop_libawt_Hashtable.obj:
Hashtable.cpp
c:/cygwin64/home/franc/java/jdk12/src/java.desktop/windows/native/libawt/windows/Hashtable.cpp(53): 
error C2664: 'void DTrace_PrintFunction(DTRACE_PRINT_CALLBACK,dtrace_id 
*,dtrace_id *,const char *,int,int,const char *,...)': cannot convert 
argument 1 from 'void (__stdcall *)(const char *,int,int,const char 
*,va_list)' to 'DTRACE_PRINT_CALLBACK'
c:/cygwin64/home/franc/java/jdk12/src/java.desktop/windows/native/libawt/windows/Hashtable.cpp(53): 
note: None of the functions with this name in scope match the target type


Sorry I can't see anything that would cause that - certainly nothing 
32-bit specific.


David
-


    ... (rest of output omitted)

* All command lines available in 
/cygdrive/c/cygwin64/home/franc/java/jdk12/build/windows-x86-client-fastdebug/make-support/failure-logs.

=== End of repeated output ===

No indication of failed target found.
Hint: Try searching the build log for '] Error'.
Hint: See doc/building.html#troubleshooting for assistance.

make[1]: *** [/home/franc/java/jdk12/make/Init.gmk:310: main] Error 2
make: *** [/home/franc/java/jdk12/make/Init.gmk:186: default] Error 2


El lun., 11 de feb. de 2019 a la(s) 19:53, David Holmes 
(david.hol...@oracle.com ) escribió:


On 12/02/2019 8:28 am, Franco Gastón Pellegrini wrote:
 > My mistake to not fully describe it but I tried jdk 11 and 12
using the
 > disable warning as error on both, getting similar errors. (Both
32 bits)

The "operator delete" issue has already been encountered:

https://bugs.openjdk.java.net/browse/JDK-8196880

But I can't see how that relates to share/code/codeBlob.cpp and only
for
32-bit. That would be a question for hotspot-...@openjdk.java.net


David

 > El lun., 11 de feb. de 2019 19:26, David Holmes
mailto:david.hol...@oracle.com>
 > >> escribió:
 >
 >     On 12/02/2019 12:03 am, Alexey Ivanov wrote:
 >      > Hi David,
 >      >
 >      > On 11/02/2019 11:33, David Holmes wrote:
 >      >> Hi Alexey,
 >      >>
 >      >> On 11/02/2019 7:12 pm, Alexey Ivanov wrote:
 >      >>> Hi Franco,
 >      >>>
 >      >>> On 11/02/2019 02:03, David Holmes wrote:
 >       On 8/02/2019 5:07 am, Franco Gastón Pellegrini wrote:
 >      > I tried compiling JDK 12 for 32 bits, and I get
similar errors:
 >      >
 >      > === Output from failing command(s) repeated here ===
 >      > * For target
 >     hotspot_variant-client_libjvm_objs_classFileParser.obj:
 >      > classFileParser.cpp
 >      >
 >   
  c:/cygwin64/home/franc/java/jdk12/src/hotspot/share/classfile/classFileParser.cpp(312):

 >
 >      > error C2220: warning treated as error - no 'object' file
 >     generated
 >      >
 >   
  c:/cygwin64/home/franc/java/jdk12/src/hotspot/share/classfile/classFileParser.cpp(312):

 >
 >      > warning C4267: '=': conversion from 'size_t' to 'u2',
 >     possible loss
 >      > of data
 >      >     ... (rest of output omitted)
 >      >>>
 >      >>> I used --disable-warnings-as-errors option to configure
when I
 >     built
 >      >>> JDK for 32 bit Windows last time.
 >      >>
 >      >> Note there are actual errors in Franco's log not just the
 >     warnings I
 >      >> commented on. I think we've already encountered the
operate delete
 >      >> issue so it may be fixed in 13, but not 12. Need to track
it down.
 >      >
 >      > I must have missed that point.
 >      > The message above says “error C2220: warning treated as
error”, so I
 >      > decided to let Franco know --disable-warnings-as-errors
helped me.
 >
 >     Yeah sorry - getting confused by the different things Franco
tried. He
 >     tried a JDK11 build with --disable-warnings-as-errors but it
still
 >     failed because of real errors:
 >
 >   
  c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(229):

 >
 >     error C2956: sized deallocation function 'operator delete(void*,
 >     size_t)' would be 

Re: compiling openJdk 11 on windows 7 32bits fail

[Franco Gastón Pellegrini]

I just downloaded again (to be sure about my errors) JDK 12 and use this
command:
bash ./configure --enable-debug --disable-warnings-as-errors
--with-target-bits=32 --with-toolchain-version=2017
--with-jvm-variants=client --with-boot-jdk="/cygdrive/c/Program
Files/Java/jdk-11.0.2/";

and I get:

ERROR: Build failed for target 'default (exploded-image)' in configuration
'windows-x86-client-fastdebug' (exit code 2)
Stopping sjavac server

=== Output from failing command(s) repeated here ===
* For target support_native_java.desktop_libawt_Hashtable.obj:
Hashtable.cpp
c:/cygwin64/home/franc/java/jdk12/src/java.desktop/windows/native/libawt/windows/Hashtable.cpp(53):
error C2664: 'void DTrace_PrintFunction(DTRACE_PRINT_CALLBACK,dtrace_id
*,dtrace_id *,const char *,int,int,const char *,...)': cannot convert
argument 1 from 'void (__stdcall *)(const char *,int,int,const char
*,va_list)' to 'DTRACE_PRINT_CALLBACK'
c:/cygwin64/home/franc/java/jdk12/src/java.desktop/windows/native/libawt/windows/Hashtable.cpp(53):
note: None of the functions with this name in scope match the target type
   ... (rest of output omitted)

* All command lines available in
/cygdrive/c/cygwin64/home/franc/java/jdk12/build/windows-x86-client-fastdebug/make-support/failure-logs.
=== End of repeated output ===

No indication of failed target found.
Hint: Try searching the build log for '] Error'.
Hint: See doc/building.html#troubleshooting for assistance.

make[1]: *** [/home/franc/java/jdk12/make/Init.gmk:310: main] Error 2
make: *** [/home/franc/java/jdk12/make/Init.gmk:186: default] Error 2


El lun., 11 de feb. de 2019 a la(s) 19:53, David Holmes (
david.hol...@oracle.com) escribió:

> On 12/02/2019 8:28 am, Franco Gastón Pellegrini wrote:
> > My mistake to not fully describe it but I tried jdk 11 and 12 using the
> > disable warning as error on both, getting similar errors. (Both 32 bits)
>
> The "operator delete" issue has already been encountered:
>
> https://bugs.openjdk.java.net/browse/JDK-8196880
>
> But I can't see how that relates to share/code/codeBlob.cpp and only for
> 32-bit. That would be a question for hotspot-...@openjdk.java.net
>
> David
>
> > El lun., 11 de feb. de 2019 19:26, David Holmes  > > escribió:
> >
> > On 12/02/2019 12:03 am, Alexey Ivanov wrote:
> >  > Hi David,
> >  >
> >  > On 11/02/2019 11:33, David Holmes wrote:
> >  >> Hi Alexey,
> >  >>
> >  >> On 11/02/2019 7:12 pm, Alexey Ivanov wrote:
> >  >>> Hi Franco,
> >  >>>
> >  >>> On 11/02/2019 02:03, David Holmes wrote:
> >   On 8/02/2019 5:07 am, Franco Gastón Pellegrini wrote:
> >  > I tried compiling JDK 12 for 32 bits, and I get similar
> errors:
> >  >
> >  > === Output from failing command(s) repeated here ===
> >  > * For target
> > hotspot_variant-client_libjvm_objs_classFileParser.obj:
> >  > classFileParser.cpp
> >  >
> >
>  
> c:/cygwin64/home/franc/java/jdk12/src/hotspot/share/classfile/classFileParser.cpp(312):
> >
> >  > error C2220: warning treated as error - no 'object' file
> > generated
> >  >
> >
>  
> c:/cygwin64/home/franc/java/jdk12/src/hotspot/share/classfile/classFileParser.cpp(312):
> >
> >  > warning C4267: '=': conversion from 'size_t' to 'u2',
> > possible loss
> >  > of data
> >  > ... (rest of output omitted)
> >  >>>
> >  >>> I used --disable-warnings-as-errors option to configure when I
> > built
> >  >>> JDK for 32 bit Windows last time.
> >  >>
> >  >> Note there are actual errors in Franco's log not just the
> > warnings I
> >  >> commented on. I think we've already encountered the operate
> delete
> >  >> issue so it may be fixed in 13, but not 12. Need to track it
> down.
> >  >
> >  > I must have missed that point.
> >  > The message above says “error C2220: warning treated as error”,
> so I
> >  > decided to let Franco know --disable-warnings-as-errors helped me.
> >
> > Yeah sorry - getting confused by the different things Franco tried.
> He
> > tried a JDK11 build with --disable-warnings-as-errors but it still
> > failed because of real errors:
> >
> >
>  c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(229):
> >
> > error C2956: sized deallocation function 'operator delete(void*,
> > size_t)' would be chosen as placement deallocation function.
> > predefined C++ types (compiler internal)(44): note: see declaration
> of
> > 'operator delete'
> >
> > Then he posted that he'd tried jdk12 as well with "similar errors"
> but
> > only showed the
> >
> > error C2220: warning treated as error - no 'object' file generated
> > warning C4267: '=': conversion from 'size_t' to 'u2', possible loss
> > of data
> >
> > which means he was not running with --disable-warnings-as-errors
> >
> > David
> > -
> >
> >
> >

Re: compiling openJdk 11 on windows 7 32bits fail

[David Holmes]

On 12/02/2019 8:28 am, Franco Gastón Pellegrini wrote:
My mistake to not fully describe it but I tried jdk 11 and 12 using the 
disable warning as error on both, getting similar errors. (Both 32 bits)


The "operator delete" issue has already been encountered:

https://bugs.openjdk.java.net/browse/JDK-8196880

But I can't see how that relates to share/code/codeBlob.cpp and only for 
32-bit. That would be a question for hotspot-...@openjdk.java.net


David

El lun., 11 de feb. de 2019 19:26, David Holmes > escribió:


On 12/02/2019 12:03 am, Alexey Ivanov wrote:
 > Hi David,
 >
 > On 11/02/2019 11:33, David Holmes wrote:
 >> Hi Alexey,
 >>
 >> On 11/02/2019 7:12 pm, Alexey Ivanov wrote:
 >>> Hi Franco,
 >>>
 >>> On 11/02/2019 02:03, David Holmes wrote:
  On 8/02/2019 5:07 am, Franco Gastón Pellegrini wrote:
 > I tried compiling JDK 12 for 32 bits, and I get similar errors:
 >
 > === Output from failing command(s) repeated here ===
 > * For target
hotspot_variant-client_libjvm_objs_classFileParser.obj:
 > classFileParser.cpp
 >

c:/cygwin64/home/franc/java/jdk12/src/hotspot/share/classfile/classFileParser.cpp(312):

 > error C2220: warning treated as error - no 'object' file
generated
 >

c:/cygwin64/home/franc/java/jdk12/src/hotspot/share/classfile/classFileParser.cpp(312):

 > warning C4267: '=': conversion from 'size_t' to 'u2',
possible loss
 > of data
 >     ... (rest of output omitted)
 >>>
 >>> I used --disable-warnings-as-errors option to configure when I
built
 >>> JDK for 32 bit Windows last time.
 >>
 >> Note there are actual errors in Franco's log not just the
warnings I
 >> commented on. I think we've already encountered the operate delete
 >> issue so it may be fixed in 13, but not 12. Need to track it down.
 >
 > I must have missed that point.
 > The message above says “error C2220: warning treated as error”, so I
 > decided to let Franco know --disable-warnings-as-errors helped me.

Yeah sorry - getting confused by the different things Franco tried. He
tried a JDK11 build with --disable-warnings-as-errors but it still
failed because of real errors:

c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(229):

error C2956: sized deallocation function 'operator delete(void*,
size_t)' would be chosen as placement deallocation function.
predefined C++ types (compiler internal)(44): note: see declaration of
'operator delete'

Then he posted that he'd tried jdk12 as well with "similar errors" but
only showed the

error C2220: warning treated as error - no 'object' file generated
warning C4267: '=': conversion from 'size_t' to 'u2', possible loss
of data

which means he was not running with --disable-warnings-as-errors

David
-


 >
 > It's been a long while since I built jdk-dev on 32 bit Windows last
 > time; many things could have changed there.
 >
 > Regards,
 > Alexey
 >
 >>
 >> Cheers,
 >> David
 >>
 >>> David pointed to JDK-8205677 which should be forwardported to
13 to
 >>> fix the problem.
 >>>
 >>> Regards,
 >>> Alexey
 >>>
 
  This is an issue we ran into compiling 8u with VS2017:
 
  https://bugs.openjdk.java.net/browse/JDK-8205677
 
  We probably never noticed in JDK 12 because we don't do 32-bits
  builds with VS2017.
 
  David
  -
 
 > * All command lines available in
 >

/cygdrive/c/cygwin64/home/franc/java/jdk12/build/windows-x86-client-fastdebug/make-support/failure-logs.

 >
 > === End of repeated output ===
 >
 > No indication of failed target found.
 > Hint: Try searching the build log for '] Error'.
 > Hint: See doc/building.html#troubleshooting for assistance.
 >
 > make[1]: *** [/home/franc/java/jdk12/make/Init.gmk:310: main]
Error 2
 > make: *** [/home/franc/java/jdk12/make/Init.gmk:186: default]
Error 2
 >
 >
 > El mié., 6 de feb. de 2019 a la(s) 19:23, Franco Gastón
Pellegrini
 > (francogpellegr...@gmail.com

>)
 > escribió:
 >
 >     I just tried --disable-warnings-as-errors, and JDK 11
64bits as a
 >     bootjdk, but I get a lots of errors, and it refuse to build,
 > like this:
 >
 >

c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/classfile/classFileParser.cpp(310):

 >
 >     warning C4267: '=': conversion from 'size_t' to 'u2',
possible
 > 

Re: compiling openJdk 11 on windows 7 32bits fail

[Franco Gastón Pellegrini]

My mistake to not fully describe it but I tried jdk 11 and 12 using the
disable warning as error on both, getting similar errors. (Both 32 bits)

El lun., 11 de feb. de 2019 19:26, David Holmes 
escribió:

> On 12/02/2019 12:03 am, Alexey Ivanov wrote:
> > Hi David,
> >
> > On 11/02/2019 11:33, David Holmes wrote:
> >> Hi Alexey,
> >>
> >> On 11/02/2019 7:12 pm, Alexey Ivanov wrote:
> >>> Hi Franco,
> >>>
> >>> On 11/02/2019 02:03, David Holmes wrote:
>  On 8/02/2019 5:07 am, Franco Gastón Pellegrini wrote:
> > I tried compiling JDK 12 for 32 bits, and I get similar errors:
> >
> > === Output from failing command(s) repeated here ===
> > * For target hotspot_variant-client_libjvm_objs_classFileParser.obj:
> > classFileParser.cpp
> >
> c:/cygwin64/home/franc/java/jdk12/src/hotspot/share/classfile/classFileParser.cpp(312):
>
> > error C2220: warning treated as error - no 'object' file generated
> >
> c:/cygwin64/home/franc/java/jdk12/src/hotspot/share/classfile/classFileParser.cpp(312):
>
> > warning C4267: '=': conversion from 'size_t' to 'u2', possible loss
> > of data
> > ... (rest of output omitted)
> >>>
> >>> I used --disable-warnings-as-errors option to configure when I built
> >>> JDK for 32 bit Windows last time.
> >>
> >> Note there are actual errors in Franco's log not just the warnings I
> >> commented on. I think we've already encountered the operate delete
> >> issue so it may be fixed in 13, but not 12. Need to track it down.
> >
> > I must have missed that point.
> > The message above says “error C2220: warning treated as error”, so I
> > decided to let Franco know --disable-warnings-as-errors helped me.
>
> Yeah sorry - getting confused by the different things Franco tried. He
> tried a JDK11 build with --disable-warnings-as-errors but it still
> failed because of real errors:
>
> c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(229):
>
> error C2956: sized deallocation function 'operator delete(void*,
> size_t)' would be chosen as placement deallocation function.
> predefined C++ types (compiler internal)(44): note: see declaration of
> 'operator delete'
>
> Then he posted that he'd tried jdk12 as well with "similar errors" but
> only showed the
>
> error C2220: warning treated as error - no 'object' file generated
> warning C4267: '=': conversion from 'size_t' to 'u2', possible loss of data
>
> which means he was not running with --disable-warnings-as-errors
>
> David
> -
>
>
> >
> > It's been a long while since I built jdk-dev on 32 bit Windows last
> > time; many things could have changed there.
> >
> > Regards,
> > Alexey
> >
> >>
> >> Cheers,
> >> David
> >>
> >>> David pointed to JDK-8205677 which should be forwardported to 13 to
> >>> fix the problem.
> >>>
> >>> Regards,
> >>> Alexey
> >>>
> 
>  This is an issue we ran into compiling 8u with VS2017:
> 
>  https://bugs.openjdk.java.net/browse/JDK-8205677
> 
>  We probably never noticed in JDK 12 because we don't do 32-bits
>  builds with VS2017.
> 
>  David
>  -
> 
> > * All command lines available in
> >
> /cygdrive/c/cygwin64/home/franc/java/jdk12/build/windows-x86-client-fastdebug/make-support/failure-logs.
>
> >
> > === End of repeated output ===
> >
> > No indication of failed target found.
> > Hint: Try searching the build log for '] Error'.
> > Hint: See doc/building.html#troubleshooting for assistance.
> >
> > make[1]: *** [/home/franc/java/jdk12/make/Init.gmk:310: main] Error 2
> > make: *** [/home/franc/java/jdk12/make/Init.gmk:186: default] Error 2
> >
> >
> > El mié., 6 de feb. de 2019 a la(s) 19:23, Franco Gastón Pellegrini
> > (francogpellegr...@gmail.com )
> > escribió:
> >
> > I just tried --disable-warnings-as-errors, and JDK 11 64bits as a
> > bootjdk, but I get a lots of errors, and it refuse to build,
> > like this:
> >
> >
> c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/classfile/classFileParser.cpp(310):
>
> >
> > warning C4267: '=': conversion from 'size_t' to 'u2', possible
> > loss
> > of data
> >
> c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(229):
> >
> > error C2956: sized deallocation function 'operator delete(void*,
> > size_t)' would be chosen as placement deallocation function.
> > predefined C++ types (compiler internal)(44): note: see
> > declaration
> > of 'operator delete'
> >
> c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(250):
> >
> > error C2956: sized deallocation function 'operator delete(void*,
> > size_t)' would be chosen as placement deallocation function.
> > predefined C++ types (compiler internal)(44): note: see
> > declaration
> > of 'operator delete'
> >
> 

Re: compiling openJdk 11 on windows 7 32bits fail

[David Holmes]

On 12/02/2019 12:03 am, Alexey Ivanov wrote:

Hi David,

On 11/02/2019 11:33, David Holmes wrote:

Hi Alexey,

On 11/02/2019 7:12 pm, Alexey Ivanov wrote:

Hi Franco,

On 11/02/2019 02:03, David Holmes wrote:

On 8/02/2019 5:07 am, Franco Gastón Pellegrini wrote:

I tried compiling JDK 12 for 32 bits, and I get similar errors:

=== Output from failing command(s) repeated here ===
* For target hotspot_variant-client_libjvm_objs_classFileParser.obj:
classFileParser.cpp
c:/cygwin64/home/franc/java/jdk12/src/hotspot/share/classfile/classFileParser.cpp(312): 
error C2220: warning treated as error - no 'object' file generated
c:/cygwin64/home/franc/java/jdk12/src/hotspot/share/classfile/classFileParser.cpp(312): 
warning C4267: '=': conversion from 'size_t' to 'u2', possible loss 
of data

    ... (rest of output omitted)


I used --disable-warnings-as-errors option to configure when I built 
JDK for 32 bit Windows last time.


Note there are actual errors in Franco's log not just the warnings I 
commented on. I think we've already encountered the operate delete 
issue so it may be fixed in 13, but not 12. Need to track it down.


I must have missed that point.
The message above says “error C2220: warning treated as error”, so I 
decided to let Franco know --disable-warnings-as-errors helped me.


Yeah sorry - getting confused by the different things Franco tried. He 
tried a JDK11 build with --disable-warnings-as-errors but it still 
failed because of real errors:


c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(229): 
error C2956: sized deallocation function 'operator delete(void*, 
size_t)' would be chosen as placement deallocation function.
predefined C++ types (compiler internal)(44): note: see declaration of 
'operator delete'


Then he posted that he'd tried jdk12 as well with "similar errors" but 
only showed the


error C2220: warning treated as error - no 'object' file generated
warning C4267: '=': conversion from 'size_t' to 'u2', possible loss of data

which means he was not running with --disable-warnings-as-errors

David
-




It's been a long while since I built jdk-dev on 32 bit Windows last 
time; many things could have changed there.


Regards,
Alexey



Cheers,
David

David pointed to JDK-8205677 which should be forwardported to 13 to 
fix the problem.


Regards,
Alexey



This is an issue we ran into compiling 8u with VS2017:

https://bugs.openjdk.java.net/browse/JDK-8205677

We probably never noticed in JDK 12 because we don't do 32-bits 
builds with VS2017.


David
-

* All command lines available in 
/cygdrive/c/cygwin64/home/franc/java/jdk12/build/windows-x86-client-fastdebug/make-support/failure-logs. 


=== End of repeated output ===

No indication of failed target found.
Hint: Try searching the build log for '] Error'.
Hint: See doc/building.html#troubleshooting for assistance.

make[1]: *** [/home/franc/java/jdk12/make/Init.gmk:310: main] Error 2
make: *** [/home/franc/java/jdk12/make/Init.gmk:186: default] Error 2


El mié., 6 de feb. de 2019 a la(s) 19:23, Franco Gastón Pellegrini 
(francogpellegr...@gmail.com ) 
escribió:


    I just tried --disable-warnings-as-errors, and JDK 11 64bits as a
    bootjdk, but I get a lots of errors, and it refuse to build, 
like this:


c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/classfile/classFileParser.cpp(310): 

    warning C4267: '=': conversion from 'size_t' to 'u2', possible 
loss

    of data
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(229): 


    error C2956: sized deallocation function 'operator delete(void*,
    size_t)' would be chosen as placement deallocation function.
    predefined C++ types (compiler internal)(44): note: see 
declaration

    of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(250): 


    error C2956: sized deallocation function 'operator delete(void*,
    size_t)' would be chosen as placement deallocation function.
    predefined C++ types (compiler internal)(44): note: see 
declaration

    of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(289): 


    error C2956: sized deallocation function 'operator delete(void*,
    size_t)' would be chosen as placement deallocation function.
    predefined C++ types (compiler internal)(44): note: see 
declaration

    of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(312): 


    error C2956: sized deallocation function 'operator delete(void*,
    size_t)' would be chosen as placement deallocation function.
    predefined C++ types (compiler internal)(44): note: see 
declaration

    of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(333): 


    error C2956: sized deallocation function 'operator delete(void*,
    size_t)' would be chosen as placement deallocation function.
    predefined C++ types (compiler 

Re: RFR: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

[Erik Joelsson]

Hello Severin,

I think you also need a $(wildcard ) around it, but I may be wrong. Did 
you try this version?


Also, please do not indent so much. We have style guidelines [1], which 
recommend 4 spaces for line break indentation.


/Erik

[1] http://openjdk.java.net/groups/build/doc/code-conventions.html

On 2019-02-11 10:03, Severin Gehwolf wrote:

Hi Erik,

On Thu, 2019-02-07 at 17:01 -0800, Erik Joelsson wrote:

On 2019-02-07 11:09, Severin Gehwolf wrote:

Hi Erik,

On Thu, 2019-02-07 at 09:39 -0800, Erik Joelsson wrote:

Hello Severin,

There is a macro for automatically finding all source dirs for a module.
So in Gensrc-jdk.jlink.gmk, I think it would be better expressed using
that macro, like this:

JLINK_RESOURCE_DIRS := $(wildcard $(addsuffix
/jdk/tools/jlink/resources, $(call FindModuleSrcSdirs, jdk.jlink)))

The above could/should even be inlined.

I've considered this. It seems, though, that FindModuleSrcDirs comes
from make/common/Modules.gmk which isn't included in
make/gensrc/Gensrc-jdk.jlink.gmk. Given that it has already caused
problems with multiple includes of Modules.gmk (JDK-8213736) I was
reluctant to include it here too. Without the new include the above
won't work.

The approach I've taken here seems to be the lesser evil. Thoughts?

I appreciate your concern, but JDK-8213736 was a problem in Main.gmk,
which is part of where Modules.gmk gets bootstrapped. In any normal
makefile (as in where stuff is just being built), the bootstrapping is
done and including Modules.gmk is completely fine. Any
-.gmk file certainly qualifies here.

OK. Updated:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8214796/05/

Thanks,
Severin


/Erik


Thanks,
Severin


Otherwise build changes look ok.

/Erik

On 2019-02-07 09:09, Severin Gehwolf wrote:

Hi,

Could I please get reviews for this enhancement? It adds a
debug
symbols stripping plug-in to jlink for Linux and Unix
platforms. It's
the first platform specific jlink plugin and the approach taken
for
keeping it contained is to use a plugin specific
ResourceBundle.
Discussion for this happened in [1].

The test uses a native library which should never get debug
symbols
stripped during the test library build. As such, tiny
modifications
were needed to make/common/TestFilesCompilation.gmk. Hence,
build-dev
being on the list for this RFR. The test currently only runs on
Linux
and requires objcopy to be available. Otherwise the test is
being
skipped.

Example usage of this plugin is described in the bug.

webrev:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8214796/04/webrev/
Bug: https://bugs.openjdk.java.net/browse/JDK-8214796

Testing: test/jdk/tools/jlink test/jdk/jdk/modules tests on
Linux
x86_64 (with good and broken objcopy) and the newly added test.
It's
currently running through jdk/submit too.

Thoughts?

Thanks,
Severin

[1]
http://mail.openjdk.java.net/pipermail/jigsaw-dev/2019-January/014109.html

Re: RFR: JDK-8218413 make reconfigure ignores configure-time AUTOCONF environment variable

[Martin Buchholz]

Looks good to me.

On Mon, Feb 11, 2019 at 3:42 AM Magnus Ihse Bursie <
magnus.ihse.bur...@oracle.com> wrote:

>  From the bug report:
>
> "Suppose PATH points to an out-of date autoconf.
> We can use the AUTOCONF environment variable with configure to override
> finding autoconf on PATH, but that variable is not remembered, so
> make reconfigure fails.
>
> # Recipe:
> rm -rf build
> AUTOCONF=/usr/bin/autoconf PATH="$MOLDY/bin:$PATH" bash configure ...
> # configure + make succeed
>
> make reconfigure
> # Fails with:
> Using autoconf at $MOLDY/bin/autoconf [autoconf (GNU Autoconf) 2.62]
> stdin:33: error: Autoconf version 2.69 or higher is required"
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8218413
> WebRev:
>
> http://cr.openjdk.java.net/~ihse/JDK-8218413-preserve-AUTOCONF-for-reconfigure/webrev.01
>
> /Magnus
>

Re: RFR: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

[Severin Gehwolf]

Hi Alan,

Thanks for the review!

On Fri, 2019-02-08 at 10:08 +, Alan Bateman wrote:
> On 07/02/2019 17:09, Severin Gehwolf wrote:
> > Hi,
> > 
> > Could I please get reviews for this enhancement? It adds a debug
> > symbols stripping plug-in to jlink for Linux and Unix platforms. It's
> > the first platform specific jlink plugin and the approach taken for
> > keeping it contained is to use a plugin specific ResourceBundle.
> > Discussion for this happened in [1].
> > 
> > The test uses a native library which should never get debug symbols
> > stripped during the test library build. As such, tiny modifications
> > were needed to make/common/TestFilesCompilation.gmk. Hence, build-dev
> > being on the list for this RFR. The test currently only runs on Linux
> > and requires objcopy to be available. Otherwise the test is being
> > skipped.
> > 
> > Example usage of this plugin is described in the bug.
> > 
> > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8214796/04/webrev/
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8214796
> > 
> I agree with Mandy that the CLI options need examination. The proposed 
> `--strip-native-debug-symbols` seems reasonable but it will be 
> inconsistent with the existing `--strip-debug` option. Mandy - what you 
> would think about renaming the existing option to something that makes 
> it clear that it strips the debug attribute from class files? (we would 
> of course need to do something to keep the existing option working).
> 
> The need to specify the argument as "defaults" or "options" is a bit 
> annoying. It might be time to replace hasArguments in the plugin 
> interface to allow for optional arguments. The plugin interface is not 
> exported/documented/supported so we have flexibility to change it.

I've filed this bug for optional arguments:
https://bugs.openjdk.java.net/browse/JDK-8218761

It's a separate issue, after all.

> If we 
> do this then it should mean the usages reduce down to:
> 
> --strip-native-debug-symbols
> --strip-native-debug-symbols objcopy=:...
> 
> I see the plugin has moved to src/jdk.jlink/unix in this iteration. It 
> might be better to start out in src/jdk.jlink/linux - we can always move 
> to the unix tree in the event that there is interest/support on other 
> platforms.
> 
> Mandy points out the issue with wrapping in the usage output. I agree 
> that the`jlink --list-plugins` needs to be readable/tidy esp. in this 
> case as there are many sub-options to read about.

I'll tackle those once there is some agreement as to what the option
should be called and which arguments it should have for the initial
implementation. I'll reply with a proposal in the other thread.

> The implementation will need a bit of a tidy up too. The readFileBytes 
> method can be replaced with Files.readAllBytes. The BAIS usage can be 
> replaced with Files.write. Ignoring exceptions thrown in stripBinary 
> will also need consideration.

Should be fixed in the latest webrev:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8214796/05/webrev/

FWIW, I've refrained from using Files.readAllBytes in the initial
webrev because of this note in the javadoc:

"""
Note that this method is intended for simple cases where it is
convenient to read all bytes into a byte array. It is not intended for
reading in large files.
"""

Cheers,
Severin

Re: RFR: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

[Severin Gehwolf]

Hi Erik,

On Thu, 2019-02-07 at 17:01 -0800, Erik Joelsson wrote:
> On 2019-02-07 11:09, Severin Gehwolf wrote:
> > Hi Erik,
> > 
> > On Thu, 2019-02-07 at 09:39 -0800, Erik Joelsson wrote:
> > > Hello Severin,
> > > 
> > > There is a macro for automatically finding all source dirs for a module.
> > > So in Gensrc-jdk.jlink.gmk, I think it would be better expressed using
> > > that macro, like this:
> > > 
> > > JLINK_RESOURCE_DIRS := $(wildcard $(addsuffix
> > > /jdk/tools/jlink/resources, $(call FindModuleSrcSdirs, jdk.jlink)))
> > > 
> > > The above could/should even be inlined.
> > I've considered this. It seems, though, that FindModuleSrcDirs comes
> > from make/common/Modules.gmk which isn't included in
> > make/gensrc/Gensrc-jdk.jlink.gmk. Given that it has already caused
> > problems with multiple includes of Modules.gmk (JDK-8213736) I was
> > reluctant to include it here too. Without the new include the above
> > won't work.
> > 
> > The approach I've taken here seems to be the lesser evil. Thoughts?
> 
> I appreciate your concern, but JDK-8213736 was a problem in Main.gmk, 
> which is part of where Modules.gmk gets bootstrapped. In any normal 
> makefile (as in where stuff is just being built), the bootstrapping is 
> done and including Modules.gmk is completely fine. Any 
> -.gmk file certainly qualifies here.

OK. Updated:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8214796/05/

Thanks,
Severin

> /Erik
> 
> > Thanks,
> > Severin
> > 
> > > Otherwise build changes look ok.
> > > 
> > > /Erik
> > > 
> > > On 2019-02-07 09:09, Severin Gehwolf wrote:
> > > > Hi,
> > > > 
> > > > Could I please get reviews for this enhancement? It adds a
> > > > debug
> > > > symbols stripping plug-in to jlink for Linux and Unix
> > > > platforms. It's
> > > > the first platform specific jlink plugin and the approach taken
> > > > for
> > > > keeping it contained is to use a plugin specific
> > > > ResourceBundle.
> > > > Discussion for this happened in [1].
> > > > 
> > > > The test uses a native library which should never get debug
> > > > symbols
> > > > stripped during the test library build. As such, tiny
> > > > modifications
> > > > were needed to make/common/TestFilesCompilation.gmk. Hence,
> > > > build-dev
> > > > being on the list for this RFR. The test currently only runs on
> > > > Linux
> > > > and requires objcopy to be available. Otherwise the test is
> > > > being
> > > > skipped.
> > > > 
> > > > Example usage of this plugin is described in the bug.
> > > > 
> > > > webrev: 
> > > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8214796/04/webrev/
> > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8214796
> > > > 
> > > > Testing: test/jdk/tools/jlink test/jdk/jdk/modules tests on
> > > > Linux
> > > > x86_64 (with good and broken objcopy) and the newly added test.
> > > > It's
> > > > currently running through jdk/submit too.
> > > > 
> > > > Thoughts?
> > > > 
> > > > Thanks,
> > > > Severin
> > > > 
> > > > [1] 
> > > > http://mail.openjdk.java.net/pipermail/jigsaw-dev/2019-January/014109.html
> > > > 

Re: RFR: JDK-8218413 make reconfigure ignores configure-time AUTOCONF environment variable

[Erik Joelsson]

Looks good.

/Erik

On 2019-02-11 03:42, Magnus Ihse Bursie wrote:

From the bug report:

"Suppose PATH points to an out-of date autoconf.
We can use the AUTOCONF environment variable with configure to 
override finding autoconf on PATH, but that variable is not 
remembered, so

make reconfigure fails.

# Recipe:
rm -rf build
AUTOCONF=/usr/bin/autoconf PATH="$MOLDY/bin:$PATH" bash configure ...
# configure + make succeed

make reconfigure
# Fails with:
Using autoconf at $MOLDY/bin/autoconf [autoconf (GNU Autoconf) 2.62]
stdin:33: error: Autoconf version 2.69 or higher is required"

Bug: https://bugs.openjdk.java.net/browse/JDK-8218413
WebRev: 
http://cr.openjdk.java.net/~ihse/JDK-8218413-preserve-AUTOCONF-for-reconfigure/webrev.01


/Magnus

Re: compiling openJdk 11 on windows 7 32bits fail

[Alexey Ivanov]

Hi David,

On 11/02/2019 11:33, David Holmes wrote:

Hi Alexey,

On 11/02/2019 7:12 pm, Alexey Ivanov wrote:

Hi Franco,

On 11/02/2019 02:03, David Holmes wrote:

On 8/02/2019 5:07 am, Franco Gastón Pellegrini wrote:

I tried compiling JDK 12 for 32 bits, and I get similar errors:

=== Output from failing command(s) repeated here ===
* For target hotspot_variant-client_libjvm_objs_classFileParser.obj:
classFileParser.cpp
c:/cygwin64/home/franc/java/jdk12/src/hotspot/share/classfile/classFileParser.cpp(312): 
error C2220: warning treated as error - no 'object' file generated
c:/cygwin64/home/franc/java/jdk12/src/hotspot/share/classfile/classFileParser.cpp(312): 
warning C4267: '=': conversion from 'size_t' to 'u2', possible loss 
of data

    ... (rest of output omitted)


I used --disable-warnings-as-errors option to configure when I built 
JDK for 32 bit Windows last time.


Note there are actual errors in Franco's log not just the warnings I 
commented on. I think we've already encountered the operate delete 
issue so it may be fixed in 13, but not 12. Need to track it down.


I must have missed that point.
The message above says “error C2220: warning treated as error”, so I 
decided to let Franco know --disable-warnings-as-errors helped me.


It's been a long while since I built jdk-dev on 32 bit Windows last 
time; many things could have changed there.


Regards,
Alexey



Cheers,
David

David pointed to JDK-8205677 which should be forwardported to 13 to 
fix the problem.


Regards,
Alexey



This is an issue we ran into compiling 8u with VS2017:

https://bugs.openjdk.java.net/browse/JDK-8205677

We probably never noticed in JDK 12 because we don't do 32-bits 
builds with VS2017.


David
-

* All command lines available in 
/cygdrive/c/cygwin64/home/franc/java/jdk12/build/windows-x86-client-fastdebug/make-support/failure-logs. 


=== End of repeated output ===

No indication of failed target found.
Hint: Try searching the build log for '] Error'.
Hint: See doc/building.html#troubleshooting for assistance.

make[1]: *** [/home/franc/java/jdk12/make/Init.gmk:310: main] Error 2
make: *** [/home/franc/java/jdk12/make/Init.gmk:186: default] Error 2


El mié., 6 de feb. de 2019 a la(s) 19:23, Franco Gastón Pellegrini 
(francogpellegr...@gmail.com ) 
escribió:


    I just tried --disable-warnings-as-errors, and JDK 11 64bits as a
    bootjdk, but I get a lots of errors, and it refuse to build, 
like this:


c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/classfile/classFileParser.cpp(310): 

    warning C4267: '=': conversion from 'size_t' to 'u2', possible 
loss

    of data
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(229): 


    error C2956: sized deallocation function 'operator delete(void*,
    size_t)' would be chosen as placement deallocation function.
    predefined C++ types (compiler internal)(44): note: see 
declaration

    of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(250): 


    error C2956: sized deallocation function 'operator delete(void*,
    size_t)' would be chosen as placement deallocation function.
    predefined C++ types (compiler internal)(44): note: see 
declaration

    of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(289): 


    error C2956: sized deallocation function 'operator delete(void*,
    size_t)' would be chosen as placement deallocation function.
    predefined C++ types (compiler internal)(44): note: see 
declaration

    of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(312): 


    error C2956: sized deallocation function 'operator delete(void*,
    size_t)' would be chosen as placement deallocation function.
    predefined C++ types (compiler internal)(44): note: see 
declaration

    of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(333): 


    error C2956: sized deallocation function 'operator delete(void*,
    size_t)' would be chosen as placement deallocation function.
    predefined C++ types (compiler internal)(44): note: see 
declaration

    of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(372): 


    error C2956: sized deallocation function 'operator delete(void*,
    size_t)' would be chosen as placement deallocation function.
    predefined C++ types (compiler internal)(44): note: see 
declaration

    of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(437): 


    error C2956: sized deallocation function 'operator delete(void*,
    size_t)' would be chosen as placement deallocation function.
    predefined C++ types (compiler internal)(44): note: see 
declaration

    of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(541): 


    error C2956: sized deallocation function 'operator delete(void*,

RFR: JDK-8218413 make reconfigure ignores configure-time AUTOCONF environment variable

[Magnus Ihse Bursie]

From the bug report:

"Suppose PATH points to an out-of date autoconf.
We can use the AUTOCONF environment variable with configure to override 
finding autoconf on PATH, but that variable is not remembered, so

make reconfigure fails.

# Recipe:
rm -rf build
AUTOCONF=/usr/bin/autoconf PATH="$MOLDY/bin:$PATH" bash configure ...
# configure + make succeed

make reconfigure
# Fails with:
Using autoconf at $MOLDY/bin/autoconf [autoconf (GNU Autoconf) 2.62]
stdin:33: error: Autoconf version 2.69 or higher is required"

Bug: https://bugs.openjdk.java.net/browse/JDK-8218413
WebRev: 
http://cr.openjdk.java.net/~ihse/JDK-8218413-preserve-AUTOCONF-for-reconfigure/webrev.01


/Magnus

Re: compiling openJdk 11 on windows 7 32bits fail

[David Holmes]

Hi Alexey,

On 11/02/2019 7:12 pm, Alexey Ivanov wrote:

Hi Franco,

On 11/02/2019 02:03, David Holmes wrote:

On 8/02/2019 5:07 am, Franco Gastón Pellegrini wrote:

I tried compiling JDK 12 for 32 bits, and I get similar errors:

=== Output from failing command(s) repeated here ===
* For target hotspot_variant-client_libjvm_objs_classFileParser.obj:
classFileParser.cpp
c:/cygwin64/home/franc/java/jdk12/src/hotspot/share/classfile/classFileParser.cpp(312): 
error C2220: warning treated as error - no 'object' file generated
c:/cygwin64/home/franc/java/jdk12/src/hotspot/share/classfile/classFileParser.cpp(312): 
warning C4267: '=': conversion from 'size_t' to 'u2', possible loss 
of data

    ... (rest of output omitted)


I used --disable-warnings-as-errors option to configure when I built JDK 
for 32 bit Windows last time.


Note there are actual errors in Franco's log not just the warnings I 
commented on. I think we've already encountered the operate delete issue 
so it may be fixed in 13, but not 12. Need to track it down.


Cheers,
David

David pointed to JDK-8205677 which should be forwardported to 13 to fix 
the problem.


Regards,
Alexey



This is an issue we ran into compiling 8u with VS2017:

https://bugs.openjdk.java.net/browse/JDK-8205677

We probably never noticed in JDK 12 because we don't do 32-bits builds 
with VS2017.


David
-

* All command lines available in 
/cygdrive/c/cygwin64/home/franc/java/jdk12/build/windows-x86-client-fastdebug/make-support/failure-logs. 


=== End of repeated output ===

No indication of failed target found.
Hint: Try searching the build log for '] Error'.
Hint: See doc/building.html#troubleshooting for assistance.

make[1]: *** [/home/franc/java/jdk12/make/Init.gmk:310: main] Error 2
make: *** [/home/franc/java/jdk12/make/Init.gmk:186: default] Error 2


El mié., 6 de feb. de 2019 a la(s) 19:23, Franco Gastón Pellegrini 
(francogpellegr...@gmail.com ) 
escribió:


    I just tried --disable-warnings-as-errors, and JDK 11 64bits as a
    bootjdk, but I get a lots of errors, and it refuse to build, like 
this:


c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/classfile/classFileParser.cpp(310): 


    warning C4267: '=': conversion from 'size_t' to 'u2', possible loss
    of data
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(229): 


    error C2956: sized deallocation function 'operator delete(void*,
    size_t)' would be chosen as placement deallocation function.
    predefined C++ types (compiler internal)(44): note: see declaration
    of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(250): 


    error C2956: sized deallocation function 'operator delete(void*,
    size_t)' would be chosen as placement deallocation function.
    predefined C++ types (compiler internal)(44): note: see declaration
    of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(289): 


    error C2956: sized deallocation function 'operator delete(void*,
    size_t)' would be chosen as placement deallocation function.
    predefined C++ types (compiler internal)(44): note: see declaration
    of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(312): 


    error C2956: sized deallocation function 'operator delete(void*,
    size_t)' would be chosen as placement deallocation function.
    predefined C++ types (compiler internal)(44): note: see declaration
    of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(333): 


    error C2956: sized deallocation function 'operator delete(void*,
    size_t)' would be chosen as placement deallocation function.
    predefined C++ types (compiler internal)(44): note: see declaration
    of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(372): 


    error C2956: sized deallocation function 'operator delete(void*,
    size_t)' would be chosen as placement deallocation function.
    predefined C++ types (compiler internal)(44): note: see declaration
    of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(437): 


    error C2956: sized deallocation function 'operator delete(void*,
    size_t)' would be chosen as placement deallocation function.
    predefined C++ types (compiler internal)(44): note: see declaration
    of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(541): 


    error C2956: sized deallocation function 'operator delete(void*,
    size_t)' would be chosen as placement deallocation function.
    predefined C++ types (compiler internal)(44): note: see declaration
    of 'operator delete'

Re: RFR: JDK-8218736 Build warning in lib/JvmFlags.gmk: extraneous text after 'ifeq' directive

[Aleksey Shipilev]

On 2/11/19 11:23 AM, Magnus Ihse Bursie wrote:
> Unfortunately I introduced a build error in JDK-8218431 (Improved platform 
> checking). This resulted
> in the following error message:
> lib/JvmFlags.gmk:77: extraneous text after 'ifeq' directive
> 
> This only happens for fastdebug builds, which is why I did not discover it 
> during the testing of
> JDK-8218431. The fix is trivial.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8218736
> Patch inline:
> diff --git a/make/hotspot/lib/JvmFlags.gmk b/make/hotspot/lib/JvmFlags.gmk
> --- a/make/hotspot/lib/JvmFlags.gmk
> +++ b/make/hotspot/lib/JvmFlags.gmk
> @@ -74,7 +74,7 @@
>    endif
>  else ifeq ($(DEBUG_LEVEL), fastdebug)
>    JVM_CFLAGS_DEBUGLEVEL := -DASSERT
> -  ifeq ($call isTargetOs, windows aix), false)
> +  ifeq ($(call isTargetOs, windows aix), false)
>  # NOTE: Old build did not define CHECK_UNHANDLED_OOPS on Windows and AIX.
>  JVM_CFLAGS_DEBUGLEVEL += -DCHECK_UNHANDLED_OOPS
>    endif

Looks good and trivial.

-Aleksey

Re: RFR: JDK-8218736 Build warning in lib/JvmFlags.gmk: extraneous text after 'ifeq' directive

[Claes Redestad]

Looks good, ship it!

/Claes

On 2019-02-11 11:23, Magnus Ihse Bursie wrote:
Unfortunately I introduced a build error in JDK-8218431 (Improved 
platform checking). This resulted in the following error message:

lib/JvmFlags.gmk:77: extraneous text after 'ifeq' directive

This only happens for fastdebug builds, which is why I did not discover 
it during the testing of JDK-8218431. The fix is trivial.


Bug: https://bugs.openjdk.java.net/browse/JDK-8218736
Patch inline:
diff --git a/make/hotspot/lib/JvmFlags.gmk b/make/hotspot/lib/JvmFlags.gmk
--- a/make/hotspot/lib/JvmFlags.gmk
+++ b/make/hotspot/lib/JvmFlags.gmk
@@ -74,7 +74,7 @@
    endif
  else ifeq ($(DEBUG_LEVEL), fastdebug)
    JVM_CFLAGS_DEBUGLEVEL := -DASSERT
-  ifeq ($call isTargetOs, windows aix), false)
+  ifeq ($(call isTargetOs, windows aix), false)
  # NOTE: Old build did not define CHECK_UNHANDLED_OOPS on Windows 
and AIX.

  JVM_CFLAGS_DEBUGLEVEL += -DCHECK_UNHANDLED_OOPS
    endif

/Magnus

RFR: JDK-8218736 Build warning in lib/JvmFlags.gmk: extraneous text after 'ifeq' directive

[Magnus Ihse Bursie]

Unfortunately I introduced a build error in JDK-8218431 (Improved 
platform checking). This resulted in the following error message:

lib/JvmFlags.gmk:77: extraneous text after 'ifeq' directive

This only happens for fastdebug builds, which is why I did not discover 
it during the testing of JDK-8218431. The fix is trivial.


Bug: https://bugs.openjdk.java.net/browse/JDK-8218736
Patch inline:
diff --git a/make/hotspot/lib/JvmFlags.gmk b/make/hotspot/lib/JvmFlags.gmk
--- a/make/hotspot/lib/JvmFlags.gmk
+++ b/make/hotspot/lib/JvmFlags.gmk
@@ -74,7 +74,7 @@
   endif
 else ifeq ($(DEBUG_LEVEL), fastdebug)
   JVM_CFLAGS_DEBUGLEVEL := -DASSERT
-  ifeq ($call isTargetOs, windows aix), false)
+  ifeq ($(call isTargetOs, windows aix), false)
 # NOTE: Old build did not define CHECK_UNHANDLED_OOPS on Windows 
and AIX.

 JVM_CFLAGS_DEBUGLEVEL += -DCHECK_UNHANDLED_OOPS
   endif

/Magnus

Re: compiling openJdk 11 on windows 7 32bits fail

[Alexey Ivanov]

Hi Franco,

On 11/02/2019 02:03, David Holmes wrote:

On 8/02/2019 5:07 am, Franco Gastón Pellegrini wrote:

I tried compiling JDK 12 for 32 bits, and I get similar errors:

=== Output from failing command(s) repeated here ===
* For target hotspot_variant-client_libjvm_objs_classFileParser.obj:
classFileParser.cpp
c:/cygwin64/home/franc/java/jdk12/src/hotspot/share/classfile/classFileParser.cpp(312): 
error C2220: warning treated as error - no 'object' file generated
c:/cygwin64/home/franc/java/jdk12/src/hotspot/share/classfile/classFileParser.cpp(312): 
warning C4267: '=': conversion from 'size_t' to 'u2', possible loss 
of data

    ... (rest of output omitted)


I used --disable-warnings-as-errors option to configure when I built JDK 
for 32 bit Windows last time.


David pointed to JDK-8205677 which should be forwardported to 13 to fix 
the problem.


Regards,
Alexey



This is an issue we ran into compiling 8u with VS2017:

https://bugs.openjdk.java.net/browse/JDK-8205677

We probably never noticed in JDK 12 because we don't do 32-bits builds 
with VS2017.


David
-

* All command lines available in 
/cygdrive/c/cygwin64/home/franc/java/jdk12/build/windows-x86-client-fastdebug/make-support/failure-logs.

=== End of repeated output ===

No indication of failed target found.
Hint: Try searching the build log for '] Error'.
Hint: See doc/building.html#troubleshooting for assistance.

make[1]: *** [/home/franc/java/jdk12/make/Init.gmk:310: main] Error 2
make: *** [/home/franc/java/jdk12/make/Init.gmk:186: default] Error 2


El mié., 6 de feb. de 2019 a la(s) 19:23, Franco Gastón Pellegrini 
(francogpellegr...@gmail.com ) 
escribió:


    I just tried --disable-warnings-as-errors, and JDK 11 64bits as a
    bootjdk, but I get a lots of errors, and it refuse to build, like 
this:


c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/classfile/classFileParser.cpp(310):
    warning C4267: '=': conversion from 'size_t' to 'u2', possible loss
    of data
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(229):
    error C2956: sized deallocation function 'operator delete(void*,
    size_t)' would be chosen as placement deallocation function.
    predefined C++ types (compiler internal)(44): note: see declaration
    of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(250):
    error C2956: sized deallocation function 'operator delete(void*,
    size_t)' would be chosen as placement deallocation function.
    predefined C++ types (compiler internal)(44): note: see declaration
    of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(289):
    error C2956: sized deallocation function 'operator delete(void*,
    size_t)' would be chosen as placement deallocation function.
    predefined C++ types (compiler internal)(44): note: see declaration
    of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(312):
    error C2956: sized deallocation function 'operator delete(void*,
    size_t)' would be chosen as placement deallocation function.
    predefined C++ types (compiler internal)(44): note: see declaration
    of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(333):
    error C2956: sized deallocation function 'operator delete(void*,
    size_t)' would be chosen as placement deallocation function.
    predefined C++ types (compiler internal)(44): note: see declaration
    of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(372):
    error C2956: sized deallocation function 'operator delete(void*,
    size_t)' would be chosen as placement deallocation function.
    predefined C++ types (compiler internal)(44): note: see declaration
    of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(437):
    error C2956: sized deallocation function 'operator delete(void*,
    size_t)' would be chosen as placement deallocation function.
    predefined C++ types (compiler internal)(44): note: see declaration
    of 'operator delete'
c:/cygwin64/home/franc/java/jdk11/src/hotspot/share/code/codeBlob.cpp(541):
    error C2956: sized deallocation function 'operator delete(void*,
    size_t)' would be chosen as placement deallocation function.
    predefined C++ types (compiler internal)(44): note: see declaration
    of 'operator delete'