Re: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports
Hi Martin! On 12/15/19 5:07 PM, Martin Buchholz wrote: > I tried both variants as below, but autoconf is failing me when I try to > regenerate > configure. > > > You didn't say how. > (...) > bulding.md says > > > The build system will detect if the Autoconf source files have changed, and > will trigger a regeneration of the generated script if needed. You can also > manually request such an update by `bash configure autogen`. Yep. Already figured out that my changes didn't work. I got it working now and posted JDK-8235960 for review. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Re: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports
On Sun, Dec 15, 2019 at 1:49 AM John Paul Adrian Glaubitz < glaub...@physik.fu-berlin.de> wrote: > > I tried both variants as below, but autoconf is failing me when I try to > regenerate > configure. > You didn't say how. > > Can anyone remind me what the proper way of regenerating the configure > script is > these days? > bulding.md says The build system will detect if the Autoconf source files have changed, and will trigger a regeneration of the generated script if needed. You can also manually request such an update by `bash configure autogen`.
RFR: 8235960: Zero should not trigger the deprecation warning for ports
Hi! JDK-8234370 introduced a deprecation warning for ports that are going to be removed in the future. The change in question checks for the target architecture and operating system but does however does not account for the Zero variant which doesn't need support for a specific target besides a few autonconf definitions and some #ifdef magic. This change extends the change from JDK-8234370 to additionally test whether we're building the Zero variant. With this change, I can configure OpenJDK Zero on a Linux/SPARC target again without getting a deprecation message. Please review. Thanks, Adrian > [1] http://cr.openjdk.java.net/~glaubitz/8235960/webrev.00/ -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Re: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports
Hi! On 12/15/19 10:13 AM, John Paul Adrian Glaubitz wrote: > The change for JDK-8234370 also triggers for Zero which is not correct. > > It should trigger for the normal build only. > > I will file a bug report. I have filed JDK-8235960 now, but I haven't managed to come up with a working fix yet. I tried both variants as below, but autoconf is failing me when I try to regenerate configure. Can anyone remind me what the proper way of regenerating the configure script is these days? Thanks, Adrian glaubitz@gcc202:~/jdk$ hg diff diff -r eefd0a71c160 make/autoconf/platform.m4 --- a/make/autoconf/platform.m4 Sat Dec 14 13:50:34 2019 +0800 +++ b/make/autoconf/platform.m4 Sun Dec 15 12:46:47 2019 +0300 @@ -566,7 +566,7 @@ AC_ARG_ENABLE(deprecated-ports, [AS_HELP_STRING([--enable-deprecated-ports@<:@=yes/no@:>@], [Suppress the error when configuring for a deprecated port @<:@no@:>@])]) - if test "x$OPENJDK_TARGET_OS" = xsolaris || test "x$OPENJDK_TARGET_CPU_ARCH" = xsparc; then + if test "x$OPENJDK_TARGET_OS" = xsolaris || test "x$OPENJDK_TARGET_CPU_ARCH" = xsparc && test "x$JVM_VARIANTS" != xzero; then if test "x$enable_deprecated_ports" = "xyes"; then AC_MSG_WARN([The Solaris and SPARC ports are deprecated and may be removed in a future release.]) else glaubitz@gcc202:~/jdk$ glaubitz@gcc202:~/jdk$ hg diff diff -r eefd0a71c160 make/autoconf/platform.m4 --- a/make/autoconf/platform.m4 Sat Dec 14 13:50:34 2019 +0800 +++ b/make/autoconf/platform.m4 Sun Dec 15 12:47:35 2019 +0300 @@ -566,7 +566,7 @@ AC_ARG_ENABLE(deprecated-ports, [AS_HELP_STRING([--enable-deprecated-ports@<:@=yes/no@:>@], [Suppress the error when configuring for a deprecated port @<:@no@:>@])]) - if test "x$OPENJDK_TARGET_OS" = xsolaris || test "x$OPENJDK_TARGET_CPU_ARCH" = xsparc; then + if test "x$OPENJDK_TARGET_OS" = xsolaris || test "x$OPENJDK_TARGET_CPU_ARCH" = xsparc && ! HOTSPOT_CHECK_JVM_VARIANT(zero); then if test "x$enable_deprecated_ports" = "xyes"; then AC_MSG_WARN([The Solaris and SPARC ports are deprecated and may be removed in a future release.]) else glaubitz@gcc202:~/jdk$ -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Re: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports
Hi! The change for JDK-8234370 also triggers for Zero which is not correct. It should trigger for the normal build only. I will file a bug report. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
