Re: RFR: 8199138: Add RISC-V support to Zero
Looks still good.
..Thomas
On Tue 7. Apr 2020 at 01:20, John Paul Adrian Glaubitz <
glaub...@physik.fu-berlin.de> wrote:
> Hello!
>
> On 4/6/20 8:09 PM, John Paul Adrian Glaubitz wrote:
> > I have reduced the complexity of the patch as some of the changes from
> > the previous change set are not necessary, in particular the changes
> > to config.{guess,sub}, the definition of EM_RISCV (which is already
> defined
> > by the Linux kernel headers now provided the kernel is recent enough).
>
> After checking various kernel headers of older but still supported
> enterprise
> Linux distributions such as SLE-12 and RHEL-7, I think it's probably better
> to include the redundant EM_RISCV definition to avoid build problems on
> these
> platforms [1]. I just want to be on the safe side.
>
> The build changes are unchanged.
>
> Adrian
>
> > [1] http://cr.openjdk.java.net/~glaubitz/8199138/webrev.03/
>
> --
> .''`. John Paul Adrian Glaubitz
> : :' : Debian Developer - glaub...@debian.org
> `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
> `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
>
Re: RFR: 8199138: Add RISC-V support to Zero
Hello!
On 4/6/20 8:09 PM, John Paul Adrian Glaubitz wrote:
> I have reduced the complexity of the patch as some of the changes from
> the previous change set are not necessary, in particular the changes
> to config.{guess,sub}, the definition of EM_RISCV (which is already defined
> by the Linux kernel headers now provided the kernel is recent enough).
After checking various kernel headers of older but still supported enterprise
Linux distributions such as SLE-12 and RHEL-7, I think it's probably better
to include the redundant EM_RISCV definition to avoid build problems on these
platforms [1]. I just want to be on the safe side.
The build changes are unchanged.
Adrian
> [1] http://cr.openjdk.java.net/~glaubitz/8199138/webrev.03/
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaub...@debian.org
`. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
`-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Re: RFR: 8199138: Add RISC-V support to Zero
Hi Adrian, looks good to me.
Cheers, Thomas
On Mon, Apr 6, 2020, 20:11 John Paul Adrian Glaubitz <
glaub...@physik.fu-berlin.de> wrote:
> Hello!
>
> Please review this small change which adds basic support for the riscv64
> target for Linux/Zero [1].
>
> I have reduced the complexity of the patch as some of the changes from
> the previous change set are not necessary, in particular the changes
> to config.{guess,sub}, the definition of EM_RISCV (which is already defined
> by the Linux kernel headers now provided the kernel is recent enough).
>
> Additionally, I'm leaving the change for os::get_summary_cpu_info() out
> as I would like to clean up this code a bit first - it's rather
> inconsistent
> considering whether the arch override is used for Hotspot arches only or
> also for Zero arches.
>
> Thanks,
> Adrian
>
> > [1] http://cr.openjdk.java.net/~glaubitz/8199138/webrev.02/
>
> --
> .''`. John Paul Adrian Glaubitz
> : :' : Debian Developer - glaub...@debian.org
> `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
> `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
>
Re: RFR: 8199138: Add RISC-V support to Zero
Build change looks good.
/Erik
On 2020-04-06 11:09, John Paul Adrian Glaubitz wrote:
Hello!
Please review this small change which adds basic support for the riscv64
target for Linux/Zero [1].
I have reduced the complexity of the patch as some of the changes from
the previous change set are not necessary, in particular the changes
to config.{guess,sub}, the definition of EM_RISCV (which is already defined
by the Linux kernel headers now provided the kernel is recent enough).
Additionally, I'm leaving the change for os::get_summary_cpu_info() out
as I would like to clean up this code a bit first - it's rather inconsistent
considering whether the arch override is used for Hotspot arches only or
also for Zero arches.
Thanks,
Adrian
[1] http://cr.openjdk.java.net/~glaubitz/8199138/webrev.02/
RFR: 8199138: Add RISC-V support to Zero
Hello!
Please review this small change which adds basic support for the riscv64
target for Linux/Zero [1].
I have reduced the complexity of the patch as some of the changes from
the previous change set are not necessary, in particular the changes
to config.{guess,sub}, the definition of EM_RISCV (which is already defined
by the Linux kernel headers now provided the kernel is recent enough).
Additionally, I'm leaving the change for os::get_summary_cpu_info() out
as I would like to clean up this code a bit first - it's rather inconsistent
considering whether the arch override is used for Hotspot arches only or
also for Zero arches.
Thanks,
Adrian
> [1] http://cr.openjdk.java.net/~glaubitz/8199138/webrev.02/
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaub...@debian.org
`. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
`-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Re: RFR 15 8225319: Remove the RMI static stub compiler rmic
On 03/04/2020 16:43, Roger Riggs wrote: Please review the CSR[1] and changes to remove the RMI static stub compiler (rmic). RMIC was deprecated for removal in JDK 13 [3]. The components modified are: - remove the jdk.rmic module - remove the jdk.rmic man page - remove all tests of rmic or relying on rmic - update or remove makefiles to remove references and dependencies on rmic - update source files in java.rmi module to remove extraneous references to rmic Wevrev: http://cr.openjdk.java.net/~rriggs/webrev-remove-rmic-8225319 The javadoc updates and the other changes in the webrev look good. The second webrev with other removals that Amy brought up look good too. I updated the CSR to provide a bit more history and focus it more on the interfaces that are removed rather than the source code view. -Alan
Re: RFR 15 8225319: Remove the RMI static stub compiler rmic
Hi, Roger
I noticed some other minor cleanup needed, will they be included in this
fix, or separately in the future?
1. test/jdk/TEST.groups
To remove `sun/tools/java` from core_tools and svc_tools group. (The
only one test under `sun/tools/java` got removed in this patch.)
2. doc/building.md and doc/building.html, both mention rmic tool.
3. langtools tests
module:jdk.rmic
./test/langtools/jdk/javadoc/doclet/testModules/jdk/element-list
new String[] {"jdk.compiler", "jdk.rmic"},
new String[] {"jdk.compiler", "jdk.javadoc",
"jdk.rmic"},
new String[] {"java.compiler", "jdk.compiler",
"jdk.rmic"},
new String[] {"java.compiler", "jdk.compiler",
"jdk.javadoc", "jdk.rmic"},
./test/langtools/tools/jdeps/modules/InverseDeps.java
4. hotspot tests
* @summary run CTW for all classes from jdk.rmic module
* @modules jdk.rmic
* @run driver/timeout=7200 sun.hotspot.tools.ctw.CtwRunner
modules:jdk.rmic
./test/hotspot/jtreg/applications/ctw/modules/jdk_rmic.java
"sun/rmi/rmic/Main",
./test/hotspot/jtreg/runtime/cds/appcds/ProtectionDomain.java
// sun.rmi.rmic.Main (testcase 4),
{"Loading non-shared app module class first", "sun.rmi.rmic",
"sun.rmi.rmic.RMIGenerator", "sun.rmi.rmic.Main"},
./test/hotspot/jtreg/runtime/cds/appcds/test-classes/JimageClassPackage.java
"sun/rmi/rmic/Main",
./test/hotspot/jtreg/runtime/cds/appcds/SharedPackages.java
Thanks,
Amy
On 4/3/20 11:43 PM, Roger Riggs wrote:
Please review the CSR[1] and changes to remove the RMI static stub
compiler (rmic).
RMIC was deprecated for removal in JDK 13 [3].
The components modified are:
- remove the jdk.rmic module
- remove the jdk.rmic man page
- remove all tests of rmic or relying on rmic
- update or remove makefiles to remove references and dependencies on
rmic
- update source files in java.rmi module to remove extraneous
references to rmic
Wevrev:
http://cr.openjdk.java.net/~rriggs/webrev-remove-rmic-8225319
Thanks, Roger
[1] CSR:
https://bugs.openjdk.java.net/browse/JDK-8242049
[2] Issue:
https://bugs.openjdk.java.net/browse/JDK-8225319
[3] Deprecate rmic for removal
https://bugs.openjdk.java.net/browse/JDK-8217412
