Re: RFR: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow [v2]
> This adds the cross-compiled build only, as no Windows+Arm64 machines are > available on GitHub Action that we could use to run the tests. > > Due to cross-compilation a build JDK is required. Initially I added EA builds > to be downloaded from https://jdk.java.net/16/ and used for that, but then I > saw how @shipiliv attempted it for the linux cross-compilation builds in > https://github.com/openjdk/jdk/pull/1147. That is using the JDK image > produced by the x64 variant. This however add more stress to the "critical > path", as now two more jobs depend on the x64 build first. > > Let's see how it works out in the long-run. A Windows+AArch64 build takes > 40-50min. Bernhard Urban-Forster has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: - todo note for caching devkit - remove release build - move windows_aarch64_build next to other builds - Merge remote-tracking branch 'upstream/master' into 8256657-win-arm64-gh-submit-workflow - remove fixpath.exe workaround - 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow This adds the cross-compiled build only, as no Windows+Arm64 machines are available on GitHub Action that we could use to run the tests. Due to cross-compilation a build JDK is required. Initially I added EA builds to be downloaded from https://jdk.java.net/16/ and used for that, but then I saw how @shipiliv attempted it for the linux cross-compilation builds in https://github.com/openjdk/jdk/pull/1147. That is using the JDK image produced by the x64 variant. This however add more stress to the "critical path", as now two more jobs depend on the x64 build first. Let's see how it works out in the long-run. A Windows+AArch64 build takes 40-50min. - Changes: https://git.openjdk.java.net/jdk/pull/1379/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1379=01 Stats: 155 lines in 1 file changed: 153 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/1379.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1379/head:pull/1379 PR: https://git.openjdk.java.net/jdk/pull/1379
Integrated: 8253753 Enable default constructor warning in client modules
On Tue, 24 Nov 2020 19:10:04 GMT, Joe Darcy wrote: > With the default constructors warnings in java.desktop and jdk.accessibility > now fixed, the warning should be enabled in the build for those modules. This pull request has now been integrated. Changeset: 65137ff0 Author:Joe Darcy URL: https://git.openjdk.java.net/jdk/commit/65137ff0 Stats: 5 lines in 1 file changed: 0 ins; 5 del; 0 mod 8253753: Enable default constructor warning in client modules Reviewed-by: prr, serb, ihse - PR: https://git.openjdk.java.net/jdk/pull/1420
Integrated: 8257208: Fix typo in doc/building.md
On Sat, 21 Nov 2020 14:28:23 GMT, Hollow Man wrote: > overriden -> overridden This pull request has now been integrated. Changeset: f6bfbb2b Author:Hollow Man Committer: Magnus Ihse Bursie URL: https://git.openjdk.java.net/jdk/commit/f6bfbb2b Stats: 6 lines in 2 files changed: 0 ins; 0 del; 6 mod 8257208: Fix typo in doc/building.md Reviewed-by: ihse - PR: https://git.openjdk.java.net/jdk/pull/1365
Re: RFR: 8257208: Fix typo in doc/building.md
On Fri, 27 Nov 2020 14:22:01 GMT, Magnus Ihse Bursie wrote: >> overriden -> overridden > > Marked as reviewed by ihse (Reviewer). @magicus Thanks for reviewing! Now could you please sponsor this change? Thanks! - PR: https://git.openjdk.java.net/jdk/pull/1365
RFR: JDK-8256950: Add record attribute support to symbol generator CreateSymbols
Adding support for record classes in the historical data for ct.sym. This includes a few changes not strictly needed for the change: -updating and moving tests into test/langtools, so that it is easier to run them. -fixing Record attribute reading in javac's ClassReader (used for tests, but seems like the proper thing to do anyway). -fixing the -Xprint annotation processor to print record component annotations. Changes to jdk.jdeps' classfile library are needed so that the ct.sym creation works. - Commit messages: - Update CreateSymbolsTest.java - Cleaning TODO. - Cleaning TODO. - Adding test verifying javac can read Record attribute properly. - Cleanup. - JDK-8256950: Add record attribute support to symbol generator CreateSymbols Changes: https://git.openjdk.java.net/jdk/pull/1480/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1480=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8256950 Stats: 1910 lines in 12 files changed: 1147 ins; 745 del; 18 mod Patch: https://git.openjdk.java.net/jdk/pull/1480.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1480/head:pull/1480 PR: https://git.openjdk.java.net/jdk/pull/1480
Re: RFR: 8257208: Fix typo in doc/building.md
On Sat, 21 Nov 2020 14:28:23 GMT, Hollow Man wrote: > overriden -> overridden Marked as reviewed by ihse (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/1365
RFR: 8257208: Fix typo in doc/building.md
overriden -> overridden - Commit messages: - 8257208: Fix typo in doc/building.md Changes: https://git.openjdk.java.net/jdk/pull/1365/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1365=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8257208 Stats: 6 lines in 2 files changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/jdk/pull/1365.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1365/head:pull/1365 PR: https://git.openjdk.java.net/jdk/pull/1365
Re: RFR: 8257208: Fix typo in doc/building.md
On Sat, 21 Nov 2020 14:28:23 GMT, Hollow Man wrote: > overriden -> overridden > Hi @HollowMan6! > > Thank you for submitting this PR. As the contribution docs state, you need a > sponsor for this PR. I'll be your sponsor. > > I have opened a bug issue for this fix: > https://bugs.openjdk.java.net/browse/JDK-8257208 > > Please update the PR title to `8257208: Fix typo in doc/building.md`. @magicus Done! Thanks. - PR: https://git.openjdk.java.net/jdk/pull/1365
Re: RFR: 8257208: Fix typo in doc/building.md
On Sat, 21 Nov 2020 14:28:23 GMT, Hollow Man wrote: > overriden -> overridden Hi @HollowMan6! Thank you for submitting this PR. As the contribution docs state, you need a sponsor for this PR. I'll be your sponsor. I have opened a bug issue for this fix: https://bugs.openjdk.java.net/browse/JDK-8257208 Please update the PR title to `8257208: Fix typo in doc/building.md`. - PR: https://git.openjdk.java.net/jdk/pull/1365
