Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge [v2]
On Mon, 8 Mar 2021 19:30:17 GMT, Sergey Bylokhov wrote: >> It seems to be fine not to use UNIX epoch at first glance as long as we can >> know the timing of events, but I'm not sure (Thus I rewrote to comply with >> the original code). So I want to hear from the others. > > Did you check via some a11y tool that the new code actually works? No, can you help? - PR: https://git.openjdk.java.net/jdk/pull/2859
Re: RFR: 8257913: Add more known library locations to simplify Linux cross-compilation [v3]
On Mon, 8 Mar 2021 16:14:21 GMT, Aleksey Shipilev wrote: >> make/autoconf/platform.m4 line 364: >> >>> 362: AC_SUBST(OPENJDK_TARGET_CPU_AUTOCONF) >>> 363: AC_SUBST(OPENJDK_TARGET_LIBC) >>> 364: AC_SUBST(OPENJDK_TARGET_ABI) >> >> I realize this has already been integrated, but I don't fully understand >> this. There is no corresponding change in spec.gmk.in adding >> OPENJDK_TARGET/BUILD_CPU_AUTOCONF and OPENJDK_TARGET/BUILD_ABI. >> >> So why the AC_SUBST()? > > I thought we need to declare these as `AC_SUBST` as we define the variables > outside this file? I can revert these additions if you think these are > incorrect. No, they are only needed to be able to populate the @FOO@ tags in spec.gmk.in. All the *.m4 files are concatenated into a single shell script by autoconf, so referring to variables in a different m4 file does not really matter. I don't think it's worth a separate bug to remove them, but if you touch the area again you can get rid of them while you're at it :) - PR: https://git.openjdk.java.net/jdk/pull/2833
Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge [v2]
On Mon, 8 Mar 2021 07:46:54 GMT, Yasumasa Suenaga wrote: >> src/jdk.accessibility/windows/native/common/AccessBridgeDebug.cpp line 80: >> >>> 78: uli.LowPart = ft.dwLowDateTime; >>> 79: uli.HighPart = ft.dwHighDateTime; >>> 80: return (uli.QuadPart / 1ULL) - 1164447360ULL; // Rebase >>> Epoch from 1601 to 1970 >> >> This is good and true to the original change; >> >> I am not even sure the epoch rebase is needed. All 8196681 did was to print >> out the timestamps verbatim. I do not know enough about how that debug trace >> is used, and if the timestamps really have to be 1970 based. > > It seems to be fine not to use UNIX epoch at first glance as long as we can > know the timing of events, but I'm not sure (Thus I rewrote to comply with > the original code). So I want to hear from the others. Did you check via some a11y tool that the new code actually works? - PR: https://git.openjdk.java.net/jdk/pull/2859
Integrated: JDK-8251210: Link JDK api docs to other versions
On Sat, 6 Mar 2021 02:21:00 GMT, Jonathan Gibbons wrote: > Please review a small change to Docs.gmk, such that the short version string > in the upper right corner of the main API docs bundle is linked to a page > that links to other versions of the documentation. While it is not so useful > in this release, to be able to access _older_ versions, going forward, this > will simplify the ability to get to _newer_ versions when search engines take > you to the docs for an older release. This pull request has now been integrated. Changeset: b1cc864a Author:Jonathan Gibbons URL: https://git.openjdk.java.net/jdk/commit/b1cc864a Stats: 10 lines in 2 files changed: 9 ins; 0 del; 1 mod 8251210: Link JDK api docs to other versions Reviewed-by: iris, erikj - PR: https://git.openjdk.java.net/jdk/pull/2854
Re: RFR: 8257913: Add more known library locations to simplify Linux cross-compilation [v3]
On Mon, 8 Mar 2021 16:11:20 GMT, Magnus Ihse Bursie wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Replace with linux with TARGET_OS > > make/autoconf/platform.m4 line 364: > >> 362: AC_SUBST(OPENJDK_TARGET_CPU_AUTOCONF) >> 363: AC_SUBST(OPENJDK_TARGET_LIBC) >> 364: AC_SUBST(OPENJDK_TARGET_ABI) > > I realize this has already been integrated, but I don't fully understand > this. There is no corresponding change in spec.gmk.in adding > OPENJDK_TARGET/BUILD_CPU_AUTOCONF and OPENJDK_TARGET/BUILD_ABI. > > So why the AC_SUBST()? I thought we need to declare these as `AC_SUBST` as we define the variables outside this file? I can revert these additions if you think these are incorrect. - PR: https://git.openjdk.java.net/jdk/pull/2833
Re: RFR: 8257913: Add more known library locations to simplify Linux cross-compilation [v3]
On Fri, 5 Mar 2021 16:03:18 GMT, Aleksey Shipilev wrote: >> Current cross-compilation configurations require adding the whole lot of >> configure options to make it find the dependencies: freetype and X11 libs >> are the only problematic dependencies. We should be able to specify just the >> `--with-sysroot`, and get everything else autodetected. >> >> After this patch, doing `sh ./configure >> --openjdk-target=powerpc64le-linux-gnu --with-sysroot=/chroots/ppc64el`, >> where chroot is `debootstrap`-ed chroot as per our build docs, is enough to >> get everything configured. See the GH Actions definition to see what options >> are not needed anymore. >> >> Some explanations: >> - `*-gnuabi64` is needed for `mips64el` >> - `*-gnueabihf` is needed for `armhf` >> - `$OPENJDK_TARGET_CPU_AUTOCONF-linux-gnu` is needed for `powerpc*`, >> because OpenJDK build rewrites `VAR_CPU` to `ppc`, leading to mismatch. >> >> Additional testing: >> - [x] Configure with target `x86_64-linux-gnu` >> - [x] Configure with cross-target `i686-linux-gnu` >> - [x] Configure with cross-target `alpha-linux-gnu` >> - [x] Configure with cross-target `aarch64-linux-gnu` >> - [x] Configure with cross-target `arm-linux-gnueabihf` >> - [x] Configure with cross-target `arm-linux-gnueabi` >> - [x] Configure with cross-target `mipsel-linux-gnu` >> - [x] Configure with cross-target `mips64el-linux-gnuabi64` >> - [x] Configure with cross-target `powerpc-linux-gnu` >> - [x] Configure with cross-target `powerpc64-linux-gnu` >> - [x] Configure with cross-target `powerpc64le-linux-gnu` >> - [x] Configure with cross-target `m68k-linux-gnu` >> - [x] Configure with cross-target `sh4-linux-gnu` > > Aleksey Shipilev has updated the pull request incrementally with one > additional commit since the last revision: > > Replace with linux with TARGET_OS make/autoconf/platform.m4 line 364: > 362: AC_SUBST(OPENJDK_TARGET_CPU_AUTOCONF) > 363: AC_SUBST(OPENJDK_TARGET_LIBC) > 364: AC_SUBST(OPENJDK_TARGET_ABI) I realize this has already been integrated, but I don't fully understand this. There is no corresponding change in spec.gmk.in adding OPENJDK_TARGET/BUILD_CPU_AUTOCONF and OPENJDK_TARGET/BUILD_ABI. So why the AC_SUBST()? - PR: https://git.openjdk.java.net/jdk/pull/2833
Integrated: 8263097: Update JMH devkit to 1.28
On Fri, 5 Mar 2021 16:04:49 GMT, Claes Redestad wrote: > Currently at 1.26, so there are a few good improvements and a few bug fixes - > notably resolving a build reproducibility issue. This pull request has now been integrated. Changeset: 679faa69 Author:Claes Redestad URL: https://git.openjdk.java.net/jdk/commit/679faa69 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 8263097: Update JMH devkit to 1.28 Reviewed-by: ecaspole, erikj - PR: https://git.openjdk.java.net/jdk/pull/2848
Re: RFR: 8263097: Update JMH devkit to 1.28 [v2]
On Mon, 8 Mar 2021 14:18:27 GMT, Erik Joelsson wrote: >> Claes Redestad has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Keep jib-profiles in sync > > Marked as reviewed by erikj (Reviewer). Thank you for reviewing, Eric and Erik! - PR: https://git.openjdk.java.net/jdk/pull/2848
Re: RFR: 8263097: Update JMH devkit to 1.28 [v2]
On Fri, 5 Mar 2021 19:25:26 GMT, Claes Redestad wrote: >> Currently at 1.26, so there are a few good improvements and a few bug fixes >> - notably resolving a build reproducibility issue. > > Claes Redestad has updated the pull request incrementally with one additional > commit since the last revision: > > Keep jib-profiles in sync Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2848
Re: RFR: JDK-8251210: Link JDK api docs to other versions
On Sat, 6 Mar 2021 02:21:00 GMT, Jonathan Gibbons wrote: > Please review a small change to Docs.gmk, such that the short version string > in the upper right corner of the main API docs bundle is linked to a page > that links to other versions of the documentation. While it is not so useful > in this release, to be able to access _older_ versions, going forward, this > will simplify the ability to get to _newer_ versions when search engines take > you to the docs for an older release. Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2854
Re: RFR: 8263097: Update JMH devkit to 1.28 [v2]
On Fri, 5 Mar 2021 17:25:02 GMT, Erik Joelsson wrote: >> Good! >> Eric > > Should also updated jib-profiles.js Oracle builds get the new version. Uploaded and verified jib picks up the new version. - PR: https://git.openjdk.java.net/jdk/pull/2848
Integrated: 8257913: Add more known library locations to simplify Linux cross-compilation
On Thu, 4 Mar 2021 18:58:03 GMT, Aleksey Shipilev wrote: > Current cross-compilation configurations require adding the whole lot of > configure options to make it find the dependencies: freetype and X11 libs are > the only problematic dependencies. We should be able to specify just the > `--with-sysroot`, and get everything else autodetected. > > After this patch, doing `sh ./configure > --openjdk-target=powerpc64le-linux-gnu --with-sysroot=/chroots/ppc64el`, > where chroot is `debootstrap`-ed chroot as per our build docs, is enough to > get everything configured. See the GH Actions definition to see what options > are not needed anymore. > > Some explanations: > - `*-gnuabi64` is needed for `mips64el` > - `*-gnueabihf` is needed for `armhf` > - `$OPENJDK_TARGET_CPU_AUTOCONF-linux-gnu` is needed for `powerpc*`, > because OpenJDK build rewrites `VAR_CPU` to `ppc`, leading to mismatch. > > Additional testing: > - [x] Configure with target `x86_64-linux-gnu` > - [x] Configure with cross-target `i686-linux-gnu` > - [x] Configure with cross-target `alpha-linux-gnu` > - [x] Configure with cross-target `aarch64-linux-gnu` > - [x] Configure with cross-target `arm-linux-gnueabihf` > - [x] Configure with cross-target `arm-linux-gnueabi` > - [x] Configure with cross-target `mipsel-linux-gnu` > - [x] Configure with cross-target `mips64el-linux-gnuabi64` > - [x] Configure with cross-target `powerpc-linux-gnu` > - [x] Configure with cross-target `powerpc64-linux-gnu` > - [x] Configure with cross-target `powerpc64le-linux-gnu` > - [x] Configure with cross-target `m68k-linux-gnu` > - [x] Configure with cross-target `sh4-linux-gnu` This pull request has now been integrated. Changeset: 61cff4da Author:Aleksey Shipilev URL: https://git.openjdk.java.net/jdk/commit/61cff4da Stats: 55 lines in 4 files changed: 51 ins; 4 del; 0 mod 8257913: Add more known library locations to simplify Linux cross-compilation Reviewed-by: erikj - PR: https://git.openjdk.java.net/jdk/pull/2833
Re: RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v11]
> **Description :** > This is the implementation of [JEP 382 : New macOS Rendering > Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361) > It implements a Java 2D internal rendering pipeline for macOS using the Apple > Metal API. > The entire work on this was done under [OpenJDK Project - > Lanai](http://openjdk.java.net/projects/lanai/) > > We iterated through several Early Access (EA) builds and have reached a stage > where it is ready to be integrated to openjdk/jdk. The latest EA build is > available at - https://jdk.java.net/lanai/ > > A new option -Dsun.java2d.metal=true | True needs to be used to use this > pipeline. > > **Testing :** > This implementation has been tested with the tests present at - [Test Plan > for JEP 382: New macOS Rendering > Pipeline](https://bugs.openjdk.java.net/browse/JDK-8251396) > > **Note to reviewers :** > 1) Default rendering pipeline on macOS has not been changed by this PR. > OpenGL still stays as the default rendering pipeline and Metal rendering > pipeline is optional to choose. > > 2) To apply and test this PR - > To enable the metal pipeline you must specify on command line > -Dsun.java2d.metal=true (No message will be printed in this case) or > -Dsun.java2d.metal=True (A message indicating Metal rendering pipeline is > enabled gets printed) > > 3) Review comments (including some preliminary informal review comments) are > tracked with JBS issues - https://bugs.openjdk.java.net/issues/?filter=40598 Ajit Ghaisas has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 41 additional commits since the last revision: - Lanai PR#210 - 8263159 - jdv - Lanai PR#209 - 8262936 - jdv - Lanai PR#208 - 8262928 - jdv - Lanai PR#207 - 8262750 - jdv - Merge branch 'master' into 8260931_lanai_JEP_branch - Lanai PR#206 - 8262729 - aghaisas - Lanai PR#205 - 8262496 - avu - Lanai PR#203 - 8262313 - jdv - Lanai PR#202 - 8262293 - avu - Lanai PR#201 - 8261891 - avu - ... and 31 more: https://git.openjdk.java.net/jdk/compare/582d72a8...de456939 - Changes: - all: https://git.openjdk.java.net/jdk/pull/2403/files - new: https://git.openjdk.java.net/jdk/pull/2403/files/5cb1fd91..de456939 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=2403=10 - incr: https://webrevs.openjdk.java.net/?repo=jdk=2403=09-10 Stats: 8128 lines in 291 files changed: 5147 ins; 1823 del; 1158 mod Patch: https://git.openjdk.java.net/jdk/pull/2403.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2403/head:pull/2403 PR: https://git.openjdk.java.net/jdk/pull/2403
