Integrated: JDK-8265483: All-caps “JAVA” in the top navigation bar

2021-04-20 Thread Jonathan Gibbons
On Tue, 20 Apr 2021 22:36:28 GMT, Jonathan Gibbons  wrote:

> Please review a moderately simple change to `make/Docs.gmk` to move the link 
> for "Other Versions" from a "hidden" link in the top nav bar to an explicit 
> link in the "bottom" text. The link is placed to appear after the sentence 
> beginning "For more information..." and before all the legal text (i.e. 
> trademark, copyright, license, etc)
> 
> A side effect of moving the link is that the top text reverts to its intended 
> appearance of "Java ...", without all-caps.
> 
> As before, the presence of the link is optional, and depends on the specific 
> docs target. It is set up to just appear for the main JDK/JavaSE 
> documentation, and not the other docs bundles, such as docs-reference.

This pull request has now been integrated.

Changeset: 3de0dcba
Author:Jonathan Gibbons 
URL:   https://git.openjdk.java.net/jdk/commit/3de0dcba
Stats: 16 lines in 1 file changed: 6 ins; 6 del; 4 mod

8265483: All-caps “JAVA” in the top navigation bar

Reviewed-by: iris, erikj

-

PR: https://git.openjdk.java.net/jdk/pull/3594


Re: RFR: JDK-8265483: All-caps “JAVA” in the top navigation bar

2021-04-20 Thread Erik Joelsson
On Tue, 20 Apr 2021 22:36:28 GMT, Jonathan Gibbons  wrote:

> Please review a moderately simple change to `make/Docs.gmk` to move the link 
> for "Other Versions" from a "hidden" link in the top nav bar to an explicit 
> link in the "bottom" text. The link is placed to appear after the sentence 
> beginning "For more information..." and before all the legal text (i.e. 
> trademark, copyright, license, etc)
> 
> A side effect of moving the link is that the top text reverts to its intended 
> appearance of "Java ...", without all-caps.
> 
> As before, the presence of the link is optional, and depends on the specific 
> docs target. It is set up to just appear for the main JDK/JavaSE 
> documentation, and not the other docs bundles, such as docs-reference.

Marked as reviewed by erikj (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/3594


Re: RFR: JDK-8265483: All-caps “JAVA” in the top navigation bar

2021-04-20 Thread Iris Clark
On Tue, 20 Apr 2021 22:36:28 GMT, Jonathan Gibbons  wrote:

> Please review a moderately simple change to `make/Docs.gmk` to move the link 
> for "Other Versions" from a "hidden" link in the top nav bar to an explicit 
> link in the "bottom" text. The link is placed to appear after the sentence 
> beginning "For more information..." and before all the legal text (i.e. 
> trademark, copyright, license, etc)
> 
> A side effect of moving the link is that the top text reverts to its intended 
> appearance of "Java ...", without all-caps.
> 
> As before, the presence of the link is optional, and depends on the specific 
> docs target. It is set up to just appear for the main JDK/JavaSE 
> documentation, and not the other docs bundles, such as docs-reference.

Marked as reviewed by iris (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/3594


RFR: JDK-8265483: All-caps “JAVA” in the top navigation bar

2021-04-20 Thread Jonathan Gibbons
Please review a moderately simple change to `make/Docs.gmk` to move the link 
for "Other Versions" from a "hidden" link in the top nav bar to an explicit 
link in the "bottom" text. The link is placed to appear after the sentence 
beginning "For more information..." and before all the legal text (i.e. 
trademark, copyright, license, etc)

A side effect of moving the link is that the top text reverts to its intended 
appearance of "Java ...", without all-caps.

As before, the presence of the link is optional, and depends on the specific 
docs target. It is set up to just appear for the main JDK/JavaSE documentation, 
and not the other docs bundles, such as docs-reference.

-

Commit messages:
 - JDK-8265483: All-caps “JAVA” in the top navigation bar

Changes: https://git.openjdk.java.net/jdk/pull/3594/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3594&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8265483
  Stats: 16 lines in 1 file changed: 6 ins; 6 del; 4 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3594.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3594/head:pull/3594

PR: https://git.openjdk.java.net/jdk/pull/3594


Integrated: 8257459: Bump minimum boot jdk to JDK 16

2021-04-20 Thread Mikael Vidstedt
On Sat, 17 Apr 2021 07:20:21 GMT, Mikael Vidstedt  wrote:

> With JDK 16 having gone GA about a month ago it's time to bump the minimum 
> boot JDK version for mainline/JDK 17.
> 
> Testing: tier1-5.

This pull request has now been integrated.

Changeset: 72c88fc4
Author:Mikael Vidstedt 
URL:   https://git.openjdk.java.net/jdk/commit/72c88fc4
Stats: 13 lines in 3 files changed: 0 ins; 0 del; 13 mod

8257459: Bump minimum boot jdk to JDK 16

Reviewed-by: darcy, iris, erikj

-

PR: https://git.openjdk.java.net/jdk/pull/3555


Re: RFR: 8257459: Bump minimum boot jdk to JDK 16

2021-04-20 Thread Mikael Vidstedt
On Sat, 17 Apr 2021 07:20:21 GMT, Mikael Vidstedt  wrote:

> With JDK 16 having gone GA about a month ago it's time to bump the minimum 
> boot JDK version for mainline/JDK 17.
> 
> Testing: tier1-5.

Joe, Iris, Erik - thank you for the reviews!

-

PR: https://git.openjdk.java.net/jdk/pull/3555