Re: RFR: JDK-8274311: Make build.tools.jigsaw.GenGraphs more configurable
On Fri, 24 Sep 2021 23:07:33 GMT, Mandy Chung wrote: > GenGraphs tool generates the module graph. It currently supports the > configuration via javadoc-graphs.properties. However, > `make/jdk/src/classes/build/tools/jigsaw/javadoc-graphs.properties` only > documents two properties. It should be updated to cover all configurable > properties. > > There are a couple other properties not configurable such as nodesep and node > margin. This extends the configuration to allow to set additional properties. > > This also fixes `requiresMandatedColor` in javadoc-graphs.properties to light > gray to match the default configuration in the implementation, i.e. the color > of the edge to java.base. It seems a bug that was unnoticed until Alex and > Iris spotted it. Marked as reviewed by alanb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5690
RFR: JDK-8274311: Make build.tools.jigsaw.GenGraphs more configurable
GenGraphs tool generates the module graph. It currently supports the configuration via javadoc-graphs.properties. However, `make/jdk/src/classes/build/tools/jigsaw/javadoc-graphs.properties` only documents two properties. It should be updated to cover all configurable properties. There are a couple other properties not configurable such as nodesep and node margin. This extends the configuration to allow to set additional properties. This also fixes `requiresMandatedColor` in javadoc-graphs.properties to light gray to match the default configuration in the implementation, i.e. the color of the edge to java.base. It seems a bug that was unnoticed until Alex and Iris spotted it. - Commit messages: - JDK-8274311: Make build.tools.jigsaw.GenGraphs more configurable Changes: https://git.openjdk.java.net/jdk/pull/5690/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5690&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274311 Stats: 167 lines in 3 files changed: 100 ins; 33 del; 34 mod Patch: https://git.openjdk.java.net/jdk/pull/5690.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5690/head:pull/5690 PR: https://git.openjdk.java.net/jdk/pull/5690
Integrated: 8274273: Update testing docs for MacOS with Non-US locale
On Fri, 24 Sep 2021 09:50:19 GMT, Jie Fu wrote: > Hi all, > > I'd like to update the testing docs for MacOS with Non-US locale. > > Our experiments show that the solution mentioned for Windows with Non-US > locale also works for MacOS. > So it would be helpful to mention MacOS explicitly. > > FYI: changes in doc/testing.html was made by `make update-build-docs` . > > Thanks. > Best regards, > Jie This pull request has now been integrated. Changeset: 5756385c Author:Jie Fu URL: https://git.openjdk.java.net/jdk/commit/5756385c2bb106917f45ba71b24cf1645f702ebf Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 8274273: Update testing docs for MacOS with Non-US locale Reviewed-by: erikj - PR: https://git.openjdk.java.net/jdk/pull/5676
Re: RFR: 8274273: Update testing docs for MacOS with Non-US locale [v2]
On Fri, 24 Sep 2021 13:36:51 GMT, Jie Fu wrote: >> Hi all, >> >> I'd like to update the testing docs for MacOS with Non-US locale. >> >> Our experiments show that the solution mentioned for Windows with Non-US >> locale also works for MacOS. >> So it would be helpful to mention MacOS explicitly. >> >> FYI: changes in doc/testing.html was made by `make update-build-docs` . >> >> Thanks. >> Best regards, >> Jie > > Jie Fu has updated the pull request incrementally with one additional commit > since the last revision: > > Update testing.html by hand > Can you please take a look at this review request which actually fixes this > problem? > #5098 Sure. Will test your patch and let you know tomorrow. Thanks. - PR: https://git.openjdk.java.net/jdk/pull/5676
Re: RFR: 8274273: Update testing docs for MacOS with Non-US locale [v2]
On Fri, 24 Sep 2021 13:36:51 GMT, Jie Fu wrote: >> Hi all, >> >> I'd like to update the testing docs for MacOS with Non-US locale. >> >> Our experiments show that the solution mentioned for Windows with Non-US >> locale also works for MacOS. >> So it would be helpful to mention MacOS explicitly. >> >> FYI: changes in doc/testing.html was made by `make update-build-docs` . >> >> Thanks. >> Best regards, >> Jie > > Jie Fu has updated the pull request incrementally with one additional commit > since the last revision: > > Update testing.html by hand Can you please take a look at this review request which actually fixes this problem? https://github.com/openjdk/jdk/pull/5098 - PR: https://git.openjdk.java.net/jdk/pull/5676
Re: RFR: 8274273: Update testing docs for MacOS with Non-US locale [v2]
On Fri, 24 Sep 2021 13:36:51 GMT, Jie Fu wrote: >> Hi all, >> >> I'd like to update the testing docs for MacOS with Non-US locale. >> >> Our experiments show that the solution mentioned for Windows with Non-US >> locale also works for MacOS. >> So it would be helpful to mention MacOS explicitly. >> >> FYI: changes in doc/testing.html was made by `make update-build-docs` . >> >> Thanks. >> Best regards, >> Jie > > Jie Fu has updated the pull request incrementally with one additional commit > since the last revision: > > Update testing.html by hand Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5676
Re: RFR: 8274273: Update testing docs for MacOS with Non-US locale [v2]
> Hi all, > > I'd like to update the testing docs for MacOS with Non-US locale. > > Our experiments show that the solution mentioned for Windows with Non-US > locale also works for MacOS. > So it would be helpful to mention MacOS explicitly. > > FYI: changes in doc/testing.html was made by `make update-build-docs` . > > Thanks. > Best regards, > Jie Jie Fu has updated the pull request incrementally with one additional commit since the last revision: Update testing.html by hand - Changes: - all: https://git.openjdk.java.net/jdk/pull/5676/files - new: https://git.openjdk.java.net/jdk/pull/5676/files/88ac471a..e52ffc82 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5676&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5676&range=00-01 Stats: 27 lines in 1 file changed: 1 ins; 8 del; 18 mod Patch: https://git.openjdk.java.net/jdk/pull/5676.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5676/head:pull/5676 PR: https://git.openjdk.java.net/jdk/pull/5676
Re: RFR: 8274273: Update testing docs for MacOS with Non-US locale [v2]
On Fri, 24 Sep 2021 13:06:55 GMT, Erik Joelsson wrote: > The actual change is ok, but it seems your version of pandoc is creating a > lot of spurious changes throughout the html version. Since this change is so > small, maybe you could just manually revert everything but the actual text > addition you are making in that file? Thanks @erikj79 for your review. Updated. - PR: https://git.openjdk.java.net/jdk/pull/5676
Re: RFR: 8274273: Update testing docs for MacOS with Non-US locale
On Fri, 24 Sep 2021 09:50:19 GMT, Jie Fu wrote: > Hi all, > > I'd like to update the testing docs for MacOS with Non-US locale. > > Our experiments show that the solution mentioned for Windows with Non-US > locale also works for MacOS. > So it would be helpful to mention MacOS explicitly. > > FYI: changes in doc/testing.html was made by `make update-build-docs` . > > Thanks. > Best regards, > Jie The actual change is ok, but it seems your version of pandoc is creating a lot of spurious changes throughout the html version. Since this change is so small, maybe you could just manually revert everything but the actual text addition you are making in that file? - PR: https://git.openjdk.java.net/jdk/pull/5676
Re: RFR: JDK-8274170: Add hooks for custom makefiles to augment jtreg test execution
On Thu, 23 Sep 2021 22:02:07 GMT, Mikhailo Seledtsov wrote: > Please review this small change that adds hook for custom makefiles to > augment parameters for jtreg test execution. Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5666
Re: RFR: 8274083: Update testing docs to mention tiered testing [v6]
On Fri, 24 Sep 2021 06:12:20 GMT, Aleksey Shipilev wrote:
>> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions,
>> let's mention them in `testing.md`.
>>
>> Current patch is my braindump, I am open for suggestions :)
>
> Aleksey Shipilev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Another minor touchup
Looks good to me.
-
PR: https://git.openjdk.java.net/jdk/pull/5615
RFR: 8274273: Update testing docs for MacOS with Non-US locale
Hi all, I'd like to update the testing docs for MacOS with Non-US locale. Our experiments show that the solution mentioned for Windows with Non-US locale also works for MacOS. So it would be helpful to mention MacOS explicitly. FYI: changes in doc/testing.html was made by `make update-build-docs` . Thanks. Best regards, Jie - Commit messages: - 8274273: Update testing docs for MacOS with Non-US locale Changes: https://git.openjdk.java.net/jdk/pull/5676/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5676&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274273 Stats: 28 lines in 2 files changed: 8 ins; 1 del; 19 mod Patch: https://git.openjdk.java.net/jdk/pull/5676.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5676/head:pull/5676 PR: https://git.openjdk.java.net/jdk/pull/5676
Integrated: 8274083: Update testing docs to mention tiered testing
On Tue, 21 Sep 2021 14:52:26 GMT, Aleksey Shipilev wrote:
> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, let's
> mention them in `testing.md`.
>
> Current patch is my braindump, I am open for suggestions :)
This pull request has now been integrated.
Changeset: 971aa353
Author:Aleksey Shipilev
URL:
https://git.openjdk.java.net/jdk/commit/971aa353aae51222ca33ebfdd61b91672a6c871a
Stats: 60 lines in 2 files changed: 60 ins; 0 del; 0 mod
8274083: Update testing docs to mention tiered testing
Reviewed-by: dholmes, jiefu, stuefe, ihse, mseledtsov, alanb
-
PR: https://git.openjdk.java.net/jdk/pull/5615
