Re: RFR: 8274716: JDWP Spec: the description for the Dispose command confuses suspend with resume.
On Mon, 4 Oct 2021 13:44:44 GMT, Richard Reingruber wrote: > The following sentence in the JDWP Specification describing the Dispose > command confuses resume with suspend [1]: > > All threads suspended by the thread-level **resume** command or the VM-level > **resume** command are resumed as many times as necessary for them to run. > > It should be changed to > > All threads suspended by the thread-level **suspend** command or the > VM-level > **suspend** command are resumed as many times as necessary for them to run. > > [1] [JDWP Spec, Dispose Command > (JDK17).](https://docs.oracle.com/en/java/javase/17/docs/specs/jdwp/jdwp-protocol.html#JDWP_VirtualMachine_Dispose) Can you update the copyright please? I checked the JDI spec and it looks correct there, which is actually surprising since errors like this usually appear in both specs. - Marked as reviewed by cjplummer (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/5804
Re: RFR: 8274610: Add linux-aarch64 to bootcycle build profiles
On Thu, 30 Sep 2021 22:01:51 GMT, Mikhailo Seledtsov wrote: > Please review this simple/trivial change that add linux-aarch64 platform to > bootcycle build profiles. Thank you Erik. - PR: https://git.openjdk.java.net/jdk/pull/5783
Integrated: 8274610: Add linux-aarch64 to bootcycle build profiles
On Thu, 30 Sep 2021 22:01:51 GMT, Mikhailo Seledtsov wrote: > Please review this simple/trivial change that add linux-aarch64 platform to > bootcycle build profiles. This pull request has now been integrated. Changeset: 9914e5c4 Author:Mikhailo Seledtsov URL: https://git.openjdk.java.net/jdk/commit/9914e5c416b518f408837e31ba0a35138bfcadc7 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8274610: Add linux-aarch64 to bootcycle build profiles Reviewed-by: erikj - PR: https://git.openjdk.java.net/jdk/pull/5783
Integrated: 8274658: ISO 4217 Amendment 170 Update
On Fri, 1 Oct 2021 18:57:28 GMT, Naoto Sato wrote: > This is to incorporate the ISO 4217 amendment #170, which has been released > today, effective immediately. This pull request has now been integrated. Changeset: f2404d60 Author:Naoto Sato URL: https://git.openjdk.java.net/jdk/commit/f2404d60de2b58c590bf885f5cce50c289073673 Stats: 15 lines in 6 files changed: 3 ins; 0 del; 12 mod 8274658: ISO 4217 Amendment 170 Update Reviewed-by: lancea, iris - PR: https://git.openjdk.java.net/jdk/pull/5790
Re: RFR: 8274716: JDWP Spec: the description for the Dispose command confuses suspend with resume.
On Mon, 4 Oct 2021 14:22:50 GMT, Alan Bateman wrote: > > > It looks like this typo goes all the way back to JDK 1.2 but was not noticed. Thanks for reviewing. JDK 1.2 is surely long ago. Nevertheless not too many will have read that sentence since then I reckon ;) - PR: https://git.openjdk.java.net/jdk/pull/5804
Re: RFR: 8274716: JDWP Spec: the description for the Dispose command confuses suspend with resume.
On Mon, 4 Oct 2021 13:44:44 GMT, Richard Reingruber wrote: > The following sentence in the JDWP Specification describing the Dispose > command confuses resume with suspend [1]: > > All threads suspended by the thread-level **resume** command or the VM-level > **resume** command are resumed as many times as necessary for them to run. > > It should be changed to > > All threads suspended by the thread-level **suspend** command or the > VM-level > **suspend** command are resumed as many times as necessary for them to run. > > [1] [JDWP Spec, Dispose Command > (JDK17).](https://docs.oracle.com/en/java/javase/17/docs/specs/jdwp/jdwp-protocol.html#JDWP_VirtualMachine_Dispose) It looks like this typo goes all the way back to JDK 1.2 but was not noticed. - Marked as reviewed by alanb (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/5804
RFR: 8274716: JDWP Spec: the description for the Dispose command confuses suspend with resume.
The following sentence in the JDWP Specification describing the Dispose command confuses resume with suspend [1]: All threads suspended by the thread-level **resume** command or the VM-level **resume** command are resumed as many times as necessary for them to run. It should be changed to All threads suspended by the thread-level **suspend** command or the VM-level **suspend** command are resumed as many times as necessary for them to run. [1] [JDWP Spec, Dispose Command (JDK17).](https://docs.oracle.com/en/java/javase/17/docs/specs/jdwp/jdwp-protocol.html#JDWP_VirtualMachine_Dispose) - Commit messages: - Correct JDWP spec, Dispose command. Changes: https://git.openjdk.java.net/jdk/pull/5804/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=5804=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274716 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/5804.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5804/head:pull/5804 PR: https://git.openjdk.java.net/jdk/pull/5804
RFR: 8274559: JFR: Typo in 'jfr help configure' text
Hi, Could I have review of a typo. Testing: jdk/jdk/jfr Thanks Erik - Commit messages: - Initial Changes: https://git.openjdk.java.net/jdk/pull/5803/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=5803=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274559 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/5803.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5803/head:pull/5803 PR: https://git.openjdk.java.net/jdk/pull/5803
