Re: RFR: 8274083: Update testing docs to mention tiered testing [v5]
On 9/23/2021 11:00 PM, Alan Bateman wrote:
On Thu, 23 Sep 2021 12:53:23 GMT, Aleksey Shipilev wrote:
Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, let's
mention them in `testing.md`.
Current patch is my braindump, I am open for suggestions :)
Aleksey Shipilev has updated the pull request incrementally with one additional
commit since the last revision:
More fixes
Marked as reviewed by alanb (Reviewer).
doc/testing.html line 80:
78:
79: tier1: This is the lowest test tier. Multiple developers run these tests every day. Because of the
widespread use, the tests in tier1 are carefully selected and optimized to run fast, and to run in the most stable manner. The
test failures in tier1 are usually followed up on quickly, either with fixes, or adding relevant tests to problem list. GitHub
Actions workflows, if enabled, run tier1 tests.
80: tier2: This test group covers even more ground. These contain, among other
things, tests that either run for too long to be at tier1, or may require special configuration, or
tests that are less stable, or cover the broader range of less critical JVM and JDK features/components (for example,
jaxp).
Thanks for the updates, I think it reads much better now.
A small suggestion is to change "less critical" to "non-core", and "jaxp" to
"XML" as I don't expect too many people know what JAXP is.
Catching up on email, for some belated context, the initial tired
testing email thread did included some discussion about what the tiered
were intended to mean including:
http://mail.openjdk.java.net/pipermail/jdk9-dev/2015-March/001991.html
Thanks,
-Joe
-
PR: https://git.openjdk.java.net/jdk/pull/5615
Integrated: 8272167: AbsPathsInImage.java should skip *.dSYM directories
On Sun, 10 Oct 2021 22:35:40 GMT, Sergey Bylokhov wrote: > This fix changes the AbsPathsInImage test to skip *.dSYM directories. This pull request has now been integrated. Changeset: dd93c6e2 Author:Sergey Bylokhov URL: https://git.openjdk.java.net/jdk/commit/dd93c6e27b66acebb221583fd28d03c65bfc1f24 Stats: 11 lines in 1 file changed: 9 ins; 1 del; 1 mod 8272167: AbsPathsInImage.java should skip *.dSYM directories Reviewed-by: ihse, erikj - PR: https://git.openjdk.java.net/jdk/pull/5885
Re: RFR: 8274851: [PPC64] Port zgc to linux on ppc64le [v3]
On Fri, 8 Oct 2021 15:41:47 GMT, Niklas Radomski wrote: >> Port the Z garbage collector >> ([JDK-8209683](https://bugs.openjdk.java.net/browse/JDK-8209683)) to linux >> on ppc64le. > > Niklas Radomski has updated the pull request incrementally with three > additional commits since the last revision: > > - Remove superfluous copyright change > - Fix predicate conditions > - Add ByteSize constructor to Address Thank you for your reviews! Glad to see that the changes have been so well received. - PR: https://git.openjdk.java.net/jdk/pull/5842
Re: RFR: 8274851: [PPC64] Port zgc to linux on ppc64le [v3]
On Fri, 8 Oct 2021 15:41:47 GMT, Niklas Radomski wrote: >> Port the Z garbage collector >> ([JDK-8209683](https://bugs.openjdk.java.net/browse/JDK-8209683)) to linux >> on ppc64le. > > Niklas Radomski has updated the pull request incrementally with three > additional commits since the last revision: > > - Remove superfluous copyright change > - Fix predicate conditions > - Add ByteSize constructor to Address Thanks for doing the requested fixes. LGTM. - Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/5842
Re: RFR: 8272167: AbsPathsInImage.java should skip *.dSYM directories
On Sun, 10 Oct 2021 22:35:40 GMT, Sergey Bylokhov wrote: > This fix changes the AbsPathsInImage test to skip *.dSYM directories. Thanks for fixing this! - Marked as reviewed by erikj (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/5885
Re: RFR: 8275008: gtest build failure due to stringop-overflow warning with gcc11
On Mon, 11 Oct 2021 02:35:20 GMT, David Holmes wrote: >> Hi all, >> >> gtest build fails due to stringop-overflow warning with gcc11. >> >> This is because gcc11 seems to be smart enough to detect the following >> stringop-overflow at test/hotspot/gtest/memory/test_guardedMemory.cpp:125:11. >> >> * For target hotspot_variant-server_libjvm_gtest_objs_test_guardedMemory.o: >> In file included from /usr/include/string.h:495, >> from >> /home/jdk/src/hotspot/share/utilities/globalDefinitions_gcc.hpp:35, >> from >> /home/jdk/src/hotspot/share/utilities/globalDefinitions.hpp:35, >> from /home/jdk/src/hotspot/share/memory/allocation.hpp:29, >> from >> /home/jdk/test/hotspot/gtest/memory/test_guardedMemory.cpp:25: >> In function 'void* memset(void*, int, size_t)', >> inlined from 'virtual void >> GuardedMemory_buffer_overrun_tail_Test::TestBody()' at >> /home/jdk/test/hotspot/gtest/memory/test_guardedMemory.cpp:125:11: > > Okay. Seems a bit heavy handed to disable across all gtests but okay. > > Thanks, > David Thanks @dholmes-ora and @magicus . - PR: https://git.openjdk.java.net/jdk/pull/5881
Integrated: 8275008: gtest build failure due to stringop-overflow warning with gcc11
On Sun, 10 Oct 2021 13:05:40 GMT, Jie Fu wrote: > Hi all, > > gtest build fails due to stringop-overflow warning with gcc11. > > This is because gcc11 seems to be smart enough to detect the following > stringop-overflow at test/hotspot/gtest/memory/test_guardedMemory.cpp:125:11. > > * For target hotspot_variant-server_libjvm_gtest_objs_test_guardedMemory.o: > In file included from /usr/include/string.h:495, > from > /home/jdk/src/hotspot/share/utilities/globalDefinitions_gcc.hpp:35, > from > /home/jdk/src/hotspot/share/utilities/globalDefinitions.hpp:35, > from /home/jdk/src/hotspot/share/memory/allocation.hpp:29, > from > /home/jdk/test/hotspot/gtest/memory/test_guardedMemory.cpp:25: > In function 'void* memset(void*, int, size_t)', > inlined from 'virtual void > GuardedMemory_buffer_overrun_tail_Test::TestBody()' at > /home/jdk/test/hotspot/gtest/memory/test_guardedMemory.cpp:125:11: This pull request has now been integrated. Changeset: c55dd365 Author:Jie Fu URL: https://git.openjdk.java.net/jdk/commit/c55dd365e3463670697b09de0ff70877203e5a69 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8275008: gtest build failure due to stringop-overflow warning with gcc11 Reviewed-by: dholmes, ihse - PR: https://git.openjdk.java.net/jdk/pull/5881
Re: RFR: 8272167: AbsPathsInImage.java should skip *.dSYM directories
On Sun, 10 Oct 2021 22:35:40 GMT, Sergey Bylokhov wrote: > This fix changes the AbsPathsInImage test to skip *.dSYM directories. LGTM - Marked as reviewed by ihse (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/5885
Re: RFR: 8275008: gtest build failure due to stringop-overflow warning with gcc11
On Sun, 10 Oct 2021 13:05:40 GMT, Jie Fu wrote: > Hi all, > > gtest build fails due to stringop-overflow warning with gcc11. > > This is because gcc11 seems to be smart enough to detect the following > stringop-overflow at test/hotspot/gtest/memory/test_guardedMemory.cpp:125:11. > > * For target hotspot_variant-server_libjvm_gtest_objs_test_guardedMemory.o: > In file included from /usr/include/string.h:495, > from > /home/jdk/src/hotspot/share/utilities/globalDefinitions_gcc.hpp:35, > from > /home/jdk/src/hotspot/share/utilities/globalDefinitions.hpp:35, > from /home/jdk/src/hotspot/share/memory/allocation.hpp:29, > from > /home/jdk/test/hotspot/gtest/memory/test_guardedMemory.cpp:25: > In function 'void* memset(void*, int, size_t)', > inlined from 'virtual void > GuardedMemory_buffer_overrun_tail_Test::TestBody()' at > /home/jdk/test/hotspot/gtest/memory/test_guardedMemory.cpp:125:11: Marked as reviewed by ihse (Reviewer). We do not currently have a way to disable warnings for individual files in a library. The only other way to disable warnings for a specific place is to use `#pragma`. Looks good. - PR: https://git.openjdk.java.net/jdk/pull/5881
