Re: Error while using self compiled openJDK14 in eclipse

2021-04-24 Thread Guoxiong Li
After building, the sub-directories under 'linux-x86_64-server-release' are
shown as below.


*bootcycle-spec.gmk  build.log.old  configure.log  hotspot  Makefile
   supportbuildjdk-spec.gmk   buildtools configure.log.old  images
make-supportbuild.log   compare.sh configure-support  jdk
 spec.gmk*

What you are missing is the folder `images`.
Could you give the brief steps on how you build the jdk?
Did you use `make images` or `make all`?


On Sat, Apr 24, 2021 at 10:19 PM Manavjeet Singh 
wrote:

> Moved this thread to build-dev@openjdk.java.net from
> hotspot-gc-...@openjdk.java.net.
>
>
> On Sat, Apr 24, 2021 at 7:44 PM Guoxiong Li  wrote:
>
>> Hi Manavjeet,
>>
>> It seems like an issue about building. Could you move this thread to
>> build-dev@openjdk.java.net ?
>> We can continue the discussion there.
>>
>> 
>> Best Regards,
>> Guoxiong.
>>
>> On Sat, Apr 24, 2021 at 9:28 PM Manavjeet Singh <
>> manavjeet18...@iiitd.ac.in> wrote:
>>
>>> Hi Guoxiong,
>>> There isn't any images folder under 'linux-x86_64-server-release'. I
>>> have only the following files(not bold ones are the folders).
>>> bootcycle-spec.gmk  build.log.old  configure.log  hotspot
>>> Makefile  support
>>> buildjdk-spec.gmk   buildtools configure.log.old  jdk
>>> make-support
>>> build.log   compare.sh configure-support  jdk.code-workspace
>>>  spec.gmk
>>>
>>> And the following filed under 'linux-x86_64-server-release/jdk/'
>>> bin   include  man  _optimize_image_exec.cmdline
>>> _optimize_image_exec.marker
>>> conf  lib  modules  _optimize_image_exec.log  release
>>>
>>>
>>>
>>> On Sat, Apr 24, 2021 at 6:40 PM Guoxiong Li  wrote:
>>>
>>>> Hi Manavjeet,
>>>>
>>>> I haven't used eclipse for a long time so my idea may be wrong.
>>>> According to your description, I think you should use
>>>> the path `jdk14/build/linux-x86_64-server-release*/images/jdk*`
>>>> instead.
>>>>
>>>> ---
>>>> Best Regards,
>>>> Guoxiong.
>>>>
>>>> On Sat, Apr 24, 2021 at 8:59 PM Manavjeet Singh <
>>>> manavjeet18...@iiitd.ac.in> wrote:
>>>>
>>>>> Hi!
>>>>> I compiled OpenJDK-14 on my machine and it is working fine when used
>>>>> from
>>>>> the command line. I want to build a program using it but when trying
>>>>> to add
>>>>> it to Eclipse(v4.18) through Window->Preferences->Installed
>>>>> JREs->Add->StandardVM and giving the path
>>>>> jdk14/build/linux-x86_64-server-release/jdk/.
>>>>> But it is showing the error: "Target is not a JDK root. System library
>>>>> not
>>>>> found".
>>>>> Have I made some mistake while compiling the jdk? Any help would be
>>>>> appreciated.
>>>>> Thanks
>>>>>
>>>>


Re: Error while using self compiled openJDK14 in eclipse

2021-04-25 Thread Guoxiong Li
Hi Manavjeet,

Glad to see that your issue has been solved.

FYI:
I found your last email was only sent to me and not sent(or CC) to `
build-dev@openjdk.java.net`.
It makes it impossible for others to receive and reply to your email. Just
a reminder for you.

---
Best Regards,
Guoxiong.


On Sat, Apr 24, 2021 at 11:32 PM Manavjeet Singh 
wrote:

> I used 'make CONF=linux-x86_64-server-release'. After using `make images
> CONF=linux-x86_64-server-release` I got the folder images in
> 'linux-x86_64-server-release'.
> Thanks!
> Manavjeet Singh
> CSD Undergraduate | 2018295
> Indraprastha Institute of Information Technology (IIITD)
>


Re: github PR fails to send RFR email

2021-05-10 Thread Guoxiong Li
Hi jie,

The same problem occurred in my PR[1].
And this problem began yesterday and only affects newly issued PRs(about 5
PRs now).

Similar problems have occurred in the past(also on *weekends*).
The maintainers may fix it quickly during working time.

CC'ing skara-...@openjdk.java.net

[1] https://github.com/openjdk/jdk/pull/3942


Best Regards,
-- Guoxiong


On Mon, May 10, 2021 at 2:24 PM jiefu(傅杰)  wrote:

> Hi all,
>
>
>
> I found my PR [1] fails to send RFR email.
>
>
>
> Is there anything wrong?
>
> Or am I missing something?
>
>
>
> Thanks.
>
> Best regards,
>
> Jie
>
>
>
> [1] https://github.com/openjdk/jdk/pull/3941
>
>


Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v34]

2022-04-28 Thread Guoxiong Li
On Thu, 28 Apr 2022 18:10:57 GMT, Maurizio Cimadamore  
wrote:

>> This PR contains the API and implementation changes for JEP-424 [1]. A more 
>> detailed description of such changes, to avoid repetitions during the review 
>> process, is included as a separate comment.
>> 
>> [1] - https://openjdk.java.net/jeps/424
>
> Maurizio Cimadamore has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Downcall and upcall tests use wrong layout which is missing some trailing 
> padding

Remind: please use the command `/jep JEP-424` [1] to mark this PR.

[1] 
https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands#PullRequestCommands-/jep

-

PR: https://git.openjdk.java.net/jdk/pull/7888


Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v34]

2022-04-29 Thread Guoxiong Li
On Fri, 29 Apr 2022 08:06:24 GMT, Maurizio Cimadamore  
wrote:

> would a jep unneeded be enough to "unstuck" this PR?

Yes if no bug. Conceptually, the `/jep unneeded` will behave as no jep command.

-

PR: https://git.openjdk.java.net/jdk/pull/7888