Integrated: Merge jdk18

[Jesper Wilhelmsson]

On Tue, 18 Jan 2022 01:13:45 GMT, Jesper Wilhelmsson  
wrote:

> Forwardport JDK 18 -> JDK 19

This pull request has now been integrated.

Changeset: 39f140a2
Author:Jesper Wilhelmsson 
URL:   
https://git.openjdk.java.net/jdk/commit/39f140a20120300074167597580f9be34e812cad
Stats: 403 lines in 9 files changed: 361 ins; 4 del; 38 mod

Merge

-

PR: https://git.openjdk.java.net/jdk/pull/7119

RFR: Merge jdk18

[Jesper Wilhelmsson]

Forwardport JDK 18 -> JDK 19

-

Commit messages:
 - Merge remote-tracking branch 'jdk18/master' into Merge_jdk18
 - 8279998: PPC64 debug builds fail with "untested: RangeCheckStub: 
predicate_failed_trap_id"
 - 8280034: ProblemList jdk/jfr/api/consumer/recordingstream/TestOnEvent.java 
on linux-x64
 - 8279924: [PPC64, s390] implement frame::is_interpreted_frame_valid checks
 - 8279702: [macosx] ignore xcodebuild warnings on M1
 - 8279930: Synthetic cast causes generation of store barriers when using heap 
segments
 - 8279597: [TESTBUG] ReturnBlobToWrongHeapTest.java fails with 
-XX:TieredStopAtLevel=1 on machines with many cores
 - 8278434: timeouts in test  
java/time/test/java/time/format/TestZoneTextPrinterParser.java

The webrevs contain the adjustments done while merging with regards to each 
parent branch:
 - master: https://webrevs.openjdk.java.net/?repo=jdk&pr=7119&range=00.0
 - jdk18: https://webrevs.openjdk.java.net/?repo=jdk&pr=7119&range=00.1

Changes: https://git.openjdk.java.net/jdk/pull/7119/files
  Stats: 403 lines in 9 files changed: 361 ins; 4 del; 38 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7119.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7119/head:pull/7119

PR: https://git.openjdk.java.net/jdk/pull/7119

Integrated: Merge jdk18

[Jesper Wilhelmsson]

On Tue, 4 Jan 2022 18:37:53 GMT, Jesper Wilhelmsson  
wrote:

> Forwardport JDK 18 -> JDK 19

This pull request has now been integrated.

Changeset: 191f7307
Author:Jesper Wilhelmsson 
URL:   
https://git.openjdk.java.net/jdk/commit/191f7307bb2f2e2ce93480b4fc5fbbef216ff7cd
Stats: 161 lines in 9 files changed: 125 ins; 11 del; 25 mod

Merge

-

PR: https://git.openjdk.java.net/jdk/pull/6959

RFR: Merge jdk18

[Jesper Wilhelmsson]

Forwardport JDK 18 -> JDK 19

-

Commit messages:
 - Merge remote-tracking branch 'jdk18/master' into Merge_jdk18
 - 8275830: C2: Receiver downcast is missing when inlining through method 
handle linkers
 - 8265317: [vector] assert(payload->is_object()) failed: expected 'object' 
value for scalar-replaced boxed vector but got: NULL
 - 8279379: GHA: Print tests that are in error
 - 8278966: two microbenchmarks tests fail 
"assert(!jvms->method()->has_exception_handlers()) failed: no exception handler 
expected" after JDK-8275638
 - 8278824: Uneven work distribution when scanning heap roots in G1

The webrevs contain the adjustments done while merging with regards to each 
parent branch:
 - master: https://webrevs.openjdk.java.net/?repo=jdk&pr=6959&range=00.0
 - jdk18: https://webrevs.openjdk.java.net/?repo=jdk&pr=6959&range=00.1

Changes: https://git.openjdk.java.net/jdk/pull/6959/files
  Stats: 161 lines in 9 files changed: 125 ins; 11 del; 25 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6959.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6959/head:pull/6959

PR: https://git.openjdk.java.net/jdk/pull/6959

Integrated: Merge jdk18

[Jesper Wilhelmsson]

On Thu, 23 Dec 2021 17:11:15 GMT, Jesper Wilhelmsson  
wrote:

> Forwardport JDK 18 -> JDK 19

This pull request has now been integrated.

Changeset: a3b1c6b0
Author:Jesper Wilhelmsson 
URL:   
https://git.openjdk.java.net/jdk/commit/a3b1c6b03600da21b00a1f37ea4712096d636b14
Stats: 299 lines in 17 files changed: 141 ins; 126 del; 32 mod

Merge

-

PR: https://git.openjdk.java.net/jdk/pull/6931

Re: RFR: Merge jdk18 [v2]

[Jesper Wilhelmsson]

> Forwardport JDK 18 -> JDK 19

Jesper Wilhelmsson has updated the pull request with a new target base due to a 
merge or a rebase. The pull request now contains 113 commits:

 - Merge
 - 8279115: Fix internal doc comment errors.
   
   Reviewed-by: mli
 - 8276302: Locale.filterTags methods ignore actual weight when matching "*" 
(as if it is 1)
   
   Reviewed-by: naoto
 - 8278766: Enable OpenJDK build support for reproducible jars and jmods using 
--date
   
   Reviewed-by: erikj
 - 8278125: Some preallocated OOMEs are missing stack trace
   
   Co-authored-by: dongyun.tdy 
   Reviewed-by: dholmes, coleenp
 - 8244669: convert clhsdb "mem" command from javascript to java
   
   Reviewed-by: sspitsyn, kevinw, poonam
 - 8209398: sun/security/pkcs11/KeyStore/SecretKeysBasic.sh failed with 
"PKCS11Exception: CKR_ATTRIBUTE_SENSITIVE"
   
   Reviewed-by: hchao, weijun
 - Merge
 - 8279022: JCmdTestFileSafety.java should check file time stamp for test result
   
   Reviewed-by: ccheung
 - 8279018: CRC calculation in CDS should not include _version and _head_size
   
   Reviewed-by: iklam, ccheung
 - ... and 103 more: 
https://git.openjdk.java.net/jdk/compare/04ad6689...a3fcfa2b

-

Changes: https://git.openjdk.java.net/jdk/pull/6931/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6931&range=01
  Stats: 19323 lines in 545 files changed: 14840 ins; 3205 del; 1278 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6931.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6931/head:pull/6931

PR: https://git.openjdk.java.net/jdk/pull/6931

RFR: Merge jdk18

[Jesper Wilhelmsson]

Forwardport JDK 18 -> JDK 19

-

Commit messages:
 - Merge
 - 8279204: [BACKOUT] JDK-8278413: C2 crash when allocating array of size too 
large
 - 8268297: jdk/jfr/api/consumer/streaming/TestLatestEvent.java times out
 - 8279076: C2: Bad AD file when matching SqrtF with UseSSE=0
 - 8278967: rmiregistry fails to start because SecurityManager is disabled
 - 8278239: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine failed with 
EXCEPTION_ACCESS_VIOLATION at 0x000d

The webrevs contain the adjustments done while merging with regards to each 
parent branch:
 - master: https://webrevs.openjdk.java.net/?repo=jdk&pr=6931&range=00.0
 - jdk18: https://webrevs.openjdk.java.net/?repo=jdk&pr=6931&range=00.1

Changes: https://git.openjdk.java.net/jdk/pull/6931/files
  Stats: 299 lines in 17 files changed: 141 ins; 126 del; 32 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6931.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6931/head:pull/6931

PR: https://git.openjdk.java.net/jdk/pull/6931

Integrated: Merge jdk18

[Jesper Wilhelmsson]

On Wed, 22 Dec 2021 16:03:43 GMT, Jesper Wilhelmsson  
wrote:

> Forwardport JDK 18 -> JDK 19

This pull request has now been integrated.

Changeset: f1fbba23
Author:Jesper Wilhelmsson 
URL:   
https://git.openjdk.java.net/jdk/commit/f1fbba23ebdb28a32977241f8e85b60e10878cbc
Stats: 260 lines in 21 files changed: 170 ins; 55 del; 35 mod

Merge

-

PR: https://git.openjdk.java.net/jdk/pull/6918

Re: RFR: Merge jdk18 [v2]

[Jesper Wilhelmsson]

> Forwardport JDK 18 -> JDK 19

Jesper Wilhelmsson has updated the pull request with a new target base due to a 
merge or a rebase. The pull request now contains 104 commits:

 - Merge
 - 8279063: Consolidate push and push_if_necessary in PreservedMarks
   
   Reviewed-by: rkennke, mli, tschatzl
 - 8279024: Remove javascript references from clhsdb.html
   
   Reviewed-by: kevinw, sspitsyn
 - Merge
 - 8244670: convert clhsdb "whatis" command from javascript to java
   
   Reviewed-by: sspitsyn, kevinw
 - 8279066: entries.remove(entry) is useless in PKCS12KeyStore
   
   Reviewed-by: mullan
 - Merge
 - 8279060: Parallel: Remove unused PSVirtualSpace constructors
   
   Reviewed-by: mli, sjohanss, tschatzl
 - 8278396: G1: Initialize the BOT threshold to be region bottom
   
   Reviewed-by: tschatzl, sjohanss
 - 8279043: Some Security Exception Messages Miss Spaces
   
   Reviewed-by: weijun
 - ... and 94 more: https://git.openjdk.java.net/jdk/compare/dfb15c3e...70630b7b

-

Changes: https://git.openjdk.java.net/jdk/pull/6918/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6918&range=01
  Stats: 18775 lines in 519 files changed: 14457 ins; 3098 del; 1220 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6918.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6918/head:pull/6918

PR: https://git.openjdk.java.net/jdk/pull/6918

RFR: Merge jdk18

[Jesper Wilhelmsson]

Forwardport JDK 18 -> JDK 19

-

Commit messages:
 - Merge
 - 8274315: JFR: One closed state per file or stream
 - 8271447: java.nio.file.InvalidPathException: Malformed input or input 
contains unmappable characters
 - 8278987: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in 
__write_sample_info__
 - 8279007: jstatd fails to start because SecurityManager is disabled
 - 8278508: Enable X86 maskAll instruction pattern for 32 bit JVM.
 - 8279045: Intrinsics missing vzeroupper instruction

The webrevs contain the adjustments done while merging with regards to each 
parent branch:
 - master: https://webrevs.openjdk.java.net/?repo=jdk&pr=6918&range=00.0
 - jdk18: https://webrevs.openjdk.java.net/?repo=jdk&pr=6918&range=00.1

Changes: https://git.openjdk.java.net/jdk/pull/6918/files
  Stats: 260 lines in 21 files changed: 170 ins; 55 del; 35 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6918.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6918/head:pull/6918

PR: https://git.openjdk.java.net/jdk/pull/6918

Integrated: Merge jdk17

[Jesper Wilhelmsson]

On Mon, 2 Aug 2021 23:30:55 GMT, Jesper Wilhelmsson  
wrote:

> Forwardport JDK 17 -> JDK 18

This pull request has now been integrated.

Changeset: c8add223
Author:Jesper Wilhelmsson 
URL:   
https://git.openjdk.java.net/jdk/commit/c8add223a10030e40ccef42e081fd0d8f00e0593
Stats: 534 lines in 36 files changed: 449 ins; 1 del; 84 mod

Merge

Reviewed-by: mikael

-

PR: https://git.openjdk.java.net/jdk/pull/4964

Re: RFR: Merge jdk17 [v2]

[Jesper Wilhelmsson]

> Forwardport JDK 17 -> JDK 18

Jesper Wilhelmsson has updated the pull request incrementally with one 
additional commit since the last revision:

  Revert "8271150: Remove EA from JDK 17 version string starting with Initial 
RC promotion on Aug 5, 2021(B34)"
  
  This reverts commit f8fb5713074b8960f5530d7aca954f84d57c1f30.

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4964/files
  - new: https://git.openjdk.java.net/jdk/pull/4964/files/a95b06a1..e353ddcc

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4964&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4964&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4964.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4964/head:pull/4964

PR: https://git.openjdk.java.net/jdk/pull/4964

RFR: Merge jdk17

[Jesper Wilhelmsson]

Forwardport JDK 17 -> JDK 18

-

Commit messages:
 - Merge
 - 8067223: [TESTBUG] Rename Whitebox API package
 - 8271150: Remove EA from JDK 17 version string starting with Initial RC 
promotion on Aug 5, 2021(B34)

The webrevs contain the adjustments done while merging with regards to each 
parent branch:
 - master: https://webrevs.openjdk.java.net/?repo=jdk&pr=4964&range=00.0
 - jdk17: https://webrevs.openjdk.java.net/?repo=jdk&pr=4964&range=00.1

Changes: https://git.openjdk.java.net/jdk/pull/4964/files
  Stats: 535 lines in 37 files changed: 449 ins; 1 del; 85 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4964.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4964/head:pull/4964

PR: https://git.openjdk.java.net/jdk/pull/4964

Integrated: Merge jdk17

[Jesper Wilhelmsson]

On Wed, 14 Jul 2021 21:35:34 GMT, Jesper Wilhelmsson  
wrote:

> Forwardport JDK 17 -> JDK 18

This pull request has now been integrated.

Changeset: 7d0edb57
Author:Jesper Wilhelmsson 
URL:   
https://git.openjdk.java.net/jdk/commit/7d0edb5743aacfc22f76ee8aa7b03d7dc0f90dca
Stats: 328 lines in 19 files changed: 240 ins; 14 del; 74 mod

Merge

-

PR: https://git.openjdk.java.net/jdk/pull/4786

RFR: Merge jdk17

[Jesper Wilhelmsson]

Forwardport JDK 17 -> JDK 18

-

Commit messages:
 - Merge
 - 8270422: Test build/AbsPathsInImage.java fails after JDK-8259848
 - 8266313: (JEP-356) - RandomGenerator spec implementation requirements 
tightly coupled to JDK internal classes
 - 8270075: SplittableRandom extends AbstractSplittableGenerator
 - 8266889: [macosx-aarch64] Crash with SIGBUS in 
MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 
test run
 - 8259499: Handling type arguments from outer classes for inner class in 
javadoc
 - 8268620: InfiniteLoopException test may fail on x86 platforms
 - 8269865: Async UL needs to handle ERANGE on exceeding SEM_VALUE_MAX
 - 8270056: Generated lambda class can not access protected static method of 
target class

The webrevs contain the adjustments done while merging with regards to each 
parent branch:
 - master: https://webrevs.openjdk.java.net/?repo=jdk&pr=4786&range=00.0
 - jdk17: https://webrevs.openjdk.java.net/?repo=jdk&pr=4786&range=00.1

Changes: https://git.openjdk.java.net/jdk/pull/4786/files
  Stats: 328 lines in 19 files changed: 240 ins; 14 del; 74 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4786.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4786/head:pull/4786

PR: https://git.openjdk.java.net/jdk/pull/4786

Integrated: Merge jdk17

[Jesper Wilhelmsson]

On Wed, 14 Jul 2021 00:13:41 GMT, Jesper Wilhelmsson  
wrote:

> Forwardport JDK 17 -> JDK 18

This pull request has now been integrated.

Changeset: 4a7ccf36
Author:Jesper Wilhelmsson 
URL:   
https://git.openjdk.java.net/jdk/commit/4a7ccf36e9a3978c437db3efe892dd23e8a0b772
Stats: 388 lines in 13 files changed: 322 ins; 18 del; 48 mod

Merge

-

PR: https://git.openjdk.java.net/jdk/pull/4771

RFR: Merge jdk17

[Jesper Wilhelmsson]

Forwardport JDK 17 -> JDK 18

-

Commit messages:
 - Merge
 - 8270025: DynamicCallSiteDesc::withArgs doesn't throw NPE
 - 8270184: [TESTBUG] Add coverage for jvmci ResolvedJavaType.toJavaName() for 
lambdas
 - 8269281: java/foreign/Test{Down,Up}call.java time out
 - 8269635: Stress test SEGV while emitting OldObjectSample
 - 8269525: Deadlock during Volano with JFR
 - 8259848: Interim javadoc build does not support platform links
 - 8269795: C2: Out of bounds array load floats above its range check in loop 
peeling resulting in SEGV
 - 8270203: Missing build dependency between jdk.jfr-gendata and 
buildtools-hotspot

The webrevs contain the adjustments done while merging with regards to each 
parent branch:
 - master: https://webrevs.openjdk.java.net/?repo=jdk&pr=4771&range=00.0
 - jdk17: https://webrevs.openjdk.java.net/?repo=jdk&pr=4771&range=00.1

Changes: https://git.openjdk.java.net/jdk/pull/4771/files
  Stats: 388 lines in 13 files changed: 322 ins; 18 del; 48 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4771.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4771/head:pull/4771

PR: https://git.openjdk.java.net/jdk/pull/4771

Re: RFR: Merge jdk17 [v2]

[Jesper Wilhelmsson]

> Forwardport JDK 17 -> JDK 18

Jesper Wilhelmsson has updated the pull request with a new target base due to a 
merge or a rebase. The pull request now contains 180 commits:

 - Merge
 - 8264735: Make dynamic dump repeatable
   
   Reviewed-by: ccheung, iklam
 - 8269481: SctpMultiChannel never releases own file descriptor
   
   Reviewed-by: alanb, chegar
 - 8270027: ProblemList jdk/jfr/event/oldobject/TestObjectSize.java on macOS-x64
   
   Reviewed-by: mgronlun
 - 8267303: Replace MinObjectAlignmentSize usages for non-Java heap objects
   
   Reviewed-by: kbarrett, tschatzl, minqi
 - 8268635: Corrupt oop in ClassLoaderData
   
   Reviewed-by: iklam, dholmes
 - 8269923: runtime/jni/checked/TestPrimitiveArrayCriticalWithBadParam.java 
failed with "FATAL ERROR in native method: Primitive type array expected but 
not received for JNI array operation"
   
   Reviewed-by: dcubed, dholmes
 - 8269761: idea.sh missing .exe suffix when invoking javac on WSL
   
   Reviewed-by: mcimadamore, erikj
 - 8269294: Verify_before/after_young_collection should execute all verification
   
   Reviewed-by: iwalulya, kbarrett
 - 8269908: Move MemoryService::track_memory_usage call into G1MonitoringScope
   
   Reviewed-by: ayang, kbarrett
 - ... and 170 more: 
https://git.openjdk.java.net/jdk/compare/c812bbbe...e5695159

-

Changes: https://git.openjdk.java.net/jdk/pull/4713/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4713&range=01
  Stats: 46991 lines in 850 files changed: 21189 ins; 22881 del; 2921 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4713.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4713/head:pull/4713

PR: https://git.openjdk.java.net/jdk/pull/4713

Integrated: Merge jdk17

[Jesper Wilhelmsson]

On Thu, 8 Jul 2021 00:01:43 GMT, Jesper Wilhelmsson  
wrote:

> Forwardport JDK 17 -> JDK 18

This pull request has now been integrated.

Changeset: 270fbcb3
Author:Jesper Wilhelmsson 
URL:   
https://git.openjdk.java.net/jdk/commit/270fbcb3f5755baf045fa6dec3fba459d32c32e1
Stats: 1083 lines in 36 files changed: 629 ins; 278 del; 176 mod

Merge

-

PR: https://git.openjdk.java.net/jdk/pull/4713

RFR: Merge jdk17

[Jesper Wilhelmsson]

Forwardport JDK 17 -> JDK 18

-

Commit messages:
 - Merge
 - 8269929: (test) Add diagnostic info to ProceessBuilder/Basic.java for 
unexpected output
 - 8269185: Directories in /opt/runtimepackagetest and /path/to/jdk-17 are 
different
 - 8269879: [PPC64] C2: Math.rint intrinsic uses wrong rounding mode
 - 8266036: class file for sun.misc.Contended not found
 - 8269772: [macos-aarch64] test compilation failed with "SocketException: No 
buffer space available"
 - 8268859: jshell throws exception while parsing illegal "case true"
 - 8269802: javac fails to compile nested pattern matching switches
 - 8269830: SA's vm object vtable matching code sometimes matches on incorrect 
type
 - 8268778: CDS check_excluded_classes needs DumpTimeTable_lock

The webrevs contain the adjustments done while merging with regards to each 
parent branch:
 - master: https://webrevs.openjdk.java.net/?repo=jdk&pr=4713&range=00.0
 - jdk17: https://webrevs.openjdk.java.net/?repo=jdk&pr=4713&range=00.1

Changes: https://git.openjdk.java.net/jdk/pull/4713/files
  Stats: 1083 lines in 36 files changed: 629 ins; 278 del; 176 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4713.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4713/head:pull/4713

PR: https://git.openjdk.java.net/jdk/pull/4713

Integrated: Merge jdk17

[Jesper Wilhelmsson]

On Sun, 27 Jun 2021 23:05:10 GMT, Jesper Wilhelmsson  
wrote:

> Forwardport JDK 17 -> JDK 18

This pull request has now been integrated.

Changeset: a29953d8
Author:Jesper Wilhelmsson 
URL:   
https://git.openjdk.java.net/jdk/commit/a29953d805ac6360bcfe005bcefa60e112788494
Stats: 1925 lines in 90 files changed: 1452 ins; 227 del; 246 mod

Merge

-

PR: https://git.openjdk.java.net/jdk/pull/4606

RFR: Merge jdk17

[Jesper Wilhelmsson]

Forwardport JDK 17 -> JDK 18

-

Commit messages:
 - Merge
 - 8258746: illegal access to global field _jvmci_old_thread_counters by 
terminated thread causes crash
 - 8266269: Lookup::accessClass fails with IAE when accessing an arrayClass 
with a protected inner class as component class
 - 8269351: Proxy::newProxyInstance and 
MethodHandleProxies::asInterfaceInstance should reject sealed interfaces
 - 8269260: Add AVX512 and other SSE + AVX combinations testing for tests which 
generate vector instructions
 - 8269302: serviceability/dcmd/framework/InvalidCommandTest.java still fails 
after JDK-8268433
 - 8269036: tools/jpackage/share/AppImagePackageTest.java failed with "hdiutil: 
create failed - Resource busy"
 - 8269074: (fs) Files.copy fails to copy from /proc on some linux kernel 
versions
 - 8256919: BCEL: Utility.encode forget to close
 - 8269335: Unable to load svml library
 - ... and 20 more: https://git.openjdk.java.net/jdk/compare/8bed3534...2d9b73c0

The webrevs contain the adjustments done while merging with regards to each 
parent branch:
 - master: https://webrevs.openjdk.java.net/?repo=jdk&pr=4606&range=00.0
 - jdk17: https://webrevs.openjdk.java.net/?repo=jdk&pr=4606&range=00.1

Changes: https://git.openjdk.java.net/jdk/pull/4606/files
  Stats: 1925 lines in 90 files changed: 1452 ins; 227 del; 246 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4606.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4606/head:pull/4606

PR: https://git.openjdk.java.net/jdk/pull/4606

Withdrawn: Merge jdk17

[Jesper Wilhelmsson]

On Thu, 24 Jun 2021 00:36:38 GMT, Jesper Wilhelmsson  
wrote:

> Forwardport JDK 17 -> JDK 18

This pull request has been closed without being integrated.

-

PR: https://git.openjdk.java.net/jdk/pull/4579

RFR: Merge jdk17

[Jesper Wilhelmsson]

Forwardport JDK 17 -> JDK 18

-

Commit messages:
 - Merge
 - 8266854: LibraryCallKit::inline_preconditions_checkIndex modifies control 
flow even if the intrinsic bailed out
 - 8254571: Erroneous generic type inference in a lambda expression with a 
checked exception
 - 8269125: Klass enqueue element size calculation wrong when traceid value 
cross compress limit
 - 8268961: Parenthesized pattern with guards does not work
 - 8269066: assert(ZAddress::is_marked(addr)) failed: Should be marked
 - 8269064: Dropped messages of AsyncLogWriter cause memleak
 - 8269148: Update minor GCC version in GitHub Actions pipeline
 - 8266885: [aarch64] Crash with 'Field too big for insn' for some tests under 
compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/

The merge commit only contains trivial merges, so no merge-specific webrevs 
have been generated.

Changes: https://git.openjdk.java.net/jdk/pull/4579/files
  Stats: 408 lines in 17 files changed: 347 ins; 32 del; 29 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4579.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4579/head:pull/4579

PR: https://git.openjdk.java.net/jdk/pull/4579

Integrated: Merge jdk17

[Jesper Wilhelmsson]

On Mon, 21 Jun 2021 22:03:59 GMT, Jesper Wilhelmsson  
wrote:

> Forwardport JDK 17 -> JDK 18

This pull request has now been integrated.

Changeset: 0458113c
Author:Jesper Wilhelmsson 
URL:   
https://git.openjdk.java.net/jdk/commit/0458113c6b1cf500ffdf049c1e3a698b16ce12ce
Stats: 608 lines in 25 files changed: 578 ins; 17 del; 13 mod

Merge

-

PR: https://git.openjdk.java.net/jdk/pull/4545

Re: RFR: Merge jdk17 [v2]

[Jesper Wilhelmsson]

> Forwardport JDK 17 -> JDK 18

Jesper Wilhelmsson has updated the pull request with a new target base due to a 
merge or a rebase. The pull request now contains 52 commits:

 - Merge
 - 8268458: Add verification type for evacuation failures
   
   Reviewed-by: kbarrett, iwalulya
 - 8268952: Automatically update heap sizes in G1MonitoringScope
   
   Reviewed-by: kbarrett, iwalulya
 - 8269029: compiler/codegen/TestCharVect2.java fails for client VMs
   
   Reviewed-by: kvn, jiefu
 - 8017163: G1: Refactor remembered sets
   8048504: G1: Investigate replacing the coarse and fine grained data 
structures in the remembered sets
   6949259: G1: Merge sparse and fine remembered set hash tables
   
   Co-authored-by: Ivan Walulya 
   Co-authored-by: Thomas Schatzl 
   Reviewed-by: sjohanss, iwalulya
 - 8266082: AssertionError in Annotate.fromAnnotations with -Xdoclint
   
   Reviewed-by: vromero
 - Merge
 - 8267042: bug in monitor locking/unlocking on ARM32 C1 due to uninitialized 
BasicObjectLock::_displaced_header
   
   Co-authored-by: Chris Cole 
   Reviewed-by: dsamersoff
 - 8268964: Remove unused ReferenceProcessorAtomicMutator
   
   Reviewed-by: tschatzl, pliden
 - 8268900: com/sun/net/httpserver/Headers.java: Fix indentation and whitespace
   
   Reviewed-by: dfuchs, chegar, michaelm
 - ... and 42 more: https://git.openjdk.java.net/jdk/compare/d3ad8cd3...40c550db

-

Changes: https://git.openjdk.java.net/jdk/pull/4545/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4545&range=01
  Stats: 14796 lines in 230 files changed: 12511 ins; 1719 del; 566 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4545.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4545/head:pull/4545

PR: https://git.openjdk.java.net/jdk/pull/4545

RFR: Merge jdk17

[Jesper Wilhelmsson]

Forwardport JDK 17 -> JDK 18

-

Commit messages:
 - Merge
 - 8268672: C2: assert(!loop->is_member(u_loop)) failed: can be in outer loop 
or out of both loops only
 - 8268717: Upstream: 8268673: Stack walk across optimized entry frame on fresh 
native thread fails
 - 8268362: [REDO] C2 crash when compile negative Arrays.copyOf length after 
loop
 - 8268702: JFR diagnostic commands lack argument descriptors when viewed using 
Platform MBean Server
 - 8267042: bug in monitor locking/unlocking on ARM32 C1 due to uninitialized 
BasicObjectLock::_displaced_header
 - 8269063: Build failure due to VerifyReceiverTypes was not declared after 
JDK-8268405

The webrevs contain the adjustments done while merging with regards to each 
parent branch:
 - master: https://webrevs.openjdk.java.net/?repo=jdk&pr=4545&range=00.0
 - jdk17: https://webrevs.openjdk.java.net/?repo=jdk&pr=4545&range=00.1

Changes: https://git.openjdk.java.net/jdk/pull/4545/files
  Stats: 608 lines in 25 files changed: 578 ins; 17 del; 13 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4545.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4545/head:pull/4545

PR: https://git.openjdk.java.net/jdk/pull/4545

Integrated: Merge jdk17

[Jesper Wilhelmsson]

On Thu, 17 Jun 2021 00:49:27 GMT, Jesper Wilhelmsson  
wrote:

> Forwardport JDK 17 -> JDK 18

This pull request has now been integrated.

Changeset: 3637e50b
Author:Jesper Wilhelmsson 
URL:   
https://git.openjdk.java.net/jdk/commit/3637e50b30e92538510c1a8e8893cedc3bd4ccd5
Stats: 659 lines in 33 files changed: 450 ins; 121 del; 88 mod

Merge

-

PR: https://git.openjdk.java.net/jdk/pull/4514

Re: RFR: Merge jdk17 [v2]

[Jesper Wilhelmsson]

> Forwardport JDK 17 -> JDK 18

Jesper Wilhelmsson has updated the pull request with a new target base due to a 
merge or a rebase. The incremental webrev excludes the unrelated changes 
brought in by the merge/rebase. The pull request contains 35 additional commits 
since the last revision:

 - Merge
 - 8268852: AsyncLogWriter should not overide is_Named_thread()
   
   Reviewed-by: dholmes, ysuenaga
 - 8259338: Add expiry exception for identrustdstx3 alias to VerifyCACerts.java 
test
   
   Reviewed-by: xuelei
 - 8259066: Obsolete -XX:+AlwaysLockClassLoader
   
   Reviewed-by: hseigel
 - 8268778: CDS check_excluded_classes needs DumpTimeTable_lock
   
   Reviewed-by: ccheung, minqi
 - 8267752: KVHashtable doesn't deallocate entries
   
   Reviewed-by: iklam, stuefe
 - 8267870: Remove unnecessary char_converter during class loading
   
   Reviewed-by: dholmes, iklam
 - 8268078: ClassListParser::_interfaces should be freed
   
   Reviewed-by: minqi, iklam, coleenp
 - 8268780: Use 'print_cr' instead of 'print' for the message 'eliminated 
'
   
   Reviewed-by: cjplummer, zgu, dcubed
 - Merge
 - ... and 25 more: https://git.openjdk.java.net/jdk/compare/fdaabfed...c47ba95e

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4514/files
  - new: https://git.openjdk.java.net/jdk/pull/4514/files/c47ba95e..c47ba95e

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4514&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4514&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4514.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4514/head:pull/4514

PR: https://git.openjdk.java.net/jdk/pull/4514

RFR: Merge jdk17

[Jesper Wilhelmsson]

Forwardport JDK 17 -> JDK 18

-

Commit messages:
 - Merge
 - 8260194: Update the documentation for -Xcheck:jni
 - 8268863: ProblemList serviceability/sa/TestJmapCoreMetaspace.java on 
linux-x64 with ZGC
 - 8268909: ProblemList jdk/jfr/api/consumer/streaming/TestLatestEvent.java on 
win-x64
 - 8259338: Add expiry exception for identrustdstx3 alias to VerifyCACerts.java 
test
 - 8268774: Residual logging output written to STDOUT, not STDERR
 - 8268714: [macos-aarch64] 7 java/net/httpclient/websocket tests failed
 - 8268901: JDK-8268768 missed removing two files
 - 8256934: C2: assert(C->live_nodes() <= C->max_node_limit()) failed: Live 
Node limit exceeded limit
 - 8268861: Disable Windows-Aarch64 build in GitHub Actions
 - ... and 4 more: https://git.openjdk.java.net/jdk/compare/02c9bf08...c47ba95e

The merge commit only contains trivial merges, so no merge-specific webrevs 
have been generated.

Changes: https://git.openjdk.java.net/jdk/pull/4514/files
  Stats: 659 lines in 33 files changed: 450 ins; 121 del; 88 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4514.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4514/head:pull/4514

PR: https://git.openjdk.java.net/jdk/pull/4514

Integrated: Merge jdk17

[Jesper Wilhelmsson]

On Tue, 15 Jun 2021 21:51:33 GMT, Jesper Wilhelmsson  
wrote:

> Forwardport JDK 17 -> JDK 18

This pull request has now been integrated.

Changeset: e0f6f70d
Author:Jesper Wilhelmsson 
URL:   
https://git.openjdk.java.net/jdk/commit/e0f6f70d3f9e748d2bc53f371beca487e9343d4a
Stats: 1606 lines in 62 files changed: 1180 ins; 181 del; 245 mod

Merge

-

PR: https://git.openjdk.java.net/jdk/pull/4499

Re: RFR: Merge jdk17 [v2]

[Jesper Wilhelmsson]

> Forwardport JDK 17 -> JDK 18

Jesper Wilhelmsson has updated the pull request with a new target base due to a 
merge or a rebase. The incremental webrev excludes the unrelated changes 
brought in by the merge/rebase. The pull request contains 25 additional commits 
since the last revision:

 - Merge jdk17
 - 8268620: InfiniteLoopException test may fail on x86 platforms
   
   Reviewed-by: prr, trebari, azvegint
 - 8268125: ZGC: Clone oop array gets wrong acopy stub
   
   Reviewed-by: kvn, vlivanov
 - 8238649: Call new Win32 API SetThreadDescription in 
os::set_native_thread_name
   
   Co-authored-by: Markus GaisBauer 
   Reviewed-by: stuefe, luhenry
 - 8268626: Remove native pre-jdk9 support for jtreg failure handler
   
   Reviewed-by: erikj
 - 8268699: Shenandoah: Add test for JDK-8268127
   
   Reviewed-by: rkennke
 - Merge
   
   Reviewed-by: dcubed
 - 8262731: [macOS] Exception from "Printable.print" is swallowed during 
"PrinterJob.print"
   
   Reviewed-by: prr
 - 8267579: Thread::cooked_allocated_bytes() hits assert(left >= right) failed: 
avoid underflow
   
   Reviewed-by: dcubed, stefank, kbarrett
 - 8266791: Annotation property which is compiled as an array property but 
changed to a single element throws NullPointerException
   
   Reviewed-by: darcy, jfranck
 - ... and 15 more: https://git.openjdk.java.net/jdk/compare/6da37cd0...e748b877

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4499/files
  - new: https://git.openjdk.java.net/jdk/pull/4499/files/e748b877..e748b877

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4499&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4499&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4499.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4499/head:pull/4499

PR: https://git.openjdk.java.net/jdk/pull/4499

RFR: Merge jdk17

[Jesper Wilhelmsson]

Forwardport JDK 17 -> JDK 18

-

Commit messages:
 - Merge jdk17
 - 8268768: idea.sh has been updated in surprising and incompatible ways
 - 8268828: ProblemList compiler/intrinsics/VectorizedMismatchTest.java on 
win-x64
 - 8268723: Problem list SA core file tests on OSX when using ZGC
 - 8268736: Use apiNote in AutoCloseable.close javadoc
 - 8263321: Regression 8% in javadoc-steady in 17-b11
 - 8268125: ZGC: Clone oop array gets wrong acopy stub
 - 8268663: Crash when guards contain boolean expression
 - 8268347: C2: nested locks optimization may create unbalanced monitor 
enter/exit code
 - 8268643: SVML lib shouldn't be generated when C2 is absent
 - ... and 7 more: https://git.openjdk.java.net/jdk/compare/0b09129f...e748b877

The webrevs contain the adjustments done while merging with regards to each 
parent branch:
 - master: https://webrevs.openjdk.java.net/?repo=jdk&pr=4499&range=00.0
 - jdk17: https://webrevs.openjdk.java.net/?repo=jdk&pr=4499&range=00.1

Changes: https://git.openjdk.java.net/jdk/pull/4499/files
  Stats: 1606 lines in 62 files changed: 1180 ins; 181 del; 245 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4499.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4499/head:pull/4499

PR: https://git.openjdk.java.net/jdk/pull/4499

Integrated: Merge jdk16

[Jesper Wilhelmsson]

On Thu, 4 Feb 2021 01:17:48 GMT, Jesper Wilhelmsson  
wrote:

> Forwardport JDK 16 -> JDK 17

This pull request has now been integrated.

Changeset: 9b7a8f19
Author:Jesper Wilhelmsson 
URL:   https://git.openjdk.java.net/jdk/commit/9b7a8f19
Stats: 2645 lines in 56 files changed: 2497 ins; 69 del; 79 mod

Merge

-

PR: https://git.openjdk.java.net/jdk/pull/2392

RFR: Merge jdk16

[Jesper Wilhelmsson]

Forwardport JDK 16 -> JDK 17

-

Commit messages:
 - Merge
 - 8259794: Remove EA from JDK 16 version string starting with Initial RC 
promotion on Feb 04, 2021(B35)
 - 8260704: ParallelGC: oldgen expansion needs release-store for _end
 - 8260927: StringBuilder::insert is incorrect without Compact Strings
 - 8258378: Final nroff manpage update for JDK 16
 - 8257215: JFR: Events dropped when streaming over a chunk rotation
 - 8260473: [vector] ZGC: VectorReshape test produces incorrect results with 
ZGC enabled
 - 8260632: Build failures after JDK-8253353
 - 8260339: JVM crashes when executing PhaseIdealLoop::match_fill_loop
 - 8260608: add a regression test for 8260370
 - ... and 2 more: https://git.openjdk.java.net/jdk/compare/f025bc1d...dad835ee

The webrevs contain the adjustments done while merging with regards to each 
parent branch:
 - master: https://webrevs.openjdk.java.net/?repo=jdk&pr=2392&range=00.0
 - jdk16: https://webrevs.openjdk.java.net/?repo=jdk&pr=2392&range=00.1

Changes: https://git.openjdk.java.net/jdk/pull/2392/files
  Stats: 2645 lines in 56 files changed: 2497 ins; 69 del; 79 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2392.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2392/head:pull/2392

PR: https://git.openjdk.java.net/jdk/pull/2392

[jdk16] Integrated: 8259794: Remove EA from JDK 16 version string starting with Initial RC promotion on Feb 04, 2021(B35)

[Jesper Wilhelmsson]

On Tue, 2 Feb 2021 18:17:55 GMT, Jesper Wilhelmsson  
wrote:

> We have our (first) RC candidate build for JDK 16 on Feb 04, 2021. We need to 
> remove the EA from version string for this build (b35) and going forward.
> 
> Pushing this for @pashh

This pull request has now been integrated.

Changeset: 1a7040e5
Author:Jesper Wilhelmsson 
URL:   https://git.openjdk.java.net/jdk16/commit/1a7040e5
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod

8259794: Remove EA from JDK 16 version string starting with Initial RC 
promotion on Feb 04, 2021(B35)

Reviewed-by: iignatyev, mikael

-

PR: https://git.openjdk.java.net/jdk16/pull/146

[jdk16] RFR: 8259794: Remove EA from JDK 16 version string starting with Initial RC promotion on Feb 04, 2021(B35)

[Jesper Wilhelmsson]

We have our (first) RC candidate build for JDK 16 on Feb 04, 2021. We need to 
remove the EA from version string for this build (b35) and going forward.

Pushing this for @pashh

-

Commit messages:
 - Remove ea

Changes: https://git.openjdk.java.net/jdk16/pull/146/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk16&pr=146&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8259794
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk16/pull/146.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk16 pull/146/head:pull/146

PR: https://git.openjdk.java.net/jdk16/pull/146

Integrated: Merge jdk16

[Jesper Wilhelmsson]

On Mon, 11 Jan 2021 22:04:16 GMT, Jesper Wilhelmsson  
wrote:

> Forwardport JDK 16 -> JDK 17

This pull request has now been integrated.

Changeset: b378f54d
Author:Jesper Wilhelmsson 
URL:   https://git.openjdk.java.net/jdk/commit/b378f54d
Stats: 139 lines in 12 files changed: 116 ins; 2 del; 21 mod

Merge

-

PR: https://git.openjdk.java.net/jdk/pull/2040

Re: RFR: Merge jdk16 [v2]

[Jesper Wilhelmsson]

> Forwardport JDK 16 -> JDK 17

Jesper Wilhelmsson has updated the pull request incrementally with one 
additional commit since the last revision:

  Merge

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2040/files
  - new: https://git.openjdk.java.net/jdk/pull/2040/files/e55da33b..69dad8ed

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2040&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2040&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2040.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2040/head:pull/2040

PR: https://git.openjdk.java.net/jdk/pull/2040

RFR: Merge jdk16

[Jesper Wilhelmsson]

Forwardport JDK 16 -> JDK 17

-

Commit messages:
 - Merge
 - 8253996: Javac error on jdk16 build 18: invalid flag: -Xdoclint:-missing
 - 8259028: ClassCastException when using custom filesystem with wrapper 
FileChannel impl
 - 8259043: More Zero architectures need linkage with libatomic
 - 8259429: Update reference to README.md
 - 8259014: (so) 
ServerSocketChannel.bind(UnixDomainSocketAddress)/SocketChannel.bind(UnixDomainSocketAddress)
 will have unknown user and group owner (win)

The webrevs contain the adjustments done while merging with regards to each 
parent branch:
 - master: https://webrevs.openjdk.java.net/?repo=jdk&pr=2040&range=00.0
 - jdk16: https://webrevs.openjdk.java.net/?repo=jdk&pr=2040&range=00.1

Changes: https://git.openjdk.java.net/jdk/pull/2040/files
  Stats: 140 lines in 12 files changed: 117 ins; 2 del; 21 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2040.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2040/head:pull/2040

PR: https://git.openjdk.java.net/jdk/pull/2040

Integrated: Merge jdk16

[Jesper Wilhelmsson]

Forwardport JDK 16 -> JDK 17

-

Commit messages:
 - Merge
 - 8258484: AIX build fails in Harfbuzz with XLC 16.01..0006
 - 8039278: console.sh failed Automatically with exit code 1
 - 8258972: unexpected compilation error with generic sealed interface
 - 8259227: C2 crashes with SIGFPE due to a division that floats above its zero 
check
 - 8258657: Doc build is broken by use of new language features
 - 8250903: jdk/jfr/javaagent/TestLoadedAgent.java fails with Mismatch in 
TestEvent count

The webrevs contain the adjustments done while merging with regards to each 
parent branch:
 - master: https://webrevs.openjdk.java.net/?repo=jdk&pr=1994&range=00.0
 - jdk16: https://webrevs.openjdk.java.net/?repo=jdk&pr=1994&range=00.1

Changes: https://git.openjdk.java.net/jdk/pull/1994/files
  Stats: 198 lines in 15 files changed: 147 ins; 31 del; 20 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1994.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1994/head:pull/1994

PR: https://git.openjdk.java.net/jdk/pull/1994

Integrated: Merge jdk16

[Jesper Wilhelmsson]

On Thu, 7 Jan 2021 23:46:55 GMT, Jesper Wilhelmsson  
wrote:

> Forwardport JDK 16 -> JDK 17

This pull request has now been integrated.

Changeset: 56a354eb
Author:Jesper Wilhelmsson 
URL:   https://git.openjdk.java.net/jdk/commit/56a354eb
Stats: 198 lines in 15 files changed: 147 ins; 31 del; 20 mod

Merge

-

PR: https://git.openjdk.java.net/jdk/pull/1994

Integrated: Merge jdk16

[Jesper Wilhelmsson]

On Thu, 7 Jan 2021 20:40:49 GMT, Jesper Wilhelmsson  
wrote:

> Forwardport JDK 16 -> JDK 17

This pull request has now been integrated.

Changeset: 555641ed
Author:Jesper Wilhelmsson 
URL:   https://git.openjdk.java.net/jdk/commit/555641ed
Stats: 2957 lines in 68 files changed: 751 ins; 2142 del; 64 mod

Merge

-

PR: https://git.openjdk.java.net/jdk/pull/1989

RFR: Merge jdk16

[Jesper Wilhelmsson]

Forwardport JDK 16 -> JDK 17

-

Commit messages:
 - Merge
 - 8249633: doclint reports missing javadoc for JavaFX property methods that 
have a property description
 - 8251200: False positive messages about missing comments for serialization
 - 8259312: VerifyCACerts.java fails as soneraclass2ca cert will expire in 90 
days
 - 8259075: Update the copyright notice in the files generated by CLDR 
Converter tool
 - 8259224: (ann) getAnnotatedReceiverType should not parameterize owner(s) of 
statically nested classes
 - 8258558: Revert changes for JDK-8252505 and related issues
 - 8259032: MappedMemorySegmentImpl#makeMappedSegment() ignores 
Unmapper#pagePosition
 - 8259007: This test printed a blank page
 - 8258989: JVM is failed to inline in 
jdk.internal.vm.vector.VectorSupport::convert
 - ... and 8 more: https://git.openjdk.java.net/jdk/compare/0e6de4eb...bbd6426f

The webrevs contain the adjustments done while merging with regards to each 
parent branch:
 - master: https://webrevs.openjdk.java.net/?repo=jdk&pr=1989&range=00.0
 - jdk16: https://webrevs.openjdk.java.net/?repo=jdk&pr=1989&range=00.1

Changes: https://git.openjdk.java.net/jdk/pull/1989/files
  Stats: 2957 lines in 68 files changed: 751 ins; 2142 del; 64 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1989.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1989/head:pull/1989

PR: https://git.openjdk.java.net/jdk/pull/1989

Integrated: Merge jdk16

[Jesper Wilhelmsson]

On Thu, 17 Dec 2020 20:38:45 GMT, Jesper Wilhelmsson  
wrote:

> Forwardport JDK 16 -> JDK 17

This pull request has now been integrated.

Changeset: f15528eb
Author:Jesper Wilhelmsson 
URL:   https://git.openjdk.java.net/jdk/commit/f15528eb
Stats: 773 lines in 63 files changed: 449 ins; 124 del; 200 mod

Merge

-

PR: https://git.openjdk.java.net/jdk/pull/1827

Integrated: Merge jdk16

[Jesper Wilhelmsson]

Forwardport JDK 16 -> JDK 17

-

Commit messages:
 - Merge
 - 8247994: Localize javadoc search
 - 8258515: javac should issue an error if an annotation is nested in a local 
class or interface
 - 8258225: compiler/c2/cr6340864/TestIntVect.java runs faster in interpreter
 - 8258293: tools/jpackage/share/RuntimePackageTest.java#id0 with 
RuntimePackageTest.testUsrInstallDir2
 - 8257621: JFR StringPool misses cached items across consecutive recordings
 - 8257999: Parallel GC crash in gc/parallel/TestDynShrinkHeap.java: new region 
is not in covered_region
 - 8257636: Update usage of "type" terminology in java.lang.Class and 
java.lang.reflect
 - 8258505: [TESTBUG] TestDivZeroWithSplitIf.java fails due to missing 
UnlockDiagnosticVMOptions
 - 8254023: A module declaration is not allowed to be a target of an annotation 
that lacks an @Target meta-annotation

The webrevs contain the adjustments done while merging with regards to each 
parent branch:
 - master: https://webrevs.openjdk.java.net/?repo=jdk&pr=1827&range=00.0
 - jdk16: https://webrevs.openjdk.java.net/?repo=jdk&pr=1827&range=00.1

Changes: https://git.openjdk.java.net/jdk/pull/1827/files
  Stats: 773 lines in 63 files changed: 449 ins; 124 del; 200 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1827.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1827/head:pull/1827

PR: https://git.openjdk.java.net/jdk/pull/1827

Re: RFR: 8257450: Start of release updates for JDK 17 [v2]

[Jesper Wilhelmsson]

On Mon, 7 Dec 2020 19:38:41 GMT, Joe Darcy  wrote:

>> Start of JDK 17 updates.
>
> Joe Darcy has updated the pull request with a new target base due to a merge 
> or a rebase. The incremental webrev excludes the unrelated changes brought in 
> by the merge/rebase. The pull request contains eight additional commits since 
> the last revision:
> 
>  - Merge branch 'master' into JDK-8257450
>  - Update tests.
>  - Merge branch 'master' into JDK-8257450
>  - Merge branch 'JDK-8257450' of https://github.com/jddarcy/jdk into 
> JDK-8257450
>  - Merge branch 'JDK-8257450' of https://github.com/jddarcy/jdk into 
> JDK-8257450
>  - JDK-8257450
>  - JDK-8257450
>  - JDK-8257450

Marked as reviewed by jwilhelm (Reviewer).

src/java.compiler/share/classes/javax/lang/model/SourceVersion.java line 234:

> 232:  * @since 17
> 233:  */
> 234: RELEASE_17;

Would it make sense to have a RELEASE_LATEST for the cases that are just 
updated to the latest release every six months?

-

PR: https://git.openjdk.java.net/jdk/pull/1531

Re: RFR: JDK-8241271 Make hotspot build reproducible

[Jesper Wilhelmsson]

Hotspot change looks good, and trivial.
/Jesper

> On 23 Mar 2020, at 09:45, Magnus Ihse Bursie  
> wrote:
> 
> On 2020-03-20 14:19, Stefan Karlsson wrote:
>> HotSpot changes look good.
> 
> Can I have a second hotspot reviewer on this, or a confirmation that it's 
> considered trivial?
> 
> /Magnus
>> 
>> StefanK
>> 
>> On 2020-03-20 14:15, Magnus Ihse Bursie wrote:
>>> Can I get some hotspot reviewers on this as well? And is this trivial, from 
>>> the Hotspot PoV?
>>> 
>>> /Magnus
>>> 
>>> On 2020-03-20 14:05, Erik Joelsson wrote:
 Looks good!
 
 /Erik
 
 On 2020-03-20 03:58, Magnus Ihse Bursie wrote:
> On 2020-03-19 19:01, Erik Joelsson wrote:
>> On 2020-03-19 10:20, Magnus Ihse Bursie wrote:
>>> Currently, it is not possible two make hotspot builds reproducible, 
>>> since the current date and time is always inserted using the special 
>>> macros __DATE__ and __TIME__. This patch makes it possible to override 
>>> these values from the build system, paving the way for making re-builds 
>>> of hotspot bit-by-bit identical.
>>> 
>> I like the ability to achieve this.
>>> On linux/gcc, we can now actually get bit-by-bit identical builds of 
>>> libjvm.so (if not using precompiled headers), so I've updated the 
>>> baseline-cmp profiles and compare script to reflect this.
>>> 
>> I'm not sure this is a good idea though. It means I can't reasonably 
>> compare to validate build changes that affect the precompiled header. 
>> Similarly, the COMPARE_BUILD make variable argument will not work unless 
>> you use both of these configure arguments.
>> 
>> Since compare.sh is generated through configure, perhaps these 
>> exceptions can be made conditional on if these configure arguments are 
>> setup correctly for a reproducible libjvm.so?
> 
> Good thinking! I did not think of this possibility. And yes, I too did 
> not like the current solution, but could think of no way around it. 
> Here's an improved webrev.
> 
> WebRev: 
> http://cr.openjdk.java.net/~ihse/JDK-8241271-make-hotspot-reproducible/webrev.02
> 
> Technically, you can make this fail by setting HOTSPOT_BUILD_TIME but to 
> different values, but hey, there's no need to make this idiot-proof.
> 
> /Magnus
>> 
>> /Erik
>> 
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8241271
>>> WebRev: 
>>> http://cr.openjdk.java.net/~ihse/JDK-8241271-make-hotspot-reproducible/webrev.01
>>> 
>>> /Magnus
> 
>>> 
>> 
> 

Re: RFR (xs): 8238515 - Backout JDK-8236092 from jdk/jdk

[Jesper Wilhelmsson]

Thank you David!
/Jesper

> On 5 Feb 2020, at 03:37, David Holmes  wrote:
> 
> Looks good and trivial.
> 
> Thanks,
> David
> 
> On 5/02/2020 12:36 pm, Jesper Wilhelmsson wrote:
>> Hi.
>> I need a review for this tiny change.
>> The "ea" suffix was removed from the JDK 14 version string with JDK-8236092. 
>> Since that change is forwardported to jdk/jdk I need to back it out there.
>> This is the backout diff as created by hg backout:
>> diff --git a/make/autoconf/version-numbers b/make/autoconf/version-numbers
>> --- a/make/autoconf/version-numbers
>> +++ b/make/autoconf/version-numbers
>> @@ -38,7 +38,7 @@
>> DEFAULT_VERSION_CLASSFILE_MINOR=0
>> DEFAULT_ACCEPTABLE_BOOT_VERSIONS="13 14 15"
>> DEFAULT_JDK_SOURCE_TARGET_VERSION=15
>> -DEFAULT_PROMOTED_VERSION_PRE=
>> +DEFAULT_PROMOTED_VERSION_PRE=ea
>> LAUNCHER_NAME=openjdk
>> PRODUCT_NAME=OpenJDK
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8238515
>> Thanks,
>> /Jesper

Re: RFR (xs): 8238515 - Backout JDK-8236092 from jdk/jdk

[Jesper Wilhelmsson]

Thank you Tim!
/Jesper

> On 5 Feb 2020, at 03:40, Tim Bell  wrote:
> 
> Jesper:
> 
> Looks good to me as well.
> 
> Tim
> 
> On 2/4/20 6:37 PM, David Holmes wrote:
>> Looks good and trivial.
>> Thanks,
>> David
>> On 5/02/2020 12:36 pm, Jesper Wilhelmsson wrote:
>>> Hi.
>>> 
>>> I need a review for this tiny change.
>>> The "ea" suffix was removed from the JDK 14 version string with 
>>> JDK-8236092. Since that change is forwardported to jdk/jdk I need to back 
>>> it out there.
>>> This is the backout diff as created by hg backout:
>>> 
>>> diff --git a/make/autoconf/version-numbers b/make/autoconf/version-numbers
>>> --- a/make/autoconf/version-numbers
>>> +++ b/make/autoconf/version-numbers
>>> @@ -38,7 +38,7 @@
>>> DEFAULT_VERSION_CLASSFILE_MINOR=0
>>> DEFAULT_ACCEPTABLE_BOOT_VERSIONS="13 14 15"
>>> DEFAULT_JDK_SOURCE_TARGET_VERSION=15
>>> -DEFAULT_PROMOTED_VERSION_PRE=
>>> +DEFAULT_PROMOTED_VERSION_PRE=ea
>>> LAUNCHER_NAME=openjdk
>>> PRODUCT_NAME=OpenJDK
>>> 
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8238515
>>> 
>>> Thanks,
>>> /Jesper
>>> 
> 

RFR (xs): 8238515 - Backout JDK-8236092 from jdk/jdk

[Jesper Wilhelmsson]

Hi.

I need a review for this tiny change.
The "ea" suffix was removed from the JDK 14 version string with JDK-8236092. 
Since that change is forwardported to jdk/jdk I need to back it out there.
This is the backout diff as created by hg backout:

diff --git a/make/autoconf/version-numbers b/make/autoconf/version-numbers
--- a/make/autoconf/version-numbers
+++ b/make/autoconf/version-numbers
@@ -38,7 +38,7 @@
DEFAULT_VERSION_CLASSFILE_MINOR=0
DEFAULT_ACCEPTABLE_BOOT_VERSIONS="13 14 15"
DEFAULT_JDK_SOURCE_TARGET_VERSION=15
-DEFAULT_PROMOTED_VERSION_PRE=
+DEFAULT_PROMOTED_VERSION_PRE=ea
LAUNCHER_NAME=openjdk
PRODUCT_NAME=OpenJDK

Bug: https://bugs.openjdk.java.net/browse/JDK-8238515

Thanks,
/Jesper

Re: RFR: JDK-8238281 Raise minimum gcc version needed to 5.0

[Jesper Wilhelmsson]

Looks good!

In a few comments you refer to the version with just the number 5. Would it be 
more correct to write 5.0?
(doc/building.html and doc/building.md)

/Jesper

> On 4 Feb 2020, at 22:48, Magnus Ihse Bursie  
> wrote:
> 
> Can I have one more hotspot reviewer, please?
> 
> /Magnus
> 
> On 2020-02-03 09:02, Magnus Ihse Bursie wrote:
>> JEP 347 "Adopt C++14 Language Features in HotSpot" (JDK-8208089) will 
>> require that all compilers support the C++14 language extension. The first 
>> gcc version to fully support C++14 is 5.0. We need to raise the bar from 4.8 
>> to 5.0.
>> 
>> Since removing support for old compilers, especially gcc, can be tricky to 
>> handle for some on old and odd setups, I think it's best to do this as a 
>> separate step from the C++14 upgrade.
>> 
>> On the way, this will allow us to remove some workarounds/close some bugs 
>> for really old gcc versions.
>> 
>> For hotspot, most notably this means:
>> 
>>  * The workarounds for no ATTRIBUTE_PRINTF are not needed anymore.
>> 
>> * The workaround for ATTRIBUTE_ALIGNED is no longer needed.
>> 
>> * The workaround in offset_of is not needed anymore. Instead, the 
>> appropriate warning is disabled. (In fact, now only xlc need special 
>> treatment for offset_of; if that could be fixed now, it would mean that 
>> offset_of can be replaced by offsetof in hotspot.)
>> 
>> * [Bug fix] The define CAN_USE_NAN_DEFINE (which is used only in 
>> share/runtime/sharedRuntimeTrans.cpp), is now always defined for gcc. This 
>> was previously done only for gcc >= 4.3 and < 5. I believe this was a bug, 
>> and the intention was to allow for old-style NaN behavior in gcc 4.2 and 
>> older.
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8238281
>> WebRev: 
>> http://cr.openjdk.java.net/~ihse/JDK-8238281-make-gcc-5-minimum/webrev.01
>> 
> 

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

[jesper . wilhelmsson]

Looks good to me.
/Jesper

> On 11 Jun 2018, at 22:42, Erik Joelsson  wrote:
> 
> Hello,
> 
> Based on the discussion here, I have reverted back to something more similar 
> to webrev.02, but with a few changes. Mainly fixing a bug that caused 
> JVM_FEATURES_hardened to not actually be the same as for server (if you have 
> custom additions in configure). I also added a check so that configure fails 
> if you try to enable either variant hardened or feature no-speculative-cti 
> and the flags aren't available.
> 
> Webrev: http://cr.openjdk.java.net/~erikj/8202384/webrev.05/index.html
> 
> /Erik
> 
> On 2018-06-11 00:10, Magnus Ihse Bursie wrote:
>> On 2018-06-08 23:50, Erik Joelsson wrote:
>>> On 2018-06-07 17:30, David Holmes wrote:
 On 8/06/2018 6:11 AM, Erik Joelsson wrote:
> I just don't think the extra work is warranted or should be prioritized 
> at this point. I also cannot think of a combination of options required 
> for what you are suggesting that wouldn't be confusing to the user. If 
> someone truly feels like these flags are forced on them and can't live 
> with them, we or preferably that person can fix it then. I don't think 
> that's dictatorship. OpenJDK is still open source and anyone can 
> contribute.
 
 I don't see why --enable-hardened-jdk and --enable-hardened-hotspot to add 
 to the right flags would be either complicated or confusing.
 
>>> For me the confusion surrounds the difference between 
>>> --enable-hardened-hotspot and --with-jvm-variants=server, hardened and 
>>> making the user understand it. But sure, it is doable. Here is a new webrev 
>>> with those two options as I interpret them. Here is the help text:
>>> 
>>>  --enable-hardened-jdk   enable hardenening compiler flags for all jdk
>>>   libraries (except the JVM), typically disabling
>>>   speculative cti. [disabled]
>>>  --enable-hardened-hotspot
>>>   enable hardenening compiler flags for hotspot (all
>>>   jvm variants), typically disabling speculative 
>>> cti.
>>>   To make hardening of hotspot a runtime choice,
>>>   consider the "hardened" jvm variant instead of 
>>> this
>>>   option. [disabled]
>>> 
>>> Note that this changes the default for jdk libraries to not enable 
>>> hardening unless the user requests it.
>>> 
>>> Webrev: http://cr.openjdk.java.net/~erikj/8202384/webrev.04/
>> 
>> Hold it, hold it! I'm not sure how we ended up here, but I don't like it at 
>> all. :-(
>> 
>> I think Eriks initial patch is much better than this. Some arguments in 
>> random order to defend this position:
>> 
>> 1) Why should we have a configure option to disable security relevant flags 
>> for the JDK, if there has been no measured negative effect? We don't do this 
>> for any other compiler flags, especially not security relevant ones!
>> 
>> I've re-read the entire thread to see if I could understand what could 
>> possibly motivate this, but the only thing I can find is David Holmes vague 
>> fear that these flags would not be well-tested enough. Let me counter with 
>> my own vague guesses: I believe the spectre mitigation methods to have been 
>> fully and properly tested, since they are rolled-out massively on all 
>> products. And let me complement with my own fear: the PR catastrophe if 
>> OpenJDK were *not* built with spectre mitigations, and someone were to 
>> exploit that!
>> 
>> In fact, I could even argue that "server" should be hardened *by default*, 
>> and that we should instead introduce a non-hardened JVM named something akin 
>> to "quick-but-dangerous-server" instead. But I realize that a 25% 
>> performance hit is hard to swallow, so I won't push this agenda.
>> 
>> 2) It is by no means clear that "--enable-hardened-jdk" does not harden all 
>> aspects of the JDK! If we should keep the option (which I definitely do not 
>> think we should!) it should be renamed to "--enable-hardened-libraries", or 
>> something like that. And it should be on by default, so it should be a 
>> "--disabled-hardened-jdk-libraries".
>> 
>> Also, the general-sounding name "hardened" sounds like it might encompass 
>> more things than it does. What if I disabled a hardened jdk build, should I 
>> still get stack banging protection? If so, you need to move a lot more 
>> security-related flags to this option. (And, just to be absolutely clear: I 
>> don't think you should do that.)
>> 
>> 3) Having two completely different ways of turning on Spectre protection for 
>> hotspot is just utterly confusing! This was a perfect example of how to use 
>> the JVM features, just as in the original patch.
>> 
>> If you want to have spectre mitigation enabled for both server and client, 
>> by default, you would just need to run "configure 
>> --with-jvm-variants=server,client --with-jvm-features=no-speculative-cti",

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

[jesper . wilhelmsson]

> On 6 Jun 2018, at 06:17, David Holmes  wrote:
> 
> Hi Erik, Jesper,
> 
> On 6/06/2018 2:59 AM, jesper.wilhelms...@oracle.com 
>  wrote:
>>> On 5 Jun 2018, at 08:10, David Holmes  wrote:
>>> 
>>> Sorry to be late to this party ...
>>> 
>>> On 5/06/2018 6:10 AM, Erik Joelsson wrote:
 New webrev: http://cr.openjdk.java.net/~erikj/8202384/webrev.02/
 Renamed the new jvm variant to "hardened".
>>> 
>>> As it is a hardened server build I'd prefer if that were somehow reflected 
>>> in the name. Though really I don't see why this should be restricted this 
>>> way ... to be honest I don't see hardened as a variant of server vs. client 
>>> vs. zero etc at all, you should be able to harden any of those.
>>> 
>>> So IIUC with this change we will:
>>> - always build JDK native code "hardened" (if toolchain supports it)
>>> - only build hotspot "hardened" if requested; and in that case
>>>  - jvm.cfg will list -server and -hardened with server as default
>>> 
>>> Is that right? I can see that we may choose to always build Oracle JDK this 
>>> way but it isn't clear to me that its suitable for OpenJDK. Nor why hotspot 
>>> is selectable but JDK is not. ??
>> Sorry for the lack of information here. There has been a lot of off-list 
>> discussions behind this change, I've added the background to the bug now.
>> The short version is that we see a ~25% regression in startup times if the 
>> JVM is compiled with the gcc flags to avoid speculative execution. We have 
>> not observed any performance regressions due to compiling the rest of the 
>> native libraries with these gcc flags, so there doesn't seem to be any 
>> reason to have different versions of other libraries.
> 
> So "benevolent dictatorship"?  ;-)
> 
> My main concern is that the updated toolchains that support this have all 
> been produced in a mad rush and quite frankly I expect them to be buggy. I 
> don't think it is hard to enable the builder of OpenJDK to have full choice 
> and control here.

My assumption has been, and still is, that we're not the only ones that will 
use gcc 7.3.0 with these flags. If there were bugs in the new code they would 
most likely have been found already. The experience from our own work in this 
area is that the bugs are unlikely to be crashes due to the new code, but 
rather weird corner cases where the new code is not inserted where it was 
needed, leaving speculative execution unblocked in that single case.

That said, I have no strong opinions on what is possible to configure in the 
build, as long as the Oracle OpenJDK builds comes with two JVM libraries and 
one copy of all other libraries. But that is of course a slightly different 
issue as long as it is possible to do.

Thanks,
/Jesper

> 
> Cheers,
> David
> 
>> /Jesper
>>> Sorry.
>>> 
>>> David
>>> -
>>> 
 /Erik
 On 2018-06-04 09:54, jesper.wilhelms...@oracle.com wrote:
>> On 4 Jun 2018, at 17:52, Erik Joelsson  wrote:
>> 
>> Hello,
>> 
>> On 2018-06-01 14:00, Aleksey Shipilev wrote:
>>> On 06/01/2018 10:53 PM, Erik Joelsson wrote:
 This patch defines flags for disabling speculative execution for GCC 
 and Visual Studio and applies
 them to all binaries except libjvm when available in the compiler. It 
 defines a new jvm feature
 no-speculative-cti, which is used to control whether to use the flags 
 for libjvm. It also defines a
 new jvm variant "altserver" which is the same as server, but with this 
 new feature added.
>>> I think the classic name for such product configuration is "hardened", 
>>> no?
>> I don't know. I'm open to suggestions on naming.
> "hardened" sounds good to me.
> 
> The change looks good as well.
> /Jesper
> 
>> /Erik
>>> -Aleksey

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

[jesper . wilhelmsson]

> On 5 Jun 2018, at 08:10, David Holmes  wrote:
> 
> Sorry to be late to this party ...
> 
> On 5/06/2018 6:10 AM, Erik Joelsson wrote:
>> New webrev: http://cr.openjdk.java.net/~erikj/8202384/webrev.02/
>> Renamed the new jvm variant to "hardened".
> 
> As it is a hardened server build I'd prefer if that were somehow reflected in 
> the name. Though really I don't see why this should be restricted this way 
> ... to be honest I don't see hardened as a variant of server vs. client vs. 
> zero etc at all, you should be able to harden any of those.
> 
> So IIUC with this change we will:
> - always build JDK native code "hardened" (if toolchain supports it)
> - only build hotspot "hardened" if requested; and in that case
>  - jvm.cfg will list -server and -hardened with server as default
> 
> Is that right? I can see that we may choose to always build Oracle JDK this 
> way but it isn't clear to me that its suitable for OpenJDK. Nor why hotspot 
> is selectable but JDK is not. ??

Sorry for the lack of information here. There has been a lot of off-list 
discussions behind this change, I've added the background to the bug now.

The short version is that we see a ~25% regression in startup times if the JVM 
is compiled with the gcc flags to avoid speculative execution. We have not 
observed any performance regressions due to compiling the rest of the native 
libraries with these gcc flags, so there doesn't seem to be any reason to have 
different versions of other libraries.

/Jesper

> Sorry.
> 
> David
> -
> 
>> /Erik
>> On 2018-06-04 09:54, jesper.wilhelms...@oracle.com wrote:
 On 4 Jun 2018, at 17:52, Erik Joelsson  wrote:
 
 Hello,
 
 On 2018-06-01 14:00, Aleksey Shipilev wrote:
> On 06/01/2018 10:53 PM, Erik Joelsson wrote:
>> This patch defines flags for disabling speculative execution for GCC and 
>> Visual Studio and applies
>> them to all binaries except libjvm when available in the compiler. It 
>> defines a new jvm feature
>> no-speculative-cti, which is used to control whether to use the flags 
>> for libjvm. It also defines a
>> new jvm variant "altserver" which is the same as server, but with this 
>> new feature added.
> I think the classic name for such product configuration is "hardened", no?
 I don't know. I'm open to suggestions on naming.
>>> "hardened" sounds good to me.
>>> 
>>> The change looks good as well.
>>> /Jesper
>>> 
 /Erik
> -Aleksey
> 

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

[jesper . wilhelmsson]

Looks good to me.
/Jesper

> On 4 Jun 2018, at 22:10, Erik Joelsson  wrote:
> 
> New webrev: http://cr.openjdk.java.net/~erikj/8202384/webrev.02/
> 
> Renamed the new jvm variant to "hardened".
> 
> /Erik
> 
> 
> On 2018-06-04 09:54, jesper.wilhelms...@oracle.com wrote:
>>> On 4 Jun 2018, at 17:52, Erik Joelsson  wrote:
>>> 
>>> Hello,
>>> 
>>> On 2018-06-01 14:00, Aleksey Shipilev wrote:
 On 06/01/2018 10:53 PM, Erik Joelsson wrote:
> This patch defines flags for disabling speculative execution for GCC and 
> Visual Studio and applies
> them to all binaries except libjvm when available in the compiler. It 
> defines a new jvm feature
> no-speculative-cti, which is used to control whether to use the flags for 
> libjvm. It also defines a
> new jvm variant "altserver" which is the same as server, but with this 
> new feature added.
 I think the classic name for such product configuration is "hardened", no?
>>> I don't know. I'm open to suggestions on naming.
>> "hardened" sounds good to me.
>> 
>> The change looks good as well.
>> /Jesper
>> 
>>> /Erik
 -Aleksey
 
> 

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

[jesper . wilhelmsson]

> On 4 Jun 2018, at 17:52, Erik Joelsson  wrote:
> 
> Hello,
> 
> On 2018-06-01 14:00, Aleksey Shipilev wrote:
>> On 06/01/2018 10:53 PM, Erik Joelsson wrote:
>>> This patch defines flags for disabling speculative execution for GCC and 
>>> Visual Studio and applies
>>> them to all binaries except libjvm when available in the compiler. It 
>>> defines a new jvm feature
>>> no-speculative-cti, which is used to control whether to use the flags for 
>>> libjvm. It also defines a
>>> new jvm variant "altserver" which is the same as server, but with this new 
>>> feature added.
>> I think the classic name for such product configuration is "hardened", no?
> I don't know. I'm open to suggestions on naming.

"hardened" sounds good to me.

The change looks good as well.
/Jesper

> 
> /Erik
>> -Aleksey
>> 
> 

Re: RFR(xs): 8193909: Obsolete(remove) Co-operative Memory Management (CMM)

[jesper . wilhelmsson]

Looks good!
/Jesper

> On 14 Feb 2018, at 22:45, sangheon.kim  wrote:
> 
> Hi all,
> 
> Could I have some reviews for CMM removal?
> This is closed CR but some public codes also need small modifications. This 
> CR is for removing stuff related to an Oracle JDK module/package.
> Changes are just removing CMM from lists or in a test to skip the testing 
> logic.
> 
> CR: https://bugs.openjdk.java.net/browse/JDK-8193909
> Webrev: http://cr.openjdk.java.net/~sangheki/8193909/webrev.0
> Testing: hs-tier1~5, jdk1~3, open/test/jdk:jdk_core
> 
> Thanks,
> Sangheon
> 

Re: RFR(xs): JDK-8190865 - Require jtreg 4.2 b10

[jesper . wilhelmsson]

Thanks!
/Jesper

> On 7 Nov 2017, at 18:05, Daniel D. Daugherty  
> wrote:
> 
> Thumbs up!
> 
> Dan
> 
> 
> On 11/7/17 11:56 AM, jesper.wilhelms...@oracle.com wrote:
>> Hi,
>> 
>> Please review this minor change to use the latest jtreg version in HotSpot 
>> testing.
>> This should get rid of the SocketTimeoutExceptions that we currently see in 
>> the HotSpot nightly.
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8190865 
>> 
>> 
>> Patch:
>> 
>> diff --git a/make/conf/jib-profiles.js b/make/conf/jib-profiles.js
>> --- a/make/conf/jib-profiles.js
>> +++ b/make/conf/jib-profiles.js
>> @@ -1060,7 +1060,7 @@
>>  jtreg: {
>>  server: "javare",
>>  revision: "4.2",
>> - build_number: "b09",
>> + build_number: "b10",
>>  checksum_file: "MD5_VALUES",
>>  file: "jtreg_bin-4.2.zip",
>>  environment_name: "JT_HOME",
>> 
>> Thanks,
>> /Jesper
>> 
> 

Re: RFR(xs): JDK-8190865 - Require jtreg 4.2 b10

[jesper . wilhelmsson]

Including build-dev.

> On 7 Nov 2017, at 17:56, jesper.wilhelms...@oracle.com wrote:
> 
> Hi,
> 
> Please review this minor change to use the latest jtreg version in HotSpot 
> testing.
> This should get rid of the SocketTimeoutExceptions that we currently see in 
> the HotSpot nightly.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8190865 
> 
> 
> Patch:
> 
> diff --git a/make/conf/jib-profiles.js b/make/conf/jib-profiles.js 
> --- a/make/conf/jib-profiles.js 
> +++ b/make/conf/jib-profiles.js 
> @@ -1060,7 +1060,7 @@ 
> jtreg: { 
> server: "javare", 
> revision: "4.2", 
> - build_number: "b09", 
> + build_number: "b10", 
> checksum_file: "MD5_VALUES", 
> file: "jtreg_bin-4.2.zip", 
> environment_name: "JT_HOME",
> 
> Thanks,
> /Jesper
> 

Re: C/C++ IDE support for HotSpot

[jesper . wilhelmsson]

Hi,

The project in common/nb_native/nbproject does not have a build configuration 
for Windows. The project itself should still be usable for browsing the code, 
but it might require some changes to make it build correctly. If you have a 
NetBeans / SolarisStudio installation on Windows and want to make the changes 
required to add a build configuration for Windows I'd be happy to sponsor the 
change.

Thanks,
/Jesper

> On 22 Mar 2017, at 18:34, Thomas Stüfe  wrote:
> 
> Hi Stanislav,
> 
> last time I checked, there was no support for netbeans on Windows, is that
> still the case?
> 
> Thanks, Thomas
> 
> On Wed, Mar 22, 2017 at 4:02 PM, Stanislav Smirnov <
> stanislav.smir...@oracle.com> wrote:
> 
>> Hi Mikael,
>> 
>> why do not you try NetBeans that has openjdk project support out of the
>> box?
>> common/nb_native/nbproject
>> 
>> Best regards,
>> Stanislav Smirnov
>> 
>> 
>> 
>> 
>> 
>>> On 22 Mar 2017, at 17:21, Mikael Gerdin 
>> wrote:
>>> 
>>> Hi all,
>>> 
>>> I've finally grown tired of manually setting up a hand crafted Eclipse
>> CDT configuration for the JVM sources and decided to share my progress
>> towards improving the overall situation for JVM developers.
>>> 
>>> To achieve better IDE support without having to add project generators
>> for all different kinds of past or future IDEs I've decided to try to
>> leverage CMake to do project generation.
>>> The idea is to have the JDK build system generate a CMakeLists.txt
>> describing all the include paths and definitions required by an IDE to
>> interpret the sources correctly.
>>> 
>>> Several modern IDEs natively support CMake but we can also rely on the
>> fact that the CMake build system has the ability to generate projects for a
>> number of different IDEs. For information about which generators CMake
>> supports see
>>> https://cmake.org/cmake/help/v3.5/manual/cmake-generators.7.html
>>> for your CMake version.
>>> 
>>> To try this out check out (heh) my branch "JDK-8177329-cmake-branch" in
>> the jdk10/sandbox forest:
>>> http://hg.openjdk.java.net/jdk10/sandbox/branches
>>> So far I've only made changes in the toplevel and hotspot repositories.
>>> I've written a short readme in the repo:
>>> http://hg.openjdk.java.net/jdk10/sandbox/raw-file/JDK-
>> 8177329-cmake-branch/README-cmake.html
>>> 
>>> It would be great if people tried this out to see if it works on their
>> setup but I don't expect it to work on Windows without changing the
>> makefile to do path conversion.
>>> If we can make this work properly then perhaps we can get rid of the
>> Visual Studio generator and rely on CMake to generate VS projects.
>>> 
>>> It would also be great if someone from build-dev could give me some
>> hints about how to do the file writing and "vardeps" thing properly.
>>> 
>>> Thanks
>>> /Mikael
>> 
>> 

Re: C/C++ IDE support for HotSpot

[jesper . wilhelmsson]

Hi,

I use the OpenJDK NetBeans project most of the time and am very happy with it. 
I still think Mikael's initiative is a very good one since I don't believe in 
forcing developers to use some specific tools, but rather think that we should 
make the OpenJDK code available to as many developers as possible regardless of 
their IDE preference.

The technology should adapt to humans, humans should not adapt to technology.

Thanks,
/Jesper

> On 22 Mar 2017, at 16:02, Stanislav Smirnov  
> wrote:
> 
> Hi Mikael,
> 
> why do not you try NetBeans that has openjdk project support out of the box?
> common/nb_native/nbproject
> 
> Best regards,
> Stanislav Smirnov
> 
> 
>> On 22 Mar 2017, at 17:21, Mikael Gerdin  wrote:
>> 
>> Hi all,
>> 
>> I've finally grown tired of manually setting up a hand crafted Eclipse CDT 
>> configuration for the JVM sources and decided to share my progress towards 
>> improving the overall situation for JVM developers.
>> 
>> To achieve better IDE support without having to add project generators for 
>> all different kinds of past or future IDEs I've decided to try to leverage 
>> CMake to do project generation.
>> The idea is to have the JDK build system generate a CMakeLists.txt 
>> describing all the include paths and definitions required by an IDE to 
>> interpret the sources correctly.
>> 
>> Several modern IDEs natively support CMake but we can also rely on the fact 
>> that the CMake build system has the ability to generate projects for a 
>> number of different IDEs. For information about which generators CMake 
>> supports see
>> https://cmake.org/cmake/help/v3.5/manual/cmake-generators.7.html
>> for your CMake version.
>> 
>> To try this out check out (heh) my branch "JDK-8177329-cmake-branch" in the 
>> jdk10/sandbox forest:
>> http://hg.openjdk.java.net/jdk10/sandbox/branches
>> So far I've only made changes in the toplevel and hotspot repositories.
>> I've written a short readme in the repo:
>> http://hg.openjdk.java.net/jdk10/sandbox/raw-file/JDK-8177329-cmake-branch/README-cmake.html
>> 
>> It would be great if people tried this out to see if it works on their setup 
>> but I don't expect it to work on Windows without changing the makefile to do 
>> path conversion.
>> If we can make this work properly then perhaps we can get rid of the Visual 
>> Studio generator and rely on CMake to generate VS projects.
>> 
>> It would also be great if someone from build-dev could give me some hints 
>> about how to do the file writing and "vardeps" thing properly.
>> 
>> Thanks
>> /Mikael
> 

Re: RFR: JDK-8028162 - Update Netbeans / Solaris Studio project files

[Jesper Wilhelmsson]

Hi Brad,

I use the DevStudio IDE [1] (which builds on top of NetBeans) as my default IDE 
and I use the project files for JVM development. I'm not sure exactly what your 
question is, but at least to me it is convenient to have the project already 
there, configured and ready to go every time I make a new clone of the JDK.


If you work on the JDK libraries the project won't be as useful. You can still 
browse and build of course, but symbol lookup is not configured properly for the 
Java source. That's why the project is called nb_native (native as in C++).
As far as I know there is currently no way to set up a project that works for 
both Java and C++.


/Jesper

[1] 
http://www.oracle.com/technetwork/server-storage/developerstudio/downloads/index-jsp-141149.html


Den 29/6/16 kl. 20:18, skrev Bradford Wetmore:

Jesper,

This is not a review comment, but could you tell us how these netbeans projects
are supposed to be used?  To do my JDK debugging, I usually create an exploded
JDK build using the normal make files, then in Netbeans created a new platform
that pointed at the build/*/jdk directory, then created a test file as a regular
project and assigned the just-created platform to it.  I can then run the test
and step through the JDK code, recompiling using an external make if I need to
iterate.  Very convenient.

What does this Netbeans project file do that I won't get with my current 
approach?

Brad


On 6/23/2016 3:55 PM, Jesper Wilhelmsson wrote:

Hi,

Please review this patch to update the NetBeans project files for JDK 9.
Several big changes in the code base (Jigsaw, GC restructuring, etc)
have made the old NBproject in need of an update.

Vladimir Kvashin in the Studio IDE team has kindly helped us to update
the project files on all platforms. I have reviewed the changes and used
the new project on Mac to verify that it works as expected.

I'm not sure if I'm a reviewer or a Reviewer in this part of the JDK
forest.
One more Reviewer is needed.

Webrev: http://cr.openjdk.java.net/~jwilhelm/8028162/webrev.01/

Bugs:
https://bugs.openjdk.java.net/browse/JDK-8028162
https://bugs.openjdk.java.net/browse/JDK-8028163
https://bugs.openjdk.java.net/browse/JDK-8028164


Thanks,
/Jesper

Re: RFR: JDK-8028162 - Update Netbeans / Solaris Studio project files

[Jesper Wilhelmsson]

Thanks Erik!
/Jesper

Den 27/6/16 kl. 11:37, skrev Erik Joelsson:

I'm not a Netbeans user so can't really verify that this works as intended. I'm
pretty sure the current project files don't work well at all however, so any
change to the better is likely good. Since changing the project files will not
affect the product or the build of it directly, I'm fine with this. Consider it
reviewed from the build group.

/Erik

On 2016-06-24 00:55, Jesper Wilhelmsson wrote:

Hi,

Please review this patch to update the NetBeans project files for JDK 9.
Several big changes in the code base (Jigsaw, GC restructuring, etc) have made
the old NBproject in need of an update.

Vladimir Kvashin in the Studio IDE team has kindly helped us to update the
project files on all platforms. I have reviewed the changes and used the new
project on Mac to verify that it works as expected.

I'm not sure if I'm a reviewer or a Reviewer in this part of the JDK forest.
One more Reviewer is needed.

Webrev: http://cr.openjdk.java.net/~jwilhelm/8028162/webrev.01/

Bugs:
https://bugs.openjdk.java.net/browse/JDK-8028162
https://bugs.openjdk.java.net/browse/JDK-8028163
https://bugs.openjdk.java.net/browse/JDK-8028164


Thanks,
/Jesper

RFR: JDK-8028162 - Update Netbeans / Solaris Studio project files

[Jesper Wilhelmsson]

Hi,

Please review this patch to update the NetBeans project files for JDK 9.
Several big changes in the code base (Jigsaw, GC restructuring, etc) have made 
the old NBproject in need of an update.


Vladimir Kvashin in the Studio IDE team has kindly helped us to update the 
project files on all platforms. I have reviewed the changes and used the new 
project on Mac to verify that it works as expected.


I'm not sure if I'm a reviewer or a Reviewer in this part of the JDK forest.
One more Reviewer is needed.

Webrev: http://cr.openjdk.java.net/~jwilhelm/8028162/webrev.01/

Bugs:
https://bugs.openjdk.java.net/browse/JDK-8028162
https://bugs.openjdk.java.net/browse/JDK-8028163
https://bugs.openjdk.java.net/browse/JDK-8028164


Thanks,
/Jesper

Re: RFR: 8159364: Gtest unit tests does not support PCH

[Jesper Wilhelmsson]

Looks good!
/Jesper


Den 14/6/16 kl. 11:50, skrev Erik Helin:

Hi all,

this patch adds support for pre-compiled headers (PCH) to the gtest unit
tests.

Bug:
https://bugs.openjdk.java.net/browse/JDK-8159364

Webrev:
http://cr.openjdk.java.net/~ehelin/8159364/00/

Testing:
- JPRT

Thanks,
Erik

Re: RFR: 8159340: Add extension to CompileGtest.gmk

[Jesper Wilhelmsson]

Looks good!
/Jesper


Den 14/6/16 kl. 11:27, skrev Erik Helin:

Hi all,

this small patch adds an extension to CompileGtest.gmk.

Bug:
https://bugs.openjdk.java.net/browse/JDK-8159340

Webrev:
http://cr.openjdk.java.net/~ehelin/8159340/00/

Testing:
- JPRT

Thanks,
Erik

Re: RFR: 8157325: gtest tests are not excluded for minimal builds

[Jesper Wilhelmsson]

Looks good!
/Jesper

Den 19/5/16 kl. 12:44, skrev Erik Helin:

Hi all,

this small patch ensures that the Makefiles correctly excludes gtest
unit tests for a minimal build. Right now, if you add a test to e.g.
hotspot/native/gc/g1, the test will be included in a minimal build,
which will fail.

Thanks to Erik Joelsson for helping out with this patch!

Bug:
https://bugs.openjdk.java.net/browse/JDK-8157325

Webrev:
http://cr.openjdk.java.net/~ehelin/8157325/webrev.00/

Testing:
- JPRT (with test in hotspot/native/gc/g1)
- Locally on Linux x86-64, both with and without a test in
  hotspot/native/gc/g1, both minimal and full build

Thanks,
Erik

Re: Add top-level Makefile target for running gtest

[Jesper Wilhelmsson]

Looks good!
/Jesper

Den 17/5/16 kl. 10:16, skrev Erik Helin:

Hi all,

this small patch adds a top-level Makefile target for conveniently
running the gtest unit tests.

Bug:
https://bugs.openjdk.java.net/browse/JDK-8157028

Webrev:
http://cr.openjdk.java.net/~ehelin/8157028/webrev.00/

Testing:
- Running locally on Linux x86-64

Thanks,
Erik

Re: RFR: 8149594 - Clean up Hotspot makefiles

[Jesper Wilhelmsson]

Den 11/2/16 kl. 03:07, skrev David Holmes:

Jesper,

Magnus is rewriting all of the hotspot build system. Are these cleanups really
worthwhile at this stage?


The cleanups are worthwhile to me since I work on mostly Mac and port all my 
changes over to the linux makefiles in bulk, and without these cleanups my 
patches won't apply cleanly. The reason I want to push them now even though it 
is a while left until the GTest stuff is done, is that every time anyone makes a 
change in the makefiles (which happens more often than I had expected) I get 
merge conflicts everywhere.

/Jesper



David

On 11/02/2016 8:10 AM, Jesper Wilhelmsson wrote:

Sending again to include the build-dev list.
/Jesper

Den 10/2/16 kl. 21:31, skrev Jesper Wilhelmsson:

Hi,

Please review this cleanup of the Hotspot makefiles.

Since I have been spending some time in the makefiles lately there
were a few
random cleanups that I couldn't stop myself from doing. Most of these
are made
to make the linux and bsd makefiles more alike. This has helped a lot
when
porting the framework to the different platforms.

There are a couple of preparing alignment changes that I included in this
cleanup to make the Google test patch easier to review later.

There are also a couple of "real" changes:

* In make/bsd/makefiles/buildtree.make we set up OS_VENDOR with the
motivation
that we don't include defs.make. Three lines below we include defs.make.

* In make/bsd/makefiles/buildtree.make the 'install' target depends on
'install_jsigs'. There is no rule called 'install_jsigs', it is called
'install_jsig'.


Another difference that I find interesting but that I have not changed
in this
patch (I can do that if requested) is that in the bsd version of
fastdebug.make
VERSION is set to "fastdebug" but in the linux version it is set to
"optimized".
Given the name of the makefile fastdebug seems more correct, but
whichever is
the correct value, shouldn't they be the same on linux and bsd?


https://bugs.openjdk.java.net/browse/JDK-8149594
http://cr.openjdk.java.net/~jwilhelm/8149594/webrev.00/

Thanks,
/Jesper

Re: RFR: 8149594 - Clean up Hotspot makefiles

[Jesper Wilhelmsson]

Hi Kim,

Thanks for looking at this!

Den 10/2/16 kl. 23:34, skrev Kim Barrett:

Den 10/2/16 kl. 21:31, skrev Jesper Wilhelmsson:

https://bugs.openjdk.java.net/browse/JDK-8149594
http://cr.openjdk.java.net/~jwilhelm/8149594/webrev.00/



--
I might have preferred two webrevs, one of only whitespace changes and
one of other changes.


Yes, I'll split it up in the next version if there is a need for it.


--
make/bsd/Makefile
make/linux/Makefile
  172 TARGETS  = debug fastdebug optimized product
...
  200 BUILDTREE= $(MAKE) -f $(BUILDTREE_MAKE) $(BUILDTREE_VARS)

If there's a non-whitespace change (increasing the separation between
the variables and the "=" or "+="), I couldn't find it.  I'm guessing
this is being done because the planned later changes introduce
something in here that leads to that reformatting?


Yes, this is one of those changes that is motivated by future changes. I wanted 
to separate this whitespace change from the actual change to make that one 
easier to review.




--
make/bsd/makefiles/gcc.make
  278 WARNING_FLAGS += -Wconversion

Oh, cool!  So we haven't been using that option after all!

Note: This is a "real change" that wasn't mentioned in the RFR.

I've been meaning to file a bug report against this for a while.  The
pre-gcc4.3 version of -Wconversion probably ought not be used in a
production context anyway.

https://gcc.gnu.org/wiki/NewWconversion
The old behavior for -Wconversion was intended to aid translation of
old C code to modern C standards by identifying places where adding
function prototypes may result in different behavior.  That's just not
an issue for C++, nor for our code in general.

And we're not prepared to use the new -Wconversion; see JDK-8135181.

So rather than changing our builds to actually use this option with
old compilers that Oracle doesn't support (so we can't locally test
this change), I suggest removing the option entirely, since it hasn't
actually been used anyway.


This typo was only present on bsd. Are you suggesting to remove it only on bsd, 
or on linux as well?




--
make/bsd/makefiles/jvmti.make
make/linux/makefiles/trace.make

The only non-copyright change in these files seem to be the addition
of a blank line to the end of the file.


Yes, this is to make the bsd and linux versions of the files the same. It makes 
it easier to apply patches from one platform to the other when porting stuff.




--
make/bsd/makefiles/top.make
   88 vm_build_preliminaries:  checks $(Cached_plat) $(AD_Files_If_Required) 
trace_stuff jvmti_stuff dtrace_stuff

What is the point of re-ordering trace_stuff and jvmti_stuff?


To make the bsd and linux versions the same.



Also, elsewhere the whitespace after the target's ":" is minimized,
but not here.


Oops. I'll fix that.
/Jesper




--

Re: RFR: 8149594 - Clean up Hotspot makefiles

[Jesper Wilhelmsson]

Sending again to include the build-dev list.
/Jesper

Den 10/2/16 kl. 21:31, skrev Jesper Wilhelmsson:

Hi,

Please review this cleanup of the Hotspot makefiles.

Since I have been spending some time in the makefiles lately there were a few
random cleanups that I couldn't stop myself from doing. Most of these are made
to make the linux and bsd makefiles more alike. This has helped a lot when
porting the framework to the different platforms.

There are a couple of preparing alignment changes that I included in this
cleanup to make the Google test patch easier to review later.

There are also a couple of "real" changes:

* In make/bsd/makefiles/buildtree.make we set up OS_VENDOR with the motivation
that we don't include defs.make. Three lines below we include defs.make.

* In make/bsd/makefiles/buildtree.make the 'install' target depends on
'install_jsigs'. There is no rule called 'install_jsigs', it is called
'install_jsig'.


Another difference that I find interesting but that I have not changed in this
patch (I can do that if requested) is that in the bsd version of fastdebug.make
VERSION is set to "fastdebug" but in the linux version it is set to "optimized".
Given the name of the makefile fastdebug seems more correct, but whichever is
the correct value, shouldn't they be the same on linux and bsd?


https://bugs.openjdk.java.net/browse/JDK-8149594
http://cr.openjdk.java.net/~jwilhelm/8149594/webrev.00/

Thanks,
/Jesper

Re: RFR: Forward port of 8055006 - Store original value of Min/MaxHeapFreeRatio

[Jesper Wilhelmsson]

For some reason my mail didn't make it to jdk-build-dev. I'm resending it and 
include build-dev this time, just in case.


Sorry for the noise!
/Jesper


Jesper Wilhelmsson skrev 20/9/14 19:16:

Hi all,

I got approvals for the HotSpot changes and they have now been pushed to
jdk9/hs-gc. For the JDK makefile change I would prefer if someone that feels
comfortable with the JDK makefiles would have a look at it before I push that 
part.

Thanks,
/Jesper

Jesper Wilhelmsson skrev 16/9/14 20:32:

Hi,

The fix for JDK-8055006 was reviewed by several engineers and was pushed
directly to 8u40 due to time constraints. This is a forward port to get the same
changes into JDK 9.

There are two webrevs, one for HotSpot and one for the JDK.

The 8u40 HotSpot change applied cleanly to 9 so if this was a traditional
backport it wouldn't require another review. But since this is a weird situation
and I'm pushing to 9 I'll ask for reviews just to be on the safe side.
Also, the original 8u40 push contained some unnecessary changes that was later
cleaned up by JDK-8056056. In this port to 9 I have merged these two changes
into one to avoid introducing a known issue only to remove it again.

The JDK change is new. The makefiles differ between 8u40 and 9 and this new
change makes use of functionality not present in 8u40. This patch was provided
by Erik Joelsson and I have reviewed it myself, but it needs two reviews so
another one is welcome.

Bug: https://bugs.openjdk.java.net/browse/JDK-8055006

Webrevs: http://cr.openjdk.java.net/~jwilhelm/8055006/jdk9/


8u40 Webrevs: http://cr.openjdk.java.net/~jwilhelm/8055006/

8u40 changes:
http://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot/rev/f933a15469d4
http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/312152328471

Bug and change for the second 8u40 fix:
https://bugs.openjdk.java.net/browse/JDK-8056056
http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/rev/9be4ca335650

Thanks!
/Jesper

Re: RFR(XS): 8056056 - Remove unnecessary inclusion of HS_ALT_MAKE from solaris Makefile

[Jesper Wilhelmsson]

Thanks David!
/Jesper

David Holmes skrev 5/9/14 13:22:

Looks good.

Thanks,
David

On 5/09/2014 8:47 AM, Jesper Wilhelmsson wrote:

Hi,

Looking for reviews for this small fix that removes the unnecessary
passing of HS_ALT_MAKE to buildtree.make from the Solaris Makefile. It
was recently added but is not needed since buildtree.make explicitly
includes defs.make where HS_ALT_MAKE is defined.

Webrev: http://cr.openjdk.java.net/~jwilhelm/8056056/webrev/

Bug: https://bugs.openjdk.java.net/browse/JDK-8056056

Thanks,
/Jesper

Re: RFR(XS): 8056056 - Remove unnecessary inclusion of HS_ALT_MAKE from solaris Makefile

[Jesper Wilhelmsson]

Thanks Erik!
/Jesper

Erik Joelsson skrev 5/9/14 11:47:

Looks good to me.

/Erik

On 2014-09-05 08:37, Jesper Wilhelmsson wrote:

I forgot to mention that this one is aiming for 8u40.
Thanks,
/Jesper

Jesper Wilhelmsson skrev 5/9/14 00:47:

Hi,

Looking for reviews for this small fix that removes the unnecessary passing of
HS_ALT_MAKE to buildtree.make from the Solaris Makefile. It was recently added
but is not needed since buildtree.make explicitly includes defs.make where
HS_ALT_MAKE is defined.

Webrev: http://cr.openjdk.java.net/~jwilhelm/8056056/webrev/

Bug: https://bugs.openjdk.java.net/browse/JDK-8056056

Thanks,
/Jesper

Re: RFR(XS): 8056056 - Remove unnecessary inclusion of HS_ALT_MAKE from solaris Makefile

[Jesper Wilhelmsson]

I forgot to mention that this one is aiming for 8u40.
Thanks,
/Jesper

Jesper Wilhelmsson skrev 5/9/14 00:47:

Hi,

Looking for reviews for this small fix that removes the unnecessary passing of
HS_ALT_MAKE to buildtree.make from the Solaris Makefile. It was recently added
but is not needed since buildtree.make explicitly includes defs.make where
HS_ALT_MAKE is defined.

Webrev: http://cr.openjdk.java.net/~jwilhelm/8056056/webrev/

Bug: https://bugs.openjdk.java.net/browse/JDK-8056056

Thanks,
/Jesper

RFR(XS): 8056056 - Remove unnecessary inclusion of HS_ALT_MAKE from solaris Makefile

[Jesper Wilhelmsson]

Hi,

Looking for reviews for this small fix that removes the unnecessary passing of 
HS_ALT_MAKE to buildtree.make from the Solaris Makefile. It was recently added 
but is not needed since buildtree.make explicitly includes defs.make where 
HS_ALT_MAKE is defined.


Webrev: http://cr.openjdk.java.net/~jwilhelm/8056056/webrev/

Bug: https://bugs.openjdk.java.net/browse/JDK-8056056

Thanks,
/Jesper

Re: RFR[P1]: 8055744 - 8u-dev nightly solaris builds failed on 08/20

[Jesper Wilhelmsson]

Hi David,

The change was pushed on Friday so it included the change in the Makefile. I 
filed JDK-8056056 to remove it.


Thanks!
/Jesper

David Holmes skrev 25/8/14 02:50:

Sorry I'm late but had a long weekend and was off last Friday.

On 22/08/2014 3:04 AM, Jesper Wilhelmsson wrote:

Thank you for the quick reply Dan!

A new webrev with your suggested change is available here:

http://cr.openjdk.java.net/~jwilhelm/8055744/webrev.02/


The change in make/solaris/Makefile isn't necessary. buildtree.make already
includes defs.make which defines HS_ALT_MAKE.

If this is already pushed please follow up with a correction. But don't push
this part of 8u.

Thanks,
David


/Jesper


Daniel D. Daugherty skrev 21/8/14 18:42:

On 8/21/14 10:19 AM, Jesper Wilhelmsson wrote:

Hi,

On Solaris the HS_ALT_MAKE variable was not passed to vm.make when
creating
the mapfiles which lead to mapfile-ext not being found and later a
linker
error due to symbols declared in the extra mapfile not being found.

The hotspot makefiles are .. interesting .. yes.

The proposed solution is to include defs.make where HS_ALT_MAKE is
set up into
vm.make on Solaris.


Webrev:
http://cr.openjdk.java.net/~jwilhelm/8055744/webrev/


Unfortunately, including defs.make in make/solaris/makefiles/vm.make
isn't the "right" way to get a top-level variable down into the
HotSpot build system. I cannot remember what breaks when you do that,
but it doesn't work right in all the ways that we build HotSpot.

For the HotSpot build system, you'll want to:

- update make/solaris/Makefile and add HS_ALT_MAKE to
   the BUILDTREE_VARS list:

   BUILDTREE_VARS += HS_ALT_MAKE=$(HS_ALT_MAKE)

- update make/solaris/makefiles/buildtree.make and add
   HS_ALT_MAKE to the rule that creates flags.make:

   [ -n "$(HS_ALT_MAKE)" ] && \
 echo && echo "HS_ALT_MAKE = $(HS_ALT_MAKE)"; \

The way I usually find all the right spots is I look for
where ZIPEXE is added to the above files and follow those
examples.

Dan






Bug:
https://bugs.openjdk.java.net/browse/JDK-8055744#comment-13542110

This is a P1 so if you feel comfortable with the hotspot makefiles,
please
have a look.

Thanks!
/Jesper

Re: RFR[P1]: 8055744 - 8u-dev nightly solaris builds failed on 08/20

[Jesper Wilhelmsson]

Thanks Erik!
/Jesper

Erik Joelsson skrev 22/8/14 13:02:

Hello,

Looks ok from me too.

/Erik

On 2014-08-21 19:43, Daniel D. Daugherty wrote:

> http://cr.openjdk.java.net/~jwilhelm/8055744/webrev.02/

make/solaris/Makefile
No comments.

make/solaris/makefiles/buildtree.make
No comments.

A product build with the above changes shows this:

$ cat solaris_amd64_compiler2/product/mapfile_ext

# Extended set of symbols.
JVM_SetVmMemoryPressure;

Looks right to me.

Dan


On 8/21/14 11:04 AM, Jesper Wilhelmsson wrote:

Thank you for the quick reply Dan!

A new webrev with your suggested change is available here:

http://cr.openjdk.java.net/~jwilhelm/8055744/webrev.02/

/Jesper


Daniel D. Daugherty skrev 21/8/14 18:42:

On 8/21/14 10:19 AM, Jesper Wilhelmsson wrote:

Hi,

On Solaris the HS_ALT_MAKE variable was not passed to vm.make when creating
the mapfiles which lead to mapfile-ext not being found and later a linker
error due to symbols declared in the extra mapfile not being found.

The hotspot makefiles are .. interesting .. yes.

The proposed solution is to include defs.make where HS_ALT_MAKE is set up into
vm.make on Solaris.


Webrev:
http://cr.openjdk.java.net/~jwilhelm/8055744/webrev/


Unfortunately, including defs.make in make/solaris/makefiles/vm.make
isn't the "right" way to get a top-level variable down into the
HotSpot build system. I cannot remember what breaks when you do that,
but it doesn't work right in all the ways that we build HotSpot.

For the HotSpot build system, you'll want to:

- update make/solaris/Makefile and add HS_ALT_MAKE to
   the BUILDTREE_VARS list:

   BUILDTREE_VARS += HS_ALT_MAKE=$(HS_ALT_MAKE)

- update make/solaris/makefiles/buildtree.make and add
   HS_ALT_MAKE to the rule that creates flags.make:

   [ -n "$(HS_ALT_MAKE)" ] && \
 echo && echo "HS_ALT_MAKE = $(HS_ALT_MAKE)"; \

The way I usually find all the right spots is I look for
where ZIPEXE is added to the above files and follow those
examples.

Dan






Bug:
https://bugs.openjdk.java.net/browse/JDK-8055744#comment-13542110

This is a P1 so if you feel comfortable with the hotspot makefiles, please
have a look.

Thanks!
/Jesper

Re: RFR[P1]: 8055744 - 8u-dev nightly solaris builds failed on 08/20

[Jesper Wilhelmsson]

Yep, that's how it's supposed to look :)
Thanks!
/Jesper


Daniel D. Daugherty skrev 21/8/14 19:43:

 > http://cr.openjdk.java.net/~jwilhelm/8055744/webrev.02/

make/solaris/Makefile
 No comments.

make/solaris/makefiles/buildtree.make
 No comments.

A product build with the above changes shows this:

$ cat solaris_amd64_compiler2/product/mapfile_ext

 # Extended set of symbols.
 JVM_SetVmMemoryPressure;

Looks right to me.

Dan


On 8/21/14 11:04 AM, Jesper Wilhelmsson wrote:

Thank you for the quick reply Dan!

A new webrev with your suggested change is available here:

http://cr.openjdk.java.net/~jwilhelm/8055744/webrev.02/

/Jesper


Daniel D. Daugherty skrev 21/8/14 18:42:

On 8/21/14 10:19 AM, Jesper Wilhelmsson wrote:

Hi,

On Solaris the HS_ALT_MAKE variable was not passed to vm.make when creating
the mapfiles which lead to mapfile-ext not being found and later a linker
error due to symbols declared in the extra mapfile not being found.

The hotspot makefiles are .. interesting .. yes.

The proposed solution is to include defs.make where HS_ALT_MAKE is set up into
vm.make on Solaris.


Webrev:
http://cr.openjdk.java.net/~jwilhelm/8055744/webrev/


Unfortunately, including defs.make in make/solaris/makefiles/vm.make
isn't the "right" way to get a top-level variable down into the
HotSpot build system. I cannot remember what breaks when you do that,
but it doesn't work right in all the ways that we build HotSpot.

For the HotSpot build system, you'll want to:

- update make/solaris/Makefile and add HS_ALT_MAKE to
   the BUILDTREE_VARS list:

   BUILDTREE_VARS += HS_ALT_MAKE=$(HS_ALT_MAKE)

- update make/solaris/makefiles/buildtree.make and add
   HS_ALT_MAKE to the rule that creates flags.make:

   [ -n "$(HS_ALT_MAKE)" ] && \
 echo && echo "HS_ALT_MAKE = $(HS_ALT_MAKE)"; \

The way I usually find all the right spots is I look for
where ZIPEXE is added to the above files and follow those
examples.

Dan






Bug:
https://bugs.openjdk.java.net/browse/JDK-8055744#comment-13542110

This is a P1 so if you feel comfortable with the hotspot makefiles, please
have a look.

Thanks!
/Jesper

Re: RFR[P1]: 8055744 - 8u-dev nightly solaris builds failed on 08/20

[Jesper Wilhelmsson]

Thank you for the quick reply Dan!

A new webrev with your suggested change is available here:

http://cr.openjdk.java.net/~jwilhelm/8055744/webrev.02/

/Jesper


Daniel D. Daugherty skrev 21/8/14 18:42:

On 8/21/14 10:19 AM, Jesper Wilhelmsson wrote:

Hi,

On Solaris the HS_ALT_MAKE variable was not passed to vm.make when creating
the mapfiles which lead to mapfile-ext not being found and later a linker
error due to symbols declared in the extra mapfile not being found.

The hotspot makefiles are .. interesting .. yes.

The proposed solution is to include defs.make where HS_ALT_MAKE is set up into
vm.make on Solaris.


Webrev:
http://cr.openjdk.java.net/~jwilhelm/8055744/webrev/


Unfortunately, including defs.make in make/solaris/makefiles/vm.make
isn't the "right" way to get a top-level variable down into the
HotSpot build system. I cannot remember what breaks when you do that,
but it doesn't work right in all the ways that we build HotSpot.

For the HotSpot build system, you'll want to:

- update make/solaris/Makefile and add HS_ALT_MAKE to
   the BUILDTREE_VARS list:

   BUILDTREE_VARS += HS_ALT_MAKE=$(HS_ALT_MAKE)

- update make/solaris/makefiles/buildtree.make and add
   HS_ALT_MAKE to the rule that creates flags.make:

   [ -n "$(HS_ALT_MAKE)" ] && \
 echo && echo "HS_ALT_MAKE = $(HS_ALT_MAKE)"; \

The way I usually find all the right spots is I look for
where ZIPEXE is added to the above files and follow those
examples.

Dan






Bug:
https://bugs.openjdk.java.net/browse/JDK-8055744#comment-13542110

This is a P1 so if you feel comfortable with the hotspot makefiles, please
have a look.

Thanks!
/Jesper

RFR[P1]: 8055744 - 8u-dev nightly solaris builds failed on 08/20

[Jesper Wilhelmsson]

Hi,

On Solaris the HS_ALT_MAKE variable was not passed to vm.make when creating the 
mapfiles which lead to mapfile-ext not being found and later a linker error due 
to symbols declared in the extra mapfile not being found.


The hotspot makefiles are .. interesting .. yes.

The proposed solution is to include defs.make where HS_ALT_MAKE is set up into 
vm.make on Solaris.



Webrev:
http://cr.openjdk.java.net/~jwilhelm/8055744/webrev/

Bug:
https://bugs.openjdk.java.net/browse/JDK-8055744#comment-13542110

This is a P1 so if you feel comfortable with the hotspot makefiles, please have 
a look.


Thanks!
/Jesper

Re: RFR: 8028162 - Update Netbeans / Solaris Studio project files on Mac

[Jesper Wilhelmsson]

Hi Magnus,

Magnus Ihse Bursie skrev 14/11/13 9:51 AM:

Hi Jesper,

I assume you wanted to post this to the build-dev list -- the build-infra-dev
was a project-based list used during active development of the new build system.


OK, thanks for forwarding.



As far as I can tell, the changes looks good. (But I'm not a formal reviewer)


Thanks! Do you know which repository is the most suitable to push this change? I 
can't go through hsx/hotspot-gc ;-)




Thinking long term, this file should probably be generated on the fly instead of
updated manually like this.


It is fairly automatic since Solaris Studio generates the files, but if it could 
be done by the make files it would of course be even better.

/Jesper



/Magnus

On 2013-11-12 13:56, Jesper Wilhelmsson wrote:

Hi,

Could I have a couple of reviews of the updated project files for NetBeans /
Solaris Studio.

This change updates the Mac part of the project files. I intend to do the same
change on linux as well but that will be a separate change. Then maybe someone
who has a Solaris box can update the Solaris part?

Bug: https://bugs.openjdk.java.net/browse/JDK-8028162

Webrev: http://cr.openjdk.java.net/~jwilhelm/8028162/webrev/

Looking at the diff you will see that all $SRC have been replaced by 0. This
was done automatically by Solaris Studio. I asked in the support forum if this
was correct, and apparently it was :-)

Forum: http://myforums.oracle.com/jive3/thread.jspa?threadID=1350319&tstart=0

Thanks,
/Jesper

Re: RFR: Project files for Solaris Studio / NetBeans

[Jesper Wilhelmsson]

Hi,

A new version of the project files are now available:

http://cr.openjdk.java.net/~jwilhelm/7074926/webrev.4/

A new platform was added, we now support Mac, Linux and Solaris.

The project was moved to /common/nb_native/nbproject/ to clearly indicate that 
this project only indexes the C++ part of OpenJDK.


Thanks for everyones comments!
/Jesper


Jesper Wilhelmsson skrev 27/3/13 5:04 PM:

Hi,

A new webrev is now available. The issues reported from the first review should
be fixed and the project now contains configurations for both Linux_64 and 
Mac_64.

To select configuration there is a dropdown menu next to the build button.

http://cr.openjdk.java.net/~jwilhelm/7074926/webrev.2/

Thanks,
/Jesper


Jesper Wilhelmsson skrev 25/3/13 5:29 PM:

Hi,

Sorry for cross posting, but I think this could be useful for several areas.

I would like to add Solaris Studio / NetBeans project files for the entire
OpenJDK project. To clarify: One project that contains the entire OpenJDK.


With the new build infrastructure in JDK 8 building the entire OpenJDK is fairly
fast and even though I personally mostly work in the HotSpot tree, I tend to
always clone and build the entire JDK forest. I find this to have several
benefits.

Webrev: http://cr.openjdk.java.net/~jwilhelm/7074926/webrev/

The configuration in this project is currently Mac only. Linux and Solaris
configurations are also planned.

The webrev is made from the jdk8/build repository which is where I think a
change like this should go in. Let me know if you think something else.



To use this project (once pushed):

1. Clone your favorite repository
hg clone http://hg.openjdk.java.net/hsx/hotspot-gc

2. Get the whole forest
cd hotspot-gc
sh get_source.sh

3. Configure
sh configure

4. Open Solaris studio / NetBeans and load the project.
The project in located in the common directory.


Thanks,
/Jesper