Re: [8u] RFR: 8210350: -Wl,-z,defs JDK 8 build failure

2018-09-20 Thread Erik Joelsson 

Looks good to me.

/Erik


On 2018-09-20 08:09, Severin Gehwolf wrote:

Hi,

Could someone please review this JDK 8u only change. When building with
extra linker flags, namely -Wl,-z,defs, the build fails on linux in the
serviciability agent. The reason for this is missing -ldl on the link
command. Note that JDK 9+ with the new build system have that already.
Thoughts?

Bug: https://bugs.openjdk.java.net/browse/JDK-8210350
webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210350/webrev.01/

Thanks,
Severin

[8u] RFR: 8210350: -Wl,-z,defs JDK 8 build failure

2018-09-20 Thread Severin Gehwolf 
Hi,

Could someone please review this JDK 8u only change. When building with
extra linker flags, namely -Wl,-z,defs, the build fails on linux in the
serviciability agent. The reason for this is missing -ldl on the link
command. Note that JDK 9+ with the new build system have that already.
Thoughts?

Bug: https://bugs.openjdk.java.net/browse/JDK-8210350
webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210350/webrev.01/

Thanks,
Severin