Code review request: 8031372 JDK 9 Specification-Version in jar files is still 1.8
Hi, I have a change that needs a review to the manifest.mf file for the Specification-Version from 1.8 to 1.9. This is needed as part of the build signing of crypto signed jar files. Being from the security side and not the build side of the openjdk world, if there is a better way to address this, please let me know. http://cr.openjdk.java.net/~ascarpino/8031372/webrev.00/ thanks Tony
Re: Code review request: 8031372 JDK 9 Specification-Version in jar files is still 1.8
On 09/01/2014 08:07, Anthony Scarpino wrote: Hi, I have a change that needs a review to the manifest.mf file for the Specification-Version from 1.8 to 1.9. This is needed as part of the build signing of crypto signed jar files. Being from the security side and not the build side of the openjdk world, if there is a better way to address this, please let me know. http://cr.openjdk.java.net/~ascarpino/8031372/webrev.00/ This looks right to me. As an aside, I think we should strike while the iron is hot and get the changes required to move major versions written down somewhere (maybe checked into the forest). I see Joe has updated the JDK_MINOR_VERSION, there was change required to jtreg, and probably a few other changes that. Having these tasks captured somewhere might make it easier the next time. -Alan
Re: Code review request: 8031372 JDK 9 Specification-Version in jar files is still 1.8
On 2014-01-09 09:34, Alan Bateman wrote: On 09/01/2014 08:07, Anthony Scarpino wrote: Hi, I have a change that needs a review to the manifest.mf file for the Specification-Version from 1.8 to 1.9. This is needed as part of the build signing of crypto signed jar files. Being from the security side and not the build side of the openjdk world, if there is a better way to address this, please let me know. http://cr.openjdk.java.net/~ascarpino/8031372/webrev.00/ This looks right to me. As an aside, I think we should strike while the iron is hot and get the changes required to move major versions written down somewhere (maybe checked into the forest). I see Joe has updated the JDK_MINOR_VERSION, there was change required to jtreg, and probably a few other changes that. Having these tasks captured somewhere might make it easier the next time. The patch looks good to me. For the future, is there a reason for not automatically generating the specification-version based on the version numbers we have, or at least move the definition of it to the version numbers file? /Erik
Re: Code review request: 8031372 JDK 9 Specification-Version in jar files is still 1.8
2014/1/8 16:47 -0800, erik.joels...@oracle.com: ... For the future, is there a reason for not automatically generating the specification-version based on the version numbers we have, or at least move the definition of it to the version numbers file? Excellent question. We should try to minimize the number of places where version numbers need to be changed. - Mark
Re: Code review request: 8031372 JDK 9 Specification-Version in jar files is still 1.8
On 1/9/2014 12:34 AM, Alan Bateman wrote: On 09/01/2014 08:07, Anthony Scarpino wrote: As an aside, I think we should strike while the iron is hot and get the changes required to move major versions written down somewhere (maybe checked into the forest). I see Joe has updated the JDK_MINOR_VERSION, there was change required to jtreg, and probably a few other changes that. Having these tasks captured somewhere might make it easier the next time. Agreed. See below. And Erik/Mark wrote: For the future, is there a reason for not automatically generating the specification-version based on the version numbers we have, or at least move the definition of it to the version numbers file? Excellent question. We should try to minimize the number of places where version numbers need to be changed. Just in case this suggestion gets forgotten, earlier this week, I added a few notes/links to JDK-8029942, the JDK 10 equivalent for JDK-8000962. JDK-8029942: Update JDK_MINOR_VERSION for JDK 10 JDK-8000962: Update JDK_MINOR_VERSION for JDK 9 If someone feels like including the bugid for JTREG changes, feel free to add it. If so, then we might want to change the synopsis to a more general Update build version values to JDK 10 instead of Update JDK_MINOR_VERSION for JDK 10. Brad
Re: Code review request: 8031372 JDK 9 Specification-Version in jar files is still 1.8
P.S. Forgot to mention, this looks good to me. Thanks for jumping in on this one. ;) Brad On 1/9/2014 12:07 AM, Anthony Scarpino wrote: Hi, I have a change that needs a review to the manifest.mf file for the Specification-Version from 1.8 to 1.9. This is needed as part of the build signing of crypto signed jar files. Being from the security side and not the build side of the openjdk world, if there is a better way to address this, please let me know. http://cr.openjdk.java.net/~ascarpino/8031372/webrev.00/ thanks Tony
