Re: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports

[Erik Joelsson]

Looks good.

/Erik

On 2019-11-18 15:28, Mikael Vidstedt wrote:

Please review this change which implements the changes for JEP 362: Deprecate 
the Solaris and SPARC Ports.

JBS: https://bugs.openjdk.java.net/browse/JDK-8234370
Webrev: 
http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.00/open/webrev/

I’ve tested that the expected error message is produced by default, and that 
running with --enable-deprecated-ports=yes produces a warning instead.

Cheers,
Mikael

Re: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports

[Mikael Vidstedt]

I noticed that most of the configure options include the default value in the 
help string (in brackets), so here’s an updated webrev which does exactly that:

Webrev: 
http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.01/open/webrev 

Webrev (incremental): 
http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.01.incr/open/webrev/ 


Cheers,
Mikael

> On Nov 20, 2019, at 7:47 AM, Erik Joelsson  wrote:
> 
> Looks good.
> 
> /Erik
> 
> On 2019-11-18 15:28, Mikael Vidstedt wrote:
>> Please review this change which implements the changes for JEP 362: 
>> Deprecate the Solaris and SPARC Ports.
>> 
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8234370
>> Webrev: 
>> http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.00/open/webrev/
>> 
>> I’ve tested that the expected error message is produced by default, and that 
>> running with --enable-deprecated-ports=yes produces a warning instead.
>> 
>> Cheers,
>> Mikael
>> 

Re: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports

[Erik Joelsson]

Looks good.

/Erik

On 2019-11-20 12:03, Mikael Vidstedt wrote:


I noticed that most of the configure options include the default value 
in the help string (in brackets), so here’s an updated webrev which 
does exactly that:


Webrev: 
http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.01/open/webrev
Webrev (incremental): 
http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.01.incr/open/webrev/


Cheers,
Mikael

On Nov 20, 2019, at 7:47 AM, Erik Joelsson > wrote:


Looks good.

/Erik

On 2019-11-18 15:28, Mikael Vidstedt wrote:
Please review this change which implements the changes for JEP 362: 
Deprecate the Solaris and SPARC Ports.


JBS: https://bugs.openjdk.java.net/browse/JDK-8234370
Webrev: 
http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.00/open/webrev/


I’ve tested that the expected error message is produced by default, 
and that running with --enable-deprecated-ports=yes produces a 
warning instead.


Cheers,
Mikael

Re: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports

[Tim Bell]

Mikael:

Looks good to me as well.

Tim

On 2019-11-22 06:10, Erik Joelsson wrote:

Looks good.

/Erik

On 2019-11-20 12:03, Mikael Vidstedt wrote:


I noticed that most of the configure options include the default value 
in the help string (in brackets), so here’s an updated webrev which 
does exactly that:


Webrev: 
http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.01/open/webrev
Webrev (incremental): 
http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.01.incr/open/webrev/ 



Cheers,
Mikael

On Nov 20, 2019, at 7:47 AM, Erik Joelsson > wrote:


Looks good.

/Erik

On 2019-11-18 15:28, Mikael Vidstedt wrote:
Please review this change which implements the changes for JEP 362: 
Deprecate the Solaris and SPARC Ports.


JBS: https://bugs.openjdk.java.net/browse/JDK-8234370
Webrev: 
http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.00/open/webrev/ 



I’ve tested that the expected error message is produced by default, 
and that running with --enable-deprecated-ports=yes produces a 
warning instead.


Cheers,
Mikael

Re: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports

[Mikael Vidstedt]

Erik/Tim, thanks for the reviews!

On more small change: Update building.md (and .html) to reflect the deprecation 
of the ports:

http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.02.incr/open/webrev/ 


Let me know if you think of other places where this should be reflected.

Cheers,
Mikael

> On Nov 22, 2019, at 6:17 AM, Tim Bell  wrote:
> 
> Mikael:
> 
> Looks good to me as well.
> 
> Tim
> 
> On 2019-11-22 06:10, Erik Joelsson wrote:
>> Looks good.
>> /Erik
>> On 2019-11-20 12:03, Mikael Vidstedt wrote:
>>> 
>>> I noticed that most of the configure options include the default value in 
>>> the help string (in brackets), so here’s an updated webrev which does 
>>> exactly that:
>>> 
>>> Webrev: 
>>> http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.01/open/webrev
>>> Webrev (incremental): 
>>> http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.01.incr/open/webrev/
>>>  
>>> 
>>> Cheers,
>>> Mikael
>>> 
 On Nov 20, 2019, at 7:47 AM, Erik Joelsson >>> > wrote:
 
 Looks good.
 
 /Erik
 
 On 2019-11-18 15:28, Mikael Vidstedt wrote:
> Please review this change which implements the changes for JEP 362: 
> Deprecate the Solaris and SPARC Ports.
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8234370
> Webrev: 
> http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.00/open/webrev/ 
> 
> I’ve tested that the expected error message is produced by default, and 
> that running with --enable-deprecated-ports=yes produces a warning 
> instead.
> 
> Cheers,
> Mikael
> 
>>> 
> 

Re: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports

[John Paul Adrian Glaubitz]

Hi!

On 11/22/19 8:01 PM, Mikael Vidstedt wrote:
> Erik/Tim, thanks for the reviews!
> 
> On more small change: Update building.md (and .html) to reflect the 
> deprecation of the ports:
> 
> http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.02.incr/open/webrev/
>  
> 
> 
> Let me know if you think of other places where this should be reflected.

Out of curiosity: With Oracle Solaris officially being supported until at
least 2034, does that mean the SPARC port of OpenJDK-11 will be maintained
until 2034 as well?

So far I don't understand the reasoning behind deprecating Solaris SPARC when
the platform has still official support until 2034. The last SPARC CPU was
the M8 which was released 2017.

Thanks,
Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

RE: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports

[Langer, Christoph]

Hi Mikael (or build folks),

after 8234370 was submitted, I recognize the following output for configure:

stdin:85: warning: AC_REQUIRE: `PLATFORM_EXTRACT_TARGET_AND_BUILD' was expanded 
before it was required
stdin:85: 
http://www.gnu.org/software/autoconf/manual/autoconf.html#Expanded-Before-Required
/.../jdk/make/autoconf/platform.m4:545: PLATFORM_SETUP_OPENJDK_BUILD_AND_TARGET 
is expanded from...
stdin:85: the top level

Would you mind to check (and fix?) this?
Shall I create a bug?

Thanks
Christoph


> -Original Message-
> From: build-dev  On Behalf Of
> Mikael Vidstedt
> Sent: Freitag, 22. November 2019 20:01
> To: build-dev 
> Subject: Re: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris
> and SPARC Ports
> 
> 
> Erik/Tim, thanks for the reviews!
> 
> On more small change: Update building.md (and .html) to reflect the
> deprecation of the ports:
> 
> http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.02.incr/open
> /webrev/
> <http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.02.incr/ope
> n/webrev/>
> 
> Let me know if you think of other places where this should be reflected.
> 
> Cheers,
> Mikael
> 
> > On Nov 22, 2019, at 6:17 AM, Tim Bell  wrote:
> >
> > Mikael:
> >
> > Looks good to me as well.
> >
> > Tim
> >
> > On 2019-11-22 06:10, Erik Joelsson wrote:
> >> Looks good.
> >> /Erik
> >> On 2019-11-20 12:03, Mikael Vidstedt wrote:
> >>>
> >>> I noticed that most of the configure options include the default value in
> the help string (in brackets), so here’s an updated webrev which does
> exactly that:
> >>>
> >>> Webrev:
> http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.01/open/we
> brev
> >>> Webrev (incremental):
> http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.01.incr/open
> /webrev/
> >>>
> >>> Cheers,
> >>> Mikael
> >>>
> >>>> On Nov 20, 2019, at 7:47 AM, Erik Joelsson  <mailto:erik.joels...@oracle.com>> wrote:
> >>>>
> >>>> Looks good.
> >>>>
> >>>> /Erik
> >>>>
> >>>> On 2019-11-18 15:28, Mikael Vidstedt wrote:
> >>>>> Please review this change which implements the changes for JEP 362:
> Deprecate the Solaris and SPARC Ports.
> >>>>>
> >>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8234370
> >>>>> Webrev:
> http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.00/open/we
> brev/
> >>>>>
> >>>>> I’ve tested that the expected error message is produced by default,
> and that running with --enable-deprecated-ports=yes produces a warning
> instead.
> >>>>>
> >>>>> Cheers,
> >>>>> Mikael
> >>>>>
> >>>
> >

Re: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports

[Mikael Vidstedt]

Christoph,

Thanks for reporting! I filed https://bugs.openjdk.java.net/browse/JDK-8235789 
<https://bugs.openjdk.java.net/browse/JDK-8235789> and will send out an RFR 
shortly.

Cheers,
Mikael

> On Dec 11, 2019, at 1:27 AM, Langer, Christoph  
> wrote:
> 
> Hi Mikael (or build folks),
> 
> after 8234370 was submitted, I recognize the following output for configure:
> 
> stdin:85: warning: AC_REQUIRE: `PLATFORM_EXTRACT_TARGET_AND_BUILD' was 
> expanded before it was required
> stdin:85: 
> http://www.gnu.org/software/autoconf/manual/autoconf.html#Expanded-Before-Required
> /.../jdk/make/autoconf/platform.m4:545: 
> PLATFORM_SETUP_OPENJDK_BUILD_AND_TARGET is expanded from...
> stdin:85: the top level
> 
> Would you mind to check (and fix?) this?
> Shall I create a bug?
> 
> Thanks
> Christoph
> 
> 
>> -Original Message-
>> From: build-dev  On Behalf Of
>> Mikael Vidstedt
>> Sent: Freitag, 22. November 2019 20:01
>> To: build-dev 
>> Subject: Re: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris
>> and SPARC Ports
>> 
>> 
>> Erik/Tim, thanks for the reviews!
>> 
>> On more small change: Update building.md (and .html) to reflect the
>> deprecation of the ports:
>> 
>> http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.02.incr/open
>> /webrev/
>> <http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.02.incr/ope
>> n/webrev/>
>> 
>> Let me know if you think of other places where this should be reflected.
>> 
>> Cheers,
>> Mikael
>> 
>>> On Nov 22, 2019, at 6:17 AM, Tim Bell  wrote:
>>> 
>>> Mikael:
>>> 
>>> Looks good to me as well.
>>> 
>>> Tim
>>> 
>>> On 2019-11-22 06:10, Erik Joelsson wrote:
>>>> Looks good.
>>>> /Erik
>>>> On 2019-11-20 12:03, Mikael Vidstedt wrote:
>>>>> 
>>>>> I noticed that most of the configure options include the default value in
>> the help string (in brackets), so here’s an updated webrev which does
>> exactly that:
>>>>> 
>>>>> Webrev:
>> http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.01/open/we
>> brev
>>>>> Webrev (incremental):
>> http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.01.incr/open
>> /webrev/
>>>>> 
>>>>> Cheers,
>>>>> Mikael
>>>>> 
>>>>>> On Nov 20, 2019, at 7:47 AM, Erik Joelsson > <mailto:erik.joels...@oracle.com>> wrote:
>>>>>> 
>>>>>> Looks good.
>>>>>> 
>>>>>> /Erik
>>>>>> 
>>>>>> On 2019-11-18 15:28, Mikael Vidstedt wrote:
>>>>>>> Please review this change which implements the changes for JEP 362:
>> Deprecate the Solaris and SPARC Ports.
>>>>>>> 
>>>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8234370
>>>>>>> Webrev:
>> http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.00/open/we
>> brev/
>>>>>>> 
>>>>>>> I’ve tested that the expected error message is produced by default,
>> and that running with --enable-deprecated-ports=yes produces a warning
>> instead.
>>>>>>> 
>>>>>>> Cheers,
>>>>>>> Mikael
>>>>>>> 
>>>>> 
>>> 
> 

RE: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports

[Langer, Christoph]

Hi Mikael,

thank you for fixing this.

Cheers
Christoph

From: Mikael Vidstedt 
Sent: Mittwoch, 11. Dezember 2019 20:31
To: Langer, Christoph 
Cc: build-dev 
Subject: Re: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and 
SPARC Ports


Christoph,

Thanks for reporting! I filed https://bugs.openjdk.java.net/browse/JDK-8235789 
and will send out an RFR shortly.

Cheers,
Mikael


On Dec 11, 2019, at 1:27 AM, Langer, Christoph 
mailto:christoph.lan...@sap.com>> wrote:

Hi Mikael (or build folks),

after 8234370 was submitted, I recognize the following output for configure:

stdin:85: warning: AC_REQUIRE: `PLATFORM_EXTRACT_TARGET_AND_BUILD' was expanded 
before it was required
stdin:85: 
http://www.gnu.org/software/autoconf/manual/autoconf.html#Expanded-Before-Required
/.../jdk/make/autoconf/platform.m4:545: PLATFORM_SETUP_OPENJDK_BUILD_AND_TARGET 
is expanded from...
stdin:85: the top level

Would you mind to check (and fix?) this?
Shall I create a bug?

Thanks
Christoph



-Original Message-
From: build-dev 
mailto:build-dev-boun...@openjdk.java.net>> 
On Behalf Of
Mikael Vidstedt
Sent: Freitag, 22. November 2019 20:01
To: build-dev mailto:build-dev@openjdk.java.net>>
Subject: Re: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris
and SPARC Ports


Erik/Tim, thanks for the reviews!

On more small change: Update building.md (and .html) to reflect the
deprecation of the ports:

http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.02.incr/open
/webrev/
<http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.02.incr/ope
n/webrev/<http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.02.incr/ope%0bn/webrev/>>

Let me know if you think of other places where this should be reflected.

Cheers,
Mikael


On Nov 22, 2019, at 6:17 AM, Tim Bell 
mailto:tim.b...@oracle.com>> wrote:

Mikael:

Looks good to me as well.

Tim

On 2019-11-22 06:10, Erik Joelsson wrote:

Looks good.
/Erik
On 2019-11-20 12:03, Mikael Vidstedt wrote:


I noticed that most of the configure options include the default value in
the help string (in brackets), so here’s an updated webrev which does
exactly that:


Webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.01/open/we
brev

Webrev (incremental):
http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.01.incr/open
/webrev/


Cheers,
Mikael


On Nov 20, 2019, at 7:47 AM, Erik Joelsson mailto:erik.joels...@oracle.com>> wrote:


Looks good.

/Erik

On 2019-11-18 15:28, Mikael Vidstedt wrote:

Please review this change which implements the changes for JEP 362:
Deprecate the Solaris and SPARC Ports.


JBS: https://bugs.openjdk.java.net/browse/JDK-8234370
Webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.00/open/we
brev/


I’ve tested that the expected error message is produced by default,
and that running with --enable-deprecated-ports=yes produces a warning
instead.


Cheers,
Mikael

Re: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports

[John Paul Adrian Glaubitz]

Hi!

The change for JDK-8234370 also triggers for Zero which is not correct.

It should trigger for the normal build only.

I will file a bug report.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Re: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports

[John Paul Adrian Glaubitz]

Hi!

On 12/15/19 10:13 AM, John Paul Adrian Glaubitz wrote:
> The change for JDK-8234370 also triggers for Zero which is not correct.
> 
> It should trigger for the normal build only.
> 
> I will file a bug report.

I have filed JDK-8235960 now, but I haven't managed to come up with a working 
fix
yet.

I tried both variants as below, but autoconf is failing me when I try to 
regenerate
configure.

Can anyone remind me what the proper way of regenerating the configure script is
these days?

Thanks,
Adrian

glaubitz@gcc202:~/jdk$ hg diff
diff -r eefd0a71c160 make/autoconf/platform.m4
--- a/make/autoconf/platform.m4 Sat Dec 14 13:50:34 2019 +0800
+++ b/make/autoconf/platform.m4 Sun Dec 15 12:46:47 2019 +0300
@@ -566,7 +566,7 @@
   AC_ARG_ENABLE(deprecated-ports, 
[AS_HELP_STRING([--enable-deprecated-ports@<:@=yes/no@:>@],
[Suppress the error when configuring for a deprecated port 
@<:@no@:>@])])
 
-  if test "x$OPENJDK_TARGET_OS" = xsolaris || test "x$OPENJDK_TARGET_CPU_ARCH" 
= xsparc; then
+  if test "x$OPENJDK_TARGET_OS" = xsolaris || test "x$OPENJDK_TARGET_CPU_ARCH" 
= xsparc && test "x$JVM_VARIANTS" != xzero; then
 if test "x$enable_deprecated_ports" = "xyes"; then
   AC_MSG_WARN([The Solaris and SPARC ports are deprecated and may be 
removed in a future release.])
 else
glaubitz@gcc202:~/jdk$

glaubitz@gcc202:~/jdk$ hg diff
diff -r eefd0a71c160 make/autoconf/platform.m4
--- a/make/autoconf/platform.m4 Sat Dec 14 13:50:34 2019 +0800
+++ b/make/autoconf/platform.m4 Sun Dec 15 12:47:35 2019 +0300
@@ -566,7 +566,7 @@
   AC_ARG_ENABLE(deprecated-ports, 
[AS_HELP_STRING([--enable-deprecated-ports@<:@=yes/no@:>@],
[Suppress the error when configuring for a deprecated port 
@<:@no@:>@])])
 
-  if test "x$OPENJDK_TARGET_OS" = xsolaris || test "x$OPENJDK_TARGET_CPU_ARCH" 
= xsparc; then
+  if test "x$OPENJDK_TARGET_OS" = xsolaris || test "x$OPENJDK_TARGET_CPU_ARCH" 
= xsparc && ! HOTSPOT_CHECK_JVM_VARIANT(zero); then
 if test "x$enable_deprecated_ports" = "xyes"; then
   AC_MSG_WARN([The Solaris and SPARC ports are deprecated and may be 
removed in a future release.])
 else
glaubitz@gcc202:~/jdk$

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Re: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports

[Martin Buchholz]

On Sun, Dec 15, 2019 at 1:49 AM John Paul Adrian Glaubitz <
glaub...@physik.fu-berlin.de> wrote:

>
> I tried both variants as below, but autoconf is failing me when I try to
> regenerate
> configure.
>

You didn't say how.


>
> Can anyone remind me what the proper way of regenerating the configure
> script is
> these days?
>

bulding.md says


The build system will detect if the Autoconf source files have changed, and
will trigger a regeneration of the generated script if needed. You can also
manually request such an update by `bash configure autogen`.

Re: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports

[John Paul Adrian Glaubitz]

Hi Martin!

On 12/15/19 5:07 PM, Martin Buchholz wrote:
> I tried both variants as below, but autoconf is failing me when I try to 
> regenerate
> configure.
> 
> 
> You didn't say how.
> (...)
> bulding.md says
> 
> 
> The build system will detect if the Autoconf source files have changed, and
> will trigger a regeneration of the generated script if needed. You can also
> manually request such an update by `bash configure autogen`.

Yep. Already figured out that my changes didn't work. I got it working now
and posted JDK-8235960 for review.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913