Re: RFC: Update test documentation by deleting "cd test && make"

2019-03-25 Thread Jing Tian 

Thanks Erik ,Tim and David for your review !

Thanks Leslie for your help !

Jing Tian

在 2019/3/26 5:30, David Holmes 写道:

Thanks Erik and Tim. Change pushed.

David

On 26/03/2019 1:57 am, Erik Joelsson wrote:

Looks good.

/Erik

On 2019-03-24 23:29, David Holmes wrote:

On 25/03/2019 4:23 pm, Jing Tian wrote:

Hi David,

Thanks for your review.

Could you please sponsor it for me?


Sure - once someone from the build team also gives the okay.

David


Thanks a lot.

Cheers,
JingTian

在 2019/3/25 11:59, David Holmes 写道:

Looks good to me!

Thanks,
David
-

On 25/03/2019 1:41 pm, Leslie Zhai wrote:

Hi David,

Webrev: http://cr.openjdk.java.net/~lzhai/8221357/webrev.01/

A patch by Jing Tian 
He also fixed two existing grammar issues.

Please review it.

Thanks,
Leslie Zhai

Re: RFC: Update test documentation by deleting "cd test && make"

2019-03-25 Thread David Holmes 

Thanks Erik and Tim. Change pushed.

David

On 26/03/2019 1:57 am, Erik Joelsson wrote:

Looks good.

/Erik

On 2019-03-24 23:29, David Holmes wrote:

On 25/03/2019 4:23 pm, Jing Tian wrote:

Hi David,

Thanks for your review.

Could you please sponsor it for me?


Sure - once someone from the build team also gives the okay.

David


Thanks a lot.

Cheers,
JingTian

在 2019/3/25 11:59, David Holmes 写道:

Looks good to me!

Thanks,
David
-

On 25/03/2019 1:41 pm, Leslie Zhai wrote:

Hi David,

Webrev: http://cr.openjdk.java.net/~lzhai/8221357/webrev.01/

A patch by Jing Tian 
He also fixed two existing grammar issues.

Please review it.

Thanks,
Leslie Zhai

Re: RFC: Update test documentation by deleting "cd test && make"

2019-03-25 Thread Erik Joelsson 

Looks good.

/Erik

On 2019-03-24 23:29, David Holmes wrote:

On 25/03/2019 4:23 pm, Jing Tian wrote:

Hi David,

Thanks for your review.

Could you please sponsor it for me?


Sure - once someone from the build team also gives the okay.

David


Thanks a lot.

Cheers,
JingTian

在 2019/3/25 11:59, David Holmes 写道:

Looks good to me!

Thanks,
David
-

On 25/03/2019 1:41 pm, Leslie Zhai wrote:

Hi David,

Webrev: http://cr.openjdk.java.net/~lzhai/8221357/webrev.01/

A patch by Jing Tian 
He also fixed two existing grammar issues.

Please review it.

Thanks,
Leslie Zhai

Re: RFC: Update test documentation by deleting "cd test && make"

2019-03-25 Thread Tim Bell 

David, JingTian, Leslie Zhai:


On 25/03/2019 4:23 pm, Jing Tian wrote:

Hi David,

Thanks for your review.

Could you please sponsor it for me?


Sure - once someone from the build team also gives the okay.


Looks good to me.

Tim



David


Thanks a lot.

Cheers,
JingTian

在 2019/3/25 11:59, David Holmes 写道:

Looks good to me!

Thanks,
David
-

On 25/03/2019 1:41 pm, Leslie Zhai wrote:

Hi David,

Webrev: http://cr.openjdk.java.net/~lzhai/8221357/webrev.01/

A patch by Jing Tian 
He also fixed two existing grammar issues.

Please review it.

Thanks,
Leslie Zhai

Re: RFC: Update test documentation by deleting "cd test && make"

2019-03-25 Thread David Holmes 

On 25/03/2019 4:23 pm, Jing Tian wrote:

Hi David,

Thanks for your review.

Could you please sponsor it for me?


Sure - once someone from the build team also gives the okay.

David


Thanks a lot.

Cheers,
JingTian

在 2019/3/25 11:59, David Holmes 写道:

Looks good to me!

Thanks,
David
-

On 25/03/2019 1:41 pm, Leslie Zhai wrote:

Hi David,

Webrev: http://cr.openjdk.java.net/~lzhai/8221357/webrev.01/

A patch by Jing Tian 
He also fixed two existing grammar issues.

Please review it.

Thanks,
Leslie Zhai

Re: RFC: Update test documentation by deleting "cd test && make"

2019-03-25 Thread Jing Tian 

Hi David,

Thanks for your review.

Could you please sponsor it for me?
Thanks a lot.

Cheers,
JingTian

在 2019/3/25 11:59, David Holmes 写道:

Looks good to me!

Thanks,
David
-

On 25/03/2019 1:41 pm, Leslie Zhai wrote:

Hi David,

Webrev: http://cr.openjdk.java.net/~lzhai/8221357/webrev.01/

A patch by Jing Tian 
He also fixed two existing grammar issues.

Please review it.

Thanks,
Leslie Zhai

Re: RFC: Update test documentation by deleting "cd test && make"

2019-03-24 Thread David Holmes 

Looks good to me!

Thanks,
David
-

On 25/03/2019 1:41 pm, Leslie Zhai wrote:

Hi David,

Webrev: http://cr.openjdk.java.net/~lzhai/8221357/webrev.01/

A patch by Jing Tian 
He also fixed two existing grammar issues.

Please review it.

Thanks,
Leslie Zhai

Re: RFC: Update test documentation by deleting "cd test && make"

2019-03-24 Thread Leslie Zhai 

Hi David,

Webrev: http://cr.openjdk.java.net/~lzhai/8221357/webrev.01/

A patch by Jing Tian 
He also fixed two existing grammar issues.

Please review it.

Thanks,
Leslie Zhai

Re: RFC: Update test documentation by deleting "cd test && make"

2019-03-24 Thread Leslie Zhai 

Hi David,

Thanks for your kind response!

> Webrev: http://cr.openjdk.java.net/~lzhai/8221357/webrev.00/

A patch by Jing Tian 
I just help him to host his patch on my cr.openjdk.java.net.

> That seems fine to me. Could I ask you to also fix two existing 
grammar issues...


Thanks for your review!  @Jing Tian  please fix the issue.

Thanks,
Leslie Zhai

Re: RFC: Update test documentation by deleting "cd test && make"

2019-03-24 Thread David Holmes 

Hi Leslie,

On 23/03/2019 12:21 pm, Leslie Zhai wrote:

Hi,

JBS: https://bugs.openjdk.java.net/browse/JDK-8221357

Webrev: http://cr.openjdk.java.net/~lzhai/8221357/webrev.00/


That seems fine to me. Could I ask you to also fix two existing grammar 
issues in the first line please:


  Previously, `make test` was used invoke an old system for running 
test, and


s/used/used to/

s/test,/tests,/

Thanks,
David


Cheers,

Leslie Zhai


在 2019年03月22日 15:10, jingtian 写道:

Hi,

`cd test && make` is not supported any more.

It might be better to update  jdk/doc .

Cheers,
JingTian

Re: RFC: Update test documentation by deleting "cd test && make"

2019-03-22 Thread Leslie Zhai 

Hi,

JBS: https://bugs.openjdk.java.net/browse/JDK-8221357

Webrev: http://cr.openjdk.java.net/~lzhai/8221357/webrev.00/

Cheers,

Leslie Zhai


在 2019年03月22日 15:10, jingtian 写道:

Hi,

`cd test && make` is not supported any more.

It might be better to update  jdk/doc .

Cheers,
JingTian

RFC: Update test documentation by deleting "cd test && make"

2019-03-22 Thread jingtian 

Hi,

`cd test && make` is not supported any more.

It might be better to update  jdk/doc .

Cheers,
JingTian