Re: RFR: 8011347: JDK-8009824 has broken webrev with some ksh versions

[Daniel Fuchs]

On 4/16/13 5:02 PM, Jim Gish wrote:

I've updated the version to 24.0 and add Mike as a reviewer.  Could
someone please push this for me?


Hi Jim,

Done.

Thanks for the fix!

-- daniel



Thanks,
 Jim

On 04/15/2013 06:34 PM, Mike Duigou wrote:

I think the version number needs to be changed. My vote is to bump it
to 24.0

Mike

On Apr 12 2013, at 11:08 , Jim Gish wrote:


Please review http://cr.openjdk.java.net/~jgish/Bug8011347-webrev/
, which fixes
the current webrev issues on solaris and mac.

Thanks,
   Jim

--
Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
Oracle Java Platform Group | Core Libraries Team
35 Network Drive
Burlington, MA 01803
jim.g...@oracle.com

Re: RFR: 8011347: JDK-8009824 has broken webrev with some ksh versions

[Daniel Fuchs]

On 4/16/13 5:02 PM, Jim Gish wrote:

I've updated the version to 24.0 and add Mike as a reviewer.  Could
someone please push this for me?


Hi Jim,

I think you will need to update the bug id in your comment:

http://cr.openjdk.java.net/~jgish/Bug8011347-webrev/tl.changeset

8009824: JDK-8009824 has broken webrev with some ksh versions
^^^

shouldn't that be 8011347 ?

-- daniel




Thanks,
 Jim

On 04/15/2013 06:34 PM, Mike Duigou wrote:

I think the version number needs to be changed. My vote is to bump it
to 24.0

Mike

On Apr 12 2013, at 11:08 , Jim Gish wrote:


Please review http://cr.openjdk.java.net/~jgish/Bug8011347-webrev/
, which fixes
the current webrev issues on solaris and mac.

Thanks,
   Jim

--
Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
Oracle Java Platform Group | Core Libraries Team
35 Network Drive
Burlington, MA 01803
jim.g...@oracle.com

Re: RFR: 8011347: JDK-8009824 has broken webrev with some ksh versions

[Jim Gish]

I've updated the version to 24.0 and add Mike as a reviewer.  Could 
someone please push this for me?


Thanks,
Jim

On 04/15/2013 06:34 PM, Mike Duigou wrote:

I think the version number needs to be changed. My vote is to bump it to 24.0

Mike

On Apr 12 2013, at 11:08 , Jim Gish wrote:


Please review http://cr.openjdk.java.net/~jgish/Bug8011347-webrev/ 
, which fixes the 
current webrev issues on solaris and mac.

Thanks,
   Jim

--
Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
Oracle Java Platform Group | Core Libraries Team
35 Network Drive
Burlington, MA 01803
jim.g...@oracle.com



--
Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
Oracle Java Platform Group | Core Libraries Team
35 Network Drive
Burlington, MA 01803
jim.g...@oracle.com

Re: RFR: 8011347: JDK-8009824 has broken webrev with some ksh versions

[Mike Duigou]

I think the version number needs to be changed. My vote is to bump it to 24.0

Mike

On Apr 12 2013, at 11:08 , Jim Gish wrote:

> Please review http://cr.openjdk.java.net/~jgish/Bug8011347-webrev/ 
> , which fixes the 
> current webrev issues on solaris and mac.
> 
> Thanks,
>   Jim
> 
> -- 
> Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
> Oracle Java Platform Group | Core Libraries Team
> 35 Network Drive
> Burlington, MA 01803
> jim.g...@oracle.com
> 

Re: RFR: 8011347: JDK-8009824 has broken webrev with some ksh versions

[Daniel Fuchs]

Hi Jim,

I had a look at your changes and they looked fine.
I imported the changeset on my Mac and it worked like a charm.

Thanks for the fix!

-- daniel
PS: I am not a JDK reviewer.

On 4/12/13 8:08 PM, Jim Gish wrote:

Please review http://cr.openjdk.java.net/~jgish/Bug8011347-webrev/
, which fixes
the current webrev issues on solaris and mac.

Thanks,
Jim

RFR: 8011347: JDK-8009824 has broken webrev with some ksh versions

[Jim Gish]

Please review http://cr.openjdk.java.net/~jgish/Bug8011347-webrev/ 
, which fixes 
the current webrev issues on solaris and mac.


Thanks,
   Jim

--
Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
Oracle Java Platform Group | Core Libraries Team
35 Network Drive
Burlington, MA 01803
jim.g...@oracle.com