Re: RFR: 8157605 Can't set both CONCURRENCY and EXTRA_JTREG_OPTIONS when running tests

2016-05-24 Thread Staffan Larsen 
Thanks!

> On 24 maj 2016, at 11:58, Erik Joelsson  wrote:
> 
> Looks good.
> 
> /Erik
> 
> On 2016-05-23 20:14, Staffan Larsen wrote:
>> This does not work:
>> 
>> $ cd test
>> $ make jtreg_tests CONCURRENCY=10 EXTRA_JTREG_OPTIONS=-k:\!headful
>> 
>> I can specify either CONCURRENCY or EXTRA_JTREG_OPTIONS, but not both.
>> 
>> Please review the fix below:
>> 
>> bug: https://bugs.openjdk.java.net/browse/JDK-8157605 
>> 
>> webrev: http://cr.openjdk.java.net/~sla/8157605/webrev.00/ 
>> 
>> 
>> Thanks,
>> /Staffan
>

Re: RFR: 8157605 Can't set both CONCURRENCY and EXTRA_JTREG_OPTIONS when running tests

2016-05-24 Thread Erik Joelsson 

Looks good.

/Erik

On 2016-05-23 20:14, Staffan Larsen wrote:

This does not work:

$ cd test
$ make jtreg_tests CONCURRENCY=10 EXTRA_JTREG_OPTIONS=-k:\!headful

I can specify either CONCURRENCY or EXTRA_JTREG_OPTIONS, but not both.

Please review the fix below:

bug: https://bugs.openjdk.java.net/browse/JDK-8157605 

webrev: http://cr.openjdk.java.net/~sla/8157605/webrev.00/ 


Thanks,
/Staffan

Re: RFR: 8157605 Can't set both CONCURRENCY and EXTRA_JTREG_OPTIONS when running tests

2016-05-24 Thread Staffan Larsen 
Thanks Tim!

> On 24 maj 2016, at 03:46, Tim Bell  wrote:
> 
> Staffan:
> 
>> This does not work:
>> 
>> $ cd test
>> $ make jtreg_tests CONCURRENCY=10 EXTRA_JTREG_OPTIONS=-k:\!headful
>> 
>> I can specify either CONCURRENCY or EXTRA_JTREG_OPTIONS, but not both.
>> 
>> Please review the fix below:
>> 
>> bug: https://bugs.openjdk.java.net/browse/JDK-8157605 
>> 
>> webrev: http://cr.openjdk.java.net/~sla/8157605/webrev.00/ 
>> 
> 
> Looks good to me.
> 
> Tim
>

Re: RFR: 8157605 Can't set both CONCURRENCY and EXTRA_JTREG_OPTIONS when running tests

2016-05-23 Thread Jonathan Gibbons 
It seems anomalous that langtools is missing, but perhaps that's a 
different problem.


-- Jon

On 05/23/2016 11:14 AM, Staffan Larsen wrote:

This does not work:

$ cd test
$ make jtreg_tests CONCURRENCY=10 EXTRA_JTREG_OPTIONS=-k:\!headful

I can specify either CONCURRENCY or EXTRA_JTREG_OPTIONS, but not both.

Please review the fix below:

bug: https://bugs.openjdk.java.net/browse/JDK-8157605 

webrev: http://cr.openjdk.java.net/~sla/8157605/webrev.00/ 


Thanks,
/Staffan

Re: RFR: 8157605 Can't set both CONCURRENCY and EXTRA_JTREG_OPTIONS when running tests

2016-05-23 Thread Tim Bell 

Staffan:


This does not work:

$ cd test
$ make jtreg_tests CONCURRENCY=10 EXTRA_JTREG_OPTIONS=-k:\!headful

I can specify either CONCURRENCY or EXTRA_JTREG_OPTIONS, but not both.

Please review the fix below:

bug: https://bugs.openjdk.java.net/browse/JDK-8157605 

webrev: http://cr.openjdk.java.net/~sla/8157605/webrev.00/ 



Looks good to me.

Tim

RFR: 8157605 Can't set both CONCURRENCY and EXTRA_JTREG_OPTIONS when running tests

2016-05-23 Thread Staffan Larsen 
This does not work: 

$ cd test 
$ make jtreg_tests CONCURRENCY=10 EXTRA_JTREG_OPTIONS=-k:\!headful 

I can specify either CONCURRENCY or EXTRA_JTREG_OPTIONS, but not both.

Please review the fix below:

bug: https://bugs.openjdk.java.net/browse/JDK-8157605 

webrev: http://cr.openjdk.java.net/~sla/8157605/webrev.00/ 


Thanks,
/Staffan