Re: RFR: 8165440: Add zero support for x86_64-linux-gnux32 target
You’re right, sorry. I haven’t been around OpenJDK for some weeks and forgot about posting to build-dev when posting. I will push in around 2-3 hours, currently on a train. Adrian > On Sep 5, 2018, at 9:05 AM, Magnus Ihse Bursie > wrote: > >> On 2018-09-04 23:29, David Holmes wrote: >> Hi Adrian, >> >> All changes that touch the build system must be reviewed by build-dev - now >> cc'd. > This has been discussed at some length in build-dev. But I agree, it's good > that also the actual RFR is cc:ed here. > > The patch, unsurprisingly, LGTM. > > /Magnus > >> >> These changes seem reasonable, though I don't like adding changes in source >> code for such an obscure (and unsupported!) platform. >> >> David >> >>> On 5/09/2018 3:45 AM, John Paul Adrian Glaubitz wrote: >>> Hi! >>> >>> This rather small change adds build support for the x86_64-linux-gnux32 >>> target. x32 is a variant of the x86_64 ABI with 64-bit registers and amd64 >>> instruction set but 32-bit pointers [1]. >>> >>> One of the Linux distributions supporting x32 is Debian, see [2]. The >>> port is not official, but the large majority of packages build fine >>> and the toolchain is in good shape. Another distribution supporting >>> x32 is Gentoo. >>> >>> Please review the change in [3]. I have changed the original patch >>> a bit that Debian uses downstream to make the changes more consistent >>> and cleaner. >>> >>> Thanks, >>> Adrian >>> [1] https://en.wikipedia.org/wiki/X32_ABI [2] http://debian-x32.org/ [2] http://cr.openjdk.java.net/~glaubitz/8165440/webrev.00/ >>> >
Re: RFR: 8165440: Add zero support for x86_64-linux-gnux32 target
On 2018-09-04 23:29, David Holmes wrote: Hi Adrian, All changes that touch the build system must be reviewed by build-dev - now cc'd. This has been discussed at some length in build-dev. But I agree, it's good that also the actual RFR is cc:ed here. The patch, unsurprisingly, LGTM. /Magnus These changes seem reasonable, though I don't like adding changes in source code for such an obscure (and unsupported!) platform. David On 5/09/2018 3:45 AM, John Paul Adrian Glaubitz wrote: Hi! This rather small change adds build support for the x86_64-linux-gnux32 target. x32 is a variant of the x86_64 ABI with 64-bit registers and amd64 instruction set but 32-bit pointers [1]. One of the Linux distributions supporting x32 is Debian, see [2]. The port is not official, but the large majority of packages build fine and the toolchain is in good shape. Another distribution supporting x32 is Gentoo. Please review the change in [3]. I have changed the original patch a bit that Debian uses downstream to make the changes more consistent and cleaner. Thanks, Adrian [1] https://en.wikipedia.org/wiki/X32_ABI [2] http://debian-x32.org/ [2] http://cr.openjdk.java.net/~glaubitz/8165440/webrev.00/
Re: RFR: 8165440: Add zero support for x86_64-linux-gnux32 target
Looks ok to me. /Erik On 2018-09-04 14:29, David Holmes wrote: Hi Adrian, All changes that touch the build system must be reviewed by build-dev - now cc'd. These changes seem reasonable, though I don't like adding changes in source code for such an obscure (and unsupported!) platform. David On 5/09/2018 3:45 AM, John Paul Adrian Glaubitz wrote: Hi! This rather small change adds build support for the x86_64-linux-gnux32 target. x32 is a variant of the x86_64 ABI with 64-bit registers and amd64 instruction set but 32-bit pointers [1]. One of the Linux distributions supporting x32 is Debian, see [2]. The port is not official, but the large majority of packages build fine and the toolchain is in good shape. Another distribution supporting x32 is Gentoo. Please review the change in [3]. I have changed the original patch a bit that Debian uses downstream to make the changes more consistent and cleaner. Thanks, Adrian [1] https://en.wikipedia.org/wiki/X32_ABI [2] http://debian-x32.org/ [2] http://cr.openjdk.java.net/~glaubitz/8165440/webrev.00/
Re: RFR: 8165440: Add zero support for x86_64-linux-gnux32 target
Hi Adrian, All changes that touch the build system must be reviewed by build-dev - now cc'd. These changes seem reasonable, though I don't like adding changes in source code for such an obscure (and unsupported!) platform. David On 5/09/2018 3:45 AM, John Paul Adrian Glaubitz wrote: Hi! This rather small change adds build support for the x86_64-linux-gnux32 target. x32 is a variant of the x86_64 ABI with 64-bit registers and amd64 instruction set but 32-bit pointers [1]. One of the Linux distributions supporting x32 is Debian, see [2]. The port is not official, but the large majority of packages build fine and the toolchain is in good shape. Another distribution supporting x32 is Gentoo. Please review the change in [3]. I have changed the original patch a bit that Debian uses downstream to make the changes more consistent and cleaner. Thanks, Adrian [1] https://en.wikipedia.org/wiki/X32_ABI [2] http://debian-x32.org/ [2] http://cr.openjdk.java.net/~glaubitz/8165440/webrev.00/
