Re: RFR: 8188073: Add Capstone as backend for hsdis [v2]
On Thu, 17 Feb 2022 15:16:41 GMT, Magnus Ihse Bursie wrote: >> The Capstone library is a simple to use, efficient disassembly library, >> distributed under the MIT license. >> >> This PR implements an hsdis backend using Capstone. It has been tested on >> Linux, macOS and Windows (x64). >> >> The actual C implementation of the backend was done by @JornVernee. I assume >> there are plenty of room for enhancing this implementation, with options >> like in the binutils backend. Such improvements can be done later, by teams >> more familiar with the requirements of hsdis. > > Magnus Ihse Bursie has updated the pull request incrementally with one > additional commit since the last revision: > > Fix indentation Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7506
Re: RFR: 8188073: Add Capstone as backend for hsdis [v2]
> The Capstone library is a simple to use, efficient disassembly library, > distributed under the MIT license. > > This PR implements an hsdis backend using Capstone. It has been tested on > Linux, macOS and Windows (x64). > > The actual C implementation of the backend was done by @JornVernee. I assume > there are plenty of room for enhancing this implementation, with options like > in the binutils backend. Such improvements can be done later, by teams more > familiar with the requirements of hsdis. Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision: Fix indentation - Changes: - all: https://git.openjdk.java.net/jdk/pull/7506/files - new: https://git.openjdk.java.net/jdk/pull/7506/files/03974854..05c19820 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=7506=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=7506=00-01 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk/pull/7506.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7506/head:pull/7506 PR: https://git.openjdk.java.net/jdk/pull/7506
Re: RFR: 8188073: Add Capstone as backend for hsdis [v2]
On Thu, 17 Feb 2022 14:11:12 GMT, Erik Joelsson wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix indentation > > make/Hsdis.gmk line 157: > >> 155: >> 156: $(INSTALLED_HSDIS): $(BUILD_HSDIS_TARGET) >> 157: ifeq ($(HSDIS_BACKEND), binutils) > > Don't we usually indent conditionals to the recipe level using spaces? Yes we do. Embarrassing. - PR: https://git.openjdk.java.net/jdk/pull/7506
Re: RFR: 8188073: Add Capstone as backend for hsdis
On Wed, 16 Feb 2022 21:55:36 GMT, Magnus Ihse Bursie wrote: > The Capstone library is a simple to use, efficient disassembly library, > distributed under the MIT license. > > This PR implements an hsdis backend using Capstone. It has been tested on > Linux, macOS and Windows (x64). > > The actual C implementation of the backend was done by @JornVernee. I assume > there are plenty of room for enhancing this implementation, with options like > in the binutils backend. Such improvements can be done later, by teams more > familiar with the requirements of hsdis. One style nit. make/Hsdis.gmk line 157: > 155: > 156: $(INSTALLED_HSDIS): $(BUILD_HSDIS_TARGET) > 157: ifeq ($(HSDIS_BACKEND), binutils) Don't we usually indent conditionals to the recipe level using spaces? - Marked as reviewed by erikj (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7506
RFR: 8188073: Add Capstone as backend for hsdis
The Capstone library is a simple to use, efficient disassembly library, distributed under the MIT license. This PR implements an hsdis backend using Capstone. It has been tested on Linux, macOS and Windows (x64). The actual C implementation of the backend was done by @JornVernee. I assume there are plenty of room for enhancing this implementation, with options like in the binutils backend. Such improvements can be done later, by teams more familiar with the requirements of hsdis. - Commit messages: - Fix whitespace error (thanks, jcheck!) - Minor fixes - The pandoc-style copyright header looks bad on Github... - Turn the README into markdown format. Add documentation on building Capstone. - Fix capstone on Windows - Add capstone as hsdis backend Changes: https://git.openjdk.java.net/jdk/pull/7506/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=7506=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8188073 Stats: 517 lines in 9 files changed: 346 ins; 136 del; 35 mod Patch: https://git.openjdk.java.net/jdk/pull/7506.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7506/head:pull/7506 PR: https://git.openjdk.java.net/jdk/pull/7506
