Re: [PING] [8u] RFR: 8210425: [x86] sharedRuntimeTrig/sharedRuntimeTrans compiled without optimization

2019-05-15 Thread Hohensee, Paul 
Looks good.

Paul

On 5/9/19, 5:39 AM, "hotspot-dev on behalf of sgehw...@redhat.com" 
 wrote:

Ping?

On Fri, 2019-05-03 at 18:35 +0200, Severin Gehwolf wrote:
> Hi,
> 
> Could I please get reviews for this 8u backport of an optimization fix
> pertaining to the hotspot copy of fdlibm? Historically,
> sharedRuntimeTrans.cpp and sharedRuntimeTrig.cpp have been compiled
> with optimization turned off on x86/x86_64. As JDK-8210416 will be
> backported to JDK 8u fixing optimization for fdlibm itself, so should
> be the hotspot copy in OpenJDK 8u. The build system for hotspot in JDK
> 8u is very different, so the original fix for JDK 12 doesn't apply.
> It's a complete rewrite. Please see this webrev which shows the
> prerequisite patch. It adds the FDLIBM_CFLAGS logic:
> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210416/jdk8/02/
> 
> It also fixes a bug on ppc64{,le} where optimization is being turned on
> in hotspot (-O3), but not providing the -ffp-contract=off flag (or
> older equivalent).
> 
> Before (on ppc64le):
> /bin/g++ -DLINUX -D_GNU_SOURCE -DPPC64 -DPRODUCT -I. 
-I/home/openjdk/jdk8u/hotspot/src/share/vm/prims 
-I/home/openjdk/jdk8u/hotspot/src/share/vm 
-I/home/openjdk/jdk8u/hotspot/src/share/vm/precompiled 
-I/home/openjdk/jdk8u/hotspot/src/cpu/ppc/vm 
-I/home/openjdk/jdk8u/hotspot/src/os_cpu/linux_ppc/vm 
-I/home/openjdk/jdk8u/hotspot/src/os/linux/vm 
-I/home/openjdk/jdk8u/hotspot/src/os/posix/vm -I../generated 
-DHOTSPOT_RELEASE_VERSION="\"25.212-b04\"" -DHOTSPOT_BUILD_TARGET="\"product\"" 
-DHOTSPOT_BUILD_USER="\"openjdk\"" -DHOTSPOT_LIB_ARCH=\"ppc64le\" 
-DHOTSPOT_VM_DISTRO="\"OpenJDK\""  -DTARGET_OS_FAMILY_linux -DTARGET_ARCH_ppc 
-DTARGET_ARCH_MODEL_ppc_64 -DTARGET_OS_ARCH_linux_ppc 
-DTARGET_OS_ARCH_MODEL_linux_ppc_64 -DTARGET_COMPILER_gcc -DCOMPILER2 -fPIC 
-fno-rtti -fno-exceptions -D_REENTRANT -fcheck-new -fvisibility=hidden -m64 
-pipe -fno-strict-aliasing  -fno-omit-frame-pointer -O3  -g -D_LP64=1 
-DVM_LITTLE_ENDIAN -DABI_ELFv2 -mcpu=power7 -mtune=power8 
-minsert-sched-nops=regroup_exact -mno-multiple -mno-string -Werror 
-Wpointer-arith -Wsign-compare -Wundef -Wunused-function -Wunused-value 
-std=gnu++98 -c -MMD -MP -MF ../generated/dependencies/sharedRuntimeTrig.o.d 
-fpch-deps -o sharedRuntimeTrig.o 
/home/openjdk/jdk8u/hotspot/src/share/vm/runtime/sharedRuntimeTrig.cpp
> After (on ppc64le; Note -ffp-contract=off flag):
> /bin/g++ -DLINUX -D_GNU_SOURCE -DPPC64 -DPRODUCT -I. 
-I/home/openjdk/jdk8u/hotspot/src/share/vm/prims 
-I/home/openjdk/jdk8u/hotspot/src/share/vm 
-I/home/openjdk/jdk8u/hotspot/src/share/vm/precompiled 
-I/home/openjdk/jdk8u/hotspot/src/cpu/ppc/vm 
-I/home/openjdk/jdk8u/hotspot/src/os_cpu/linux_ppc/vm 
-I/home/openjdk/jdk8u/hotspot/src/os/linux/vm 
-I/home/openjdk/jdk8u/hotspot/src/os/posix/vm -I../generated 
-DHOTSPOT_RELEASE_VERSION="\"25.212-b04\"" -DHOTSPOT_BUILD_TARGET="\"product\"" 
-DHOTSPOT_BUILD_USER="\"openjdk\"" -DHOTSPOT_LIB_ARCH=\"ppc64le\" 
-DHOTSPOT_VM_DISTRO="\"OpenJDK\""  -DTARGET_OS_FAMILY_linux -DTARGET_ARCH_ppc 
-DTARGET_ARCH_MODEL_ppc_64 -DTARGET_OS_ARCH_linux_ppc 
-DTARGET_OS_ARCH_MODEL_linux_ppc_64 -DTARGET_COMPILER_gcc -DCOMPILER2 -fPIC 
-fno-rtti -fno-exceptions -D_REENTRANT -fcheck-new -fvisibility=hidden -m64 
-pipe -fno-strict-aliasing  -fno-omit-frame-pointer -O3 -ffp-contract=off 
-D_LP64=1 -DVM_LITTLE_ENDIAN -DABI_ELFv2 -mcpu=power7 -mtune=power8 
-minsert-sched-nops=regroup_exact -mno-multiple -mno-string -Werror 
-Wpointer-arith -Wsign-compare -Wundef -Wunused-function -Wunused-value 
-std=gnu++98 -c -MMD -MP -MF ../generated/dependencies/sharedRuntimeTrig.o.d 
-fpch-deps -o sharedRuntimeTrig.o 
/home/openjdk/jdk8u/hotspot/src/share/vm/runtime/sharedRuntimeTrig.cpp
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8210425
> webrev: 
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210425/jdk8/02/webrev
> 
> Testing: Builds on x86_64 (server/Zero). Manual inspection of compile
> log of sharedRuntimeTrans.cpp/sharedRuntimeTrig.cpp. Same for ppc64le.
> Note that we've been using this patch downstream for a while now. We
> haven't seen any issues so far.
> 
> Thanks,
> Severin

Re: [PING] [8u] RFR: 8210425: [x86] sharedRuntimeTrig/sharedRuntimeTrans compiled without optimization

2019-05-09 Thread sgehwolf 
Ping?

On Fri, 2019-05-03 at 18:35 +0200, Severin Gehwolf wrote:
> Hi,
> 
> Could I please get reviews for this 8u backport of an optimization fix
> pertaining to the hotspot copy of fdlibm? Historically,
> sharedRuntimeTrans.cpp and sharedRuntimeTrig.cpp have been compiled
> with optimization turned off on x86/x86_64. As JDK-8210416 will be
> backported to JDK 8u fixing optimization for fdlibm itself, so should
> be the hotspot copy in OpenJDK 8u. The build system for hotspot in JDK
> 8u is very different, so the original fix for JDK 12 doesn't apply.
> It's a complete rewrite. Please see this webrev which shows the
> prerequisite patch. It adds the FDLIBM_CFLAGS logic:
> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210416/jdk8/02/
> 
> It also fixes a bug on ppc64{,le} where optimization is being turned on
> in hotspot (-O3), but not providing the -ffp-contract=off flag (or
> older equivalent).
> 
> Before (on ppc64le):
> /bin/g++ -DLINUX -D_GNU_SOURCE -DPPC64 -DPRODUCT -I. 
> -I/home/openjdk/jdk8u/hotspot/src/share/vm/prims 
> -I/home/openjdk/jdk8u/hotspot/src/share/vm 
> -I/home/openjdk/jdk8u/hotspot/src/share/vm/precompiled 
> -I/home/openjdk/jdk8u/hotspot/src/cpu/ppc/vm 
> -I/home/openjdk/jdk8u/hotspot/src/os_cpu/linux_ppc/vm 
> -I/home/openjdk/jdk8u/hotspot/src/os/linux/vm 
> -I/home/openjdk/jdk8u/hotspot/src/os/posix/vm -I../generated 
> -DHOTSPOT_RELEASE_VERSION="\"25.212-b04\"" 
> -DHOTSPOT_BUILD_TARGET="\"product\"" -DHOTSPOT_BUILD_USER="\"openjdk\"" 
> -DHOTSPOT_LIB_ARCH=\"ppc64le\" -DHOTSPOT_VM_DISTRO="\"OpenJDK\""  
> -DTARGET_OS_FAMILY_linux -DTARGET_ARCH_ppc -DTARGET_ARCH_MODEL_ppc_64 
> -DTARGET_OS_ARCH_linux_ppc -DTARGET_OS_ARCH_MODEL_linux_ppc_64 
> -DTARGET_COMPILER_gcc -DCOMPILER2 -fPIC -fno-rtti -fno-exceptions 
> -D_REENTRANT -fcheck-new -fvisibility=hidden -m64 -pipe -fno-strict-aliasing  
> -fno-omit-frame-pointer -O3  -g -D_LP64=1 -DVM_LITTLE_ENDIAN -DABI_ELFv2 
> -mcpu=power7 -mtune=power8 -minsert-sched-nops=regroup_exact -mno-multiple 
> -mno-string -Werror -Wpointer-arith -Wsign-compare -Wundef -Wunused-function 
> -Wunused-value -std=gnu++98 -c -MMD -MP -MF 
> ../generated/dependencies/sharedRuntimeTrig.o.d -fpch-deps -o 
> sharedRuntimeTrig.o 
> /home/openjdk/jdk8u/hotspot/src/share/vm/runtime/sharedRuntimeTrig.cpp
> After (on ppc64le; Note -ffp-contract=off flag):
> /bin/g++ -DLINUX -D_GNU_SOURCE -DPPC64 -DPRODUCT -I. 
> -I/home/openjdk/jdk8u/hotspot/src/share/vm/prims 
> -I/home/openjdk/jdk8u/hotspot/src/share/vm 
> -I/home/openjdk/jdk8u/hotspot/src/share/vm/precompiled 
> -I/home/openjdk/jdk8u/hotspot/src/cpu/ppc/vm 
> -I/home/openjdk/jdk8u/hotspot/src/os_cpu/linux_ppc/vm 
> -I/home/openjdk/jdk8u/hotspot/src/os/linux/vm 
> -I/home/openjdk/jdk8u/hotspot/src/os/posix/vm -I../generated 
> -DHOTSPOT_RELEASE_VERSION="\"25.212-b04\"" 
> -DHOTSPOT_BUILD_TARGET="\"product\"" -DHOTSPOT_BUILD_USER="\"openjdk\"" 
> -DHOTSPOT_LIB_ARCH=\"ppc64le\" -DHOTSPOT_VM_DISTRO="\"OpenJDK\""  
> -DTARGET_OS_FAMILY_linux -DTARGET_ARCH_ppc -DTARGET_ARCH_MODEL_ppc_64 
> -DTARGET_OS_ARCH_linux_ppc -DTARGET_OS_ARCH_MODEL_linux_ppc_64 
> -DTARGET_COMPILER_gcc -DCOMPILER2 -fPIC -fno-rtti -fno-exceptions 
> -D_REENTRANT -fcheck-new -fvisibility=hidden -m64 -pipe -fno-strict-aliasing  
> -fno-omit-frame-pointer -O3 -ffp-contract=off -D_LP64=1 -DVM_LITTLE_ENDIAN 
> -DABI_ELFv2 -mcpu=power7 -mtune=power8 -minsert-sched-nops=regroup_exact 
> -mno-multiple -mno-string -Werror -Wpointer-arith -Wsign-compare -Wundef 
> -Wunused-function -Wunused-value -std=gnu++98 -c -MMD -MP -MF 
> ../generated/dependencies/sharedRuntimeTrig.o.d -fpch-deps -o 
> sharedRuntimeTrig.o 
> /home/openjdk/jdk8u/hotspot/src/share/vm/runtime/sharedRuntimeTrig.cpp
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8210425
> webrev: 
> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210425/jdk8/02/webrev
> 
> Testing: Builds on x86_64 (server/Zero). Manual inspection of compile
> log of sharedRuntimeTrans.cpp/sharedRuntimeTrig.cpp. Same for ppc64le.
> Note that we've been using this patch downstream for a while now. We
> haven't seen any issues so far.
> 
> Thanks,
> Severin

[8u] RFR: 8210425: [x86] sharedRuntimeTrig/sharedRuntimeTrans compiled without optimization

2019-05-03 Thread Severin Gehwolf 
Hi,

Could I please get reviews for this 8u backport of an optimization fix
pertaining to the hotspot copy of fdlibm? Historically,
sharedRuntimeTrans.cpp and sharedRuntimeTrig.cpp have been compiled
with optimization turned off on x86/x86_64. As JDK-8210416 will be
backported to JDK 8u fixing optimization for fdlibm itself, so should
be the hotspot copy in OpenJDK 8u. The build system for hotspot in JDK
8u is very different, so the original fix for JDK 12 doesn't apply.
It's a complete rewrite. Please see this webrev which shows the
prerequisite patch. It adds the FDLIBM_CFLAGS logic:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210416/jdk8/02/

It also fixes a bug on ppc64{,le} where optimization is being turned on
in hotspot (-O3), but not providing the -ffp-contract=off flag (or
older equivalent).

Before (on ppc64le):
/bin/g++ -DLINUX -D_GNU_SOURCE -DPPC64 -DPRODUCT -I. 
-I/home/openjdk/jdk8u/hotspot/src/share/vm/prims 
-I/home/openjdk/jdk8u/hotspot/src/share/vm 
-I/home/openjdk/jdk8u/hotspot/src/share/vm/precompiled 
-I/home/openjdk/jdk8u/hotspot/src/cpu/ppc/vm 
-I/home/openjdk/jdk8u/hotspot/src/os_cpu/linux_ppc/vm 
-I/home/openjdk/jdk8u/hotspot/src/os/linux/vm 
-I/home/openjdk/jdk8u/hotspot/src/os/posix/vm -I../generated 
-DHOTSPOT_RELEASE_VERSION="\"25.212-b04\"" -DHOTSPOT_BUILD_TARGET="\"product\"" 
-DHOTSPOT_BUILD_USER="\"openjdk\"" -DHOTSPOT_LIB_ARCH=\"ppc64le\" 
-DHOTSPOT_VM_DISTRO="\"OpenJDK\""  -DTARGET_OS_FAMILY_linux -DTARGET_ARCH_ppc 
-DTARGET_ARCH_MODEL_ppc_64 -DTARGET_OS_ARCH_linux_ppc 
-DTARGET_OS_ARCH_MODEL_linux_ppc_64 -DTARGET_COMPILER_gcc -DCOMPILER2 -fPIC 
-fno-rtti -fno-exceptions -D_REENTRANT -fcheck-new -fvisibility=hidden -m64 
-pipe -fno-strict-aliasing  -fno-omit-frame-pointer -O3  -g -D_LP64=1 
-DVM_LITTLE_ENDIAN -DABI_ELFv2 -mcpu=power7 -mtune=power8 
-minsert-sched-nops=regroup_exact -mno-multiple -mno-string -Werror 
-Wpointer-arith -Wsign-compare -Wundef -Wunused-function -Wunused-value 
-std=gnu++98 -c -MMD -MP -MF ../generated/dependencies/sharedRuntimeTrig.o.d 
-fpch-deps -o sharedRuntimeTrig.o 
/home/openjdk/jdk8u/hotspot/src/share/vm/runtime/sharedRuntimeTrig.cpp
After (on ppc64le; Note -ffp-contract=off flag):
/bin/g++ -DLINUX -D_GNU_SOURCE -DPPC64 -DPRODUCT -I. 
-I/home/openjdk/jdk8u/hotspot/src/share/vm/prims 
-I/home/openjdk/jdk8u/hotspot/src/share/vm 
-I/home/openjdk/jdk8u/hotspot/src/share/vm/precompiled 
-I/home/openjdk/jdk8u/hotspot/src/cpu/ppc/vm 
-I/home/openjdk/jdk8u/hotspot/src/os_cpu/linux_ppc/vm 
-I/home/openjdk/jdk8u/hotspot/src/os/linux/vm 
-I/home/openjdk/jdk8u/hotspot/src/os/posix/vm -I../generated 
-DHOTSPOT_RELEASE_VERSION="\"25.212-b04\"" -DHOTSPOT_BUILD_TARGET="\"product\"" 
-DHOTSPOT_BUILD_USER="\"openjdk\"" -DHOTSPOT_LIB_ARCH=\"ppc64le\" 
-DHOTSPOT_VM_DISTRO="\"OpenJDK\""  -DTARGET_OS_FAMILY_linux -DTARGET_ARCH_ppc 
-DTARGET_ARCH_MODEL_ppc_64 -DTARGET_OS_ARCH_linux_ppc 
-DTARGET_OS_ARCH_MODEL_linux_ppc_64 -DTARGET_COMPILER_gcc -DCOMPILER2 -fPIC 
-fno-rtti -fno-exceptions -D_REENTRANT -fcheck-new -fvisibility=hidden -m64 
-pipe -fno-strict-aliasing  -fno-omit-frame-pointer -O3 -ffp-contract=off 
-D_LP64=1 -DVM_LITTLE_ENDIAN -DABI_ELFv2 -mcpu=power7 -mtune=power8 
-minsert-sched-nops=regroup_exact -mno-multiple -mno-string -Werror 
-Wpointer-arith -Wsign-compare -Wundef -Wunused-function -Wunused-value 
-std=gnu++98 -c -MMD -MP -MF ../generated/dependencies/sharedRuntimeTrig.o.d 
-fpch-deps -o sharedRuntimeTrig.o 
/home/openjdk/jdk8u/hotspot/src/share/vm/runtime/sharedRuntimeTrig.cpp

Bug: https://bugs.openjdk.java.net/browse/JDK-8210425
webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210425/jdk8/02/webrev

Testing: Builds on x86_64 (server/Zero). Manual inspection of compile
log of sharedRuntimeTrans.cpp/sharedRuntimeTrig.cpp. Same for ppc64le.
Note that we've been using this patch downstream for a while now. We
haven't seen any issues so far.

Thanks,
Severin

Re: RFR: 8210425: [x86] sharedRuntimeTrig/sharedRuntimeTrans compiled without optimization

2018-09-08 Thread Andrew Haley 
On 09/06/2018 03:32 PM, Severin Gehwolf wrote:
> Right. I should note that ppc64, s390x and aarch64 ports don't have
> this optimization turned off as those overrides are in a x86 specific
> block. It appears it hasn't caused issues for these ports so far.

That's just dumb luck. We really should turn off the merging of FP
operations on all platforms.

-- 
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. 
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671

Re: RFR: 8210425: [x86] sharedRuntimeTrig/sharedRuntimeTrans compiled without optimization

2018-09-06 Thread David Holmes 

On 7/09/2018 12:32 AM, Severin Gehwolf wrote:

Hi,

On Thu, 2018-09-06 at 07:29 +1000, David Holmes wrote:

Hi Severin,

On 6/09/2018 4:36 AM, Severin Gehwolf wrote:

Hi,

On Linux x86 (32 and 64 bit) sharedRuntime{Trans,Trig}.ccp files get
compiled with -O0. It appears to be for the same (historical?) reason
as for fdlibm files in core-libs. JDK-8210416 is an attempt to make
this consistent on all Linux arches (as s390x/ppc64/aarch64 already use
that) for fdlibm. This patch does the same for the hotspot copies.
Compile it with OPT and -ffp-contract=off instead of no optimization at
all. Thoughts?


The code in sharedRuntimeTrig is expected/required to be built the same
way as the fdlibm library as it contains the same code. So if it is okay
to change the way fdlibm is built then it follows this is okay too. I
traced this change to the optimization flags back to 2001 but no details
on the exact issue seen with fdlibm.


Right. I should note that ppc64, s390x and aarch64 ports don't have
this optimization turned off as those overrides are in a x86 specific
block. It appears it hasn't caused issues for these ports so far.

Your comment on JDK-8210416 says that it was introduced for an issue on
GCC 1.1.1 i386 back in 1998. Wow ;-)


Is -ffp-contract=off a gcc-specific flag? If so this should be a gcc
conditional not a linux-x86 one.


clang has it (as noted elsewhere), but I don't know which version.
What's the "blessed" clang version for JDK 12?


I've no idea sorry.

Once 8210416 has settled on the right approach for the makefiles the 
same can be applied here.


Thanks,
David


Thanks,
Severin


webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210425/webrev.01/
Bug:https://bugs.openjdk.java.net/browse/JDK-8210425

Testing: - make run-test-tier1 (no new failures).
   - Currently running through submit.
   - Verified objects get compiled with -O3 -ffp-contract=off in
 build logs.

Thanks,
Severin

Re: RFR: 8210425: [x86] sharedRuntimeTrig/sharedRuntimeTrans compiled without optimization

2018-09-06 Thread Severin Gehwolf 
Hi,

On Thu, 2018-09-06 at 07:29 +1000, David Holmes wrote:
> Hi Severin,
> 
> On 6/09/2018 4:36 AM, Severin Gehwolf wrote:
> > Hi,
> > 
> > On Linux x86 (32 and 64 bit) sharedRuntime{Trans,Trig}.ccp files get
> > compiled with -O0. It appears to be for the same (historical?) reason
> > as for fdlibm files in core-libs. JDK-8210416 is an attempt to make
> > this consistent on all Linux arches (as s390x/ppc64/aarch64 already use
> > that) for fdlibm. This patch does the same for the hotspot copies.
> > Compile it with OPT and -ffp-contract=off instead of no optimization at
> > all. Thoughts?
> 
> The code in sharedRuntimeTrig is expected/required to be built the same 
> way as the fdlibm library as it contains the same code. So if it is okay 
> to change the way fdlibm is built then it follows this is okay too. I 
> traced this change to the optimization flags back to 2001 but no details 
> on the exact issue seen with fdlibm.

Right. I should note that ppc64, s390x and aarch64 ports don't have
this optimization turned off as those overrides are in a x86 specific
block. It appears it hasn't caused issues for these ports so far.

Your comment on JDK-8210416 says that it was introduced for an issue on
GCC 1.1.1 i386 back in 1998. Wow ;-)

> Is -ffp-contract=off a gcc-specific flag? If so this should be a gcc 
> conditional not a linux-x86 one.

clang has it (as noted elsewhere), but I don't know which version.
What's the "blessed" clang version for JDK 12?

Thanks,
Severin

> > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210425/webrev.01/
> > Bug:https://bugs.openjdk.java.net/browse/JDK-8210425
> > 
> > Testing: - make run-test-tier1 (no new failures).
> >   - Currently running through submit.
> >   - Verified objects get compiled with -O3 -ffp-contract=off in
> > build logs.
> > 
> > Thanks,
> > Severin
> >

Re: RFR: 8210425: [x86] sharedRuntimeTrig/sharedRuntimeTrans compiled without optimization

2018-09-05 Thread David Holmes 

Hi Severin,

On 6/09/2018 4:36 AM, Severin Gehwolf wrote:

Hi,

On Linux x86 (32 and 64 bit) sharedRuntime{Trans,Trig}.ccp files get
compiled with -O0. It appears to be for the same (historical?) reason
as for fdlibm files in core-libs. JDK-8210416 is an attempt to make
this consistent on all Linux arches (as s390x/ppc64/aarch64 already use
that) for fdlibm. This patch does the same for the hotspot copies.
Compile it with OPT and -ffp-contract=off instead of no optimization at
all. Thoughts?


The code in sharedRuntimeTrig is expected/required to be built the same 
way as the fdlibm library as it contains the same code. So if it is okay 
to change the way fdlibm is built then it follows this is okay too. I 
traced this change to the optimization flags back to 2001 but no details 
on the exact issue seen with fdlibm.


Is -ffp-contract=off a gcc-specific flag? If so this should be a gcc 
conditional not a linux-x86 one.


Thanks,
David


webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210425/webrev.01/
Bug:https://bugs.openjdk.java.net/browse/JDK-8210425

Testing: - make run-test-tier1 (no new failures).
  - Currently running through submit.
  - Verified objects get compiled with -O3 -ffp-contract=off in
build logs.

Thanks,
Severin

RFR: 8210425: [x86] sharedRuntimeTrig/sharedRuntimeTrans compiled without optimization

2018-09-05 Thread Severin Gehwolf 
Hi,

On Linux x86 (32 and 64 bit) sharedRuntime{Trans,Trig}.ccp files get
compiled with -O0. It appears to be for the same (historical?) reason
as for fdlibm files in core-libs. JDK-8210416 is an attempt to make
this consistent on all Linux arches (as s390x/ppc64/aarch64 already use
that) for fdlibm. This patch does the same for the hotspot copies.
Compile it with OPT and -ffp-contract=off instead of no optimization at
all. Thoughts?

webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210425/webrev.01/
Bug:https://bugs.openjdk.java.net/browse/JDK-8210425

Testing: - make run-test-tier1 (no new failures).
 - Currently running through submit.
 - Verified objects get compiled with -O3 -ffp-contract=off in
   build logs.

Thanks,
Severin