Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive [v16]
> This patch is reorganized after 8252725, which is separated from this patch > to refactor jlink glugin code. The previous > webrev with hg can be found at: > http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-05. With 8252725 > integrated, the > regeneration of holder classes is simply to call the new added > GenerateJLIClassesHelper.cdsGenerateHolderClasses > function. Tests: tier1-4 Yumin Qi has updated the pull request incrementally with three additional commits since the last revision: - Correct typo for check message - Removed try/catch from java side and moved output to vm. - Make change to original indent - Changes: - all: https://git.openjdk.java.net/jdk/pull/193/files - new: https://git.openjdk.java.net/jdk/pull/193/files/16362e15..2184725f Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=193&range=15 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=193&range=14-15 Stats: 29 lines in 4 files changed: 1 ins; 10 del; 18 mod Patch: https://git.openjdk.java.net/jdk/pull/193.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/193/head:pull/193 PR: https://git.openjdk.java.net/jdk/pull/193
Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive [v16]
On Sat, 10 Oct 2020 00:08:26 GMT, Yumin Qi wrote: >> This patch is reorganized after 8252725, which is separated from this patch >> to refactor jlink glugin code. The previous >> webrev with hg can be found at: >> http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-05. With 8252725 >> integrated, the >> regeneration of holder classes is simply to call the new added >> GenerateJLIClassesHelper.cdsGenerateHolderClasses >> function. Tests: tier1-4 > > Yumin Qi has updated the pull request incrementally with three additional > commits since the last revision: > > - Correct typo for check message > - Removed try/catch from java side and moved output to vm. > - Make change to original indent I reviewed the files under `src/java.base`. - Marked as reviewed by mchung (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/193
Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive [v16]
On Sat, 10 Oct 2020 00:08:26 GMT, Yumin Qi wrote: >> This patch is reorganized after 8252725, which is separated from this patch >> to refactor jlink glugin code. The previous >> webrev with hg can be found at: >> http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-05. With 8252725 >> integrated, the >> regeneration of holder classes is simply to call the new added >> GenerateJLIClassesHelper.cdsGenerateHolderClasses >> function. Tests: tier1-4 > > Yumin Qi has updated the pull request incrementally with three additional > commits since the last revision: > > - Correct typo for check message > - Removed try/catch from java side and moved output to vm. > - Make change to original indent Latest version LGTM. - Marked as reviewed by iklam (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/193
