Re: RFR: 8256538: Fix annoying awk warning in configure for java versions [v2]
> The change from grep to awk in JDK-8244248 and further bug fixed in > JDK-8244756 still has invalid syntax. This causes some awk (most notably > gawk, the most commonly used) to complain: > > gawk: cmd. line:1: warning: regexp escape sequence `"' is not a known regexp > operator > > This is annoying and should be fixed. Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision: Also fix bad code as copied in BOOTJDK_CHECK_BUILD_JDK - Changes: - all: https://git.openjdk.java.net/jdk/pull/1285/files - new: https://git.openjdk.java.net/jdk/pull/1285/files/9d5fd4fc..842287e0 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=1285=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=1285=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/1285.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1285/head:pull/1285 PR: https://git.openjdk.java.net/jdk/pull/1285
Re: RFR: 8256538: Fix annoying awk warning in configure for java versions [v2]
On Wed, 18 Nov 2020 14:13:03 GMT, Bernhard Urban-Forster wrote: >> Marked as reviewed by erikj (Reviewer). > > Thank you Magnus, this is something that has bugged me as well. > > FWIW the same problem exists here with the build JDK detection: > https://github.com/openjdk/jdk/blob/9d5fd4fcabf7bdf580e2fff8e12c2cf130ef44c9/make/autoconf/boot-jdk.m4#L519 > > Would you mind fixing it as part of this PR too? @lewurm Thanks! I had not noticed that one. (In fact, I'm unsure when we got such a huge chunk of duplicated code... *sigh* Should look into it some day, I think.) - PR: https://git.openjdk.java.net/jdk/pull/1285
Re: RFR: 8256538: Fix annoying awk warning in configure for java versions
On Wed, 18 Nov 2020 13:35:14 GMT, Erik Joelsson wrote: >> The change from grep to awk in JDK-8244248 and further bug fixed in >> JDK-8244756 still has invalid syntax. This causes some awk (most notably >> gawk, the most commonly used) to complain: >> >> gawk: cmd. line:1: warning: regexp escape sequence `"' is not a known regexp >> operator >> >> This is annoying and should be fixed. > > Marked as reviewed by erikj (Reviewer). Thank you Magnus, this is something that has bugged me as well. FWIW the same problem exists here with the build JDK detection: https://github.com/openjdk/jdk/blob/9d5fd4fcabf7bdf580e2fff8e12c2cf130ef44c9/make/autoconf/boot-jdk.m4#L519 Would you mind fixing it as part of this PR too? - PR: https://git.openjdk.java.net/jdk/pull/1285
Re: RFR: 8256538: Fix annoying awk warning in configure for java versions
On Wed, 18 Nov 2020 09:47:58 GMT, Magnus Ihse Bursie wrote: > The change from grep to awk in JDK-8244248 and further bug fixed in > JDK-8244756 still has invalid syntax. This causes some awk (most notably > gawk, the most commonly used) to complain: > > gawk: cmd. line:1: warning: regexp escape sequence `"' is not a known regexp > operator > > This is annoying and should be fixed. Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/1285
Re: RFR: 8256538: Fix annoying awk warning in configure for java versions
On Wed, 18 Nov 2020 09:47:58 GMT, Magnus Ihse Bursie wrote: > The change from grep to awk in JDK-8244248 and further bug fixed in > JDK-8244756 still has invalid syntax. This causes some awk (most notably > gawk, the most commonly used) to complain: > > gawk: cmd. line:1: warning: regexp escape sequence `"' is not a known regexp > operator > > This is annoying and should be fixed. I have gotten confirmation from Martin Doerr that this also works on AIX, which has an awk that previously complained about this pattern. And I've tested it on all platforms used in the Oracle CI system. - PR: https://git.openjdk.java.net/jdk/pull/1285
RFR: 8256538: Fix annoying awk warning in configure for java versions
The change from grep to awk in JDK-8244248 and further bug fixed in JDK-8244756 still has invalid syntax. This causes some awk (most notably gawk, the most commonly used) to complain: gawk: cmd. line:1: warning: regexp escape sequence `"' is not a known regexp operator This is annoying and should be fixed. - Commit messages: - 8256538: Fix annoying awk warning in configure for java versions Changes: https://git.openjdk.java.net/jdk/pull/1285/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1285=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8256538 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/1285.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1285/head:pull/1285 PR: https://git.openjdk.java.net/jdk/pull/1285
