Re: RFR: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow [v5]
On Wed, 9 Dec 2020 07:22:51 GMT, Bernhard Urban-Forster wrote: >> This adds the cross-compiled build only, as no Windows+Arm64 machines are >> available on GitHub Action that we could use to run the tests. >> >> Due to cross-compilation a build JDK is required. Initially I added EA >> builds to be downloaded from https://jdk.java.net/16/ and used for that, but >> then I saw how @shipiliv attempted it for the linux cross-compilation builds >> in https://github.com/openjdk/jdk/pull/1147. That is using the JDK image >> produced by the x64 variant. This however add more stress to the "critical >> path", as now two more jobs depend on the x64 build first. >> >> Let's see how it works out in the long-run. A Windows+AArch64 build takes >> 40-50min. > > Bernhard Urban-Forster has updated the pull request with a new target base > due to a merge or a rebase. The pull request now contains 12 commits: > > - remove gtest and jtreg > - Merge remote-tracking branch 'upstream/master' into > 8256657-win-arm64-gh-submit-workflow > - merge mistakes > - change default target to hotspot and align with updated x64 bits > - remove devkit usage on win-aarch64 > - Merge remote-tracking branch 'upstream/master' into > 8256657-win-arm64-gh-submit-workflow > - todo note for caching devkit > - remove release build > - move windows_aarch64_build next to other builds > - Merge remote-tracking branch 'upstream/master' into > 8256657-win-arm64-gh-submit-workflow > - ... and 2 more: > https://git.openjdk.java.net/jdk/compare/9ce3d806...c07f5d72 Marked as reviewed by ihse (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/1379
Re: RFR: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow [v5]
On Wed, 9 Dec 2020 07:22:51 GMT, Bernhard Urban-Forster wrote: >> This adds the cross-compiled build only, as no Windows+Arm64 machines are >> available on GitHub Action that we could use to run the tests. >> >> Due to cross-compilation a build JDK is required. Initially I added EA >> builds to be downloaded from https://jdk.java.net/16/ and used for that, but >> then I saw how @shipiliv attempted it for the linux cross-compilation builds >> in https://github.com/openjdk/jdk/pull/1147. That is using the JDK image >> produced by the x64 variant. This however add more stress to the "critical >> path", as now two more jobs depend on the x64 build first. >> >> Let's see how it works out in the long-run. A Windows+AArch64 build takes >> 40-50min. > > Bernhard Urban-Forster has updated the pull request with a new target base > due to a merge or a rebase. The pull request now contains 12 commits: > > - remove gtest and jtreg > - Merge remote-tracking branch 'upstream/master' into > 8256657-win-arm64-gh-submit-workflow > - merge mistakes > - change default target to hotspot and align with updated x64 bits > - remove devkit usage on win-aarch64 > - Merge remote-tracking branch 'upstream/master' into > 8256657-win-arm64-gh-submit-workflow > - todo note for caching devkit > - remove release build > - move windows_aarch64_build next to other builds > - Merge remote-tracking branch 'upstream/master' into > 8256657-win-arm64-gh-submit-workflow > - ... and 2 more: > https://git.openjdk.java.net/jdk/compare/9ce3d806...c07f5d72 Thanks, updates look fine to me. - Marked as reviewed by shade (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/1379
Re: RFR: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow [v5]
> This adds the cross-compiled build only, as no Windows+Arm64 machines are > available on GitHub Action that we could use to run the tests. > > Due to cross-compilation a build JDK is required. Initially I added EA builds > to be downloaded from https://jdk.java.net/16/ and used for that, but then I > saw how @shipiliv attempted it for the linux cross-compilation builds in > https://github.com/openjdk/jdk/pull/1147. That is using the JDK image > produced by the x64 variant. This however add more stress to the "critical > path", as now two more jobs depend on the x64 build first. > > Let's see how it works out in the long-run. A Windows+AArch64 build takes > 40-50min. Bernhard Urban-Forster has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits: - remove gtest and jtreg - Merge remote-tracking branch 'upstream/master' into 8256657-win-arm64-gh-submit-workflow - merge mistakes - change default target to hotspot and align with updated x64 bits - remove devkit usage on win-aarch64 - Merge remote-tracking branch 'upstream/master' into 8256657-win-arm64-gh-submit-workflow - todo note for caching devkit - remove release build - move windows_aarch64_build next to other builds - Merge remote-tracking branch 'upstream/master' into 8256657-win-arm64-gh-submit-workflow - ... and 2 more: https://git.openjdk.java.net/jdk/compare/9ce3d806...c07f5d72 - Changes: https://git.openjdk.java.net/jdk/pull/1379/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1379=04 Stats: 92 lines in 1 file changed: 91 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/1379.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1379/head:pull/1379 PR: https://git.openjdk.java.net/jdk/pull/1379
