Re: RFR: 8256831: MIPS Zero builds fail with undefined __atomic_compare_exchange_8 [v3]
On Thu, 26 Nov 2020 11:10:43 GMT, Ao Qi wrote: >> Thanks, I'll wait for either of @glaubitz, @theaoqi or @xiangzhai to confirm >> this fixes the native `mipsel` builds for them, and then integrate. > > The native build of linux-mipsel-zero-release passed. I only have mips64el > and 64-bit OS, so I tested the patch by using a mipsel docker image. > > Some messages during the build: > > LOAD: .MIPS.abiflags .reginfo .note.gnu.build-id .dynamic .hash .dynsym > .dynstr .gnu.version .gnu.version_r .rel.dyn .init .text .MIPS.stubs .fini > .eh_frame > However, I think the native build issue has been solved. Thanks for testing! - PR: https://git.openjdk.java.net/jdk/pull/1375
Re: RFR: 8256831: MIPS Zero builds fail with undefined __atomic_compare_exchange_8 [v3]
On Wed, 25 Nov 2020 08:43:31 GMT, Aleksey Shipilev wrote: >> Marked as reviewed by ihse (Reviewer). > > Thanks, I'll wait for either of @glaubitz, @theaoqi or @xiangzhai to confirm > this fixes the native `mipsel` builds for them, and then integrate. The native build of linux-mipsel-zero-release passed. I only have mips64el and 64-bit OS, so I tested the patch by using a mipsel docker image. Some messages during the build: LOAD: .MIPS.abiflags .reginfo .note.gnu.build-id .dynamic .hash .dynsym .dynstr .gnu.version .gnu.version_r .rel.dyn .init .text .MIPS.stubs .fini .eh_frame However, I think the native build issue has been solved. - PR: https://git.openjdk.java.net/jdk/pull/1375
Re: RFR: 8256831: MIPS Zero builds fail with undefined __atomic_compare_exchange_8 [v3]
On Tue, 24 Nov 2020 07:13:27 GMT, Magnus Ihse Bursie wrote: >> Aleksey Shipilev has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains four commits: >> >> - Merge branch 'master' into JDK-8256831-mips-8-byte-cas >> - Move the library addition to LIB_SETUP_LIBRARIES >> - Merge branch 'master' into JDK-8256831-mips-8-byte-cas >> - 8256831: MIPS Zero builds fail with undefined __atomic_compare_exchange_8 > > Marked as reviewed by ihse (Reviewer). Thanks, I'll wait for either of @glaubitz, @theaoqi or @xiangzhai to confirm this fixes the native `mipsel` builds for them, and then integrate. - PR: https://git.openjdk.java.net/jdk/pull/1375
Re: RFR: 8256831: MIPS Zero builds fail with undefined __atomic_compare_exchange_8 [v3]
On Mon, 23 Nov 2020 22:35:05 GMT, Aleksey Shipilev wrote: >> If you try to build `linux-mipsel-zero-fastdebug`, this happens: >> >> >> >> >> >> >> >> I think it relates to >> [JDK-8253970](https://bugs.openjdk.java.net/browse/JDK-8253970) that >> introduced `atomic_compare_exchange` on those paths, but maybe the issue >> exists for longer. >> >> Various other reports for build failures like this suggest the binary should >> link with `libatomic`. GCC's `libatomic` is the library that provides >> runtime support for atomics not supported in hardware, which seems to >> include 8-byte CAS for MIPS, but not any other OpenJDK platform. >> >> The alternative would be to massage the otherwise generic Zero code to >> unimplement the 8-byte CAS. >> >> Attention @DamonFool, who must be running into this problem for their MIPS >> builds? >> >> Testing: >> - [x] Linux mipsel Zero fastdebug build (together with JDK-8256829 fix) > > Aleksey Shipilev has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains four commits: > > - Merge branch 'master' into JDK-8256831-mips-8-byte-cas > - Move the library addition to LIB_SETUP_LIBRARIES > - Merge branch 'master' into JDK-8256831-mips-8-byte-cas > - 8256831: MIPS Zero builds fail with undefined __atomic_compare_exchange_8 Marked as reviewed by ihse (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/1375
Re: RFR: 8256831: MIPS Zero builds fail with undefined __atomic_compare_exchange_8 [v3]
> If you try to build `linux-mipsel-zero-fastdebug`, this happens: > > > > > > > > I think it relates to > [JDK-8253970](https://bugs.openjdk.java.net/browse/JDK-8253970) that > introduced `atomic_compare_exchange` on those paths, but maybe the issue > exists for longer. > > Various other reports for build failures like this suggest the binary should > link with `libatomic`. GCC's `libatomic` is the library that provides runtime > support for atomics not supported in hardware, which seems to include 8-byte > CAS for MIPS, but not any other OpenJDK platform. > > The alternative would be to massage the otherwise generic Zero code to > unimplement the 8-byte CAS. > > Attention @DamonFool, who must be running into this problem for their MIPS > builds? > > Testing: > - [x] Linux mipsel Zero fastdebug build (together with JDK-8256829 fix) Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: - Merge branch 'master' into JDK-8256831-mips-8-byte-cas - Move the library addition to LIB_SETUP_LIBRARIES - Merge branch 'master' into JDK-8256831-mips-8-byte-cas - 8256831: MIPS Zero builds fail with undefined __atomic_compare_exchange_8 - Changes: https://git.openjdk.java.net/jdk/pull/1375/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1375=02 Stats: 8 lines in 1 file changed: 8 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/1375.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1375/head:pull/1375 PR: https://git.openjdk.java.net/jdk/pull/1375
