Re: RFR: 8266318: Switch to macos prefix for macOS bundles [v2]

2021-04-30 Thread Mikael Vidstedt
On Fri, 30 Apr 2021 03:51:18 GMT, Mikael Vidstedt  wrote:

>> Apple rebranded the operating system as "macOS" back in 2016. The JDK 
>> bundles files are still use the legacy "osx" string. They should be 
>> modernized to use "macos" instead.
>
> Mikael Vidstedt has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Fix GHA

Phil, Iris, Erik - thank you for the reviews!

-

PR: https://git.openjdk.java.net/jdk/pull/3801


Re: RFR: 8266318: Switch to macos prefix for macOS bundles [v2]

2021-04-29 Thread Iris Clark
On Fri, 30 Apr 2021 03:51:18 GMT, Mikael Vidstedt  wrote:

>> Apple rebranded the operating system as "macOS" back in 2016. The JDK 
>> bundles files are still use the legacy "osx" string. They should be 
>> modernized to use "macos" instead.
>
> Mikael Vidstedt has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Fix GHA

Marked as reviewed by iris (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/3801


Re: RFR: 8266318: Switch to macos prefix for macOS bundles [v2]

2021-04-29 Thread Mikael Vidstedt
> Apple rebranded the operating system as "macOS" back in 2016. The JDK bundles 
> files are still use the legacy "osx" string. They should be modernized to use 
> "macos" instead.

Mikael Vidstedt has updated the pull request incrementally with one additional 
commit since the last revision:

  Fix GHA

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3801/files
  - new: https://git.openjdk.java.net/jdk/pull/3801/files/1732c917..fb851a34

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3801&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3801&range=00-01

  Stats: 10 lines in 1 file changed: 0 ins; 0 del; 10 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3801.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3801/head:pull/3801

PR: https://git.openjdk.java.net/jdk/pull/3801


Re: RFR: 8266318: Switch to macos prefix for macOS bundles

2021-04-29 Thread Iris Clark
On Thu, 29 Apr 2021 19:15:52 GMT, Mikael Vidstedt  wrote:

> Apple rebranded the operating system as "macOS" back in 2016. The JDK bundles 
> files are still use the legacy "osx" string. They should be modernized to use 
> "macos" instead.

Marked as reviewed by iris (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/3801


Re: RFR: 8266318: Switch to macos prefix for macOS bundles

2021-04-29 Thread Erik Joelsson
On Thu, 29 Apr 2021 19:15:52 GMT, Mikael Vidstedt  wrote:

> Apple rebranded the operating system as "macOS" back in 2016. The JDK bundles 
> files are still use the legacy "osx" string. They should be modernized to use 
> "macos" instead.

Marked as reviewed by erikj (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/3801


Re: RFR: 8266318: Switch to macos prefix for macOS bundles

2021-04-29 Thread Phil Race
On Thu, 29 Apr 2021 19:15:52 GMT, Mikael Vidstedt  wrote:

> Apple rebranded the operating system as "macOS" back in 2016. The JDK bundles 
> files are still use the legacy "osx" string. They should be modernized to use 
> "macos" instead.

Marked as reviewed by prr (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/3801


RFR: 8266318: Switch to macos prefix for macOS bundles

2021-04-29 Thread Mikael Vidstedt
Apple rebranded the operating system as "macOS" back in 2016. The JDK bundles 
files are still use the legacy "osx" string. They should be modernized to use 
"macos" instead.

-

Commit messages:
 - 8266318: Switch to macos prefix for macOS bundles

Changes: https://git.openjdk.java.net/jdk/pull/3801/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3801&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8266318
  Stats: 11 lines in 2 files changed: 2 ins; 4 del; 5 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3801.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3801/head:pull/3801

PR: https://git.openjdk.java.net/jdk/pull/3801