RFR: 8270517: Add Zero support for LoongArch

2021-07-14 Thread Ao Qi 
LoongArch is a new RISC ISA. This issue proposes adding Zero support for 
LoongArch. Only 64-bit support is proposed at present.

linux-loongarch64-zero-{release, fastdebug} build tested:

$ ./build/linux-loongarch64-zero-fastdebug/jdk/bin/java -version
openjdk version "18-internal" 2022-03-15
OpenJDK Runtime Environment (fastdebug build 18-internal+0-adhoc.aoqi.jdk)
OpenJDK 64-Bit Zero VM (fastdebug build 18-internal+0-adhoc.aoqi.jdk, 
interpreted mode)

-

Commit messages:
 - 8270517: Add Zero support for LoongArch

Changes: https://git.openjdk.java.net/jdk/pull/4787/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4787&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8270517
  Stats: 22 lines in 3 files changed: 21 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4787.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4787/head:pull/4787

PR: https://git.openjdk.java.net/jdk/pull/4787

Re: RFR: 8270517: Add Zero support for LoongArch

2021-07-14 Thread David Holmes 
On Thu, 15 Jul 2021 04:04:08 GMT, Ao Qi  wrote:

> LoongArch is a new RISC ISA. This issue proposes adding Zero support for 
> LoongArch. Only 64-bit support is proposed at present.
> 
> linux-loongarch64-zero-{release, fastdebug} build tested:
> 
> $ ./build/linux-loongarch64-zero-fastdebug/jdk/bin/java -version
> openjdk version "18-internal" 2022-03-15
> OpenJDK Runtime Environment (fastdebug build 18-internal+0-adhoc.aoqi.jdk)
> OpenJDK 64-Bit Zero VM (fastdebug build 18-internal+0-adhoc.aoqi.jdk, 
> interpreted mode)

The hotspot changes seem fine.

Thanks,
David

-

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4787

Re: RFR: 8270517: Add Zero support for LoongArch

2021-07-14 Thread Erik Joelsson 
On Thu, 15 Jul 2021 04:04:08 GMT, Ao Qi  wrote:

> LoongArch is a new RISC ISA. This issue proposes adding Zero support for 
> LoongArch. Only 64-bit support is proposed at present.
> 
> linux-loongarch64-zero-{release, fastdebug} build tested:
> 
> $ ./build/linux-loongarch64-zero-fastdebug/jdk/bin/java -version
> openjdk version "18-internal" 2022-03-15
> OpenJDK Runtime Environment (fastdebug build 18-internal+0-adhoc.aoqi.jdk)
> OpenJDK 64-Bit Zero VM (fastdebug build 18-internal+0-adhoc.aoqi.jdk, 
> interpreted mode)

Build changes look good.

-

Marked as reviewed by erikj (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4787

Re: RFR: 8270517: Add Zero support for LoongArch

2021-07-14 Thread Aleksey Shipilev 
On Thu, 15 Jul 2021 04:04:08 GMT, Ao Qi  wrote:

> LoongArch is a new RISC ISA. This issue proposes adding Zero support for 
> LoongArch. Only 64-bit support is proposed at present.
> 
> linux-loongarch64-zero-{release, fastdebug} build tested:
> 
> $ ./build/linux-loongarch64-zero-fastdebug/jdk/bin/java -version
> openjdk version "18-internal" 2022-03-15
> OpenJDK Runtime Environment (fastdebug build 18-internal+0-adhoc.aoqi.jdk)
> OpenJDK 64-Bit Zero VM (fastdebug build 18-internal+0-adhoc.aoqi.jdk, 
> interpreted mode)

Looks good for me (from Zero maintenance standpoint). A minor suggestion below.

src/hotspot/os/linux/os_linux.cpp line 1701:

> 1699: {EM_AARCH64, EM_AARCH64, ELFCLASS64, ELFDATA2LSB, 
> (char*)"AARCH64"},
> 1700: {EM_RISCV,   EM_RISCV,   ELFCLASS64, ELFDATA2LSB, 
> (char*)"RISC-V"},
> 1701: {EM_LOONGARCH,   EM_LOONGARCH,   ELFCLASS64, ELFDATA2LSB, 
> (char*)"LoongArch"},

Suggestion:

{EM_LOONGARCH,   EM_LOONGARCH, ELFCLASS64, ELFDATA2LSB, (char*)"LoongArch"},

-

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4787

Re: RFR: 8270517: Add Zero support for LoongArch

2021-07-15 Thread Ao Qi 
On Thu, 15 Jul 2021 06:30:24 GMT, Aleksey Shipilev  wrote:

>> LoongArch is a new RISC ISA. This issue proposes adding Zero support for 
>> LoongArch. Only 64-bit support is proposed at present.
>> 
>> linux-loongarch64-zero-{release, fastdebug} build tested:
>> 
>> $ ./build/linux-loongarch64-zero-fastdebug/jdk/bin/java -version
>> openjdk version "18-internal" 2022-03-15
>> OpenJDK Runtime Environment (fastdebug build 18-internal+0-adhoc.aoqi.jdk)
>> OpenJDK 64-Bit Zero VM (fastdebug build 18-internal+0-adhoc.aoqi.jdk, 
>> interpreted mode)
>
> src/hotspot/os/linux/os_linux.cpp line 1701:
> 
>> 1699: {EM_AARCH64, EM_AARCH64, ELFCLASS64, ELFDATA2LSB, 
>> (char*)"AARCH64"},
>> 1700: {EM_RISCV,   EM_RISCV,   ELFCLASS64, ELFDATA2LSB, 
>> (char*)"RISC-V"},
>> 1701: {EM_LOONGARCH,   EM_LOONGARCH,   ELFCLASS64, ELFDATA2LSB, 
>> (char*)"LoongArch"},
> 
> Suggestion:
> 
> {EM_LOONGARCH,   EM_LOONGARCH, ELFCLASS64, ELFDATA2LSB, 
> (char*)"LoongArch"},

I added some additional whitespaces according to EM_MIPS_RS3_LE line, which is 
also too long. Your suggestion is fine to me. I will fix it.

-

PR: https://git.openjdk.java.net/jdk/pull/4787

Re: RFR: 8270517: Add Zero support for LoongArch [v2]

2021-07-15 Thread Ao Qi 
> LoongArch is a new RISC ISA. This issue proposes adding Zero support for 
> LoongArch. Only 64-bit support is proposed at present.
> 
> linux-loongarch64-zero-{release, fastdebug} build tested:
> 
> $ ./build/linux-loongarch64-zero-fastdebug/jdk/bin/java -version
> openjdk version "18-internal" 2022-03-15
> OpenJDK Runtime Environment (fastdebug build 18-internal+0-adhoc.aoqi.jdk)
> OpenJDK 64-Bit Zero VM (fastdebug build 18-internal+0-adhoc.aoqi.jdk, 
> interpreted mode)

Ao Qi has updated the pull request incrementally with one additional commit 
since the last revision:

  removed redundant whitespaces

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4787/files
  - new: https://git.openjdk.java.net/jdk/pull/4787/files/bd626159..5dbfe543

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4787&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4787&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4787.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4787/head:pull/4787

PR: https://git.openjdk.java.net/jdk/pull/4787

Re: RFR: 8270517: Add Zero support for LoongArch [v2]

2021-07-15 Thread David Holmes 
On Thu, 15 Jul 2021 07:42:33 GMT, Ao Qi  wrote:

>> LoongArch is a new RISC ISA. This issue proposes adding Zero support for 
>> LoongArch. Only 64-bit support is proposed at present.
>> 
>> linux-loongarch64-zero-{release, fastdebug} build tested:
>> 
>> $ ./build/linux-loongarch64-zero-fastdebug/jdk/bin/java -version
>> openjdk version "18-internal" 2022-03-15
>> OpenJDK Runtime Environment (fastdebug build 18-internal+0-adhoc.aoqi.jdk)
>> OpenJDK 64-Bit Zero VM (fastdebug build 18-internal+0-adhoc.aoqi.jdk, 
>> interpreted mode)
>
> Ao Qi has updated the pull request incrementally with one additional commit 
> since the last revision:
> 
>   removed redundant whitespaces

Marked as reviewed by dholmes (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/4787

Re: RFR: 8270517: Add Zero support for LoongArch [v2]

2021-07-15 Thread Ao Qi 
On Thu, 15 Jul 2021 07:54:41 GMT, David Holmes  wrote:

>> Ao Qi has updated the pull request incrementally with one additional commit 
>> since the last revision:
>> 
>>   removed redundant whitespaces
>
> Marked as reviewed by dholmes (Reviewer).

@dholmes-ora @erikj79 and @shipilev , thanks for the fast review! I also did a 
release bootcycle-images test and a jcstress test. They are passed. Could you 
help to sponsor it?

-

PR: https://git.openjdk.java.net/jdk/pull/4787

Re: RFR: 8270517: Add Zero support for LoongArch [v2]

2021-07-15 Thread Aleksey Shipilev 
On Thu, 15 Jul 2021 07:42:33 GMT, Ao Qi  wrote:

>> LoongArch is a new RISC ISA. This issue proposes adding Zero support for 
>> LoongArch. Only 64-bit support is proposed at present.
>> 
>> linux-loongarch64-zero-{release, fastdebug} build tested:
>> 
>> $ ./build/linux-loongarch64-zero-fastdebug/jdk/bin/java -version
>> openjdk version "18-internal" 2022-03-15
>> OpenJDK Runtime Environment (fastdebug build 18-internal+0-adhoc.aoqi.jdk)
>> OpenJDK 64-Bit Zero VM (fastdebug build 18-internal+0-adhoc.aoqi.jdk, 
>> interpreted mode)
>
> Ao Qi has updated the pull request incrementally with one additional commit 
> since the last revision:
> 
>   removed redundant whitespaces

Oh wait, the PR is only 4 hours old, so I removed my `/sponsor` comment, but it 
was apparently too late. I should have waited for a bit longer. No harm seems 
to be done yet. We shall do any followups, if any problems arise.

-

PR: https://git.openjdk.java.net/jdk/pull/4787

Re: RFR: 8270517: Add Zero support for LoongArch [v2]

2021-07-15 Thread Ao Qi 
On Thu, 15 Jul 2021 07:42:33 GMT, Ao Qi  wrote:

>> LoongArch is a new RISC ISA. This issue proposes adding Zero support for 
>> LoongArch. Only 64-bit support is proposed at present.
>> 
>> linux-loongarch64-zero-{release, fastdebug} build tested:
>> 
>> $ ./build/linux-loongarch64-zero-fastdebug/jdk/bin/java -version
>> openjdk version "18-internal" 2022-03-15
>> OpenJDK Runtime Environment (fastdebug build 18-internal+0-adhoc.aoqi.jdk)
>> OpenJDK 64-Bit Zero VM (fastdebug build 18-internal+0-adhoc.aoqi.jdk, 
>> interpreted mode)
>
> Ao Qi has updated the pull request incrementally with one additional commit 
> since the last revision:
> 
>   removed redundant whitespaces

I apologized that I type "/integrate" too early. I will pay close attention to 
this issue in the next few days in case any problems arise.

-

PR: https://git.openjdk.java.net/jdk/pull/4787