Re: RFR: 8274083: Update testing docs to mention tiered testing [v5]
On 9/23/2021 11:00 PM, Alan Bateman wrote:
On Thu, 23 Sep 2021 12:53:23 GMT, Aleksey Shipilev wrote:
Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, let's
mention them in `testing.md`.
Current patch is my braindump, I am open for suggestions :)
Aleksey Shipilev has updated the pull request incrementally with one additional
commit since the last revision:
More fixes
Marked as reviewed by alanb (Reviewer).
doc/testing.html line 80:
78:
79: tier1: This is the lowest test tier. Multiple developers run these tests every day. Because of the
widespread use, the tests in tier1 are carefully selected and optimized to run fast, and to run in the most stable manner. The
test failures in tier1 are usually followed up on quickly, either with fixes, or adding relevant tests to problem list. GitHub
Actions workflows, if enabled, run tier1 tests.
80: tier2: This test group covers even more ground. These contain, among other
things, tests that either run for too long to be at tier1, or may require special configuration, or
tests that are less stable, or cover the broader range of less critical JVM and JDK features/components (for example,
jaxp).
Thanks for the updates, I think it reads much better now.
A small suggestion is to change "less critical" to "non-core", and "jaxp" to
"XML" as I don't expect too many people know what JAXP is.
Catching up on email, for some belated context, the initial tired
testing email thread did included some discussion about what the tiered
were intended to mean including:
http://mail.openjdk.java.net/pipermail/jdk9-dev/2015-March/001991.html
Thanks,
-Joe
-
PR: https://git.openjdk.java.net/jdk/pull/5615
Re: RFR: 8274083: Update testing docs to mention tiered testing [v5]
On Fri, 24 Sep 2021 05:58:09 GMT, Alan Bateman wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More fixes > > doc/testing.html line 80: > >> 78: >> 79: tier1: This is the lowest test tier. Multiple >> developers run these tests every day. Because of the widespread use, the >> tests in tier1 are carefully selected and optimized to run >> fast, and to run in the most stable manner. The test failures in >> tier1 are usually followed up on quickly, either with fixes, or >> adding relevant tests to problem list. GitHub Actions workflows, if enabled, >> run tier1 tests. >> 80: tier2: This test group covers even more ground. >> These contain, among other things, tests that either run for too long to be >> at tier1, or may require special configuration, or tests that >> are less stable, or cover the broader range of less critical JVM and JDK >> features/components (for example, jaxp). > > Thanks for the updates, I think it reads much better now. > A small suggestion is to change "less critical" to "non-core", and "jaxp" to > "XML" as I don't expect too many people know what JAXP is. All right, changed. I'll be integrating this version soon. - PR: https://git.openjdk.java.net/jdk/pull/5615
Re: RFR: 8274083: Update testing docs to mention tiered testing [v5]
On Thu, 23 Sep 2021 12:53:23 GMT, Aleksey Shipilev wrote:
>> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions,
>> let's mention them in `testing.md`.
>>
>> Current patch is my braindump, I am open for suggestions :)
>
> Aleksey Shipilev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> More fixes
Marked as reviewed by alanb (Reviewer).
doc/testing.html line 80:
> 78:
> 79: tier1: This is the lowest test tier. Multiple
> developers run these tests every day. Because of the widespread use, the
> tests in tier1 are carefully selected and optimized to run fast,
> and to run in the most stable manner. The test failures in tier1
> are usually followed up on quickly, either with fixes, or adding relevant
> tests to problem list. GitHub Actions workflows, if enabled, run
> tier1 tests.
> 80: tier2: This test group covers even more ground. These
> contain, among other things, tests that either run for too long to be at
> tier1, or may require special configuration, or tests that are
> less stable, or cover the broader range of less critical JVM and JDK
> features/components (for example, jaxp).
Thanks for the updates, I think it reads much better now.
A small suggestion is to change "less critical" to "non-core", and "jaxp" to
"XML" as I don't expect too many people know what JAXP is.
-
PR: https://git.openjdk.java.net/jdk/pull/5615
Re: RFR: 8274083: Update testing docs to mention tiered testing [v5]
On Thu, 23 Sep 2021 12:53:23 GMT, Aleksey Shipilev wrote:
>> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions,
>> let's mention them in `testing.md`.
>>
>> Current patch is my braindump, I am open for suggestions :)
>
> Aleksey Shipilev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> More fixes
Marked as reviewed by jiefu (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5615
Re: RFR: 8274083: Update testing docs to mention tiered testing [v5]
On Thu, 23 Sep 2021 12:53:23 GMT, Aleksey Shipilev wrote:
>> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions,
>> let's mention them in `testing.md`.
>>
>> Current patch is my braindump, I am open for suggestions :)
>
> Aleksey Shipilev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> More fixes
Marked as reviewed by dholmes (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5615
Re: RFR: 8274083: Update testing docs to mention tiered testing [v5]
On Thu, 23 Sep 2021 12:53:23 GMT, Aleksey Shipilev wrote:
>> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions,
>> let's mention them in `testing.md`.
>>
>> Current patch is my braindump, I am open for suggestions :)
>
> Aleksey Shipilev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> More fixes
Change looks good to me, thank you.
-
Marked as reviewed by mseledtsov (Committer).
PR: https://git.openjdk.java.net/jdk/pull/5615
Re: RFR: 8274083: Update testing docs to mention tiered testing [v5]
> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, let's
> mention them in `testing.md`.
>
> Current patch is my braindump, I am open for suggestions :)
Aleksey Shipilev has updated the pull request incrementally with one additional
commit since the last revision:
More fixes
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5615/files
- new: https://git.openjdk.java.net/jdk/pull/5615/files/32e9b5b4..efd28804
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5615&range=04
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5615&range=03-04
Stats: 21 lines in 2 files changed: 4 ins; 2 del; 15 mod
Patch: https://git.openjdk.java.net/jdk/pull/5615.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/5615/head:pull/5615
PR: https://git.openjdk.java.net/jdk/pull/5615
