Re: RFR: 8274851: [PPC64] Port zgc to linux on ppc64le [v3]
On Fri, 8 Oct 2021 15:41:47 GMT, Niklas Radomski wrote: >> Port the Z garbage collector >> ([JDK-8209683](https://bugs.openjdk.java.net/browse/JDK-8209683)) to linux >> on ppc64le. > > Niklas Radomski has updated the pull request incrementally with three > additional commits since the last revision: > > - Remove superfluous copyright change > - Fix predicate conditions > - Add ByteSize constructor to Address The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout 8275049_ZGC_log_register git fetch https://git.openjdk.java.net/jdk master git merge FETCH_HEAD # if there are conflicts, follow the instructions given by git merge git commit -m "Merge master" git push - PR: https://git.openjdk.java.net/jdk/pull/5842
Re: RFR: 8274851: [PPC64] Port zgc to linux on ppc64le [v3]
On Fri, 8 Oct 2021 15:41:47 GMT, Niklas Radomski wrote: >> Port the Z garbage collector >> ([JDK-8209683](https://bugs.openjdk.java.net/browse/JDK-8209683)) to linux >> on ppc64le. > > Niklas Radomski has updated the pull request incrementally with three > additional commits since the last revision: > > - Remove superfluous copyright change > - Fix predicate conditions > - Add ByteSize constructor to Address Thank you for your reviews! Glad to see that the changes have been so well received. - PR: https://git.openjdk.java.net/jdk/pull/5842
Re: RFR: 8274851: [PPC64] Port zgc to linux on ppc64le [v3]
On Fri, 8 Oct 2021 15:41:47 GMT, Niklas Radomski wrote: >> Port the Z garbage collector >> ([JDK-8209683](https://bugs.openjdk.java.net/browse/JDK-8209683)) to linux >> on ppc64le. > > Niklas Radomski has updated the pull request incrementally with three > additional commits since the last revision: > > - Remove superfluous copyright change > - Fix predicate conditions > - Add ByteSize constructor to Address Thanks for doing the requested fixes. LGTM. - Marked as reviewed by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/5842
Re: RFR: 8274851: [PPC64] Port zgc to linux on ppc64le [v3]
On Fri, 8 Oct 2021 15:41:47 GMT, Niklas Radomski wrote: >> Port the Z garbage collector >> ([JDK-8209683](https://bugs.openjdk.java.net/browse/JDK-8209683)) to linux >> on ppc64le. > > Niklas Radomski has updated the pull request incrementally with three > additional commits since the last revision: > > - Remove superfluous copyright change > - Fix predicate conditions > - Add ByteSize constructor to Address Marked as reviewed by pliden (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5842
Re: RFR: 8274851: [PPC64] Port zgc to linux on ppc64le [v3]
> Port the Z garbage collector > ([JDK-8209683](https://bugs.openjdk.java.net/browse/JDK-8209683)) to linux on > ppc64le. Niklas Radomski has updated the pull request incrementally with three additional commits since the last revision: - Remove superfluous copyright change - Fix predicate conditions - Add ByteSize constructor to Address - Changes: - all: https://git.openjdk.java.net/jdk/pull/5842/files - new: https://git.openjdk.java.net/jdk/pull/5842/files/5da8c1b7..052ad5c8 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=5842=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk=5842=01-02 Stats: 9 lines in 3 files changed: 3 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/jdk/pull/5842.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5842/head:pull/5842 PR: https://git.openjdk.java.net/jdk/pull/5842
