On Tue, 2 Nov 2021 19:35:29 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-419 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk.java.net/jeps/419
>
> Maurizio Cimadamore has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Address impl review comments
> - Address API review comments
src/java.base/share/classes/java/lang/Module.java line 114:
> 112:
> 113: // true, if this module allows restricted native access; @Stable
> makes sure that modules that allow native
> 114: // access capture this property as a constant.
Do you mind fixing this comment to avoid the really long line, it sticks out
compare to everything else around it.
src/java.base/share/classes/sun/nio/ch/IOUtil.java line 478:
> 476: private static final JavaNioAccess NIO_ACCESS =
> SharedSecrets.getJavaNioAccess();
> 477:
> 478: static Runnable acquireScope(ByteBuffer bb, boolean async) {
At some point (not this PR) we should move the "async" out of this file, IOUtil
was for synchronous I/O.
-
PR: https://git.openjdk.java.net/jdk/pull/5907
