Re: RFR: 8284720: IntelliJ: JIRA integration

2022-04-13 Thread Andrey Turbanov 
On Tue, 12 Apr 2022 04:44:15 GMT, Daniel Jeliński  wrote:

> This patch adds clickable link to commit messages in IntelliJ's git log. 
> Example result:
> ![image](https://user-images.githubusercontent.com/30433125/162882312-6a9c7666-075d-47b7-9db5-22670b885e7b.png)

BTW, `\d` in regexps is a bit slower than `[0-9]`. It's because `[0-9]` matches 
only ASCII digits, while `\d` additional matches by extended unicode digits.

-

PR: https://git.openjdk.java.net/jdk/pull/8193

Re: RFR: 8284720: IntelliJ: JIRA integration

2022-04-12 Thread Magnus Ihse Bursie 
On Tue, 12 Apr 2022 04:44:15 GMT, Daniel Jeliński  wrote:

> This patch adds clickable link to commit messages in IntelliJ's git log. 
> Example result:
> ![image](https://user-images.githubusercontent.com/30433125/162882312-6a9c7666-075d-47b7-9db5-22670b885e7b.png)

Clever idea.

-

Marked as reviewed by ihse (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8193

Re: RFR: 8284720: IntelliJ: JIRA integration

2022-04-12 Thread Maurizio Cimadamore 
On Tue, 12 Apr 2022 04:44:15 GMT, Daniel Jeliński  wrote:

> This patch adds clickable link to commit messages in IntelliJ's git log. 
> Example result:
> ![image](https://user-images.githubusercontent.com/30433125/162882312-6a9c7666-075d-47b7-9db5-22670b885e7b.png)

Very neat!

-

Marked as reviewed by mcimadamore (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8193

Re: RFR: 8284720: IntelliJ: JIRA integration

2022-04-12 Thread Сергей Цыпанов 
On Tue, 12 Apr 2022 04:44:15 GMT, Daniel Jeliński  wrote:

> This patch adds clickable link to commit messages in IntelliJ's git log. 
> Example result:
> ![image](https://user-images.githubusercontent.com/30433125/162882312-6a9c7666-075d-47b7-9db5-22670b885e7b.png)

Looks fine and useful!

-

Marked as reviewed by stsypa...@github.com (no known OpenJDK username).

PR: https://git.openjdk.java.net/jdk/pull/8193

RFR: 8284720: IntelliJ: JIRA integration

2022-04-11 Thread Daniel Jeliński 
This patch adds clickable link to commit messages in IntelliJ's git log. 
Example result:
![image](https://user-images.githubusercontent.com/30433125/162882312-6a9c7666-075d-47b7-9db5-22670b885e7b.png)

-

Commit messages:
 - JIRA integration

Changes: https://git.openjdk.java.net/jdk/pull/8193/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8193=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8284720
  Stats: 10 lines in 1 file changed: 10 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8193.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8193/head:pull/8193

PR: https://git.openjdk.java.net/jdk/pull/8193