Re: RFR: 8287378: GHA: Update cygwin to fix issues in langtools tests on Windows
On Thu, 26 May 2022 16:07:56 GMT, Christoph Langer wrote: > This fixes the Windows GHA test failures that popped up short time ago, e.g. > [these](https://github.com/RealCLanger/jdk/runs/6598399845) > > Failing tests: > tools/javac/Paths/MineField.sh > tools/javac/Paths/wcMineField.sh > > I've debugged it and it comes down to calls to javac/java in the test through > env are failing with RC 127. E.g. here: > https://github.com/openjdk/jdk/blob/e44465d4d6eaddebfc5a1b149223aa8332affa8b/test/langtools/tools/javac/Paths/MineField.sh#L218 > > Don't know why but I figured that the test failure goes away with current > cygwin. > > It should be ok to update cygwin now because the bug that made JDK-8276854 > necessary seems to be fixed. Thanks for the review. - PR: https://git.openjdk.java.net/jdk/pull/8903
Re: RFR: 8287378: GHA: Update cygwin to fix issues in langtools tests on Windows
On Thu, 26 May 2022 16:07:56 GMT, Christoph Langer wrote: > This fixes the Windows GHA test failures that popped up short time ago, e.g. > [these](https://github.com/RealCLanger/jdk/runs/6598399845) > > Failing tests: > tools/javac/Paths/MineField.sh > tools/javac/Paths/wcMineField.sh > > I've debugged it and it comes down to calls to javac/java in the test through > env are failing with RC 127. E.g. here: > https://github.com/openjdk/jdk/blob/e44465d4d6eaddebfc5a1b149223aa8332affa8b/test/langtools/tools/javac/Paths/MineField.sh#L218 > > Don't know why but I figured that the test failure goes away with current > cygwin. > > It should be ok to update cygwin now because the bug that made JDK-8276854 > necessary seems to be fixed. Ah, Cygwin again. Current patch looks fine. Given how nasty Cygwin-caused failures are, I think keeping the version nailed still makes sense. - Marked as reviewed by shade (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8903
Re: RFR: 8287378: GHA: Update cygwin to fix issues in langtools tests on Windows
On Thu, 26 May 2022 16:07:56 GMT, Christoph Langer wrote: > This fixes the Windows GHA test failures that popped up short time ago, e.g. > [these](https://github.com/RealCLanger/jdk/runs/6598399845) > > Failing tests: > tools/javac/Paths/MineField.sh > tools/javac/Paths/wcMineField.sh > > I've debugged it and it comes down to calls to javac/java in the test through > env are failing with RC 127. E.g. here: > https://github.com/openjdk/jdk/blob/e44465d4d6eaddebfc5a1b149223aa8332affa8b/test/langtools/tools/javac/Paths/MineField.sh#L218 > > Don't know why but I figured that the test failure goes away with current > cygwin. > > It should be ok to update cygwin now because the bug that made JDK-8276854 > necessary seems to be fixed. @magicus @shipilev, WDYT? I would like to backport this to get GHA results greener... - PR: https://git.openjdk.java.net/jdk/pull/8903
Re: RFR: 8287378: GHA: Update cygwin to fix issues in langtools tests on Windows
On Thu, 26 May 2022 16:07:56 GMT, Christoph Langer wrote: > This fixes the Windows GHA test failures that popped up short time ago, e.g. > [these](https://github.com/RealCLanger/jdk/runs/6598399845) > > Failing tests: > tools/javac/Paths/MineField.sh > tools/javac/Paths/wcMineField.sh > > I've debugged it and it comes down to calls to javac/java in the test through > env are failing with RC 127. E.g. here: > https://github.com/openjdk/jdk/blob/e44465d4d6eaddebfc5a1b149223aa8332affa8b/test/langtools/tools/javac/Paths/MineField.sh#L218 > > Don't know why but I figured that the test failure goes away with current > cygwin. > > It should be ok to update cygwin now because the bug that made JDK-8276854 > necessary seems to be fixed. Marked as reviewed by aturbanov (Committer). - PR: https://git.openjdk.java.net/jdk/pull/8903
Re: RFR: 8287378: GHA: Update cygwin to fix issues in langtools tests on Windows
On Thu, 26 May 2022 16:07:56 GMT, Christoph Langer wrote: > This fixes the Windows GHA test failures that popped up short time ago, e.g. > [these](https://github.com/RealCLanger/jdk/runs/6598399845) > > Failing tests: > tools/javac/Paths/MineField.sh > tools/javac/Paths/wcMineField.sh > > I've debugged it and it comes down to calls to javac/java in the test through > env are failing with RC 127. E.g. here: > https://github.com/openjdk/jdk/blob/e44465d4d6eaddebfc5a1b149223aa8332affa8b/test/langtools/tools/javac/Paths/MineField.sh#L218 > > Don't know why but I figured that the test failure goes away with current > cygwin. > > It should be ok to update cygwin now because the bug that made JDK-8276854 > necessary seems to be fixed. PS: The Windows langtools failure seen here is jdk/jshell/HighlightUITest.java, which seems to be unstable as of [JDK-8284144](https://bugs.openjdk.java.net/browse/JDK-8284144) and has already been excluded on several other platforms but not Windows yet. - PR: https://git.openjdk.java.net/jdk/pull/8903
RFR: 8287378: GHA: Update cygwin to fix issues in langtools tests on Windows
This fixes the Windows GHA test failures that popped up short time ago, e.g. [these](https://github.com/RealCLanger/jdk/runs/6598399845) Failing tests: tools/javac/Paths/MineField.sh tools/javac/Paths/wcMineField.sh I've debugged it and it comes down to calls to javac/java in the test through env are failing with RC 127. E.g. here: https://github.com/openjdk/jdk/blob/e44465d4d6eaddebfc5a1b149223aa8332affa8b/test/langtools/tools/javac/Paths/MineField.sh#L218 Don't know why but I figured that the test failure goes away with current cygwin. It should be ok to update cygwin now because the bug that made JDK-8276854 necessary seems to be fixed. - Commit messages: - JDK-8287378 Changes: https://git.openjdk.java.net/jdk/pull/8903/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8903=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8287378 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk/pull/8903.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8903/head:pull/8903 PR: https://git.openjdk.java.net/jdk/pull/8903
