Re: RFR: JDK-8055922: Work around sjavac limitation with public api tracking cross modules
Can’t really comment on the makefile changes but I think this workaround is good for now. Thumbs up cheers /Joel On 26 aug 2014, at 11:58, Erik Joelsson wrote: > Updated webrev: http://cr.openjdk.java.net/~erikj/8055922/webrev.root.02/ > > Some of the demos failed to compile because the javac_state file did not > contain any public api and this caused grep to exit with code 1, which failed > the build. I made exit code 1 for this grep line not fail the build. > > /Erik > > On 2014-08-25 16:50, Erik Joelsson wrote: >> Hello, >> >> Please review this little workaround for a current shortcoming in Sjavac. >> See bug for more details. With this change, Sjavac will start acting >> correctly again and not miss any files that need to be recompiled. The >> approximation is course however, we should still fix >> https://bugs.openjdk.java.net/browse/JDK-8054717 to properly only recompile >> what is really necessary. Still, this workaround does add value compared to >> running without sjavac. With this change and JDK-8014510 (also on review) >> I'm starting to feel confident enough to make sjavac default for building >> jdk9. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8055922 >> Webrev: http://cr.openjdk.java.net/~erikj/8055922/webrev.root.01/ >> >> /Erik >
Re: RFR: JDK-8055922: Work around sjavac limitation with public api tracking cross modules
On 2014-08-26 11:58, Erik Joelsson wrote: Updated webrev: http://cr.openjdk.java.net/~erikj/8055922/webrev.root.02/ Some of the demos failed to compile because the javac_state file did not contain any public api and this caused grep to exit with code 1, which failed the build. I made exit code 1 for this grep line not fail the build. Looks good to me. /Magnus
Re: RFR: JDK-8055922: Work around sjavac limitation with public api tracking cross modules
Updated webrev: http://cr.openjdk.java.net/~erikj/8055922/webrev.root.02/ Some of the demos failed to compile because the javac_state file did not contain any public api and this caused grep to exit with code 1, which failed the build. I made exit code 1 for this grep line not fail the build. /Erik On 2014-08-25 16:50, Erik Joelsson wrote: Hello, Please review this little workaround for a current shortcoming in Sjavac. See bug for more details. With this change, Sjavac will start acting correctly again and not miss any files that need to be recompiled. The approximation is course however, we should still fix https://bugs.openjdk.java.net/browse/JDK-8054717 to properly only recompile what is really necessary. Still, this workaround does add value compared to running without sjavac. With this change and JDK-8014510 (also on review) I'm starting to feel confident enough to make sjavac default for building jdk9. Bug: https://bugs.openjdk.java.net/browse/JDK-8055922 Webrev: http://cr.openjdk.java.net/~erikj/8055922/webrev.root.01/ /Erik
RFR: JDK-8055922: Work around sjavac limitation with public api tracking cross modules
Hello, Please review this little workaround for a current shortcoming in Sjavac. See bug for more details. With this change, Sjavac will start acting correctly again and not miss any files that need to be recompiled. The approximation is course however, we should still fix https://bugs.openjdk.java.net/browse/JDK-8054717 to properly only recompile what is really necessary. Still, this workaround does add value compared to running without sjavac. With this change and JDK-8014510 (also on review) I'm starting to feel confident enough to make sjavac default for building jdk9. Bug: https://bugs.openjdk.java.net/browse/JDK-8055922 Webrev: http://cr.openjdk.java.net/~erikj/8055922/webrev.root.01/ /Erik
