RFR: JDK-8144172: Problem with bootcycle-images and sjavac

2015-11-27 Thread Erik Joelsson 

Hello,

The javac-server feature wasn't compatible with bootcycle-images. This 
fix is a bit of hack, but so was the original bootcycle implementation. 
We probably need to take a step back and figure out a better model for 
this later.


Bug: https://bugs.openjdk.java.net/browse/JDK-8144172
Webrev: http://cr.openjdk.java.net/~erikj/8144172/webrev.01/

/Erik

Re: RFR: JDK-8144172: Problem with bootcycle-images and sjavac

2015-11-27 Thread Magnus Ihse Bursie 

On 2015-11-27 14:28, Erik Joelsson wrote:

Hello,

The javac-server feature wasn't compatible with bootcycle-images. This 
fix is a bit of hack, but so was the original bootcycle 
implementation. We probably need to take a step back and figure out a 
better model for this later.

I agree on that. To fix the current problem, your hack looks fine, though.

/Magnus



Bug: https://bugs.openjdk.java.net/browse/JDK-8144172
Webrev: http://cr.openjdk.java.net/~erikj/8144172/webrev.01/

/Erik