Re: RFR: JDK-8219906: Update test documentation with default test jobs settings

2019-03-04 Thread Ao Qi 
Yes. Thank you Magnus.

On Mon, Mar 4, 2019 at 8:06 PM Magnus Ihse Bursie
 wrote:
>
> This looks good to me. Shall I push it for you?
>
> /Magnus
>
> > 3 mars 2019 kl. 11:26 skrev Ao Qi :
> >
> > On Fri, Mar 1, 2019 at 9:39 PM Magnus Ihse Bursie
> >  wrote:
> >>
> >> On 2019-02-28 09:13, Ao Qi wrote:
> >>
> >> Hi,
> >>
> >> Test jobs setting for sparc is different with x86 (JDK-8211727).
> >> Besides, test jobs setting is based on memory size (JDK-8214003). The
> >> test documentation fails to mention these and needs update.
> >>
> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8219906
> >>
> >> Webrev: http://cr.openjdk.java.net/~aoqi/8219906/webrev.00/
> >>
> >> Hi Ao,
> >>
> >> The html file is generated from the markdown file. Please update 
> >> testing.md instead, and then get yourself an automatically updated 
> >> testing.html using "make update-build-docs". You will need pandoc for that 
> >> to work, version 2.3.1 or newer is recommended (but not mandated).
> >
> > Hi Magnus,
> >
> > Thanks for your review and information. I did not know "make
> > update-build-docs" before. I updated testing.md and updated
> > testing.html using "make update-build-docs".
> >
> > Webrev: http://cr.openjdk.java.net/~aoqi/8219906/webrev.01/
> >
> > My environment is Ubuntu 16.04, and I manually install pandoc 2.3.1
> > from https://github.com/jgm/pandoc/releases/tag/2.3.1
> >
> > Cheers,
> > Ao Qi
> >
> >> /Magnus
> >>
> >>
> >> Cheers,
> >> Ao Qi
> >>
> >>
>

Re: RFR: JDK-8219906: Update test documentation with default test jobs settings

2019-03-04 Thread Magnus Ihse Bursie 
This looks good to me. Shall I push it for you?

/Magnus

> 3 mars 2019 kl. 11:26 skrev Ao Qi :
> 
> On Fri, Mar 1, 2019 at 9:39 PM Magnus Ihse Bursie
>  wrote:
>> 
>> On 2019-02-28 09:13, Ao Qi wrote:
>> 
>> Hi,
>> 
>> Test jobs setting for sparc is different with x86 (JDK-8211727).
>> Besides, test jobs setting is based on memory size (JDK-8214003). The
>> test documentation fails to mention these and needs update.
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8219906
>> 
>> Webrev: http://cr.openjdk.java.net/~aoqi/8219906/webrev.00/
>> 
>> Hi Ao,
>> 
>> The html file is generated from the markdown file. Please update testing.md 
>> instead, and then get yourself an automatically updated testing.html using 
>> "make update-build-docs". You will need pandoc for that to work, version 
>> 2.3.1 or newer is recommended (but not mandated).
> 
> Hi Magnus,
> 
> Thanks for your review and information. I did not know "make
> update-build-docs" before. I updated testing.md and updated
> testing.html using "make update-build-docs".
> 
> Webrev: http://cr.openjdk.java.net/~aoqi/8219906/webrev.01/
> 
> My environment is Ubuntu 16.04, and I manually install pandoc 2.3.1
> from https://github.com/jgm/pandoc/releases/tag/2.3.1
> 
> Cheers,
> Ao Qi
> 
>> /Magnus
>> 
>> 
>> Cheers,
>> Ao Qi
>> 
>>

Re: RFR: JDK-8219906: Update test documentation with default test jobs settings

2019-03-03 Thread Ao Qi 
On Fri, Mar 1, 2019 at 9:39 PM Magnus Ihse Bursie
 wrote:
>
> On 2019-02-28 09:13, Ao Qi wrote:
>
> Hi,
>
> Test jobs setting for sparc is different with x86 (JDK-8211727).
> Besides, test jobs setting is based on memory size (JDK-8214003). The
> test documentation fails to mention these and needs update.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8219906
>
> Webrev: http://cr.openjdk.java.net/~aoqi/8219906/webrev.00/
>
> Hi Ao,
>
> The html file is generated from the markdown file. Please update testing.md 
> instead, and then get yourself an automatically updated testing.html using 
> "make update-build-docs". You will need pandoc for that to work, version 
> 2.3.1 or newer is recommended (but not mandated).
>

Hi Magnus,

Thanks for your review and information. I did not know "make
update-build-docs" before. I updated testing.md and updated
testing.html using "make update-build-docs".

Webrev: http://cr.openjdk.java.net/~aoqi/8219906/webrev.01/

My environment is Ubuntu 16.04, and I manually install pandoc 2.3.1
from https://github.com/jgm/pandoc/releases/tag/2.3.1

Cheers,
Ao Qi

> /Magnus
>
>
> Cheers,
> Ao Qi
>
>

Re: RFR: JDK-8219906: Update test documentation with default test jobs settings

2019-03-01 Thread Magnus Ihse Bursie 

On 2019-02-28 09:13, Ao Qi wrote:

Hi,

Test jobs setting for sparc is different with x86 (JDK-8211727).
Besides, test jobs setting is based on memory size (JDK-8214003). The
test documentation fails to mention these and needs update.

Bug: https://bugs.openjdk.java.net/browse/JDK-8219906

Webrev: http://cr.openjdk.java.net/~aoqi/8219906/webrev.00/

Hi Ao,

The html file is generated from the markdown file. Please update 
testing.md instead, and then get yourself an automatically updated 
testing.html using "make update-build-docs". You will need pandoc for 
that to work, version 2.3.1 or newer is recommended (but not mandated).


/Magnus



Cheers,
Ao Qi

RFR: JDK-8219906: Update test documentation with default test jobs settings

2019-02-28 Thread Ao Qi 
Hi,

Test jobs setting for sparc is different with x86 (JDK-8211727).
Besides, test jobs setting is based on memory size (JDK-8214003). The
test documentation fails to mention these and needs update.

Bug: https://bugs.openjdk.java.net/browse/JDK-8219906

Webrev: http://cr.openjdk.java.net/~aoqi/8219906/webrev.00/

Cheers,
Ao Qi